Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
8 years agoRename functions in simgrid_lua.c
Christophe Thiéry [Wed, 9 Nov 2011 17:42:34 +0000 (18:42 +0100)]
Rename functions in simgrid_lua.c

8 years agoRemove a useless xbt_assert from the critical path
Martin Quinson [Wed, 9 Nov 2011 17:08:21 +0000 (18:08 +0100)]
Remove a useless xbt_assert from the critical path

The error message was not more informative than a segfault will be,
and user behavior cannot produce this (I think)

8 years agouse a sane way to declare postparse callbacks, now that this way exists
Martin Quinson [Wed, 9 Nov 2011 17:06:57 +0000 (18:06 +0100)]
use a sane way to declare postparse callbacks, now that this way exists

8 years agopartially reindent that file
Martin Quinson [Wed, 9 Nov 2011 16:45:06 +0000 (17:45 +0100)]
partially reindent that file

8 years agoRemove the complexity needed to save a global that is never used
Martin Quinson [Wed, 9 Nov 2011 16:32:36 +0000 (17:32 +0100)]
Remove the complexity needed to save a global that is never used

this is the field "model" in the surf_model_description structure. The
actual model is always saved elsewhere (like in the global
surf_workstation_model and friends).

If one day we want to have multi-model simulations, we'll need to
partially revert this change, but I guess that this day seaching the
right model linearly by name, as it was made possible with the
existing setup, will not be the way to go.

8 years agoI don't see the point of declaring and calling empty functions
Martin Quinson [Wed, 9 Nov 2011 15:50:42 +0000 (16:50 +0100)]
I don't see the point of declaring and calling empty functions

*_load *_unload callbacks of the routing logics seem unused.
We could maybe kill them?

8 years agooups, that comment were in french
Martin Quinson [Wed, 9 Nov 2011 15:30:19 +0000 (16:30 +0100)]
oups, that comment were in french

8 years agonobody use these structures, so I won't try to understand their purpose
Martin Quinson [Wed, 9 Nov 2011 15:19:22 +0000 (16:19 +0100)]
nobody use these structures, so I won't try to understand their purpose

8 years agoReorganize mallocator.c, and add the possibility to disable mallocators.
Arnaud Giersch [Wed, 20 Jul 2011 15:02:15 +0000 (17:02 +0200)]
Reorganize mallocator.c, and add the possibility to disable mallocators.

Memory leaks are sometimes hard to track when mallocators are in use.
Set MALLOCATOR_IS_WANTED to 0 to disable them during your debugging session.

The code for mallocator_new and mallocator_get is also made a bit cleaner.

8 years agoKill "if" before free, and useless cast of free argument.
Arnaud Giersch [Fri, 28 Jan 2011 15:27:37 +0000 (16:27 +0100)]
Kill "if" before free, and useless cast of free argument.

free(NULL) is a no-op, there is no need to test the given pointer
before call.
The same argument stands for xbt_free, xbt_dict_free, xbt_dynar_free,
and xbt_strbuff_free.

8 years agoReplace, when possible, calls to bprintf() by calls to xbt_strdup().
Arnaud Giersch [Tue, 13 Sep 2011 08:20:32 +0000 (10:20 +0200)]
Replace, when possible, calls to bprintf() by calls to xbt_strdup().

8 years agoFor radical it is "," and not ";"
Navarrop [Wed, 9 Nov 2011 12:48:06 +0000 (13:48 +0100)]
For radical it is "," and not ";"

8 years agoimprove documentation of MSG_task_dsend function
Lucas Schnorr [Wed, 9 Nov 2011 12:28:41 +0000 (13:28 +0100)]
improve documentation of MSG_task_dsend function

8 years agoAlso remove the comm from processes when SIMIX_post_comm is not called
Christophe Thiéry [Wed, 9 Nov 2011 11:20:26 +0000 (12:20 +0100)]
Also remove the comm from processes when SIMIX_post_comm is not called

8 years agoFix possible crashes and leaks with dsends during processes cleanup
Christophe Thiéry [Wed, 9 Nov 2011 10:46:02 +0000 (11:46 +0100)]
Fix possible crashes and leaks with dsends during processes cleanup

8 years agoDestroy sg_platf_link_cb_list on sg_platf_exit().
Arnaud Giersch [Tue, 8 Nov 2011 14:44:38 +0000 (15:44 +0100)]
Destroy sg_platf_link_cb_list on sg_platf_exit().

8 years agoDon't duplicate strings uselessly, and avoid memory leaks.
Arnaud Giersch [Mon, 7 Nov 2011 22:21:33 +0000 (23:21 +0100)]
Don't duplicate strings uselessly, and avoid memory leaks.

8 years agoReindent before change.
Arnaud Giersch [Mon, 7 Nov 2011 21:30:32 +0000 (22:30 +0100)]
Reindent before change.

8 years agoReindent surf_routing.c
Arnaud Giersch [Wed, 9 Nov 2011 10:25:12 +0000 (11:25 +0100)]
Reindent surf_routing.c

8 years agoConstification of parameter, and attribute no_return.
Arnaud Giersch [Wed, 9 Nov 2011 10:12:31 +0000 (11:12 +0100)]
Constification of parameter, and attribute no_return.

8 years agoAdd a script running GNU indent with the appropriate options.
Arnaud Giersch [Wed, 9 Nov 2011 09:25:10 +0000 (10:25 +0100)]
Add a script running GNU indent with the appropriate options.

The set of options was given by README.coding which is also updated.

8 years agoFactorize routing_parse_cluster.
Navarrop [Wed, 9 Nov 2011 10:15:29 +0000 (11:15 +0100)]
Factorize routing_parse_cluster.

8 years agoI demand you to stop that empty function chaining madness. NOW
Martin Quinson [Tue, 8 Nov 2011 21:37:37 +0000 (22:37 +0100)]
I demand you to stop that empty function chaining madness. NOW

8 years agosanitize the names of the routing's parse callbacks
Martin Quinson [Tue, 8 Nov 2011 21:31:14 +0000 (22:31 +0100)]
sanitize the names of the routing's parse callbacks

8 years agono need to have the routing_parse_Scluster() function public. routing_register_callba...
Martin Quinson [Tue, 8 Nov 2011 21:24:17 +0000 (22:24 +0100)]
no need to have the routing_parse_Scluster() function public. routing_register_callbacks is enough

8 years agosanitize the way parsing callbacks of the routing submodule are registered
Martin Quinson [Tue, 8 Nov 2011 21:19:42 +0000 (22:19 +0100)]
sanitize the way parsing callbacks of the routing submodule are registered

8 years agoOne day, we'll have to deal with route creation in sg_platf. That day, we'll need...
Martin Quinson [Tue, 8 Nov 2011 21:19:02 +0000 (22:19 +0100)]
One day, we'll have to deal with route creation in sg_platf. That day, we'll need that data structure

8 years agosimplify this function
Martin Quinson [Tue, 8 Nov 2011 21:10:28 +0000 (22:10 +0100)]
simplify this function

8 years agorename some types for consistency
Martin Quinson [Tue, 8 Nov 2011 20:57:55 +0000 (21:57 +0100)]
rename some types for consistency

8 years agothat FIXME would be a bad idea to implement
Martin Quinson [Tue, 8 Nov 2011 20:54:39 +0000 (21:54 +0100)]
that FIXME would be a bad idea to implement

8 years agoreindent, no real change
Martin Quinson [Tue, 8 Nov 2011 20:46:55 +0000 (21:46 +0100)]
reindent, no real change

8 years agoimplement cluster tag on top of sg_platf w/o XML black magic
Martin Quinson [Tue, 8 Nov 2011 20:40:14 +0000 (21:40 +0100)]
implement cluster tag on top of sg_platf w/o XML black magic

8 years agoKill the XML-level callbacks to AS_open/close and create some at sg_platf level instead
Martin Quinson [Tue, 8 Nov 2011 20:23:47 +0000 (21:23 +0100)]
Kill the XML-level callbacks to AS_open/close and create some at sg_platf level instead

8 years agosimplify that vicious nasty code
Martin Quinson [Tue, 8 Nov 2011 17:15:53 +0000 (18:15 +0100)]
simplify that vicious nasty code

8 years agokill dead code
Martin Quinson [Tue, 8 Nov 2011 16:04:04 +0000 (17:04 +0100)]
kill dead code

8 years ago/me also hates void* pointers
Martin Quinson [Tue, 8 Nov 2011 15:38:54 +0000 (16:38 +0100)]
/me also hates void* pointers

8 years ago/me hates globals
Martin Quinson [Tue, 8 Nov 2011 15:04:22 +0000 (16:04 +0100)]
/me hates globals

8 years agointegrate the peer creation in sg_platf properly
Martin Quinson [Tue, 8 Nov 2011 15:00:57 +0000 (16:00 +0100)]
integrate the peer creation in sg_platf properly

8 years agopreparse the arguments of peer tag
Martin Quinson [Tue, 8 Nov 2011 14:46:04 +0000 (15:46 +0100)]
preparse the arguments of peer tag

8 years agoimprove peer creator: use sg_platf_new_*, not the XML bypassing mechanism
Martin Quinson [Tue, 8 Nov 2011 14:30:09 +0000 (15:30 +0100)]
improve peer creator: use sg_platf_new_*, not the XML bypassing mechanism

8 years agoDestroy dax parser after use.
Arnaud Giersch [Thu, 18 Nov 2010 21:58:58 +0000 (22:58 +0100)]
Destroy dax parser after use.

8 years agoFix memory leak in xbt_cfg_set_parse().
Arnaud Giersch [Mon, 7 Nov 2011 22:04:05 +0000 (23:04 +0100)]
Fix memory leak in xbt_cfg_set_parse().

8 years agoKill bogus fixme: xbt_free_f already exists.
Arnaud Giersch [Mon, 7 Nov 2011 21:24:44 +0000 (22:24 +0100)]
Kill bogus fixme: xbt_free_f already exists.

8 years agoParenthesis should be protected in test parameters.
Arnaud Giersch [Mon, 7 Nov 2011 22:14:01 +0000 (23:14 +0100)]
Parenthesis should be protected in test parameters.

8 years agofurther parser cleanups
Martin Quinson [Tue, 8 Nov 2011 14:06:44 +0000 (15:06 +0100)]
further parser cleanups

- kill some dead code related to the old lua console
- do not load a header at the *end* of another header
- solve some header inclusion madness created in this process

8 years agodo use the parameters I'm given, not some random globals
Martin Quinson [Tue, 8 Nov 2011 13:52:27 +0000 (14:52 +0100)]
do use the parameters I'm given, not some random globals

8 years agokill dead code
Martin Quinson [Tue, 8 Nov 2011 13:29:21 +0000 (14:29 +0100)]
kill dead code

8 years agoimprove comments
Martin Quinson [Tue, 8 Nov 2011 13:24:05 +0000 (14:24 +0100)]
improve comments

8 years agoplug a memleak when the cluster's router_id is not given
Martin Quinson [Tue, 8 Nov 2011 13:22:01 +0000 (14:22 +0100)]
plug a memleak when the cluster's router_id is not given

8 years agofix constness in parser
Martin Quinson [Tue, 8 Nov 2011 12:43:27 +0000 (13:43 +0100)]
fix constness in parser

8 years agofurther fields renamings in the parser
Martin Quinson [Tue, 8 Nov 2011 12:15:40 +0000 (13:15 +0100)]
further fields renamings in the parser

8 years agoUpdate README of Lua examples
Christophe Thiéry [Tue, 8 Nov 2011 10:55:47 +0000 (11:55 +0100)]
Update README of Lua examples

8 years agoClean the code of Lua examples.
Christophe Thiéry [Tue, 8 Nov 2011 10:38:41 +0000 (11:38 +0100)]
Clean the code of Lua examples.

Reindent, remove useless semicolons, declare variables as local, etc.

8 years agoAdd unversioned chord large deployment files to .gitignore
Christophe Thiéry [Tue, 8 Nov 2011 09:58:58 +0000 (10:58 +0100)]
Add unversioned chord large deployment files to .gitignore

Also remove '\r' characters from .gitignore

8 years agoThese files have nothing to do here
Christophe Thiéry [Tue, 8 Nov 2011 09:48:40 +0000 (10:48 +0100)]
These files have nothing to do here

8 years agofurther code simplification. This one were nasty
Martin Quinson [Tue, 8 Nov 2011 11:51:01 +0000 (12:51 +0100)]
further code simplification. This one were nasty

8 years agosimplify the code a bit
Martin Quinson [Tue, 8 Nov 2011 11:22:00 +0000 (12:22 +0100)]
simplify the code a bit

8 years agoAlso cleanup the fields of s_sg_platf_link_cbarg_t
Martin Quinson [Tue, 8 Nov 2011 11:05:51 +0000 (12:05 +0100)]
Also cleanup the fields of s_sg_platf_link_cbarg_t

This one is not just a renaming:
 - kill the unused V_policy_initial_link
 - make V_link_sharing_policy (now 'policy') a
   e_surf_link_sharing_policy_t (which thus become public)
This should be enough for field renaming for now. But the cleanup is
definitly not finished :-/

8 years agoalso cleanup the field names of s_sg_platf_router_cbarg_t
Martin Quinson [Tue, 8 Nov 2011 10:48:32 +0000 (11:48 +0100)]
also cleanup the field names of s_sg_platf_router_cbarg_t

Still manual, so atomic commits to avoid issues

8 years agoParser cleanup: simplify structure's fields' names
Martin Quinson [Tue, 8 Nov 2011 10:42:19 +0000 (11:42 +0100)]
Parser cleanup: simplify structure's fields' names

Damn, my eclipse fail that refactoring! That's manual, pity me...

8 years agoReimplement the lua console on top of sg_platf
Martin Quinson [Tue, 8 Nov 2011 10:27:02 +0000 (11:27 +0100)]
Reimplement the lua console on top of sg_platf

I admit it was too early to do that change since sg_platf is not quite
fully separated from the XML parsing yet, but the cruft accumulates
from everywhere, so I have to break stuff a bit to fix the overall
picture. Yeah, the lua tests are not fixed yet.

8 years agokill more empty function chaining in lua console
Martin Quinson [Tue, 8 Nov 2011 08:06:29 +0000 (09:06 +0100)]
kill more empty function chaining in lua console

8 years agoSlight cleanups in the lua console
Martin Quinson [Mon, 7 Nov 2011 23:16:44 +0000 (00:16 +0100)]
Slight cleanups in the lua console

- kill some empty functions chaining
- allow for the creation of routers from lua
(the console is still broken, more profund cleanups will be needed)

8 years agoKill some further empty function chaining.
Martin Quinson [Mon, 7 Nov 2011 23:10:41 +0000 (00:10 +0100)]
Kill some further empty function chaining.

This breaks the lua console for a while, but this is to be redone with
the new sg_platf anyway.

8 years agoProperly integrate the link creation into sg_platf
Martin Quinson [Mon, 7 Nov 2011 22:57:42 +0000 (23:57 +0100)]
Properly integrate the link creation into sg_platf

8 years agoThis structure was not necessary
Christophe Thiéry [Mon, 7 Nov 2011 21:14:27 +0000 (22:14 +0100)]
This structure was not necessary

8 years agoLua: don't garbage collect a task after sending it (the receiver will)
Christophe Thiéry [Mon, 7 Nov 2011 18:21:29 +0000 (19:21 +0100)]
Lua: don't garbage collect a task after sending it (the receiver will)

Also clean the code of Lua tasks. Show an appropriate error message when
the sender tries to access a task already sent to someone else.

8 years agoLua: add a function sglua_copy_value
Christophe Thiéry [Mon, 7 Nov 2011 18:20:49 +0000 (19:20 +0100)]
Lua: add a function sglua_copy_value

8 years agoAdd comments about who should or shouldn't call MSG_task_destroy
Christophe Thiéry [Mon, 7 Nov 2011 18:19:24 +0000 (19:19 +0100)]
Add comments about who should or shouldn't call MSG_task_destroy

8 years agoAfter a send, the sender should never access the task anymore.
Christophe Thiéry [Mon, 7 Nov 2011 17:30:46 +0000 (18:30 +0100)]
After a send, the sender should never access the task anymore.

Since processes are in different Lua worlds, the receiver can garbage
collect the task.

8 years agofurther parser cleanups
Martin Quinson [Mon, 7 Nov 2011 17:05:18 +0000 (18:05 +0100)]
further parser cleanups

Properly integrate the begin and end of platform definition in sg_platf.

New public functions:
 - sg_platf_open()
 - sg_platf_close()
New internal callback:
 - sg_platf_postparse_add_cb(void_f_void_t)
 (nobody cares about sg_platf_open(), it's just here for cosmetics in
  user code)

8 years agoalso deprecate ETag_surfxml_router
Martin Quinson [Mon, 7 Nov 2011 15:40:25 +0000 (16:40 +0100)]
also deprecate ETag_surfxml_router

8 years agoMerge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Martin Quinson [Mon, 7 Nov 2011 15:33:59 +0000 (16:33 +0100)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid

8 years agoFurther parser cleanups
Martin Quinson [Mon, 7 Nov 2011 15:33:11 +0000 (16:33 +0100)]
Further parser cleanups

- Kill useless function chaining
- Deprecate the ETag_host in XML now that it's useless

8 years agoDon't use a fix value of host.
Navarrop [Mon, 7 Nov 2011 15:06:05 +0000 (16:06 +0100)]
Don't use a fix value of host.

8 years agoAdd a source file for model vivaldi. Write vivaldi_get_route.
Navarrop [Mon, 7 Nov 2011 14:35:46 +0000 (15:35 +0100)]
Add a source file for model vivaldi. Write vivaldi_get_route.
Update vivaldi platforms (examples/platforms/syscoord/

8 years agoRemove some bprintf, fix memleaks.
Navarrop [Mon, 7 Nov 2011 13:39:13 +0000 (14:39 +0100)]
Remove some bprintf, fix memleaks.

8 years agofix the last broken tests by sanitizing the way properties are handled during the...
Martin Quinson [Mon, 7 Nov 2011 13:11:01 +0000 (14:11 +0100)]
fix the last broken tests by sanitizing the way properties are handled during the parse

8 years agoResolved merge "merge changes. Strange, it seems to ate pierre commit" and
Navarrop [Mon, 7 Nov 2011 12:52:30 +0000 (13:52 +0100)]
Resolved merge "merge changes. Strange, it seems to ate pierre commit" and
 redo the missing part. Set the struct for get_route of tag cluster.

8 years agoRemove unused function.
Navarrop [Mon, 7 Nov 2011 12:50:43 +0000 (13:50 +0100)]
Remove unused function.

8 years agoFurther parser cleanups
Martin Quinson [Mon, 7 Nov 2011 11:14:15 +0000 (12:14 +0100)]
Further parser cleanups

Simply rename a bunch of symbols to make the module logic clear

8 years agointegrate properly the router creation in sg_platf module
Martin Quinson [Mon, 7 Nov 2011 11:04:31 +0000 (12:04 +0100)]
integrate properly the router creation in sg_platf module

8 years agoplug memleaks: surfxml does not allocate memory, sg_platf (and callbacks) do it on...
Martin Quinson [Mon, 7 Nov 2011 10:47:11 +0000 (11:47 +0100)]
plug memleaks: surfxml does not allocate memory, sg_platf (and callbacks) do it on need

8 years agoMake the sg_plat_new_host() function public
Martin Quinson [Mon, 7 Nov 2011 10:41:10 +0000 (11:41 +0100)]
Make the sg_plat_new_host() function public

8 years agoMerge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Martin Quinson [Mon, 7 Nov 2011 10:35:08 +0000 (11:35 +0100)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid

8 years agoContinue parser cleanups
Martin Quinson [Mon, 7 Nov 2011 10:31:15 +0000 (11:31 +0100)]
Continue parser cleanups

Prepare to split the interface of sg_platf in two: one public
interface (include/simgrid/platf.h) will contain the function
available to the user code to create elements while another interface
(src/include/simgrid/platf_interface.h) will contain what internal
modules need to declare callbacks on the element creation events.

For now, the files are still very empty, but I try to not break stuff
even further, so I commit soon.

8 years agoThe parser's behavior has changed, revalidate the output of msg-trace
Christophe Thiéry [Mon, 7 Nov 2011 10:03:09 +0000 (11:03 +0100)]
The parser's behavior has changed, revalidate the output of msg-trace

8 years agoAdd some _XBT_GNUC_UNUSED to avoid compilation warnings with NDEBUG
Christophe Thiéry [Mon, 7 Nov 2011 09:50:42 +0000 (10:50 +0100)]
Add some _XBT_GNUC_UNUSED to avoid compilation warnings with NDEBUG

8 years agoThis include is not needed anymore.
Arnaud Giersch [Mon, 7 Nov 2011 06:40:43 +0000 (07:40 +0100)]
This include is not needed anymore.

8 years agoRemove useless code obfuscation.
Arnaud Giersch [Sun, 6 Nov 2011 17:18:21 +0000 (18:18 +0100)]
Remove useless code obfuscation.

8 years agoFix handling of the backtrace log formatters %b and %B.
Arnaud Giersch [Sun, 6 Nov 2011 10:54:58 +0000 (11:54 +0100)]
Fix handling of the backtrace log formatters %b and %B.

The first backtrace entry (_xbt_log_event_log) is not displayed.

8 years agoCosmetics: fix comment.
Arnaud Giersch [Sun, 6 Nov 2011 10:50:18 +0000 (11:50 +0100)]
Cosmetics: fix comment.

8 years agoA message changed its category.
Arnaud Giersch [Sat, 5 Nov 2011 22:53:23 +0000 (23:53 +0100)]
A message changed its category.

8 years agoImprove xbt_log_layout_format_doit().
Arnaud Giersch [Sat, 5 Nov 2011 22:24:26 +0000 (23:24 +0100)]
Improve xbt_log_layout_format_doit().

Make it simpler and faster.

Not sure about the %b formatter, but who cares?

8 years agoImprove xbt_log_layout_simple_doit().
Arnaud Giersch [Sat, 5 Nov 2011 21:37:12 +0000 (22:37 +0100)]
Improve xbt_log_layout_simple_doit().

Make it simpler and slightly faster.

8 years agoAvoid (almost) duplicated code in xbt_log_layout_*.
Arnaud Giersch [Sat, 5 Nov 2011 21:12:11 +0000 (22:12 +0100)]
Avoid (almost) duplicated code in xbt_log_layout_*.

Remove the dynamic log layout function.

The layout functions now try to build the log string in a buffer of given
length, and return success or failure.

The first try is with a buffer of fixed size.
In case of failure, the buffer is expanded, until it is large enough.

With this change, the code is much simpler, and the only penalty is with
very large log strings.

8 years agoUse fputs() instead of fprintf("%s") in file log appender.
Arnaud Giersch [Sat, 5 Nov 2011 20:54:10 +0000 (21:54 +0100)]
Use fputs() instead of fprintf("%s") in file log appender.

It is more natural, and should be faster.

8 years agoRemove old debugging cruft.
Arnaud Giersch [Sat, 5 Nov 2011 20:51:52 +0000 (21:51 +0100)]
Remove old debugging cruft.

Rationale: xbt_backtrace_display_current() uses fprintf(stderr) instead
of the logging facility.

8 years agoFix the fixme.
Arnaud Giersch [Sat, 5 Nov 2011 20:50:41 +0000 (21:50 +0100)]
Fix the fixme.

And don't short-circuit the logging facility.

8 years agousing pointer to scalar is a strange way to return a value...
Martin Quinson [Sat, 5 Nov 2011 15:41:42 +0000 (16:41 +0100)]
using pointer to scalar is a strange way to return a value...