Arnaud Giersch [Thu, 20 Jul 2017 09:56:07 +0000 (11:56 +0200)]
Revert "Give back control to maestro as late as possible."
This reverts commit
c7829c256a041aae9a60454263de30188b3f2fcc.
Tests are failing on Travis, and build faild on Appveyor :-(
Arnaud Giersch [Wed, 19 Jul 2017 20:31:33 +0000 (22:31 +0200)]
Give back control to maestro as late as possible.
The test allred from smpi-mpich3-coll-thread (with thread contexts factory and
mmap privatization) occasionally segfaults on thread exit:
teshsuite/smpi/mpich3-test/coll$ ../../../../smpi_script/bin/smpirun \
-platform ../../../../examples/platforms/small_platform_with_routers.xml \
-hostfile ../../hostfile_coll --cfg=smpi/running-power:1e9 \
--cfg=smpi/async-small-thresh:65536 --cfg=contexts/factory:thread \
--cfg=smpi/privatization:1 -np 4 ./allred
[...]
No Errors
Segmentation fault.
Backtrace:
#0 do_lookup_x (...) at dl-lookup.c:98
#1 0x00007ffff7de596d in _dl_lookup_symbol_x (...) at dl-lookup.c:737
#2 0x00007ffff6a4da75 in do_dlsym (...) at dl-libc.c:97
#3 0x00007ffff7deaaa4 in _dl_catch_error (...) at dl-error.c:187
#4 0x00007ffff6a4dabf in dlerror_run (...) at dl-libc.c:46
#5 0x00007ffff6a4db78 in __GI___libc_dlsym (...) at dl-libc.c:210
#6 0x00007ffff730dfbe in pthread_cancel_init ()
at ../nptl/sysdeps/pthread/unwind-forcedunwind.c:55
#7 0x00007ffff730e16c in _Unwind_ForcedUnwind (...)
1at ../nptl/sysdeps/pthread/unwind-forcedunwind.c:129
#8 0x00007ffff730c5d0 in __GI___pthread_unwind (...>) at unwind.c:129
#9 0x00007ffff7307365 in __do_cancel () at pthreadP.h:280
#10 __pthread_exit (...) at pthread_exit.c:29
#11 0x00007ffff7c12df9 in xbt_os_thread_exit (...)
at [...]/src/xbt/xbt_os_thread.c:251
#12 0x00007ffff7c938ab in stop (...)
at [...]/src/kernel/context/ContextThread.cpp:205
#13 simgrid::kernel::context::ThreadContext::wrapper(void*) (...)
at [...]/src/kernel/context/ContextThread.cpp:159
#14 0x00007ffff7c16131 in wrapper_start_routine (...)
at [...]/src/xbt/xbt_os_thread.c:154
#15 0x00007ffff7306064 in start_thread (...) at pthread_create.c:309
#16 0x00007ffff6a1862d in clone ()
at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
Even if I don't fully understand what's going on, I suspect that a segment
switch is occurring while the thread is running some cleanup handlers. Thus the
proposed fix tries to delay the call to xbt_os_sem_release as late as possible.
Arnaud Giersch [Wed, 19 Jul 2017 14:15:51 +0000 (16:15 +0200)]
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
Run smpi tracing tests in their own directories.
Avoids failures when tests are run in parallel.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
examples/msg/trace-host-user-variables: remove generated files.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
tools/graphicator: run tesh in build directory.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
examples/smpi/replay_multiple: put generated file in build directory.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
teshsuite/smpi/mpich3-test/f77/datatype: put generated file in build directory.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
teshsuite/smpi/mpich3-test/f{77,90}: remove unused includes.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
Use actual names for configuration options (kebab-case + a few renames).
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
Add missing calls to XBT_LOG_CONNECT.
Frederic Suter [Thu, 20 Jul 2017 08:24:26 +0000 (10:24 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Thu, 20 Jul 2017 08:24:08 +0000 (10:24 +0200)]
try to please sonar and avoid protected fields
Frederic Suter [Thu, 20 Jul 2017 07:46:16 +0000 (09:46 +0200)]
remove useless function
Martin Quinson [Thu, 20 Jul 2017 07:45:51 +0000 (09:45 +0200)]
make the cpp file easier to read
Frederic Suter [Thu, 20 Jul 2017 07:41:18 +0000 (09:41 +0200)]
char* to string == free--
Frederic Suter [Thu, 20 Jul 2017 07:36:36 +0000 (09:36 +0200)]
adress smells in cpuTI
Martin Quinson [Wed, 19 Jul 2017 22:15:31 +0000 (00:15 +0200)]
dont document a deprecated function, and properly mark it so
Martin Quinson [Wed, 19 Jul 2017 21:48:38 +0000 (23:48 +0200)]
don't repeat yourself (DRY). Implement MSG on top of S4U instead
Martin Quinson [Wed, 19 Jul 2017 21:19:40 +0000 (23:19 +0200)]
fix gcov tests
Martin Quinson [Wed, 19 Jul 2017 17:32:34 +0000 (19:32 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Frederic Suter [Wed, 19 Jul 2017 15:57:55 +0000 (17:57 +0200)]
be more explicit
Frederic Suter [Wed, 19 Jul 2017 15:53:39 +0000 (17:53 +0200)]
some of clang-format
Martin Quinson [Wed, 19 Jul 2017 15:51:57 +0000 (17:51 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Frederic Suter [Wed, 19 Jul 2017 15:41:50 +0000 (17:41 +0200)]
try to please codacy and reduce NPath complexity
Frederic Suter [Wed, 19 Jul 2017 15:31:53 +0000 (17:31 +0200)]
please both sonar and codacy
but not for the same smell
Frederic Suter [Wed, 19 Jul 2017 15:27:16 +0000 (17:27 +0200)]
only codacy would have spot this
fInput didn't even exist ...
Frederic Suter [Wed, 19 Jul 2017 14:59:45 +0000 (16:59 +0200)]
try to improve coverage
Frederic Suter [Wed, 19 Jul 2017 11:59:57 +0000 (13:59 +0200)]
kill another old-fashioned simcall
Frederic Suter [Wed, 19 Jul 2017 11:43:18 +0000 (13:43 +0200)]
remove useless try/catch
Frederic Suter [Wed, 19 Jul 2017 11:43:07 +0000 (13:43 +0200)]
cosmetics
Martin Quinson [Tue, 18 Jul 2017 15:51:37 +0000 (17:51 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Frederic Suter [Tue, 18 Jul 2017 12:38:01 +0000 (14:38 +0200)]
some cleanups in maxmin
Frederic Suter [Tue, 18 Jul 2017 07:36:48 +0000 (09:36 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Tue, 18 Jul 2017 07:21:11 +0000 (09:21 +0200)]
plug two more leaks
Martin Quinson [Tue, 18 Jul 2017 01:36:41 +0000 (03:36 +0200)]
sonar: align with some files that moved in smpi
Martin Quinson [Tue, 18 Jul 2017 01:31:11 +0000 (03:31 +0200)]
gramar in comments
Martin Quinson [Tue, 18 Jul 2017 00:31:29 +0000 (02:31 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Tue, 18 Jul 2017 00:31:09 +0000 (02:31 +0200)]
MC: checker kindly ask the app whether an actor is enabled instead of reading tons of remote memory
Martin Quinson [Mon, 17 Jul 2017 23:49:16 +0000 (01:49 +0200)]
foward.h should remain as short as possible
Martin Quinson [Mon, 17 Jul 2017 23:41:10 +0000 (01:41 +0200)]
Merge pull request #200 from Takishipp/clear_fct
Replace a function by its contents
Martin Quinson [Mon, 17 Jul 2017 22:44:01 +0000 (00:44 +0200)]
cosmetics and comments
Augustin Degomme [Mon, 17 Jul 2017 19:39:33 +0000 (21:39 +0200)]
try with privatization
degomme [Mon, 17 Jul 2017 18:35:58 +0000 (20:35 +0200)]
activate new fortran test
degomme [Mon, 17 Jul 2017 18:10:08 +0000 (20:10 +0200)]
Add some missing SMPI fortran bindings (recently supported functions)
degomme [Mon, 17 Jul 2017 16:03:25 +0000 (18:03 +0200)]
Split up Fortran bindings in several files to avoid 2000 lines files.
degomme [Mon, 17 Jul 2017 15:24:46 +0000 (17:24 +0200)]
Explode 3700 lines of smpi_pmpi.cpp file in several smaller files.
degomme [Mon, 17 Jul 2017 13:41:54 +0000 (15:41 +0200)]
Suppress also the privatization dlopen handle "leak" in valgrind.
degomme [Mon, 17 Jul 2017 13:14:13 +0000 (15:14 +0200)]
Big move of all SMPI files in subfolders because it was a mess.
bindings : all C/F77 bindings + PMPI_* entry functions, which will be split up into several files next
mpi : all MPI structures (Request, Op, Info, Datatype, ...) implementation.
colls : untouched, collective comms folder
internals : all SMPI specifics (sharing, dvfs, instr, privatization, processes...)
include : all *.hpp and .h files (should it be moved ? it's added by default in the include path now)
degomme [Mon, 17 Jul 2017 11:43:16 +0000 (13:43 +0200)]
remove spurious ;
Frederic Suter [Mon, 17 Jul 2017 12:16:47 +0000 (14:16 +0200)]
plug leaks in low level tests
adding a higher level init function ensures that all data structures
are correctly deallocated.
Would be better to not allocate them at all (dict of mailboxes for
instance), but no user won't ever write XBT or SURF test, will they?
Frederic Suter [Mon, 17 Jul 2017 11:42:53 +0000 (13:42 +0200)]
leak plug
Frederic Suter [Mon, 17 Jul 2017 10:10:01 +0000 (12:10 +0200)]
codacy treats
Takishipp [Mon, 17 Jul 2017 10:05:59 +0000 (12:05 +0200)]
some optimizations
Takishipp [Mon, 17 Jul 2017 08:13:29 +0000 (10:13 +0200)]
delete comment
Takishipp [Mon, 17 Jul 2017 08:09:33 +0000 (10:09 +0200)]
Replace a function by its contents
Martin Quinson [Mon, 17 Jul 2017 06:40:34 +0000 (08:40 +0200)]
fix non-MC builds
Martin Quinson [Mon, 17 Jul 2017 06:09:01 +0000 (08:09 +0200)]
untangle a tiny bit checker algo and enabled actor
Martin Quinson [Sun, 16 Jul 2017 22:49:57 +0000 (00:49 +0200)]
remove one layer of calls
Martin Quinson [Sun, 16 Jul 2017 21:54:46 +0000 (23:54 +0200)]
cosmetics
Martin Quinson [Sun, 16 Jul 2017 19:32:40 +0000 (21:32 +0200)]
this is a hpp header
Martin Quinson [Sun, 16 Jul 2017 19:25:23 +0000 (21:25 +0200)]
cosmetics
Martin Quinson [Sun, 16 Jul 2017 16:22:42 +0000 (18:22 +0200)]
further cleanups of the MC protocol (and fix its build :)
Martin Quinson [Sun, 16 Jul 2017 16:00:35 +0000 (18:00 +0200)]
MC: rename process into RemoteClient
This is a proxy to the Client (ie the MCed), as seen from the server
(ie, the MCer)
Martin Quinson [Sun, 16 Jul 2017 14:10:07 +0000 (16:10 +0200)]
cleanups in the MC protocol
Martin Quinson [Sat, 15 Jul 2017 21:13:28 +0000 (23:13 +0200)]
sonar
Martin Quinson [Sat, 15 Jul 2017 21:02:55 +0000 (23:02 +0200)]
fix java builds
Martin Quinson [Sat, 15 Jul 2017 20:44:37 +0000 (22:44 +0200)]
deprecate properly another function
Martin Quinson [Thu, 13 Jul 2017 22:37:30 +0000 (00:37 +0200)]
fix clang builds
Martin Quinson [Thu, 13 Jul 2017 21:45:21 +0000 (23:45 +0200)]
properly deprecate another function
Martin Quinson [Thu, 13 Jul 2017 16:04:45 +0000 (18:04 +0200)]
Improve deprecate messages: we know when to remove it
Martin Quinson [Thu, 13 Jul 2017 10:41:00 +0000 (12:41 +0200)]
codacy
Frederic Suter [Thu, 13 Jul 2017 12:18:31 +0000 (14:18 +0200)]
a few sonar treats
Martin Quinson [Thu, 13 Jul 2017 10:01:49 +0000 (12:01 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid
Frederic Suter [Thu, 13 Jul 2017 09:41:20 +0000 (11:41 +0200)]
please sonar
Frederic Suter [Thu, 13 Jul 2017 09:40:57 +0000 (11:40 +0200)]
plug leak
Martin Quinson [Thu, 13 Jul 2017 09:11:50 +0000 (11:11 +0200)]
Merge pull request #199 from Takishipp/clear_fct
Delete useless functions
Takishipp [Thu, 13 Jul 2017 09:07:27 +0000 (11:07 +0200)]
solve codacy issue
Frederic Suter [Thu, 13 Jul 2017 07:33:53 +0000 (09:33 +0200)]
fix 32-bit storage tests
The modification of the N11 storage model uses a rounding method so
that entire numbers of bytes are written at each action update. This
causes a slight difference of 30 nanoseconds in the total execution
time of the example. Assume that we can leave with that and just print
time up to the millisecond. Moreover this model is going to change
again soon.
Frederic Suter [Thu, 13 Jul 2017 06:49:14 +0000 (08:49 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Martin Quinson [Wed, 12 Jul 2017 21:08:21 +0000 (23:08 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Wed, 12 Jul 2017 21:06:27 +0000 (23:06 +0200)]
sonar
Martin Quinson [Wed, 12 Jul 2017 21:06:09 +0000 (23:06 +0200)]
don't commit binaries
Martin Quinson [Wed, 12 Jul 2017 20:26:36 +0000 (22:26 +0200)]
Merge pull request #198 from Takishipp/clear_fct
Remove an unused function
Frederic Suter [Wed, 12 Jul 2017 17:49:37 +0000 (19:49 +0200)]
simplify simcalls
Frederic Suter [Wed, 12 Jul 2017 16:53:11 +0000 (18:53 +0200)]
simplify mgmt of write on storage + cleanups
decoupling files from storage model is one step closer
Takishipp [Wed, 12 Jul 2017 13:58:33 +0000 (15:58 +0200)]
Delete useless functions
Takishipp [Wed, 12 Jul 2017 13:55:28 +0000 (15:55 +0200)]
Delete an another unused fonction
Takishipp [Wed, 12 Jul 2017 13:42:11 +0000 (15:42 +0200)]
remove unused function
Frederic Suter [Wed, 12 Jul 2017 13:41:40 +0000 (15:41 +0200)]
update doc
Martin Quinson [Wed, 12 Jul 2017 13:40:15 +0000 (15:40 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid
Frederic Suter [Wed, 12 Jul 2017 13:19:25 +0000 (15:19 +0200)]
revisit pingpong in s4u
Frederic Suter [Wed, 12 Jul 2017 11:04:04 +0000 (13:04 +0200)]
mv deprecated examples to teshsuite
Martin Quinson [Wed, 12 Jul 2017 11:51:41 +0000 (13:51 +0200)]
Merge pull request #197 from Takishipp/clear_fct
remove print_Null function
Frederic Suter [Wed, 12 Jul 2017 10:46:55 +0000 (12:46 +0200)]
do not use deprecated and redirected functions in examples
Frederic Suter [Wed, 12 Jul 2017 10:40:07 +0000 (12:40 +0200)]
plugins are the future, this example pertains to S4U
Takishipp [Wed, 12 Jul 2017 09:42:00 +0000 (11:42 +0200)]
Delete the whole comment
Frederic Suter [Wed, 12 Jul 2017 08:05:14 +0000 (10:05 +0200)]
dict to map in vms
Frederic Suter [Wed, 12 Jul 2017 06:26:59 +0000 (08:26 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Martin Quinson [Tue, 11 Jul 2017 16:08:08 +0000 (18:08 +0200)]
ignore more cruft