Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoFix use-after-free.
Arnaud Giersch [Thu, 26 Nov 2020 11:47:27 +0000 (12:47 +0100)]
Fix use-after-free.

3 years agoSet default values.
Arnaud Giersch [Thu, 26 Nov 2020 11:34:42 +0000 (12:34 +0100)]
Set default values.

3 years agoReduce scope for variables.
Arnaud Giersch [Thu, 26 Nov 2020 11:28:18 +0000 (12:28 +0100)]
Reduce scope for variables.

3 years agoUse xbt_new0 (calloc may fail).
Arnaud Giersch [Thu, 26 Nov 2020 11:20:27 +0000 (12:20 +0100)]
Use xbt_new0 (calloc may fail).

3 years agoCosmetics.
Arnaud Giersch [Thu, 26 Nov 2020 10:49:32 +0000 (11:49 +0100)]
Cosmetics.

3 years agoDon't set variable twice.
Arnaud Giersch [Thu, 26 Nov 2020 10:45:41 +0000 (11:45 +0100)]
Don't set variable twice.

3 years agoDon't repeat obvious default values.
Arnaud Giersch [Thu, 26 Nov 2020 10:41:41 +0000 (11:41 +0100)]
Don't repeat obvious default values.

3 years agoCorrectly handle lowercase and default values for route/symmetrical.
Arnaud Giersch [Thu, 26 Nov 2020 10:16:27 +0000 (11:16 +0100)]
Correctly handle lowercase and default values for route/symmetrical.

3 years agostd::array...
Arnaud Giersch [Thu, 26 Nov 2020 08:22:37 +0000 (09:22 +0100)]
std::array...

3 years ago[pvs] A part of conditional expression is always false: parameters.empty().
Arnaud Giersch [Wed, 25 Nov 2020 22:00:42 +0000 (23:00 +0100)]
[pvs] A part of conditional expression is always false: parameters.empty().

3 years ago[pvs] A part of conditional expression is always false: simcall == nullptr.
Arnaud Giersch [Wed, 25 Nov 2020 21:57:57 +0000 (22:57 +0100)]
[pvs] A part of conditional expression is always false: simcall == nullptr.

3 years ago[pvs] Expression 'req' is always true.
Arnaud Giersch [Wed, 25 Nov 2020 21:55:46 +0000 (22:55 +0100)]
[pvs] Expression 'req' is always true.

3 years ago[pvs] Two or more case-branches perform the same actions.
Arnaud Giersch [Wed, 25 Nov 2020 21:47:23 +0000 (22:47 +0100)]
[pvs] Two or more case-branches perform the same actions.

3 years ago[pvs] The 'tp' pointer was utilized before it was verified against nullptr.
Arnaud Giersch [Wed, 25 Nov 2020 21:37:01 +0000 (22:37 +0100)]
[pvs] The 'tp' pointer was utilized before it was verified against nullptr.

3 years ago[pvs] The 'gw_src' pointer was utilized before it was verified against nullptr.
Arnaud Giersch [Wed, 25 Nov 2020 21:26:44 +0000 (22:26 +0100)]
[pvs] The 'gw_src' pointer was utilized before it was verified against nullptr.

3 years ago[pvs] The 'status' pointer was utilized before it was verified against nullptr.
Arnaud Giersch [Wed, 25 Nov 2020 21:12:02 +0000 (22:12 +0100)]
[pvs] The 'status' pointer was utilized before it was verified against nullptr.

3 years ago[pvs] The 'mc_model_checker' pointer was utilized before it was verified against...
Arnaud Giersch [Wed, 25 Nov 2020 21:07:07 +0000 (22:07 +0100)]
[pvs] The 'mc_model_checker' pointer was utilized before it was verified against nullptr.

3 years agoEnum class for MC call types, and MC comm pattern differences.
Arnaud Giersch [Wed, 18 Nov 2020 20:23:15 +0000 (21:23 +0100)]
Enum class for MC call types, and MC comm pattern differences.

3 years agoEnum class for MC call types, and MC comm pattern differences.
Arnaud Giersch [Wed, 18 Nov 2020 20:23:15 +0000 (21:23 +0100)]
Enum class for MC call types, and MC comm pattern differences.

3 years agoEnum class for MC call types, and MC comm pattern differences.
Arnaud Giersch [Wed, 18 Nov 2020 20:23:15 +0000 (21:23 +0100)]
Enum class for MC call types, and MC comm pattern differences.

3 years agoprojet_description: lookup in ModelChecker build too (e.g. for Java version).
Arnaud Giersch [Wed, 25 Nov 2020 19:26:37 +0000 (20:26 +0100)]
projet_description: lookup in ModelChecker build too (e.g. for Java version).

3 years agoFix buffer overflow.
Arnaud Giersch [Wed, 25 Nov 2020 16:17:47 +0000 (17:17 +0100)]
Fix buffer overflow.

3 years agoOnce again, use sd::array instead of C-style arrays.
Arnaud Giersch [Wed, 25 Nov 2020 15:09:07 +0000 (16:09 +0100)]
Once again, use sd::array instead of C-style arrays.

3 years agoUnused field.
Arnaud Giersch [Wed, 25 Nov 2020 14:56:11 +0000 (15:56 +0100)]
Unused field.

3 years agoSave another bunch of new/delete.
Arnaud Giersch [Wed, 25 Nov 2020 14:07:38 +0000 (15:07 +0100)]
Save another bunch of new/delete.

3 years agoA binary search can be used here too.
Arnaud Giersch [Wed, 25 Nov 2020 12:05:12 +0000 (13:05 +0100)]
A binary search can be used here too.

3 years agoReplace another handmade binary search.
Arnaud Giersch [Wed, 25 Nov 2020 08:40:04 +0000 (09:40 +0100)]
Replace another handmade binary search.

3 years ago[sonar] Rename local parameters.
Arnaud Giersch [Wed, 25 Nov 2020 08:17:42 +0000 (09:17 +0100)]
[sonar] Rename local parameters.

3 years agoWorks without pointer too.
Arnaud Giersch [Tue, 24 Nov 2020 22:07:06 +0000 (23:07 +0100)]
Works without pointer too.

3 years agoUse std algorithms for binary search.
Arnaud Giersch [Tue, 24 Nov 2020 16:30:28 +0000 (17:30 +0100)]
Use std algorithms for binary search.

3 years ago[sonar] Reduce number of 'break' in loop.
Arnaud Giersch [Tue, 24 Nov 2020 16:07:48 +0000 (17:07 +0100)]
[sonar] Reduce number of 'break' in loop.

3 years agoKill unused field.
Arnaud Giersch [Tue, 24 Nov 2020 14:50:29 +0000 (15:50 +0100)]
Kill unused field.

3 years agoDon't modify loop counter inside of loop body.
Arnaud Giersch [Tue, 24 Nov 2020 14:24:24 +0000 (15:24 +0100)]
Don't modify loop counter inside of loop body.

3 years agoFor sonar, remove explicit new/delete.
Arnaud Giersch [Tue, 24 Nov 2020 09:16:11 +0000 (10:16 +0100)]
For sonar, remove explicit new/delete.

3 years agoRevert "Make simgrid::xbt::action_fs a std::unique_ptr."
Arnaud Giersch [Tue, 24 Nov 2020 09:07:51 +0000 (10:07 +0100)]
Revert "Make simgrid::xbt::action_fs a std::unique_ptr."

This reverts commit cb0572c871501a8dab8e7ad5a833bb372b743d01.

It's a bit too cumbersome.

3 years agoExplicit cast.
Arnaud Giersch [Tue, 24 Nov 2020 08:43:39 +0000 (09:43 +0100)]
Explicit cast.

3 years agoFix ctors for smpi::Datatype.
Arnaud Giersch [Tue, 24 Nov 2020 08:34:18 +0000 (09:34 +0100)]
Fix ctors for smpi::Datatype.

const char* / unused declaration / cosmetic parameter rename

3 years agoUse a lambda for comparator.
Arnaud Giersch [Tue, 24 Nov 2020 08:19:32 +0000 (09:19 +0100)]
Use a lambda for comparator.

3 years agoCleanups in smpi::Win (use std::vector, and simplify constructor).
Arnaud Giersch [Mon, 23 Nov 2020 19:54:29 +0000 (20:54 +0100)]
Cleanups in smpi::Win (use std::vector, and simplify constructor).

3 years agoMake Datatype::name_ and Win::name_ a std::string.
Arnaud Giersch [Mon, 23 Nov 2020 15:37:21 +0000 (16:37 +0100)]
Make Datatype::name_ and Win::name_ a std::string.

3 years agoUse std::unique_ptr with std::ifstream.
Arnaud Giersch [Mon, 23 Nov 2020 15:15:20 +0000 (16:15 +0100)]
Use std::unique_ptr with std::ifstream.

3 years agoMore std::vector's.
Arnaud Giersch [Mon, 23 Nov 2020 15:03:27 +0000 (16:03 +0100)]
More std::vector's.

3 years agoOne more std::unique_ptr.
Arnaud Giersch [Mon, 23 Nov 2020 14:23:25 +0000 (15:23 +0100)]
One more std::unique_ptr.

3 years agoUseless dynamic allocation.
Arnaud Giersch [Mon, 23 Nov 2020 11:43:12 +0000 (12:43 +0100)]
Useless dynamic allocation.

3 years agoAutomatic memory management with std::unique_ptr.
Arnaud Giersch [Mon, 23 Nov 2020 11:11:25 +0000 (12:11 +0100)]
Automatic memory management with std::unique_ptr.

3 years agoMake simgrid::xbt::action_fs a std::unique_ptr.
Arnaud Giersch [Mon, 23 Nov 2020 11:00:22 +0000 (12:00 +0100)]
Make simgrid::xbt::action_fs a std::unique_ptr.

3 years agoUse std::unique_ptr for Message::answer_.
Arnaud Giersch [Mon, 23 Nov 2020 09:53:21 +0000 (10:53 +0100)]
Use std::unique_ptr for Message::answer_.

3 years agoUpdate simgrid.supp for libcgraph.
Arnaud Giersch [Sun, 22 Nov 2020 22:47:55 +0000 (23:47 +0100)]
Update simgrid.supp for libcgraph.

3 years agoRevert "Adapt projet_description again."
Arnaud Giersch [Sun, 22 Nov 2020 22:08:59 +0000 (23:08 +0100)]
Revert "Adapt projet_description again."

This reverts commit 18b77c424fa1cc619955fbe3839a1e4b5eec2a8d.

3 years agoAdapt projet_description again.
Arnaud Giersch [Sun, 22 Nov 2020 21:31:30 +0000 (22:31 +0100)]
Adapt projet_description again.

3 years agoMore thorough cleaning of /tmp on jenkins.
Arnaud Giersch [Sun, 22 Nov 2020 21:02:55 +0000 (22:02 +0100)]
More thorough cleaning of /tmp on jenkins.

3 years agoReally ignore Python 3.8 and later on appveyor.
Arnaud Giersch [Sun, 22 Nov 2020 20:44:05 +0000 (21:44 +0100)]
Really ignore Python 3.8 and later on appveyor.

3 years agoIt's ok to have only Python3_Interpreter.
Arnaud Giersch [Sun, 22 Nov 2020 20:22:42 +0000 (21:22 +0100)]
It's ok to have only Python3_Interpreter.

3 years agoSearch for Python3_Development too.
Arnaud Giersch [Sun, 22 Nov 2020 20:17:21 +0000 (21:17 +0100)]
Search for Python3_Development too.

3 years agoadapt projet_description for new python3 detection
Augustin Degomme [Sun, 22 Nov 2020 16:01:01 +0000 (17:01 +0100)]
adapt projet_description for new python3 detection

3 years agoUse ssize_t.
Arnaud Giersch [Sun, 22 Nov 2020 14:14:02 +0000 (15:14 +0100)]
Use ssize_t.

3 years ago[sonar] Extract assignment from sub-expression.
Arnaud Giersch [Sun, 22 Nov 2020 14:11:27 +0000 (15:11 +0100)]
[sonar] Extract assignment from sub-expression.

3 years agoGot SIGBUS with std::array; give std::vector a try.
Arnaud Giersch [Sun, 22 Nov 2020 13:45:26 +0000 (14:45 +0100)]
Got SIGBUS with std::array; give std::vector a try.

3 years agoRevert "Use nullptr for recvbuf when myrank != 0."
Arnaud Giersch [Sun, 22 Nov 2020 09:11:20 +0000 (10:11 +0100)]
Revert "Use nullptr for recvbuf when myrank != 0."

This reverts commit cc88d06e4fd1c32dddf17295ff750c60792588e5.

As expected it makes no difference, and it's simpler.

3 years agowe use this variable later on
Augustin Degomme [Sun, 22 Nov 2020 13:09:34 +0000 (14:09 +0100)]
we use this variable later on

3 years agopython detection with pythoninterp was deprecated in cmake 3.12. And breaks in 3.19
Augustin Degomme [Sun, 22 Nov 2020 12:19:51 +0000 (13:19 +0100)]
python detection with pythoninterp was deprecated in cmake 3.12. And breaks in 3.19

3 years agoUse nullptr for recvbuf when myrank != 0.
Arnaud Giersch [Sat, 21 Nov 2020 22:28:17 +0000 (23:28 +0100)]
Use nullptr for recvbuf when myrank != 0.

Not sure if it makes any difference, but it was like that before.

3 years agoFix test requirement (and add missing semicolon).
Arnaud Giersch [Sat, 21 Nov 2020 21:23:13 +0000 (22:23 +0100)]
Fix test requirement (and add missing semicolon).

3 years agoKill two unused helper functions.
Arnaud Giersch [Sat, 21 Nov 2020 14:51:29 +0000 (15:51 +0100)]
Kill two unused helper functions.

3 years agoRemove more new/delete, this time for lmm::System in maxmin tests.
Arnaud Giersch [Sat, 21 Nov 2020 14:33:46 +0000 (15:33 +0100)]
Remove more new/delete, this time for lmm::System in maxmin tests.

3 years agoRemove useless new/delete (please sonar).
Arnaud Giersch [Fri, 20 Nov 2020 23:19:38 +0000 (00:19 +0100)]
Remove useless new/delete (please sonar).

3 years agoAdapt to std::vector.
Arnaud Giersch [Sat, 21 Nov 2020 13:26:22 +0000 (14:26 +0100)]
Adapt to std::vector.

3 years agoReplace dynamic C-style arrays with std::vector.
Arnaud Giersch [Fri, 20 Nov 2020 20:54:06 +0000 (21:54 +0100)]
Replace dynamic C-style arrays with std::vector.

3 years agoReplace fixed-size C-style arrays with std::array.
Arnaud Giersch [Fri, 20 Nov 2020 20:52:39 +0000 (21:52 +0100)]
Replace fixed-size C-style arrays with std::array.

3 years agoUse more std::string.
Arnaud Giersch [Fri, 20 Nov 2020 20:43:47 +0000 (21:43 +0100)]
Use more std::string.

3 years agoMisc simplifications.
Arnaud Giersch [Fri, 20 Nov 2020 20:36:48 +0000 (21:36 +0100)]
Misc simplifications.

3 years agoMake pointer parameter const.
Arnaud Giersch [Fri, 20 Nov 2020 14:41:44 +0000 (15:41 +0100)]
Make pointer parameter const.

3 years agoone day, I'll add a test for this feature
Augustin Degomme [Thu, 19 Nov 2020 17:41:01 +0000 (18:41 +0100)]
one day, I'll add a test for this feature

3 years agoDefine NUM_SIMCALLS apart from the enum.
Arnaud Giersch [Thu, 19 Nov 2020 12:53:48 +0000 (13:53 +0100)]
Define NUM_SIMCALLS apart from the enum.

3 years agoDon't call function inside xbt_assert which may be disabled.
Arnaud Giersch [Thu, 19 Nov 2020 11:58:26 +0000 (12:58 +0100)]
Don't call function inside xbt_assert which may be disabled.

3 years agoVariables captured by copy are constant and cannot be std::move'd.
Arnaud Giersch [Thu, 19 Nov 2020 08:35:48 +0000 (09:35 +0100)]
Variables captured by copy are constant and cannot be std::move'd.

Try to fix with C++14 generalized lambda capture and 'mutable' specifier.

3 years agoMore useless std::move.
Arnaud Giersch [Thu, 19 Nov 2020 08:34:33 +0000 (09:34 +0100)]
More useless std::move.

3 years agoCosmetics.
Arnaud Giersch [Thu, 19 Nov 2020 07:44:47 +0000 (08:44 +0100)]
Cosmetics.

3 years agoConstify some sg_vm_t.
Arnaud Giersch [Thu, 19 Nov 2020 07:41:12 +0000 (08:41 +0100)]
Constify some sg_vm_t.

3 years agothis message does no harm
Augustin Degomme [Thu, 19 Nov 2020 09:59:21 +0000 (10:59 +0100)]
this message does no harm

3 years agoRevert "attempt to avoid ugly sed in privatize-libs. May break."
Augustin Degomme [Thu, 19 Nov 2020 09:40:56 +0000 (10:40 +0100)]
Revert "attempt to avoid ugly sed in privatize-libs. May break."

This reverts commit c8cd61907048eff98533558f3aa7393cb6cfd424.

3 years agoRevert "Intel icc doesn't like attribute [[deprecated]] with "using"."
Arnaud Giersch [Wed, 18 Nov 2020 23:01:48 +0000 (00:01 +0100)]
Revert "Intel icc doesn't like attribute [[deprecated]] with "using"."

This reverts commit b38bb1786983cd04c54ec57dc21d3f8a061e5f74.

3 years agoIcc: ignore #2651: attribute does not apply to any entity
Arnaud Giersch [Wed, 18 Nov 2020 23:00:36 +0000 (00:00 +0100)]
Icc: ignore #2651: attribute does not apply to any entity

See
https://community.intel.com/t5/Intel-C-Compiler/Bug-report-Spurious-2651-warning-for-deprecating-a-quot-using/td-p/1144317

Also write numbers in order.

3 years agoUseless std::move.
Arnaud Giersch [Wed, 18 Nov 2020 22:51:02 +0000 (23:51 +0100)]
Useless std::move.

3 years agoUse inherited constructors for derived exceptions.
Arnaud Giersch [Wed, 18 Nov 2020 22:29:04 +0000 (23:29 +0100)]
Use inherited constructors for derived exceptions.

3 years agoUse 'using-declarations' to inherit constructors.
Arnaud Giersch [Wed, 18 Nov 2020 22:15:52 +0000 (23:15 +0100)]
Use 'using-declarations' to inherit constructors.

3 years agoEnum class for Paje event types.
Arnaud Giersch [Wed, 18 Nov 2020 20:08:35 +0000 (21:08 +0100)]
Enum class for Paje event types.

3 years agoEnum class in examples/s4u/dht-chord/.
Arnaud Giersch [Wed, 18 Nov 2020 17:23:52 +0000 (18:23 +0100)]
Enum class in examples/s4u/dht-chord/.

3 years agoEnum class in examples/s4u/app-bittorrent/.
Arnaud Giersch [Wed, 18 Nov 2020 17:04:03 +0000 (18:04 +0100)]
Enum class in examples/s4u/app-bittorrent/.

3 years agoEnum class in teshsuite/mc/random-bug/.
Arnaud Giersch [Wed, 18 Nov 2020 16:58:40 +0000 (17:58 +0100)]
Enum class in teshsuite/mc/random-bug/.

3 years agoFix function name in doc.
Arnaud Giersch [Wed, 18 Nov 2020 21:14:57 +0000 (22:14 +0100)]
Fix function name in doc.

3 years agoIntel icc doesn't like attribute [[deprecated]] with "using".
Arnaud Giersch [Wed, 18 Nov 2020 16:45:21 +0000 (17:45 +0100)]
Intel icc doesn't like attribute [[deprecated]] with "using".

3 years agoPrefer "using" to "typedef".
Arnaud Giersch [Wed, 18 Nov 2020 15:11:29 +0000 (16:11 +0100)]
Prefer "using" to "typedef".

3 years agoMore const.
Arnaud Giersch [Wed, 18 Nov 2020 14:06:09 +0000 (15:06 +0100)]
More const.

3 years agoUse =default.
Arnaud Giersch [Wed, 18 Nov 2020 13:44:58 +0000 (14:44 +0100)]
Use =default.

3 years agoMore const pointers.
Arnaud Giersch [Wed, 18 Nov 2020 13:43:05 +0000 (14:43 +0100)]
More const pointers.

3 years agoKill dead code.
Arnaud Giersch [Wed, 18 Nov 2020 13:27:35 +0000 (14:27 +0100)]
Kill dead code.

3 years agoConst Disk*.
Arnaud Giersch [Wed, 18 Nov 2020 13:25:34 +0000 (14:25 +0100)]
Const Disk*.

3 years agoPlease Sonar (even if there was no bug).
Arnaud Giersch [Wed, 18 Nov 2020 12:00:11 +0000 (13:00 +0100)]
Please Sonar (even if there was no bug).

3 years agoRemove redundant "staitc" in anonymous namespaces.
Arnaud Giersch [Wed, 18 Nov 2020 09:52:00 +0000 (10:52 +0100)]
Remove redundant "staitc" in anonymous namespaces.