Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agoAdded a test for Issue #325 (call to test is commented out for now)
henricasanova [Sat, 16 Mar 2019 10:06:00 +0000 (00:06 -1000)]
Added a test for Issue #325 (call to test is commented out for now)

2 years agoRestarting or killing maestro does not seem to be a cleaver idea
Martin Quinson [Thu, 14 Mar 2019 22:33:39 +0000 (23:33 +0100)]
Restarting or killing maestro does not seem to be a cleaver idea

2 years agofurther let the actor clean for itself
Martin Quinson [Thu, 14 Mar 2019 22:16:56 +0000 (23:16 +0100)]
further let the actor clean for itself

2 years agocleaning the actor twice seems somewhat overplayed
Martin Quinson [Thu, 14 Mar 2019 21:59:10 +0000 (22:59 +0100)]
cleaning the actor twice seems somewhat overplayed

2 years agolet the actor clean for itself
Martin Quinson [Thu, 14 Mar 2019 21:03:15 +0000 (22:03 +0100)]
let the actor clean for itself

2 years agokill parts of the old doc that were converted
Martin Quinson [Thu, 14 Mar 2019 21:02:47 +0000 (22:02 +0100)]
kill parts of the old doc that were converted

+ cosmetics

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Thu, 14 Mar 2019 15:57:45 +0000 (16:57 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agorework SleepImpl (and save a cast)
Frederic Suter [Thu, 14 Mar 2019 15:29:28 +0000 (16:29 +0100)]
rework SleepImpl (and save a cast)

2 years agoInline methods of simgrid::kernel::Resource.
Arnaud Giersch [Thu, 14 Mar 2019 14:35:47 +0000 (15:35 +0100)]
Inline methods of simgrid::kernel::Resource.

2 years agoRemove useless function pointer.
Arnaud Giersch [Thu, 14 Mar 2019 13:53:33 +0000 (14:53 +0100)]
Remove useless function pointer.

2 years agoTidying simix::Timer.
Arnaud Giersch [Thu, 14 Mar 2019 13:10:58 +0000 (14:10 +0100)]
Tidying simix::Timer.

2 years agoDefine move-assignment and delete copy-assignment operators for xbt::Task.
Arnaud Giersch [Thu, 14 Mar 2019 12:54:27 +0000 (13:54 +0100)]
Define move-assignment and delete copy-assignment operators for xbt::Task.

2 years ago[sonar] Name parameters differently than request_depend_asymmetric.
Arnaud Giersch [Thu, 14 Mar 2019 10:24:50 +0000 (11:24 +0100)]
[sonar] Name parameters differently than request_depend_asymmetric.

2 years agoTry to make tests succeed with coverage on Jenkins.
Arnaud Giersch [Thu, 14 Mar 2019 09:27:51 +0000 (10:27 +0100)]
Try to make tests succeed with coverage on Jenkins.

Increase timeout, and disallow parallel run.

2 years agoMove test declaration in proper CMakeLists.txt.
Arnaud Giersch [Thu, 14 Mar 2019 09:06:49 +0000 (10:06 +0100)]
Move test declaration in proper CMakeLists.txt.

2 years agolet base class dtor deal with surf action
Frederic Suter [Thu, 14 Mar 2019 13:07:37 +0000 (14:07 +0100)]
let base class dtor deal with surf action

For CommImpl, it seems that unref() is called too late so keep the
current dtor

2 years agoWhat ActivityImpl child should look like IMHO
Frederic Suter [Thu, 14 Mar 2019 11:49:02 +0000 (12:49 +0100)]
What ActivityImpl child should look like IMHO
* ctor does nothing more than create a class instance
* all fields can be set by chainable setters
* start() has no parameter

On the S4U side, we should have the same (with CRTP soon)
* ctor calls the Impl ctor and sets thing at user level
* start() does a simcall in which we call all the Impl setters to
  transfer all field values to the kernel and then call Impl::start()

Maybe we should also replace "new *Impl()" in S4U by a call to a
Impl::create() static method to be written.

2 years agocosmetic cleanups in S4U
Frederic Suter [Thu, 14 Mar 2019 09:57:51 +0000 (10:57 +0100)]
cosmetic cleanups in S4U

2 years agoActivate assert when debug log is active.
Arnaud Giersch [Wed, 13 Mar 2019 14:16:00 +0000 (15:16 +0100)]
Activate assert when debug log is active.

2 years agoUse std::unordered_map + save an indirection.
Arnaud Giersch [Wed, 13 Mar 2019 13:12:10 +0000 (14:12 +0100)]
Use std::unordered_map + save an indirection.

2 years agoDirectly fill vectors at construction.
Arnaud Giersch [Wed, 13 Mar 2019 10:22:29 +0000 (11:22 +0100)]
Directly fill vectors at construction.

2 years agoSimplification.
Arnaud Giersch [Wed, 13 Mar 2019 08:54:18 +0000 (09:54 +0100)]
Simplification.

2 years agoRemove unused type definitions.
Arnaud Giersch [Tue, 12 Mar 2019 21:49:31 +0000 (22:49 +0100)]
Remove unused type definitions.

2 years agodon't kill the fools sourcing this script
Martin Quinson [Wed, 13 Mar 2019 14:28:23 +0000 (15:28 +0100)]
don't kill the fools sourcing this script

2 years agocomestics in src/kernel
Frederic Suter [Wed, 13 Mar 2019 12:15:12 +0000 (13:15 +0100)]
comestics in src/kernel

2 years agocleanups in smpi, mostly cosmetic stuff and indent
Frederic Suter [Wed, 13 Mar 2019 10:56:01 +0000 (11:56 +0100)]
cleanups in smpi, mostly cosmetic stuff and indent

2 years agoComplete Asan suppressions.
Arnaud Giersch [Tue, 12 Mar 2019 21:22:37 +0000 (22:22 +0100)]
Complete Asan suppressions.

2 years agoEnsure field is initialized.
Arnaud Giersch [Tue, 12 Mar 2019 17:39:10 +0000 (18:39 +0100)]
Ensure field is initialized.

2 years agoClang is picky.
Arnaud Giersch [Tue, 12 Mar 2019 16:43:38 +0000 (17:43 +0100)]
Clang is picky.

error: local variable value will be copied despite being returned by name [-Werror,-Wreturn-std-move]

2 years agoSave valgrind_stack_id in a private field.
Arnaud Giersch [Tue, 12 Mar 2019 13:31:16 +0000 (14:31 +0100)]
Save valgrind_stack_id in a private field.

Only register stacks when running on Valgrind to avoid false alarms from Asan.

2 years agoMailboxPtr looks like a smart pointer, but it's not. Kill it.
Arnaud Giersch [Tue, 12 Mar 2019 09:53:17 +0000 (10:53 +0100)]
MailboxPtr looks like a smart pointer, but it's not. Kill it.

2 years agoRemove unnecessary calls to c_str().
Arnaud Giersch [Tue, 12 Mar 2019 09:42:03 +0000 (10:42 +0100)]
Remove unnecessary calls to c_str().

2 years agoIIUC return std::move(...) is discouraged.
Arnaud Giersch [Tue, 12 Mar 2019 15:01:39 +0000 (16:01 +0100)]
IIUC return std::move(...) is discouraged.

2 years agoReferences++.
Arnaud Giersch [Tue, 12 Mar 2019 09:20:14 +0000 (10:20 +0100)]
References++.

2 years agomv ActorImpl where it belongs
Frederic Suter [Tue, 12 Mar 2019 13:53:57 +0000 (14:53 +0100)]
mv ActorImpl where it belongs

2 years agouse consistent namespaces
Frederic Suter [Tue, 12 Mar 2019 13:12:52 +0000 (14:12 +0100)]
use consistent namespaces
Storage is a resource, it goes in simgrid::kernel::resource

2 years agodon't use old fashioned simcall when you don't have to
Frederic Suter [Tue, 12 Mar 2019 12:12:10 +0000 (13:12 +0100)]
don't use old fashioned simcall when you don't have to

2 years agoproperly split task/comm in msg files
Frederic Suter [Tue, 12 Mar 2019 10:43:05 +0000 (11:43 +0100)]
properly split task/comm in msg files

2 years agoobjectify a few msg::Comm functions
Frederic Suter [Tue, 12 Mar 2019 10:36:23 +0000 (11:36 +0100)]
objectify a few msg::Comm functions

2 years agomark old MSG functions as deprecated
Frederic Suter [Tue, 12 Mar 2019 08:19:49 +0000 (09:19 +0100)]
mark old MSG functions as deprecated

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Mon, 11 Mar 2019 16:22:45 +0000 (17:22 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agoSimplifications
Frederic Suter [Mon, 11 Mar 2019 15:31:17 +0000 (16:31 +0100)]
Simplifications

Do not use an ugly global map when each smpi process can store its own
tracing category.

2 years agoReplace void* when using std::thread.
Arnaud Giersch [Mon, 11 Mar 2019 13:53:11 +0000 (14:53 +0100)]
Replace void* when using std::thread.

2 years agoDeprecated functions are still used by StarPU. Postpone their removal.
Arnaud Giersch [Mon, 11 Mar 2019 12:26:40 +0000 (13:26 +0100)]
Deprecated functions are still used by StarPU. Postpone their removal.

2 years agoPass std::string parameters by reference too.
Arnaud Giersch [Sun, 10 Mar 2019 22:20:43 +0000 (23:20 +0100)]
Pass std::string parameters by reference too.

2 years agoDon't use pass-by-value for large parameters.
Arnaud Giersch [Sun, 10 Mar 2019 17:50:42 +0000 (18:50 +0100)]
Don't use pass-by-value for large parameters.

2 years agoMore references for parameters of type std::function.
Arnaud Giersch [Sun, 10 Mar 2019 17:37:13 +0000 (18:37 +0100)]
More references for parameters of type std::function.

2 years agoConstify.
Arnaud Giersch [Sun, 10 Mar 2019 14:46:37 +0000 (15:46 +0100)]
Constify.

2 years agoBad cast.
Arnaud Giersch [Sun, 10 Mar 2019 14:34:36 +0000 (15:34 +0100)]
Bad cast.

2 years agoMake ActorImpl::context_ a std::unique_ptr.
Arnaud Giersch [Fri, 8 Mar 2019 22:06:26 +0000 (23:06 +0100)]
Make ActorImpl::context_ a std::unique_ptr.

2 years agoMake SwappedContext::parmap_ a std::unique_ptr.
Arnaud Giersch [Fri, 8 Mar 2019 14:47:58 +0000 (15:47 +0100)]
Make SwappedContext::parmap_ a std::unique_ptr.

2 years agoCosmetics around std::unique_ptr.
Arnaud Giersch [Fri, 8 Mar 2019 14:34:00 +0000 (15:34 +0100)]
Cosmetics around std::unique_ptr.

2 years agoFix xbt_assert with side effects.
Arnaud Giersch [Sat, 9 Mar 2019 15:04:32 +0000 (16:04 +0100)]
Fix xbt_assert with side effects.

2 years agoEquality/assignment mismatch.
Arnaud Giersch [Sat, 9 Mar 2019 14:59:11 +0000 (15:59 +0100)]
Equality/assignment mismatch.

2 years agoRelease memory after last use only.
Arnaud Giersch [Fri, 8 Mar 2019 13:19:50 +0000 (14:19 +0100)]
Release memory after last use only.

2 years agoPut XBT_ATTRIB_DEPRECATED at proper place.
Arnaud Giersch [Fri, 8 Mar 2019 13:09:34 +0000 (14:09 +0100)]
Put XBT_ATTRIB_DEPRECATED at proper place.

2 years ago2 fixes in host-energy plugin
Martin Quinson [Fri, 8 Mar 2019 16:52:01 +0000 (17:52 +0100)]
2 fixes in host-energy plugin

- When computing the current watts, consistently use the pstate that
  was set at the beginning of the previous period.
  (the pstate at the end of the period was used to determinate whether
  or not we are in boot/shutdown state, ie, whether speed==0)
- Do not mark as used hosts that are just turned on and off. This is
  to be consistent with the tesh files while fixing the other bug.

2 years agoSpecify bindir while launching tesh
Martin Quinson [Wed, 6 Mar 2019 23:56:19 +0000 (00:56 +0100)]
Specify bindir while launching tesh

2 years agoUse references for callback parameters of on_exit().
Arnaud Giersch [Thu, 7 Mar 2019 16:32:41 +0000 (17:32 +0100)]
Use references for callback parameters of on_exit().

2 years agoUse references for parameters of type std::function.
Arnaud Giersch [Thu, 7 Mar 2019 15:50:38 +0000 (16:50 +0100)]
Use references for parameters of type std::function.

2 years agoUse references for parameters of type std::vector.
Arnaud Giersch [Thu, 7 Mar 2019 15:00:57 +0000 (16:00 +0100)]
Use references for parameters of type std::vector.

2 years agoFix mismatched alloc/free.
Arnaud Giersch [Wed, 6 Mar 2019 22:18:11 +0000 (23:18 +0100)]
Fix mismatched alloc/free.

2 years agoRemove duplicated but unused forward declarations.
Arnaud Giersch [Wed, 6 Mar 2019 22:10:10 +0000 (23:10 +0100)]
Remove duplicated but unused forward declarations.

2 years agoDon't hide class member.
Arnaud Giersch [Fri, 8 Mar 2019 09:12:57 +0000 (10:12 +0100)]
Don't hide class member.

2 years agoFix null pointer dereference.
Arnaud Giersch [Thu, 7 Mar 2019 17:21:39 +0000 (18:21 +0100)]
Fix null pointer dereference.

2 years agoSwitch s4u tuto to pajengr as well.
degomme [Fri, 8 Mar 2019 11:05:11 +0000 (12:05 +0100)]
Switch s4u tuto to pajengr as well.

2 years agohopefully fix most issues. thx agier for spotting the main one
Frederic Suter [Fri, 8 Mar 2019 10:11:13 +0000 (11:11 +0100)]
hopefully fix most issues. thx agier for spotting the main one

2 years agopoor damage control for tonight only
Frederic Suter [Thu, 7 Mar 2019 23:13:08 +0000 (00:13 +0100)]
poor damage control for tonight only

2 years agorevalidate another tesh
Frederic Suter [Thu, 7 Mar 2019 16:46:37 +0000 (17:46 +0100)]
revalidate another tesh

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Thu, 7 Mar 2019 16:40:12 +0000 (17:40 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agorevalidate tesh
Frederic Suter [Thu, 7 Mar 2019 16:38:51 +0000 (17:38 +0100)]
revalidate tesh

2 years agosimplifications and fixes (forgot properties)
Frederic Suter [Thu, 7 Mar 2019 16:23:54 +0000 (17:23 +0100)]
simplifications and fixes (forgot properties)

2 years agoadapt smpi tuto to use pajengr (+ dockerfile)
degomme [Thu, 7 Mar 2019 16:17:20 +0000 (17:17 +0100)]
adapt smpi tuto to use pajengr (+ dockerfile)

2 years agouse extension for user data in MSG
Frederic Suter [Thu, 7 Mar 2019 15:55:15 +0000 (16:55 +0100)]
use extension for user data in MSG

2 years agoSplit the behavior of ActorImpl::create
Frederic Suter [Thu, 7 Mar 2019 14:10:14 +0000 (15:10 +0100)]
Split the behavior of ActorImpl::create
follow the init->set->start logic

2 years agoSometimes 'free' is not a member of 'std'.
Arnaud Giersch [Wed, 6 Mar 2019 21:06:24 +0000 (22:06 +0100)]
Sometimes 'free' is not a member of 'std'.

2 years agoAdd exception specification for xbt_free_f.
Arnaud Giersch [Wed, 6 Mar 2019 20:49:49 +0000 (21:49 +0100)]
Add exception specification for xbt_free_f.

Take the same exception specification as for std::free. Without that, Intel icc
fails to compile simgrid::xbt::demangle (backtrace.cpp) with:
error \#878: incompatible exception specifications

2 years agoMissing include.
Arnaud Giersch [Wed, 6 Mar 2019 17:52:28 +0000 (18:52 +0100)]
Missing include.

2 years agoUse real pointer type for context wrappers.
Arnaud Giersch [Wed, 6 Mar 2019 16:37:52 +0000 (17:37 +0100)]
Use real pointer type for context wrappers.

2 years ago[sonar] Use unsigned char* for context stacks.
Arnaud Giersch [Wed, 6 Mar 2019 16:51:30 +0000 (17:51 +0100)]
[sonar] Use unsigned char* for context stacks.

2 years ago[sonar] Use std::function.
Arnaud Giersch [Wed, 6 Mar 2019 16:11:02 +0000 (17:11 +0100)]
[sonar] Use std::function.

2 years agoDeprecate some functions.
Arnaud Giersch [Wed, 6 Mar 2019 09:22:01 +0000 (10:22 +0100)]
Deprecate some functions.

2 years agoType consistency.
Arnaud Giersch [Wed, 6 Mar 2019 14:22:32 +0000 (15:22 +0100)]
Type consistency.

2 years agooops
degomme [Wed, 6 Mar 2019 15:20:01 +0000 (16:20 +0100)]
oops

2 years agoWIP - SMPI tuto - add parts about sampling and memory sharing
degomme [Wed, 6 Mar 2019 15:01:02 +0000 (16:01 +0100)]
WIP - SMPI tuto - add parts about sampling and memory sharing

TODO :
- collectives, and more ?

2 years agoTry to help sonar.
degomme [Wed, 6 Mar 2019 14:56:25 +0000 (15:56 +0100)]
Try to help sonar.

2 years agoFix mc liveness examples.
degomme [Wed, 6 Mar 2019 14:56:12 +0000 (15:56 +0100)]
Fix mc liveness examples.

2 years agoObjectify MSG task send
Frederic Suter [Wed, 6 Mar 2019 10:57:40 +0000 (11:57 +0100)]
Objectify MSG task send

2 years agoSimplifications in MSG task execution
Frederic Suter [Wed, 6 Mar 2019 10:14:13 +0000 (11:14 +0100)]
Simplifications in MSG task execution

2 years agoplease sonar
Frederic Suter [Wed, 6 Mar 2019 08:23:10 +0000 (09:23 +0100)]
please sonar

2 years agoremove or deprecate now useless code
Frederic Suter [Wed, 6 Mar 2019 08:08:18 +0000 (09:08 +0100)]
remove or deprecate now useless code

2 years agoplease clang
Frederic Suter [Tue, 5 Mar 2019 23:11:18 +0000 (00:11 +0100)]
please clang

2 years agos4u::Exec now has 2 child classes
Frederic Suter [Tue, 5 Mar 2019 22:43:51 +0000 (23:43 +0100)]
s4u::Exec now has 2 child classes
s4u::ExecSeq and s4u::ExecPar

side effects:
+ no more C-style host list in HostImpl and ptaskLO7
+ Sequential execution can have a timeout
TODO:
+ get rid of ExecImplPtr in MSG
+ check and clean

2 years agoParmap status is simply a boolean.
Arnaud Giersch [Tue, 5 Mar 2019 22:20:38 +0000 (23:20 +0100)]
Parmap status is simply a boolean.

2 years agoUse std::function instead of function pointer.
Arnaud Giersch [Tue, 5 Mar 2019 22:05:02 +0000 (23:05 +0100)]
Use std::function instead of function pointer.

2 years agoUse proper type instead of void*.
Arnaud Giersch [Tue, 5 Mar 2019 21:46:54 +0000 (22:46 +0100)]
Use proper type instead of void*.

2 years agoAssert that the pointer is not null when dereferenced.
Arnaud Giersch [Tue, 5 Mar 2019 12:25:11 +0000 (13:25 +0100)]
Assert that the pointer is not null when dereferenced.

2 years agoField is initialized by constructor.
Arnaud Giersch [Tue, 5 Mar 2019 12:22:08 +0000 (13:22 +0100)]
Field is initialized by constructor.

2 years agothose pimpl are actually never null, stop fooling sonar
Martin Quinson [Tue, 5 Mar 2019 08:29:28 +0000 (09:29 +0100)]
those pimpl are actually never null, stop fooling sonar

2 years agoapply agier fixes for StarPU build
Frederic Suter [Tue, 5 Mar 2019 08:46:35 +0000 (09:46 +0100)]
apply agier fixes for StarPU build