Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
14 months agoUpgrade embedded xxhash (-> v0.8.1).
Arnaud Giersch [Sun, 19 Feb 2023 14:48:56 +0000 (15:48 +0100)]
Upgrade embedded xxhash (-> v0.8.1).

Taken from
https://github.com/RedSpah/xxhash_cpp/commit/d21e37c34c4ad4ad562e4ec01ec036e342c422e3

14 months agoUpgrade embedded catch2 (-> v2.13.10).
Arnaud Giersch [Sun, 19 Feb 2023 14:37:48 +0000 (15:37 +0100)]
Upgrade embedded catch2 (-> v2.13.10).

Taken from
https://github.com/catchorg/Catch2/releases/tag/v2.13.10

14 months agoFinally kill surf_interface.hpp watched_host was actually useless
Martin Quinson [Sun, 19 Feb 2023 14:45:51 +0000 (15:45 +0100)]
Finally kill surf_interface.hpp watched_host was actually useless

14 months agorename another file with had 'surf' in its name
Martin Quinson [Sun, 19 Feb 2023 11:53:23 +0000 (12:53 +0100)]
rename another file with had 'surf' in its name

14 months agoKill a file with 'surf' in its name, and further empty surf_interface.cpp
Martin Quinson [Sun, 19 Feb 2023 11:49:24 +0000 (12:49 +0100)]
Kill a file with 'surf' in its name, and further empty surf_interface.cpp

14 months agoRework a comment (to remove 'surf')
Martin Quinson [Sun, 19 Feb 2023 11:21:55 +0000 (12:21 +0100)]
Rework a comment (to remove 'surf')

14 months agoRework compile optimizations for MC.
Arnaud Giersch [Sun, 19 Feb 2023 08:37:22 +0000 (09:37 +0100)]
Rework compile optimizations for MC.

14 months agoMissing includes.
Arnaud Giersch [Sun, 19 Feb 2023 06:27:24 +0000 (07:27 +0100)]
Missing includes.

14 months agoMove -Wno-unused-local-typedefs to common flags.
Arnaud Giersch [Sun, 19 Feb 2023 06:20:34 +0000 (07:20 +0100)]
Move -Wno-unused-local-typedefs to common flags.

It's supported by Clang too, and needed with at least ns-3.31.

14 months agokill src/simix
Martin Quinson [Sat, 18 Feb 2023 21:48:39 +0000 (22:48 +0100)]
kill src/simix

14 months agoMove the non-deprecated bits of simix to kernel::actor::Simcall
Martin Quinson [Sat, 18 Feb 2023 21:44:30 +0000 (22:44 +0100)]
Move the non-deprecated bits of simix to kernel::actor::Simcall

14 months agoKill src/include
Martin Quinson [Sat, 18 Feb 2023 20:49:57 +0000 (21:49 +0100)]
Kill src/include

The -Isrc/include makes it difficult to recognize in the source which
\#include takes a public header and which one is a private header.

Plus, move the third-party headers to a specific directory.

14 months agoreduce the amount of header includes in headers, to speedup recompilation
Martin Quinson [Sat, 18 Feb 2023 20:21:56 +0000 (21:21 +0100)]
reduce the amount of header includes in headers, to speedup recompilation

14 months agoMerge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Sat, 18 Feb 2023 19:10:28 +0000 (20:10 +0100)]
Merge branch 'master' of framagit.org:simgrid/simgrid

14 months agoRemove an obsolete cmake warning
Martin Quinson [Sat, 18 Feb 2023 18:37:22 +0000 (19:37 +0100)]
Remove an obsolete cmake warning

14 months agoMove some content of surf_interface to a new math_utils.h
Martin Quinson [Sat, 18 Feb 2023 18:28:37 +0000 (19:28 +0100)]
Move some content of surf_interface to a new math_utils.h

14 months agoUpdate path.
Arnaud Giersch [Sat, 18 Feb 2023 18:04:03 +0000 (19:04 +0100)]
Update path.

Error also seen with clang 11 and ns3.31.

14 months agoMove the files related to the platform parsing to kernel/xml
Martin Quinson [Sat, 18 Feb 2023 17:45:08 +0000 (18:45 +0100)]
Move the files related to the platform parsing to kernel/xml

14 months agomove a symbol declaration out of surf_interface.hpp
Martin Quinson [Sat, 18 Feb 2023 17:32:11 +0000 (18:32 +0100)]
move a symbol declaration out of surf_interface.hpp

14 months agoCMake requires ns3 v3.28+, so don't work around a bug in v3.27
Martin Quinson [Sat, 18 Feb 2023 17:25:55 +0000 (18:25 +0100)]
CMake requires ns3 v3.28+, so don't work around a bug in v3.27

14 months agoMove the ns3 helper files to kernel/models/ns3
Martin Quinson [Sat, 18 Feb 2023 17:23:50 +0000 (18:23 +0100)]
Move the ns3 helper files to kernel/models/ns3

14 months agoMove the surf tesh tests with the other models' ones
Martin Quinson [Sat, 18 Feb 2023 16:59:53 +0000 (17:59 +0100)]
Move the surf tesh tests with the other models' ones

14 months agoRemove some more occurence of 'surf' in comments and such
Martin Quinson [Sat, 18 Feb 2023 16:31:27 +0000 (17:31 +0100)]
Remove some more occurence of 'surf' in comments and such

14 months agoMisc Sonar issues.
Arnaud Giersch [Sat, 18 Feb 2023 16:42:44 +0000 (17:42 +0100)]
Misc Sonar issues.

14 months agoVarious cleanups.
Arnaud Giersch [Sat, 18 Feb 2023 16:39:33 +0000 (17:39 +0100)]
Various cleanups.

14 months agoFurther rename the identifiers of flexml to simgrid_parse_*
Martin Quinson [Sat, 18 Feb 2023 16:21:27 +0000 (17:21 +0100)]
Further rename the identifiers of flexml to simgrid_parse_*

14 months agoChange the namespace of flexml-generated parser from surfxml to simgrid_parse
Martin Quinson [Sat, 18 Feb 2023 10:48:52 +0000 (11:48 +0100)]
Change the namespace of flexml-generated parser from surfxml to simgrid_parse

14 months agoTwo more references of the surf/precision option name
Martin Quinson [Sat, 18 Feb 2023 10:32:21 +0000 (11:32 +0100)]
Two more references of the surf/precision option name

14 months agoRemove surf from the content from the examples of simulated filesystems
Martin Quinson [Sat, 18 Feb 2023 10:07:33 +0000 (11:07 +0100)]
Remove surf from the content from the examples of simulated filesystems

14 months agoRename ActivityImpl::surf_action_ to ActivityImpl::model_action_
Martin Quinson [Sat, 18 Feb 2023 09:38:38 +0000 (10:38 +0100)]
Rename ActivityImpl::surf_action_ to ActivityImpl::model_action_

14 months agoMove HostImpl to kernel/resource with its friends
Martin Quinson [Fri, 17 Feb 2023 22:02:54 +0000 (23:02 +0100)]
Move HostImpl to kernel/resource with its friends

14 months agomove the models to the right directory (empty src/surf a bit)
Martin Quinson [Fri, 17 Feb 2023 21:31:02 +0000 (22:31 +0100)]
move the models to the right directory (empty src/surf a bit)

The remaining parts of src/surf need to be cleaned before being moved

Also, remove almost all #include "surf_interface.hpp"

14 months agoAllow precision/bmf as a synonym to bmf/precision
Martin Quinson [Thu, 16 Feb 2023 23:05:18 +0000 (00:05 +0100)]
Allow precision/bmf as a synonym to bmf/precision

14 months agoRename option maxmin/precision to precision/work-amount for clarity
Martin Quinson [Thu, 16 Feb 2023 23:01:45 +0000 (00:01 +0100)]
Rename option maxmin/precision to precision/work-amount for clarity

14 months agoRename option "surf/precision" to "precision/timing" for clarity.
Martin Quinson [Thu, 16 Feb 2023 22:44:37 +0000 (23:44 +0100)]
Rename option "surf/precision" to "precision/timing" for clarity.

14 months agoRename sg_surf_precision to sg_precision_timing for clarity
Martin Quinson [Thu, 16 Feb 2023 22:39:54 +0000 (23:39 +0100)]
Rename sg_surf_precision to sg_precision_timing for clarity

14 months agoUse surf_precision as a value for PMPI_Wtick
Martin Quinson [Thu, 16 Feb 2023 22:31:53 +0000 (23:31 +0100)]
Use surf_precision as a value for PMPI_Wtick

the unit of maxmin_precision is in flops or bytes (that's an amount of
work) while the unit of surf_precision is in seconds (that's a time).

14 months agodoc: add a little graph about the host energy plugin
Martin Quinson [Thu, 16 Feb 2023 16:48:10 +0000 (17:48 +0100)]
doc: add a little graph about the host energy plugin

14 months agoMerge branch 'fix-mc-tests' into 'master'
Martin Quinson [Thu, 16 Feb 2023 21:13:41 +0000 (21:13 +0000)]
Merge branch 'fix-mc-tests' into 'master'

Fix root node edge case for `State` instance

See merge request simgrid/simgrid!129

14 months agoInitialize uninitialized transition for root state
Maxwell Pirtle [Thu, 16 Feb 2023 14:51:37 +0000 (15:51 +0100)]
Initialize uninitialized transition for root state

The transition in the root state was uninitialized
and this appears to have caused the last of the remaining
issues with the test suite. Of course, reading from the
uninitialized pointer `transition_` is bound to cause
a bunch of problems...

14 months agoFix root-node edge cases for states
Maxwell Pirtle [Thu, 16 Feb 2023 12:11:07 +0000 (13:11 +0100)]
Fix root-node edge cases for states

14 months agofix MC+gcc builds
Martin Quinson [Thu, 16 Feb 2023 10:05:59 +0000 (11:05 +0100)]
fix MC+gcc builds

14 months agoCI: build the model-checker on framagit, to test the MRs
Martin Quinson [Thu, 16 Feb 2023 09:52:21 +0000 (10:52 +0100)]
CI: build the model-checker on framagit, to test the MRs

14 months agofix the build (but not all tests) of MC
Martin Quinson [Thu, 16 Feb 2023 08:45:47 +0000 (09:45 +0100)]
fix the build (but not all tests) of MC

14 months agoMerge branch 'actor-comms' into 'master'
Martin Quinson [Wed, 15 Feb 2023 23:59:31 +0000 (23:59 +0000)]
Merge branch 'actor-comms' into 'master'

Serialize pending transitions when responding to `ACTOR_STATUS` messages on the application side

See merge request simgrid/simgrid!127

14 months agoproperly deal with network/optim (end of the ModuleGroup cleanup)
Martin Quinson [Wed, 15 Feb 2023 23:49:30 +0000 (00:49 +0100)]
properly deal with network/optim (end of the ModuleGroup cleanup)

The network/optim was abusing the model description mechanism, because
it was introduced before the options could be restricted to a list of
values. That's a pretty old cruft :)

Moreover, the config mechanism (probably) allowed network/optim:TI but then
ignored it silently. Not nice for the users.

14 months agoKill a now useless file
Martin Quinson [Wed, 15 Feb 2023 23:31:13 +0000 (00:31 +0100)]
Kill a now useless file

14 months agoCosmetics around the creation of the VM model
Martin Quinson [Wed, 15 Feb 2023 23:26:24 +0000 (00:26 +0100)]
Cosmetics around the creation of the VM model

14 months agoFurther factorization: introduce ModuleGroup::init_from_flag_value()
Martin Quinson [Wed, 15 Feb 2023 23:21:52 +0000 (00:21 +0100)]
Further factorization: introduce ModuleGroup::init_from_flag_value()

14 months ago15 years later, I finally managed to kill host/model:compound
Martin Quinson [Wed, 15 Feb 2023 23:15:19 +0000 (00:15 +0100)]
15 years later, I finally managed to kill host/model:compound

14 months agoObjectif the disk model
Martin Quinson [Wed, 15 Feb 2023 22:41:33 +0000 (23:41 +0100)]
Objectif the disk model

14 months agoThere is no way these names are empty, bc we give a default value
Martin Quinson [Wed, 15 Feb 2023 22:31:53 +0000 (23:31 +0100)]
There is no way these names are empty, bc we give a default value

14 months agoObjectifies the host models
Martin Quinson [Wed, 15 Feb 2023 22:22:10 +0000 (23:22 +0100)]
Objectifies the host models

14 months agofactorize the flags of models and plugins
Martin Quinson [Wed, 15 Feb 2023 22:00:50 +0000 (23:00 +0100)]
factorize the flags of models and plugins

14 months agodocs: fix a sphinx formatting error
Martin Quinson [Wed, 15 Feb 2023 16:38:27 +0000 (17:38 +0100)]
docs: fix a sphinx formatting error

14 months agoObjectifies the CPU model
Martin Quinson [Wed, 15 Feb 2023 16:24:12 +0000 (17:24 +0100)]
Objectifies the CPU model

14 months agoAllow to add a disk to a host after a load_platform from xml
Martin Quinson [Wed, 15 Feb 2023 15:51:00 +0000 (16:51 +0100)]
Allow to add a disk to a host after a load_platform from xml

Fix https://github.com/simgrid/simgrid/issues/383

14 months agoAdd note about resetting `times_considered`
Maxwell Pirtle [Wed, 15 Feb 2023 09:55:14 +0000 (10:55 +0100)]
Add note about resetting `times_considered`

Resetting `times_considered` after multiple
serializations of a particular transition are performed
to give the checker all exections of an actor
that can perform multiple actions. There was concern
that this value would have to be "reset" to the
original value after the serialization, since the latter
modifies the simcall's observer's internal state.

However, no reset is actually needed as each
SIMCALL_EXECUTE message that the checker sends to the
application-side comes equipped with the latest
`times_considered`, and thus preparation will be
performed correctly before execution.

14 months agoReplace pending transition with latest execution
Maxwell Pirtle [Wed, 15 Feb 2023 09:50:16 +0000 (10:50 +0100)]
Replace pending transition with latest execution

The `State::execute_next(aid_t)` method was
adjusted to use the newest copy of the transition
that was executed by an actor in lieu of the
copy of the transition that was previously stored
by the actor, as more information may be gained
during the execution of a transition.

14 months agofix pip build
Martin Quinson [Wed, 15 Feb 2023 09:00:22 +0000 (10:00 +0100)]
fix pip build

14 months agoConvert the network models to the new plugin-like mechanism
Martin Quinson [Wed, 15 Feb 2023 08:30:06 +0000 (09:30 +0100)]
Convert the network models to the new plugin-like mechanism

14 months agoObjectify the model containers
Martin Quinson [Tue, 14 Feb 2023 20:12:10 +0000 (21:12 +0100)]
Objectify the model containers

This should allow further cleanups in the near future, where models
are handled as the plugins already are: no shotgun design anymore with
the registration, and everything about a given model contained in a
single file.

14 months agoMove the surf log categories elsewhere
Martin Quinson [Sun, 12 Feb 2023 22:22:10 +0000 (23:22 +0100)]
Move the surf log categories elsewhere

14 months agoRemove multiarch from the doc: it was never tested, and 32b is soon gone
Martin Quinson [Sat, 11 Feb 2023 23:25:30 +0000 (00:25 +0100)]
Remove multiarch from the doc: it was never tested, and 32b is soon gone

14 months agoDocument the fact that 32bits is gone
Martin Quinson [Sat, 11 Feb 2023 23:24:29 +0000 (00:24 +0100)]
Document the fact that 32bits is gone

14 months agoFix condition for XBT_DECLARE_ENUM_CLASS
Maxwell Pirtle [Tue, 14 Feb 2023 08:06:24 +0000 (09:06 +0100)]
Fix condition for XBT_DECLARE_ENUM_CLASS

The condition for the `is_valid_##EnumType`
was updated. Previously, is was missing the edge
case where `raw_value >= 0`

14 months agoReduce scope for variables.
Arnaud Giersch [Mon, 13 Feb 2023 15:09:47 +0000 (16:09 +0100)]
Reduce scope for variables.

14 months agoSimplify initialization of the root log category.
Arnaud Giersch [Mon, 13 Feb 2023 15:04:25 +0000 (16:04 +0100)]
Simplify initialization of the root log category.

14 months agoFor Sonar.
Arnaud Giersch [Mon, 13 Feb 2023 08:49:37 +0000 (09:49 +0100)]
For Sonar.

14 months agoDefine context related globals as static members of Context.
Arnaud Giersch [Sat, 11 Feb 2023 18:25:25 +0000 (19:25 +0100)]
Define context related globals as static members of Context.

14 months agoMake global variables "const".
Arnaud Giersch [Sat, 11 Feb 2023 10:45:54 +0000 (11:45 +0100)]
Make global variables "const".

Even if it has no importance, take the special values from smpi.h

14 months agoFinalize passing transitions during model checking
Maxwell Pirtle [Mon, 13 Feb 2023 09:48:20 +0000 (10:48 +0100)]
Finalize passing transitions during model checking

Transitions are now serialized and sent to the
checker side whenever a new State instance is
created (when the ACTOR_STATUS message is sent
by the checker). Transition serialization is the
first step before the work on the UDPOR branch(es)
can be integrated into Mc SimGrid.

14 months agomove the flatifier functions to the s4u::Engine, for public consumption
Martin Quinson [Sat, 11 Feb 2023 23:11:57 +0000 (00:11 +0100)]
move the flatifier functions to the s4u::Engine, for public consumption

14 months agoAdd a Link::get_concurrency_limit and use it in the flatifier
Martin Quinson [Sat, 11 Feb 2023 19:17:10 +0000 (20:17 +0100)]
Add a Link::get_concurrency_limit and use it in the flatifier

14 months agoFlatifier: make a function returning a std::string instead of using printf
Martin Quinson [Sat, 11 Feb 2023 18:34:46 +0000 (19:34 +0100)]
Flatifier: make a function returning a std::string instead of using printf

14 months agoflatifier: cosmetics + display the real name of the root zone
Martin Quinson [Fri, 10 Feb 2023 22:30:50 +0000 (23:30 +0100)]
flatifier: cosmetics + display the real name of the root zone

14 months agoFix attribution
Martin Quinson [Fri, 10 Feb 2023 18:39:45 +0000 (19:39 +0100)]
Fix attribution

14 months agoDocument recent changes
Martin Quinson [Sun, 29 Jan 2023 16:20:16 +0000 (17:20 +0100)]
Document recent changes

14 months agoUse more readable alternatives for string::compare().
Arnaud Giersch [Sat, 11 Feb 2023 07:01:49 +0000 (08:01 +0100)]
Use more readable alternatives for string::compare().

14 months agoKill another bunch of globals.
Arnaud Giersch [Thu, 9 Feb 2023 21:32:38 +0000 (22:32 +0100)]
Kill another bunch of globals.

14 months agoAdd intial steps to transfer transitions to the MC
Maxwell Pirtle [Fri, 10 Feb 2023 08:28:16 +0000 (09:28 +0100)]
Add intial steps to transfer transitions to the MC

14 months agoKill a few globals.
Arnaud Giersch [Thu, 9 Feb 2023 15:51:01 +0000 (16:51 +0100)]
Kill a few globals.

14 months agoFix comment.
Arnaud Giersch [Thu, 9 Feb 2023 15:25:23 +0000 (16:25 +0100)]
Fix comment.

14 months agoLittle simplification.
Arnaud Giersch [Thu, 9 Feb 2023 13:28:39 +0000 (14:28 +0100)]
Little simplification.

14 months agoMerge branch 'arm-patch' into 'master'
Martin Quinson [Thu, 9 Feb 2023 10:48:35 +0000 (10:48 +0000)]
Merge branch 'arm-patch' into 'master'

Add patch for arm64 Ubuntu 22.04 in `UnwindContext`

See merge request simgrid/simgrid!126

14 months agoAdd patch for arm64 Ubuntu 22.04 in UnwindContext
Maxwell Pirtle [Wed, 1 Feb 2023 13:52:53 +0000 (14:52 +0100)]
Add patch for arm64 Ubuntu 22.04 in UnwindContext

The `mcontext_t` struct on Ubuntu 22.04
running on arm64 is missing the `fregs`
field. This causes a compilation failure
in `src/mc/inspect/mc_unw.cpp` since the
code there assumes the field exists on
linux-arm64.

This commit adds a new CMake variable
SIMGRID_PROCESSOR_arm64 to account for
the additional architecture more
explicitly and to better fit the context
surrounding the code where the fix was made

14 months agomake all Activity starts vetoable
Fred Suter [Wed, 8 Feb 2023 21:10:15 +0000 (16:10 -0500)]
make all Activity starts vetoable

14 months agoTypo [ci-skip]
Arnaud Giersch [Wed, 8 Feb 2023 15:56:50 +0000 (16:56 +0100)]
Typo [ci-skip]

14 months agoRemove deprecated properties.
Arnaud Giersch [Wed, 8 Feb 2023 13:19:44 +0000 (14:19 +0100)]
Remove deprecated properties.

Last analysis had a warning:
"sonar.cfamily.cache.enabled" and "sonar.cfamily.cache.path" properties are deprecated.
Visit the documentation page for more information about analysis cache configuration
https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/

("sonar.cfamily.cache.enabled" was set to "false" anyway on CI)

14 months agoImplement ConditionWaitSimcall::to_string().
Arnaud Giersch [Wed, 8 Feb 2023 11:31:33 +0000 (12:31 +0100)]
Implement ConditionWaitSimcall::to_string().

Fix crash e.g. when running s4u-synchro-condition-variable-waituntil --log=ker_actor.thres:debug

14 months agoCosmetics with spacings around colon (:).
Arnaud Giersch [Wed, 8 Feb 2023 11:00:24 +0000 (12:00 +0100)]
Cosmetics with spacings around colon (:).

14 months agoDeclare functions with attribute 'noreturn' (sonar).
Arnaud Giersch [Wed, 8 Feb 2023 10:11:16 +0000 (11:11 +0100)]
Declare functions with attribute 'noreturn' (sonar).

14 months agoReduce scope for variables.
Arnaud Giersch [Wed, 8 Feb 2023 10:10:09 +0000 (11:10 +0100)]
Reduce scope for variables.

14 months agoSingle quotes don't need to be escaped.
Arnaud Giersch [Wed, 8 Feb 2023 09:13:59 +0000 (10:13 +0100)]
Single quotes don't need to be escaped.

14 months agoPrevent inlining for empty placeholders of sthread_enable/disable.
Arnaud Giersch [Tue, 7 Feb 2023 19:40:27 +0000 (20:40 +0100)]
Prevent inlining for empty placeholders of sthread_enable/disable.

See the gcc documentation about function attribute noinline for details.

Hope to fix hangs seen with optimized builds on recent Alpine/Linux.

Let's see also if it works as is with all supported compilers.

14 months agoCMake 2.8.12 is the minimum required version in FindSimgrid.cmake anyway.
Arnaud Giersch [Tue, 7 Feb 2023 12:17:38 +0000 (13:17 +0100)]
CMake 2.8.12 is the minimum required version in FindSimgrid.cmake anyway.

14 months agoUse native cmake commands to compute relative path.
Arnaud Giersch [Tue, 7 Feb 2023 09:21:40 +0000 (10:21 +0100)]
Use native cmake commands to compute relative path.

14 months agoNormalize names for fields in class Node (trailing '_').
Arnaud Giersch [Tue, 7 Feb 2023 07:44:47 +0000 (08:44 +0100)]
Normalize names for fields in class Node (trailing '_').

14 months agoMake global variables "const".
Arnaud Giersch [Mon, 6 Feb 2023 13:55:57 +0000 (14:55 +0100)]
Make global variables "const".

14 months agoAvoid duplicate declaration.
Arnaud Giersch [Mon, 6 Feb 2023 13:22:07 +0000 (14:22 +0100)]
Avoid duplicate declaration.