Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
11 months agoadd photovoltaic plugin
Adrien Gougeon [Tue, 16 May 2023 14:07:34 +0000 (16:07 +0200)]
add photovoltaic plugin

11 months agoSuprious brace (fix non-linux builds).
Arnaud Giersch [Mon, 15 May 2023 13:25:05 +0000 (15:25 +0200)]
Suprious brace (fix non-linux builds).

11 months agoDefine master_socket_name only once, and embed it with the request to fork.
Arnaud Giersch [Mon, 15 May 2023 08:39:45 +0000 (10:39 +0200)]
Define master_socket_name only once, and embed it with the request to fork.

11 months agoTry harder not to fail with stale sockets after several runs.
Arnaud Giersch [Fri, 12 May 2023 09:19:55 +0000 (11:19 +0200)]
Try harder not to fail with stale sockets after several runs.

* on linux, prefer abstract unix sockets that are automatically removed
* otherwise, remove possible stale socket before bind

11 months agoThe default destructor should be fine.
Arnaud Giersch [Fri, 12 May 2023 11:15:06 +0000 (13:15 +0200)]
The default destructor should be fine.

11 months agoDisable move constructor which cannot be 'noexecept' (sonar).
Arnaud Giersch [Fri, 12 May 2023 07:45:46 +0000 (09:45 +0200)]
Disable move constructor which cannot be 'noexecept' (sonar).

11 months agoCosmetics.
Arnaud Giersch [Fri, 12 May 2023 07:30:55 +0000 (09:30 +0200)]
Cosmetics.

12 months agoadd two more utility functions to the Operation plugin
Fred Suter [Thu, 11 May 2023 14:29:20 +0000 (10:29 -0400)]
add two more utility functions to the Operation plugin

12 months agoFix make distcheck
Martin Quinson [Wed, 10 May 2023 21:35:25 +0000 (23:35 +0200)]
Fix make distcheck

12 months agoMC: Kill the now useless code State::get_recipe
Martin Quinson [Wed, 10 May 2023 21:27:34 +0000 (23:27 +0200)]
MC: Kill the now useless code State::get_recipe

12 months agoMerge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Wed, 10 May 2023 21:22:28 +0000 (23:22 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid

12 months agoDFS MC: Restore from system states even if we have to run some transitions out of it
Martin Quinson [Wed, 10 May 2023 21:21:10 +0000 (23:21 +0200)]
DFS MC: Restore from system states even if we have to run some transitions out of it

This makes the model-check/checkpoint a bit more efficient by
increasing the amount of cases where we can reuse taken checkpoints.

It is still awfully slow because checkpoints are. The next step is to
implement model-check/checkpoint with forks.

12 months agoMerge branch 'dag-lab' into 'master'
Martin Quinson [Wed, 10 May 2023 11:08:09 +0000 (11:08 +0000)]
Merge branch 'dag-lab' into 'master'

Add dag scheduling lab to docs

See merge request simgrid/simgrid!150

12 months agoMerge branch 'changelog-operation-plugin' into 'master'
Martin Quinson [Wed, 10 May 2023 11:07:36 +0000 (11:07 +0000)]
Merge branch 'changelog-operation-plugin' into 'master'

Add plugins operation and battery to changelog

See merge request simgrid/simgrid!149

12 months agoUse forwarding references with std::forward (sonar).
Arnaud Giersch [Tue, 9 May 2023 14:46:08 +0000 (16:46 +0200)]
Use forwarding references with std::forward (sonar).

(hope I got it right this time)

12 months agoUse a std::vector as an underlying container for backtrack_points, so that maximal_su...
Arnaud Giersch [Tue, 9 May 2023 14:27:35 +0000 (16:27 +0200)]
Use a std::vector as an underlying container for backtrack_points, so that maximal_subsets_iterator can have a noexcept move constructor by default.

12 months agoUse a static variable for empty_set, and allow default noexcept move constructor.
Arnaud Giersch [Tue, 9 May 2023 13:57:50 +0000 (15:57 +0200)]
Use a static variable for empty_set, and allow default noexcept move constructor.

12 months agoadd dag scheduling lab
Adrien Gougeon [Tue, 9 May 2023 12:45:25 +0000 (14:45 +0200)]
add dag scheduling lab

12 months agoPlug memory leak.
Arnaud Giersch [Mon, 8 May 2023 19:27:14 +0000 (21:27 +0200)]
Plug memory leak.

12 months agoUse pointer-to-const for parameter (sonar).
Arnaud Giersch [Sat, 6 May 2023 11:48:33 +0000 (13:48 +0200)]
Use pointer-to-const for parameter (sonar).

12 months agoFix sonar bug: attribute access on a value that can be 'None'.
Arnaud Giersch [Fri, 5 May 2023 08:38:39 +0000 (10:38 +0200)]
Fix sonar bug: attribute access on a value that can be 'None'.

12 months agoMisc Sonar issues.
Arnaud Giersch [Thu, 4 May 2023 13:13:45 +0000 (15:13 +0200)]
Misc Sonar issues.

* declare functions "const"
* use pointer-to-const or reference-to-const
* use structured bindings
* extract assignment from expression
* mark constructors "explicit"
* pass large object parameters by reference-to-const
* use default implementation constructor
* explicitly capture required variables in lambdas

12 months agomess up with operations
Fred Suter [Fri, 5 May 2023 01:20:01 +0000 (21:20 -0400)]
mess up with operations
+ chainable setters
+ getters
+ boost instrusive pointers

12 months agoRename Link::get_usage() to Link::get_load() for consistency with Host::
Martin Quinson [Thu, 4 May 2023 14:14:54 +0000 (16:14 +0200)]
Rename Link::get_usage() to Link::get_load() for consistency with Host::

12 months agoadd plugins operation and battery
Adrien Gougeon [Thu, 4 May 2023 09:22:11 +0000 (11:22 +0200)]
add plugins operation and battery

12 months agofurther simplify this example
Fred Suter [Wed, 3 May 2023 14:39:56 +0000 (10:39 -0400)]
further simplify this example

12 months agoOne use less of get_recipe() that will soon die
Martin Quinson [Fri, 28 Apr 2023 00:01:20 +0000 (02:01 +0200)]
One use less of get_recipe() that will soon die

12 months agoFactorize more code between DFSExplo and LivenessExplo, and UDPOR
Martin Quinson [Thu, 27 Apr 2023 23:25:04 +0000 (01:25 +0200)]
Factorize more code between DFSExplo and LivenessExplo, and UDPOR

12 months agoKill useless empty function.
Arnaud Giersch [Tue, 2 May 2023 14:32:11 +0000 (16:32 +0200)]
Kill useless empty function.

12 months agoMissing "override".
Arnaud Giersch [Tue, 2 May 2023 14:22:02 +0000 (16:22 +0200)]
Missing "override".

12 months agoSimplify expression.
Arnaud Giersch [Tue, 2 May 2023 14:14:43 +0000 (16:14 +0200)]
Simplify expression.

12 months agoFix use-after-free observed with the s4u-operation examples.
Arnaud Giersch [Tue, 2 May 2023 14:12:18 +0000 (16:12 +0200)]
Fix use-after-free observed with the s4u-operation examples.

12 months agoCosmetics (sonar).
Arnaud Giersch [Tue, 2 May 2023 14:24:29 +0000 (16:24 +0200)]
Cosmetics (sonar).

12 months agoDefine each identifier in a dedicated statement (sonar).
Arnaud Giersch [Tue, 11 Apr 2023 09:13:59 +0000 (11:13 +0200)]
Define each identifier in a dedicated statement (sonar).

12 months agoRevert "Run mc-*-liveness tests serial, and hope to pass on CI."
Arnaud Giersch [Sat, 29 Apr 2023 08:03:02 +0000 (10:03 +0200)]
Revert "Run mc-*-liveness tests serial, and hope to pass on CI."

This reverts commit 881507dc9fbeba0c63112dd0058d9c591b67419e.

In fact, it was just the CI infrastructure that was unusually slow these days.

12 months agoWhitespace cleanup (codefactor.io).
Arnaud Giersch [Tue, 18 Apr 2023 09:39:48 +0000 (11:39 +0200)]
Whitespace cleanup (codefactor.io).

12 months agoLazily compute the recipe of a state, on need only
Martin Quinson [Thu, 27 Apr 2023 13:41:03 +0000 (15:41 +0200)]
Lazily compute the recipe of a state, on need only

This will be useful when leveraging intermediate states during
backtracks. In that case, we need to compute partial recipes, up to
the advanced restaure point.

12 months agoMore automatic memory mgmt in MC
Martin Quinson [Thu, 27 Apr 2023 12:09:03 +0000 (14:09 +0200)]
More automatic memory mgmt in MC

12 months agoMC: give each state an incoming transition too
Martin Quinson [Thu, 27 Apr 2023 11:48:19 +0000 (13:48 +0200)]
MC: give each state an incoming transition too

Using the parent's outgoing transition is not reliable anymore now
that we don't always explore the tree in order, but rather following
the exploration strategies.

12 months agoFix comment [no-ci]
Martin Quinson [Tue, 18 Apr 2023 07:01:51 +0000 (09:01 +0200)]
Fix comment [no-ci]

12 months agoRun mc-*-liveness tests serial, and hope to pass on CI.
Arnaud Giersch [Thu, 27 Apr 2023 12:57:19 +0000 (14:57 +0200)]
Run mc-*-liveness tests serial, and hope to pass on CI.

12 months agoFix comment.
Arnaud Giersch [Thu, 27 Apr 2023 09:28:08 +0000 (11:28 +0200)]
Fix comment.

12 months agoThere is no need to declare the default constructors here.
Arnaud Giersch [Thu, 27 Apr 2023 09:27:02 +0000 (11:27 +0200)]
There is no need to declare the default constructors here.

12 months agoFix build error: exception specification of explicitly
Arnaud Giersch [Thu, 27 Apr 2023 09:26:20 +0000 (11:26 +0200)]
Fix build error: exception specification of explicitly
defaulted move constructor does not match the calculated one.

12 months agoMerge branch 'operation-plugin' into 'master'
Martin Quinson [Wed, 26 Apr 2023 12:45:40 +0000 (12:45 +0000)]
Merge branch 'operation-plugin' into 'master'

Operation plugin

See merge request simgrid/simgrid!145

12 months agoMerge branch 'udpor-phase7' into 'master'
Martin Quinson [Tue, 18 Apr 2023 07:08:17 +0000 (07:08 +0000)]
Merge branch 'udpor-phase7' into 'master'

Phase 7 of UDPOR Integration: Add specialized `ex(C)` computation for `Comm*` transitions

See merge request simgrid/simgrid!144

12 months agosonar fixes
Martin Quinson [Mon, 17 Apr 2023 08:01:01 +0000 (10:01 +0200)]
sonar fixes

- Undefined return value (that would happen on a platform without any host)
- Local variable shadowing
- Automatic memory management
- const, explicit, etc.

12 months agoLet resource profiles finish their initialization by themselves and kill presolve
Martin Quinson [Sun, 16 Apr 2023 16:45:59 +0000 (18:45 +0200)]
Let resource profiles finish their initialization by themselves and kill presolve

12 months agoNo need to presolve the models to finish their initialization nowadays
Martin Quinson [Sun, 16 Apr 2023 16:31:13 +0000 (18:31 +0200)]
No need to presolve the models to finish their initialization nowadays

I think that this was a leftover of the good old C times.

12 months agoOnly fire on_platform_created after creating the platform, not after loading the...
Martin Quinson [Sun, 16 Apr 2023 10:23:18 +0000 (12:23 +0200)]
Only fire on_platform_created after creating the platform, not after loading the deployment

12 months agoAdd a target to recompile all ns3 tests (and only them)
Martin Quinson [Sun, 16 Apr 2023 09:03:31 +0000 (11:03 +0200)]
Add a target to recompile all ns3 tests (and only them)

12 months agorename create to init. add init with name only. add setters
Adrien Gougeon [Sun, 16 Apr 2023 08:41:16 +0000 (10:41 +0200)]
rename create to init. add init with name only. add setters

12 months agoMake sure that we never have a 0 transition at the end of the stack
Martin Quinson [Sat, 15 Apr 2023 22:38:08 +0000 (00:38 +0200)]
Make sure that we never have a 0 transition at the end of the stack

12 months agoAlso send the disabled transitions over: UDPOR needs it
Martin Quinson [Sat, 15 Apr 2023 21:50:48 +0000 (23:50 +0200)]
Also send the disabled transitions over: UDPOR needs it

12 months agoMore informative message on system error
Martin Quinson [Sat, 15 Apr 2023 21:40:11 +0000 (23:40 +0200)]
More informative message on system error

12 months agoMore defensive programing style
Martin Quinson [Fri, 14 Apr 2023 12:21:47 +0000 (14:21 +0200)]
More defensive programing style

12 months agoadd missing '&' causing temporary value to be modified
Adrien Gougeon [Fri, 14 Apr 2023 10:37:41 +0000 (12:37 +0200)]
add missing '&' causing temporary value to be modified

12 months agorename on_start/on_end functions call to on_this_start/on_this_end. add on_start_cb...
Adrien Gougeon [Fri, 14 Apr 2023 09:24:00 +0000 (11:24 +0200)]
rename on_start/on_end functions call to on_this_start/on_this_end. add on_start_cb and on_end_cb

12 months agoTrust the config system to check that only valid values are used
Martin Quinson [Thu, 13 Apr 2023 21:51:41 +0000 (23:51 +0200)]
Trust the config system to check that only valid values are used

12 months agoDisable coverage on circleci.
Arnaud Giersch [Wed, 12 Apr 2023 20:02:34 +0000 (22:02 +0200)]
Disable coverage on circleci.

It seems that it is not used and it slows down the tests.

[ci-skip]

12 months agoMake this example valgrind-clean
Martin Quinson [Wed, 12 Apr 2023 20:46:30 +0000 (22:46 +0200)]
Make this example valgrind-clean

12 months agoFurther cosmetics in that example, adding a helper function to s4u on the way
Martin Quinson [Wed, 12 Apr 2023 19:37:05 +0000 (21:37 +0200)]
Further cosmetics in that example, adding a helper function to s4u on the way

12 months agosimplify the example now that host can be set to serial
Fred Suter [Wed, 12 Apr 2023 18:19:28 +0000 (14:19 -0400)]
simplify the example now that host can be set to serial

12 months agoUse host->set_concurrency_limit(1) in an example where it makes sense
Martin Quinson [Wed, 12 Apr 2023 15:58:18 +0000 (17:58 +0200)]
Use host->set_concurrency_limit(1) in an example where it makes sense

12 months agoDocument a bit the MC changes
Martin Quinson [Wed, 12 Apr 2023 15:49:30 +0000 (17:49 +0200)]
Document a bit the MC changes

12 months agoAllow to set a concurrency limit on disks and hosts
Martin Quinson [Wed, 12 Apr 2023 15:43:10 +0000 (17:43 +0200)]
Allow to set a concurrency limit on disks and hosts

12 months agoInline Exploration::system_error.
Arnaud Giersch [Wed, 12 Apr 2023 12:25:33 +0000 (14:25 +0200)]
Inline Exploration::system_error.

12 months agoRemove useless specialized exceptions from simgrid::mc.
Arnaud Giersch [Wed, 12 Apr 2023 12:23:15 +0000 (14:23 +0200)]
Remove useless specialized exceptions from simgrid::mc.

12 months agoUse an exception on Exploration::system_exit().
Arnaud Giersch [Wed, 12 Apr 2023 12:08:34 +0000 (14:08 +0200)]
Use an exception on Exploration::system_exit().

The goal is to use RAII to free the memory on exit, and get cleaner valgrind reports.

12 months agoSonar...
Arnaud Giersch [Wed, 12 Apr 2023 09:38:20 +0000 (11:38 +0200)]
Sonar...

12 months agomissing virtual destructor
Adrien Gougeon [Wed, 12 Apr 2023 07:59:11 +0000 (09:59 +0200)]
missing virtual destructor

12 months agofix distcheck
Adrien Gougeon [Tue, 11 Apr 2023 21:39:40 +0000 (23:39 +0200)]
fix distcheck

12 months agomissing lib
Adrien Gougeon [Tue, 11 Apr 2023 21:18:36 +0000 (23:18 +0200)]
missing lib

12 months agoclang-format
Adrien Gougeon [Tue, 11 Apr 2023 14:33:21 +0000 (16:33 +0200)]
clang-format

12 months agoadd prog_ns3 to manifest
Adrien Gougeon [Tue, 11 Apr 2023 14:30:27 +0000 (16:30 +0200)]
add prog_ns3 to manifest

12 months agoadd operation examples
Adrien Gougeon [Tue, 11 Apr 2023 13:48:40 +0000 (15:48 +0200)]
add operation examples

12 months agoseveral updates to plugin operation
Adrien Gougeon [Tue, 11 Apr 2023 13:48:13 +0000 (15:48 +0200)]
several updates to plugin operation

12 months agoadd operation to plugin doc
Adrien Gougeon [Tue, 11 Apr 2023 13:44:56 +0000 (15:44 +0200)]
add operation to plugin doc

12 months agoadd operation to manifest
Adrien Gougeon [Tue, 11 Apr 2023 13:43:43 +0000 (15:43 +0200)]
add operation to manifest

12 months agofix bad type comparison
Adrien Gougeon [Fri, 7 Apr 2023 09:00:05 +0000 (11:00 +0200)]
fix bad type comparison

12 months agoadd operation plugin
Adrien Gougeon [Wed, 5 Apr 2023 11:52:22 +0000 (13:52 +0200)]
add operation plugin

12 months agoAssignment operators should return non-"const" references (sonar).
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Assignment operators should return non-"const" references (sonar).

Also enfore C++ "rule-of-three".

12 months agoMark functions as "const" (sonar).
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Mark functions as "const" (sonar).

12 months agoUse std::string (sonar).
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Use std::string (sonar).

12 months agoMisc sonar issues.
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Misc sonar issues.

12 months agoReduce scope for variables (sonar).
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Reduce scope for variables (sonar).

12 months agoPointer and reference should be "const" if the corresponding object is not modified...
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Pointer and reference should be "const" if the corresponding object is not modified (sonar).

12 months agoFix bound checking in assert.
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Fix bound checking in assert.

12 months agoWhitespace cleanup (codefactor.io).
Arnaud Giersch [Tue, 11 Apr 2023 13:26:28 +0000 (15:26 +0200)]
Whitespace cleanup (codefactor.io).

13 months agoUse an intermediate variable to compute the sum and access c[i][j] only once.
Arnaud Giersch [Mon, 10 Apr 2023 20:03:39 +0000 (22:03 +0200)]
Use an intermediate variable to compute the sum and access c[i][j] only once.

May fix crash when built with Intel(R) oneAPI DPC++/C++ Compiler 2023.1.0 (2023.1.0.20230320)
Probably an optimization bug!

Also clean up the function signature.

13 months agoLess low-level operations to manage receive buffer.
Arnaud Giersch [Wed, 5 Apr 2023 20:04:58 +0000 (22:04 +0200)]
Less low-level operations to manage receive buffer.

13 months agoPlease don't fix this error reported by clang-static [no-ci]
Martin Quinson [Fri, 7 Apr 2023 20:05:40 +0000 (22:05 +0200)]
Please don't fix this error reported by clang-static [no-ci]

13 months agoDefine and use VALGRIND_NO_TRACE_CHILDREN for simgrid-mc tests.
Arnaud Giersch [Fri, 7 Apr 2023 16:52:53 +0000 (18:52 +0200)]
Define and use VALGRIND_NO_TRACE_CHILDREN for simgrid-mc tests.

There are two benefits. First, memory leaks are checked for the simgrid-mc process,
and then the tests run faster.

[ci-skip]

13 months agoAdd $VALGRIND_NO_LEAK_CHECK in tesh files when simgrid-mc is used.
Arnaud Giersch [Fri, 7 Apr 2023 14:49:36 +0000 (16:49 +0200)]
Add $VALGRIND_NO_LEAK_CHECK in tesh files when simgrid-mc is used.

Too many memory leaks are detected in the MCed processes.

13 months agoPass include and library directories to try_compile.
Arnaud Giersch [Fri, 7 Apr 2023 13:23:05 +0000 (15:23 +0200)]
Pass include and library directories to try_compile.

13 months agoFix usage of option --cfg=path in tesh files.
Arnaud Giersch [Fri, 7 Apr 2023 09:43:02 +0000 (11:43 +0200)]
Fix usage of option --cfg=path in tesh files.

Most of them reference a non-existent directory: examples/smpi/msg/.
Remove them.

Use the option in tests from basic-parsing-test.

13 months agoMake distcheck
Martin Quinson [Thu, 6 Apr 2023 16:08:07 +0000 (18:08 +0200)]
Make distcheck

13 months agoMC: Reap all zombie childs to avoid them to accumulate
Martin Quinson [Thu, 6 Apr 2023 15:48:05 +0000 (17:48 +0200)]
MC: Reap all zombie childs to avoid them to accumulate

13 months agoRemove the timings of another ns3 test to help older ns3 versions
Martin Quinson [Thu, 6 Apr 2023 14:58:39 +0000 (16:58 +0200)]
Remove the timings of another ns3 test to help older ns3 versions

13 months agoAllow ns3 to be idempotent if correctly patched
Martin Quinson [Thu, 6 Apr 2023 14:28:33 +0000 (16:28 +0200)]
Allow ns3 to be idempotent if correctly patched