Augustin Degomme [Fri, 2 Apr 2021 22:19:17 +0000 (00:19 +0200)]
Pack_size is meant to return the upper bound of the size.
Thanks agier
Arnaud Giersch [Fri, 2 Apr 2021 21:03:11 +0000 (23:03 +0200)]
A bool is OK in boolean context.
Arnaud Giersch [Fri, 2 Apr 2021 20:45:36 +0000 (22:45 +0200)]
Cosmetics.
SUTER Frederic [Fri, 2 Apr 2021 21:38:48 +0000 (23:38 +0200)]
change way WIFI are create + make sharing_policy optional
SUTER Frederic [Fri, 2 Apr 2021 16:59:12 +0000 (18:59 +0200)]
reindent
SUTER Frederic [Fri, 2 Apr 2021 16:18:09 +0000 (18:18 +0200)]
more simplifications
Arnaud Giersch [Fri, 2 Apr 2021 20:31:04 +0000 (22:31 +0200)]
Fix count for SMPI leak report.
Arnaud Giersch [Fri, 2 Apr 2021 19:44:36 +0000 (21:44 +0200)]
Function doesn't exist.
Arnaud Giersch [Fri, 2 Apr 2021 14:35:31 +0000 (16:35 +0200)]
[mc] Enable finalize_app() in SafetyChecker.
Update mc-coll-allreduce-with-leaks.tesh accordingly.
Arnaud Giersch [Fri, 2 Apr 2021 12:46:22 +0000 (14:46 +0200)]
[sonar] Const in s4u::Disk.
Augustin Degomme [Fri, 2 Apr 2021 18:01:29 +0000 (20:01 +0200)]
update test with latest version from mpich.
d5e44448d0 was a misguided fix, as MPI_SUM is forbidden on MPI_BYTE... And I can't remember what the issue with ubsan was, so let's see
Augustin Degomme [Fri, 2 Apr 2021 17:29:20 +0000 (19:29 +0200)]
MPI_BYTE has some specific requirements, and doesn't allow most operations on it
Augustin Degomme [Fri, 2 Apr 2021 15:32:00 +0000 (17:32 +0200)]
report the proper size on the receiver side, when its buffer was allocated too largely.
I'm sure it used to be done properly ...
Augustin Degomme [Fri, 2 Apr 2021 15:31:12 +0000 (17:31 +0200)]
select proper errhandler when MPI_COMM_WORLD is duplicated
Augustin Degomme [Fri, 2 Apr 2021 15:30:51 +0000 (17:30 +0200)]
recv should return MPI_ERR_TRUNCATE
we crash properly when needed, but don't return it properly if errhandler is meant not to crash
Augustin Degomme [Fri, 2 Apr 2021 15:28:48 +0000 (17:28 +0200)]
fail when trying to attach a buffer if one is already attached
Augustin Degomme [Fri, 2 Apr 2021 15:27:45 +0000 (17:27 +0200)]
when the standard said "return" here, it was not meant as return value.
Augustin Degomme [Fri, 2 Apr 2021 09:34:18 +0000 (11:34 +0200)]
we need to check comm is not null before trying for the rank, duh..
Augustin Degomme [Fri, 2 Apr 2021 09:23:53 +0000 (11:23 +0200)]
this tests actually does not conform to the standard and crashed now, but it's OK to say we are strict here.
Augustin Degomme [Fri, 2 Apr 2021 09:23:03 +0000 (11:23 +0200)]
Add a deleted flag to keep track of invalid but not actually deleted handles
We can then crash if someone tries to use it later on.
just do it for Comm for now, will extend later.
Augustin Degomme [Fri, 2 Apr 2021 09:20:03 +0000 (11:20 +0200)]
fix size of allocated buffer
Augustin Degomme [Fri, 2 Apr 2021 09:19:47 +0000 (11:19 +0200)]
Implement MPI_Comm_test_inter.
Answer is no, as we don't support intercommunicators.
Augustin Degomme [Fri, 2 Apr 2021 09:19:08 +0000 (11:19 +0200)]
add more Fortran definitions
Bruno Donassolo [Fri, 2 Apr 2021 17:26:31 +0000 (19:26 +0200)]
Seal NetZone
We need to be able to seal the netzone too.
Sealing a netzone, seals its children and hosts.
Add protection to avoid sealing twice.
Bruno Donassolo [Fri, 2 Apr 2021 16:41:04 +0000 (18:41 +0200)]
Constify list of links parameter
Bruno Donassolo [Fri, 2 Apr 2021 15:21:23 +0000 (17:21 +0200)]
Simplified methods to add routes
Avoid using LinkImpl in s4u interface.
Add method that raises and exception if netpoint isn't found
Allows the implementation of a platform like small_platform.xml without
using "internal" structures.
SUTER Frederic [Fri, 2 Apr 2021 15:41:11 +0000 (17:41 +0200)]
simplify constant model a bit
SUTER Frederic [Fri, 2 Apr 2021 15:22:01 +0000 (17:22 +0200)]
snake casing IB
SUTER Frederic [Fri, 2 Apr 2021 09:28:14 +0000 (11:28 +0200)]
small simplifications and cleanups
SUTER Frederic [Fri, 2 Apr 2021 08:35:42 +0000 (10:35 +0200)]
simplification
Bruno Donassolo [Fri, 2 Apr 2021 10:01:09 +0000 (12:01 +0200)]
Fix error handling.
Raise std::invalid_argument exception instead of dying.
Thanks for the review ;)
Arnaud Giersch [Fri, 2 Apr 2021 08:50:23 +0000 (10:50 +0200)]
Avoid a local variable only used by xbt_assert.
Arnaud Giersch [Wed, 31 Mar 2021 09:58:57 +0000 (11:58 +0200)]
Change "if(...) xbt_die(...)" to "xbt_assert(...)".
Some of them could certainly be improved to report the error to the user code,
for example with a proper exception, but it's another work.
Arnaud Giersch [Fri, 2 Apr 2021 08:25:39 +0000 (10:25 +0200)]
Never disable xbt_assert anymore.
Arnaud Giersch [Fri, 2 Apr 2021 07:55:05 +0000 (09:55 +0200)]
Make mc::Api::get_actor_name return a const&.
Sometimes avoids unnecessary copies.
Arnaud Giersch [Fri, 2 Apr 2021 08:04:30 +0000 (10:04 +0200)]
Empty is when len == 0!.
Arnaud Giersch [Thu, 1 Apr 2021 21:07:28 +0000 (23:07 +0200)]
Improve debug messages (code is still not functional).
Arnaud Giersch [Thu, 1 Apr 2021 21:05:27 +0000 (23:05 +0200)]
FIXME++
Arnaud Giersch [Thu, 1 Apr 2021 20:49:03 +0000 (22:49 +0200)]
Fix segfault with debug message.
Arnaud Giersch [Thu, 1 Apr 2021 20:48:09 +0000 (22:48 +0200)]
Render mc::Api::get_actor_name() public.
Arnaud Giersch [Thu, 1 Apr 2021 20:22:15 +0000 (22:22 +0200)]
Zero-initialize struct to avoid valgrind warnings.
Use memset, since there is no warranty that the padding bits are set to zero
with an empty initilizer-list {}
Augustin Degomme [Thu, 1 Apr 2021 19:08:31 +0000 (21:08 +0200)]
[ci-skip] save some space on docker images (without breaking stuff hopefully)
Bruno Donassolo [Thu, 1 Apr 2021 17:25:15 +0000 (19:25 +0200)]
Renaming, snake_case
Bruno Donassolo [Thu, 1 Apr 2021 17:00:10 +0000 (19:00 +0200)]
Friendly set_latency, accepts strings.
Human-friendly version for set_latency function.
Accepts strings such as "1ms".
Bruno Donassolo [Thu, 1 Apr 2021 16:15:37 +0000 (18:15 +0200)]
Add create_link in s4u::NetZone
With SharingPolicy as parameter since it's mandatory to decide if we
must create a WiFi link or not.
Setting default as SHARED according to DTD
Bruno Donassolo [Thu, 1 Apr 2021 15:06:20 +0000 (17:06 +0200)]
Simplyfying create_host and exporting it to s4u::NetZone
Bruno Donassolo [Thu, 1 Apr 2021 14:31:31 +0000 (16:31 +0200)]
Adding seal() for Host
Allow changing Host settings before seal
Bruno Donassolo [Thu, 1 Apr 2021 12:16:52 +0000 (14:16 +0200)]
Factory functions for all Netzones
Arnaud Giersch [Thu, 1 Apr 2021 13:00:01 +0000 (15:00 +0200)]
Deobfuscate error checking.
Arnaud Giersch [Wed, 31 Mar 2021 20:22:32 +0000 (22:22 +0200)]
Move declarations for xbt_abort and xbt_die to xbt/asserts.h.
Adjust some #include consequently.
Arnaud Giersch [Wed, 31 Mar 2021 20:20:43 +0000 (22:20 +0200)]
Make xbt_die use the root log category.
Arnaud Giersch [Thu, 1 Apr 2021 11:28:08 +0000 (13:28 +0200)]
Using xbt_* functions in vasprintf() does not look like a good idea.
Bruno Donassolo [Thu, 1 Apr 2021 09:13:33 +0000 (11:13 +0200)]
Moving the models initialization to NetZoneImpl.
By moving the models init to NetZoneImpl, we don't need the xml to initialize the
models.
This should enable C++ platform creation.
Martin Quinson [Thu, 1 Apr 2021 07:52:25 +0000 (09:52 +0200)]
sg_exit never allowed to reload a platform afterward, so reduce the visibility of a variable
At least it never worked properly
Martin Quinson [Thu, 1 Apr 2021 07:22:05 +0000 (09:22 +0200)]
typo (reported by lintian)
Martin Quinson [Wed, 31 Mar 2021 21:08:43 +0000 (23:08 +0200)]
Actor's ID should be a long, and should be named AID
Augustin Degomme [Thu, 1 Apr 2021 06:44:28 +0000 (08:44 +0200)]
add libfmt-dev as a pajeng dependency [noci]
Arnaud Giersch [Wed, 31 Mar 2021 08:59:25 +0000 (10:59 +0200)]
Make ExecImpl::get_hosts return a const&.
Arnaud Giersch [Wed, 31 Mar 2021 08:48:38 +0000 (10:48 +0200)]
Pointer to const.
Arnaud Giersch [Wed, 31 Mar 2021 08:46:36 +0000 (10:46 +0200)]
Unused variable.
Arnaud Giersch [Wed, 31 Mar 2021 08:19:41 +0000 (10:19 +0200)]
Save a reinterpret_cast.
Arnaud Giersch [Wed, 31 Mar 2021 08:07:37 +0000 (10:07 +0200)]
Constify xbt::string::to_string_data.
Arnaud Giersch [Wed, 31 Mar 2021 07:54:55 +0000 (09:54 +0200)]
Ptrace returns a long int.
Arnaud Giersch [Tue, 30 Mar 2021 12:29:11 +0000 (14:29 +0200)]
[mc] Add some coverage_checkpoint() for model-checked applications.
Arnaud Giersch [Tue, 30 Mar 2021 12:25:54 +0000 (14:25 +0200)]
[mc] Politely ask the model-checked application to terminate on shutdown.
Arnaud Giersch [Tue, 30 Mar 2021 12:24:19 +0000 (14:24 +0200)]
[mc] Add an option to ask a model-checked application to terminate.
Arnaud Giersch [Tue, 30 Mar 2021 12:10:51 +0000 (14:10 +0200)]
[mc] Use a basic message type for answering mc::MessageType::FINALIZE.
Arnaud Giersch [Mon, 29 Mar 2021 09:53:13 +0000 (11:53 +0200)]
[mc] Use existing ModelChecker::shutdown() on ModelChecker::exit().
Arnaud Giersch [Tue, 30 Mar 2021 13:26:42 +0000 (15:26 +0200)]
[mc] Terminate crashing applications too.
Arnaud Giersch [Tue, 30 Mar 2021 09:12:12 +0000 (11:12 +0200)]
Remove function calls with side effects from xbt_assert.
Arnaud Giersch [Mon, 29 Mar 2021 20:52:42 +0000 (22:52 +0200)]
Forgot initial dash line in ChangeLog.
Arnaud Giersch [Tue, 30 Mar 2021 19:57:49 +0000 (21:57 +0200)]
[mc] Don't retrieve actor hostname again if it's already there.
Arnaud Giersch [Tue, 30 Mar 2021 19:52:54 +0000 (21:52 +0200)]
[mc] Fix mc::Api::get_actor_host_name.
Host name has moved from Host to HostImpl.
Arnaud Giersch [Tue, 30 Mar 2021 19:45:44 +0000 (21:45 +0200)]
Revert "Fix MC tests."
This reverts commit
ba5cf16371aed445f20533645ca049990862630a.
A fix for the MC side is coming soon.
Bruno Donassolo [Tue, 30 Mar 2021 17:58:32 +0000 (19:58 +0200)]
Fix MC tests.
Move back host name to s4u::Host. There, it's accessible by MC
Bruno Donassolo [Thu, 18 Mar 2021 09:49:30 +0000 (10:49 +0100)]
Refactor Host and HostImpl
- Going towards empty s4u interfaces
- s4u::Host is created at HostImpl directly as for s4u::Link and
LinkImpl.
- VirtualMachines are still an exception. The user creates directly the
s4u::VirtualMachine object
Bruno Donassolo [Thu, 25 Mar 2021 16:48:42 +0000 (17:48 +0100)]
New API: set_pstate_speed
Implement new API to set pstate for a host:
- Host* Host::set_pstate_speed(const std::vector<double>& speed_per_state)
- Host* Host::set_pstate_speed(const std::vector<std::string>& speed_per_state)
SUTER Frederic [Tue, 30 Mar 2021 10:45:34 +0000 (12:45 +0200)]
fix java test: get_remaining() needs the Exec to be started
SUTER Frederic [Sat, 27 Mar 2021 11:28:25 +0000 (12:28 +0100)]
try to match Activity design to Resource design
Arnaud Giersch [Sun, 28 Mar 2021 15:28:56 +0000 (17:28 +0200)]
Define next XBT_ATTRIB_DEPRECATED macro.
Arnaud Giersch [Sun, 28 Mar 2021 13:50:57 +0000 (15:50 +0200)]
Remove deprecated features for next release.
Arnaud Giersch [Sun, 28 Mar 2021 13:44:45 +0000 (15:44 +0200)]
Start the dev of 3.28.
Martin Quinson [Mon, 29 Mar 2021 14:44:45 +0000 (16:44 +0200)]
Release SimGrid v3.27
Arnaud Giersch [Mon, 29 Mar 2021 12:56:19 +0000 (14:56 +0200)]
Avoid using && in .gitlab-ci.yml.
It does not always stop the script as we would expect.
See https://gitlab.com/gitlab-org/gitlab-runner/-/issues/25394 for more info.
Arnaud Giersch [Mon, 29 Mar 2021 11:30:47 +0000 (13:30 +0200)]
Move xbt_modinter.h to src/include/xbt/.
Martin Quinson [Mon, 29 Mar 2021 10:28:08 +0000 (12:28 +0200)]
Typos [noci]
Augustin Degomme [Sun, 28 Mar 2021 23:36:04 +0000 (01:36 +0200)]
add some words about new options in smpi tuto
Augustin Degomme [Sun, 28 Mar 2021 15:55:04 +0000 (17:55 +0200)]
typo [noci]
Augustin Degomme [Sun, 28 Mar 2021 14:03:30 +0000 (16:03 +0200)]
cosmetics
Augustin Degomme [Sun, 28 Mar 2021 14:03:09 +0000 (16:03 +0200)]
add message when 0 bytes are allocated
Martin Quinson [Sun, 28 Mar 2021 10:11:44 +0000 (12:11 +0200)]
Proposition of a NEWS entry
Augustin Degomme [Sun, 28 Mar 2021 01:47:16 +0000 (03:47 +0200)]
cosmetics
Augustin Degomme [Sun, 28 Mar 2021 01:29:20 +0000 (03:29 +0200)]
also change option name in MC-flavored tesh
Augustin Degomme [Sun, 28 Mar 2021 00:59:56 +0000 (01:59 +0100)]
trim changelog
Augustin Degomme [Sun, 28 Mar 2021 00:59:46 +0000 (01:59 +0100)]
document new options
Augustin Degomme [Sun, 28 Mar 2021 00:57:18 +0000 (01:57 +0100)]
add -analyze to smpirun to activate both smpi/display-timing and smpi/display-allocs at once
Augustin Degomme [Sun, 28 Mar 2021 00:56:39 +0000 (01:56 +0100)]
rename option,
display-analysis was meant to display both timings and allocations, but it's just allocations.
Augustin Degomme [Sun, 28 Mar 2021 00:52:49 +0000 (01:52 +0100)]
typo
Arnaud Giersch [Sat, 27 Mar 2021 22:43:16 +0000 (23:43 +0100)]
Typos [noci]
Arnaud Giersch [Sat, 27 Mar 2021 22:38:19 +0000 (23:38 +0100)]
Add explaining comment.