Bruno Donassolo [Tue, 5 Apr 2022 09:16:16 +0000 (11:16 +0200)]
Sonar smells
Fred Suter [Tue, 5 Apr 2022 20:53:00 +0000 (16:53 -0400)]
allow Engine::link_by_name_or_null(__loopback__)
Arnaud Giersch [Tue, 5 Apr 2022 10:21:27 +0000 (12:21 +0200)]
Even more unused variable.
Arnaud Giersch [Tue, 5 Apr 2022 09:36:35 +0000 (11:36 +0200)]
More unused variables breaking new clang builds.
Arnaud Giersch [Tue, 5 Apr 2022 07:50:00 +0000 (09:50 +0200)]
Unused variable.
Bruno Donassolo [Sat, 2 Apr 2022 16:28:59 +0000 (18:28 +0200)]
Separate NetworkModel from LinkImpl.
Fix memleak in internal loopback link
Bruno Donassolo [Fri, 1 Apr 2022 21:32:01 +0000 (23:32 +0200)]
Move links_ to the netzone their are declared
Starting moving things out Engine class.
Links are stored in the netzone which their were declared.
Exception for __loopback__ link that is a special "model" link.
No changes in external Engine::get_links API.
Internally cleanup so someone can change the API.
-
msimonin [Mon, 4 Apr 2022 08:28:11 +0000 (10:28 +0200)]
doc/tuto: Engine.instance is a python property
msimonin [Mon, 4 Apr 2022 08:26:27 +0000 (10:26 +0200)]
doc/tuto: docker, show how to fix the permissions
msimonin [Mon, 4 Apr 2022 07:56:13 +0000 (09:56 +0200)]
doc/tuto: docker make clear where commands run
msimonin [Mon, 4 Apr 2022 07:52:12 +0000 (09:52 +0200)]
doc/tuto: use root shortcut in docker exec
msimonin [Mon, 4 Apr 2022 07:50:42 +0000 (09:50 +0200)]
doc/tuto: the container's name is simgrid
Arnaud Giersch [Thu, 31 Mar 2022 20:07:56 +0000 (22:07 +0200)]
Little Sonar things.
Arnaud Giersch [Thu, 31 Mar 2022 09:43:58 +0000 (11:43 +0200)]
Dead code elimination.
SUTER Frederic [Thu, 31 Mar 2022 02:24:59 +0000 (04:24 +0200)]
int->size_t
SUTER Frederic [Thu, 31 Mar 2022 02:14:56 +0000 (04:14 +0200)]
allow users to retrieve hosts and links by the zone in which they have been declared
Martin Quinson [Wed, 30 Mar 2022 21:30:16 +0000 (21:30 +0000)]
Merge branch 'add_missing_comm_python_bindings' into 'master'
Add remaining Comm bindings and examples
See merge request simgrid/simgrid!93
Arnaud Giersch [Wed, 30 Mar 2022 20:12:35 +0000 (22:12 +0200)]
[MBI] Avoid to generate if() with the same then/else branches.
PVS-studio: V523. The 'then' statement is equivalent to the 'else' statement.
Arnaud Giersch [Wed, 30 Mar 2022 19:31:19 +0000 (21:31 +0200)]
[MBI] Less duplication of constant strings (sonar).
Arnaud Giersch [Wed, 30 Mar 2022 18:58:39 +0000 (20:58 +0200)]
[MBI] Make a real copy of 'patterns' into 'replace'.
Makes minor changes to the generated output.
Arnaud Giersch [Wed, 30 Mar 2022 12:39:15 +0000 (14:39 +0200)]
[MBI] Make array initialization explicit.
PVS-studio: V1009. Check the array initialization. Only the first element is initialized explicitly.
Arnaud Giersch [Wed, 30 Mar 2022 09:16:06 +0000 (11:16 +0200)]
Field is never changed after construction.
Arnaud Giersch [Wed, 30 Mar 2022 07:23:18 +0000 (09:23 +0200)]
Indentation.
Arnaud Giersch [Tue, 29 Mar 2022 20:37:53 +0000 (22:37 +0200)]
[MBI] Remove redundant call (already called from mbi.categorize).
Arnaud Giersch [Tue, 29 Mar 2022 20:30:36 +0000 (22:30 +0200)]
[MBI] Zero send buffer for Scatter too.
Arnaud Giersch [Tue, 29 Mar 2022 20:04:17 +0000 (22:04 +0200)]
[MBI] Remove useless assignments..
Arnaud Giersch [Tue, 29 Mar 2022 19:59:00 +0000 (21:59 +0200)]
[MBI] Don't change contracts with method overrides.
Arnaud Giersch [Tue, 29 Mar 2022 19:51:32 +0000 (21:51 +0200)]
[MBI] Use check=True for subprocess.run.
Arnaud Giersch [Tue, 29 Mar 2022 19:46:26 +0000 (21:46 +0200)]
[MBI] Fix string types.
Arnaud Giersch [Tue, 29 Mar 2022 16:55:06 +0000 (18:55 +0200)]
[MBI] Add missing "self" parameter.
Arnaud Giersch [Tue, 29 Mar 2022 16:44:36 +0000 (18:44 +0200)]
[MBI] Reduce scope for variables.
Arnaud Giersch [Tue, 29 Mar 2022 15:26:50 +0000 (17:26 +0200)]
[MBI] Fix description (outside of the {c2} loop).
Arnaud Giersch [Tue, 29 Mar 2022 15:17:05 +0000 (17:17 +0200)]
[MBI] Replace more wildard imports.
Arnaud Giersch [Tue, 29 Mar 2022 13:24:01 +0000 (15:24 +0200)]
[MBI] Import generator_utils as gen.
Arnaud Giersch [Mon, 28 Mar 2022 12:49:25 +0000 (14:49 +0200)]
[MBI] Whitespace cleanup.
Arnaud Giersch [Tue, 29 Mar 2022 13:48:33 +0000 (15:48 +0200)]
[MBI] Abort cmake on failure.
Arnaud Giersch [Thu, 24 Mar 2022 21:28:48 +0000 (22:28 +0100)]
Make factory_initializer a static member of ContextFactory.
Martin Quinson [Tue, 29 Mar 2022 17:55:41 +0000 (17:55 +0000)]
Merge branch 'dev-mailbox-clear' into 'master'
Expose MailboxImpl::clear() to improve handling of node faults
See merge request simgrid/simgrid!89
Arnaud Giersch [Tue, 29 Mar 2022 12:09:11 +0000 (14:09 +0200)]
Reduce dependencies on <simgrid/version.h>.
Limit the amount of re-compilation when the file is changed by cmake.
Arnaud Giersch [Tue, 29 Mar 2022 07:29:47 +0000 (09:29 +0200)]
Propagate const pointer (thx sonar).
Martin Quinson [Mon, 28 Mar 2022 16:37:20 +0000 (18:37 +0200)]
Fix the generation of MBI test cases (and compile them with -Wno-unused-variable but with -Werror)
Arnaud Giersch [Mon, 28 Mar 2022 14:45:33 +0000 (16:45 +0200)]
Fix locale for Java example.
Arnaud Giersch [Sun, 27 Mar 2022 09:30:30 +0000 (11:30 +0200)]
Const pointer.
Martin Quinson [Mon, 28 Mar 2022 07:44:54 +0000 (09:44 +0200)]
PVS fixes in MBI: initialize buffers before use
Martin Quinson [Sun, 27 Mar 2022 20:26:17 +0000 (22:26 +0200)]
MBI: cosmetics in a diagnostic
Martin Quinson [Sun, 27 Mar 2022 20:17:04 +0000 (22:17 +0200)]
BuildSimGrid.sh: allow the use of ninja
Starting shell commands to rebuild all the 2000 binaries of MBI is
really too slow.
Martin Quinson [Sun, 27 Mar 2022 19:38:43 +0000 (21:38 +0200)]
Tiny cosmetics around MBI
Martin Quinson [Sun, 27 Mar 2022 19:36:32 +0000 (21:36 +0200)]
MBI: Do not use arrays out of bound
Bruno Donassolo [Mon, 28 Mar 2022 09:33:52 +0000 (11:33 +0200)]
Fix java test
Be a little less optimistic about double precision, use the same default
surf precision
Bruno Donassolo [Mon, 28 Mar 2022 08:44:54 +0000 (10:44 +0200)]
Cosmetics: doc about System's concurrency
Bruno Donassolo [Mon, 28 Mar 2022 08:21:26 +0000 (10:21 +0200)]
Cosmetics: System.cpp
Rename staged_penalty to staged_sharing_penalty_
Bruno Donassolo [Mon, 28 Mar 2022 08:17:16 +0000 (08:17 +0000)]
Merge branch 'issue105' into 'master'
Fix #105 - Unify expand and expand_add
Closes #105
See merge request simgrid/simgrid!92
Augustin Degomme [Sun, 27 Mar 2022 19:11:11 +0000 (19:11 +0000)]
ignore MBI in cobertura reports. Keep them for PVS for now, as report may be useful
Augustin Degomme [Sun, 27 Mar 2022 12:37:31 +0000 (12:37 +0000)]
test activating MBI on coverage build
Martin Quinson [Sat, 26 Mar 2022 23:22:25 +0000 (00:22 +0100)]
MBI: typo
Martin Quinson [Sat, 26 Mar 2022 23:08:44 +0000 (00:08 +0100)]
MBI mark the test requiring the detection of local variables as failing
Martin Quinson [Sat, 26 Mar 2022 22:59:49 +0000 (23:59 +0100)]
MBI: buffer on stack is a programming error, not a MPI error
Martin Quinson [Sat, 26 Mar 2022 22:59:06 +0000 (23:59 +0100)]
MBI test: disply the right buffer on error
Martin Quinson [Sat, 26 Mar 2022 10:01:16 +0000 (11:01 +0100)]
Resynch MBI generators with upstream
CollP2PMessageRaceGenerator.py: Replace source of second recv for message race.
(+ whitespace cleanups)
Martin Quinson [Sat, 26 Mar 2022 09:58:00 +0000 (10:58 +0100)]
Reactivate the last MBI generator now that it produces tests that compile
Arnaud Giersch [Sat, 26 Mar 2022 13:28:48 +0000 (14:28 +0100)]
Fix dead links.
Not sure what to do with the remainging links to
pda.gforge.inria.fr / lists.gforge.inria.fr / gforge.inria.fr/tracker
[ci-skip]
Arnaud Giersch [Fri, 25 Mar 2022 21:51:22 +0000 (22:51 +0100)]
Cosmetics: don't talk about ActorIDTrait if it's not required.
Arnaud Giersch [Fri, 25 Mar 2022 21:33:31 +0000 (22:33 +0100)]
Slightly improve message on deadlock.
Arnaud Giersch [Fri, 25 Mar 2022 21:21:07 +0000 (22:21 +0100)]
Remove unused member.
Arnaud Giersch [Fri, 25 Mar 2022 15:43:53 +0000 (16:43 +0100)]
[sonar] Don't mix public and private members (mc::State).
Arnaud Giersch [Fri, 25 Mar 2022 15:36:47 +0000 (16:36 +0100)]
[sonar] Don't mix public and private members (mc::ModelChecker).
Arnaud Giersch [Fri, 25 Mar 2022 13:35:13 +0000 (14:35 +0100)]
[sonar] Don't mix public and private members (resource::DiskImpl).
Martin Quinson [Fri, 25 Mar 2022 20:23:13 +0000 (21:23 +0100)]
Expose signals Activity::on_suspend and Activity::on_resume in s4u
Earlier, they were only accessible from ActivityImpl
Martin Quinson [Fri, 25 Mar 2022 20:00:40 +0000 (21:00 +0100)]
kill a signal that never worked anyway
Martin Quinson [Fri, 25 Mar 2022 14:53:10 +0000 (15:53 +0100)]
Yet another tiny improvement to the release process
Arnaud Giersch [Fri, 25 Mar 2022 08:36:50 +0000 (09:36 +0100)]
Make it possible to have an empty profile callback.
Arnaud Giersch [Fri, 25 Mar 2022 08:26:53 +0000 (09:26 +0100)]
Sonar is right: a std:vector is just fine here.
Jean-Edouard BOULANGER [Fri, 25 Mar 2022 07:26:51 +0000 (08:26 +0100)]
Add remaining Comm bindings and examples
Arnaud Giersch [Thu, 24 Mar 2022 15:47:57 +0000 (16:47 +0100)]
Make NOW a static member of EngineImpl.
Arnaud Giersch [Thu, 24 Mar 2022 15:33:18 +0000 (16:33 +0100)]
Make maxpid a static member of ActorIDTrait.
Arnaud Giersch [Thu, 24 Mar 2022 13:16:17 +0000 (14:16 +0100)]
Use a std::unique_ptr, and avoid explicit new/delete.
Arnaud Giersch [Wed, 23 Mar 2022 21:09:20 +0000 (22:09 +0100)]
Save more std::string copies.
Arnaud Giersch [Wed, 23 Mar 2022 14:53:40 +0000 (15:53 +0100)]
Avoid unnecessary copy of std::string parameter.
Martin Quinson [Thu, 24 Mar 2022 19:41:09 +0000 (20:41 +0100)]
kill trailing spaces and tabs in MBI files
Martin Quinson [Thu, 24 Mar 2022 19:38:59 +0000 (20:38 +0100)]
Sync MBI generators with upstream modifications
Martin Quinson [Thu, 24 Mar 2022 17:17:30 +0000 (18:17 +0100)]
Remove a reference to gforge from the README
Martin Quinson [Wed, 23 Mar 2022 15:46:01 +0000 (16:46 +0100)]
Revalidate the tesh outputs after cosmetics to the output in mc_dfs
Martin Quinson [Wed, 23 Mar 2022 15:44:46 +0000 (16:44 +0100)]
Fix the dependency of inter-comm transitions
Saying that COMM are indep with non-COMM transitions is good, but this
shouldnt mess up with the computation between COMM transitions...
Martin Quinson [Tue, 22 Mar 2022 20:55:09 +0000 (21:55 +0100)]
tiny fix in release process
Martin Quinson [Tue, 22 Mar 2022 20:54:50 +0000 (21:54 +0100)]
MC: be explicit when reaching an execution end (it's important when reading user's output)
Martin Quinson [Tue, 22 Mar 2022 20:53:22 +0000 (21:53 +0100)]
Comm transitions are INDEP with non-comm transitions
Arnaud Giersch [Tue, 22 Mar 2022 14:55:32 +0000 (15:55 +0100)]
More XBT_PUBLIC for mingw.
[ci-skip]
Arnaud Giersch [Tue, 22 Mar 2022 13:52:36 +0000 (14:52 +0100)]
A few Sonar smells.
Arnaud Giersch [Tue, 22 Mar 2022 13:05:43 +0000 (14:05 +0100)]
Wrong find&replace.
Arnaud Giersch [Tue, 22 Mar 2022 12:54:44 +0000 (13:54 +0100)]
Misc Python smells from codefactor.io.
* unnecesary semicolon
* unnecessary "pass" statement.
* unnecessary "else" after "return".
* unnecessary "global"
* specify exception type
* testing for None should use the 'is' operator
* don't redefine built-ins
* unused statements (import, assignment)
Arnaud Giersch [Tue, 22 Mar 2022 12:54:44 +0000 (13:54 +0100)]
Unnecessary newlines.
[ci-skip]
Arnaud Giersch [Tue, 22 Mar 2022 12:54:44 +0000 (13:54 +0100)]
Define macro XBT_ATTRIB_DEPRECATED_v336.
Arnaud Giersch [Tue, 22 Mar 2022 12:54:44 +0000 (13:54 +0100)]
Remove deprecated features for next release (3.32).
FIXME: NetZoneImpl::on_route_creation is not removed.
Arnaud Giersch [Tue, 22 Mar 2022 12:54:44 +0000 (13:54 +0100)]
Start the dev cycle toward v3.32.
Martin Quinson [Tue, 22 Mar 2022 11:52:24 +0000 (12:52 +0100)]
Fix the release date in the release notes
Martin Quinson [Tue, 22 Mar 2022 10:38:44 +0000 (11:38 +0100)]
Release v3.31
Martin Quinson [Tue, 22 Mar 2022 10:33:55 +0000 (11:33 +0100)]
Update tuto MC to the latest tool output
Bruno Donassolo [Tue, 22 Mar 2022 10:05:43 +0000 (11:05 +0100)]
Add test for issue105
Martin Quinson [Tue, 22 Mar 2022 09:26:08 +0000 (10:26 +0100)]
Fix make distcheck, once again
Martin Quinson [Tue, 22 Mar 2022 08:49:46 +0000 (09:49 +0100)]
Complete the documentation of v3.31