Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agothis was a bad idea and I messed up my commits
Frederic Suter [Tue, 17 Oct 2017 14:10:00 +0000 (16:10 +0200)]
this was a bad idea and I messed up my commits

2 years agostart deprecating xbt_dict
Frederic Suter [Tue, 17 Oct 2017 13:41:55 +0000 (15:41 +0200)]
start deprecating xbt_dict

2 years agoMerge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Tue, 17 Oct 2017 13:03:58 +0000 (15:03 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid

2 years agostop using xbt_dict_set/get_ext
Frederic Suter [Tue, 17 Oct 2017 13:01:01 +0000 (15:01 +0200)]
stop using xbt_dict_set/get_ext

2 years agoUse std::string in network_ns3, and fix memory leak.
Arnaud Giersch [Tue, 17 Oct 2017 10:28:53 +0000 (12:28 +0200)]
Use std::string in network_ns3, and fix memory leak.

2 years agoMark unused parameters.
Arnaud Giersch [Tue, 17 Oct 2017 10:21:08 +0000 (12:21 +0200)]
Mark unused parameters.

Sonar, are you happy with that?

2 years agotiny cleanups
Frederic Suter [Tue, 17 Oct 2017 09:17:30 +0000 (11:17 +0200)]
tiny cleanups

2 years agokill LAST dict in internals !!!
Frederic Suter [Tue, 17 Oct 2017 08:31:12 +0000 (10:31 +0200)]
kill LAST dict in internals !!!

hey, agier, there are some leaks in ns3 that are captured by CI.

2 years agoVariable may be unused.
Arnaud Giersch [Mon, 16 Oct 2017 21:26:46 +0000 (23:26 +0200)]
Variable may be unused.

2 years agoReplace some more malloc/free.
Arnaud Giersch [Mon, 16 Oct 2017 21:11:13 +0000 (23:11 +0200)]
Replace some more malloc/free.

2 years agoUse simgrid::xbt::string_printf.
Arnaud Giersch [Mon, 16 Oct 2017 21:08:53 +0000 (23:08 +0200)]
Use simgrid::xbt::string_printf.

2 years agoAdd default label to switch.
Arnaud Giersch [Mon, 16 Oct 2017 20:42:14 +0000 (22:42 +0200)]
Add default label to switch.

2 years agoAdd a default initialization for member variables.
Arnaud Giersch [Mon, 16 Oct 2017 20:31:46 +0000 (22:31 +0200)]
Add a default initialization for member variables.

2 years agoInvert variable to circumvent false positive of cppcheck.
Arnaud Giersch [Mon, 16 Oct 2017 20:25:03 +0000 (22:25 +0200)]
Invert variable to circumvent false positive of cppcheck.

2 years agoRemove unused macros.
Arnaud Giersch [Mon, 16 Oct 2017 20:08:02 +0000 (22:08 +0200)]
Remove unused macros.

2 years agoSonar still does not like #undef. Use a local variable to hide _xbt_log_cat_init.
Arnaud Giersch [Mon, 16 Oct 2017 20:04:58 +0000 (22:04 +0200)]
Sonar still does not like #undef.  Use a local variable to hide _xbt_log_cat_init.

2 years agoSonar doesn't like #undef.
Arnaud Giersch [Mon, 16 Oct 2017 19:49:06 +0000 (21:49 +0200)]
Sonar doesn't like #undef.

2 years agoReplace macro by an inline function.
Arnaud Giersch [Mon, 16 Oct 2017 19:46:17 +0000 (21:46 +0200)]
Replace macro by an inline function.

2 years agoSonar asked to end this switch cases with an unconditional statement.
Arnaud Giersch [Mon, 16 Oct 2017 19:30:05 +0000 (21:30 +0200)]
Sonar asked to end this switch cases with an unconditional statement.

2 years agoRewrite without goto going backward.
Arnaud Giersch [Mon, 16 Oct 2017 15:09:49 +0000 (17:09 +0200)]
Rewrite without goto going backward.

A big diff due to reindentation, best viewed with "git show -w".

2 years agomore std::string and stuff
Frederic Suter [Mon, 16 Oct 2017 13:33:58 +0000 (15:33 +0200)]
more std::string and stuff

2 years agoMerge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Mon, 16 Oct 2017 13:02:14 +0000 (15:02 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid

2 years agoc++ify some (untested) code
Frederic Suter [Mon, 16 Oct 2017 12:08:38 +0000 (14:08 +0200)]
c++ify some (untested) code

2 years agoExplicitly use default ctor/dtor.
Arnaud Giersch [Mon, 16 Oct 2017 11:32:23 +0000 (13:32 +0200)]
Explicitly use default ctor/dtor.

2 years agoKill useless empty functions.
Arnaud Giersch [Mon, 16 Oct 2017 11:31:49 +0000 (13:31 +0200)]
Kill useless empty functions.

2 years agoAdd comments to acknowledge empty functions (and please Sonar).
Arnaud Giersch [Mon, 16 Oct 2017 08:50:48 +0000 (10:50 +0200)]
Add comments to acknowledge empty functions (and please Sonar).

2 years agoAllow nullptr for Extension deleter.
Arnaud Giersch [Mon, 16 Oct 2017 11:25:42 +0000 (13:25 +0200)]
Allow nullptr for Extension deleter.

2 years agoUse s4u API in example.
Arnaud Giersch [Mon, 16 Oct 2017 08:32:16 +0000 (10:32 +0200)]
Use s4u API in example.

2 years agoComment name for unused parameters.
Arnaud Giersch [Sun, 15 Oct 2017 21:20:01 +0000 (23:20 +0200)]
Comment name for unused parameters.

2 years agoMove variable defintion out of header file.
Arnaud Giersch [Sun, 15 Oct 2017 21:06:05 +0000 (23:06 +0200)]
Move variable defintion out of header file.

2 years agocosmetics after integrating #229
Martin Quinson [Sun, 15 Oct 2017 19:56:27 +0000 (21:56 +0200)]
cosmetics after integrating #229

2 years agoMerge branch 'Takishipp-actor-startkilltime'
Martin Quinson [Sun, 15 Oct 2017 19:36:50 +0000 (21:36 +0200)]
Merge branch 'Takishipp-actor-startkilltime'

2 years agoMerge branch 'actor-startkilltime' of https://github.com/Takishipp/simgrid into Takis...
Martin Quinson [Sun, 15 Oct 2017 19:36:23 +0000 (21:36 +0200)]
Merge branch 'actor-startkilltime' of https://github.com/Takishipp/simgrid into Takishipp-actor-startkilltime

2 years agofollow up on #228: fix make dist and cleanups
Martin Quinson [Sun, 15 Oct 2017 19:19:31 +0000 (21:19 +0200)]
follow up on #228: fix make dist and cleanups

2 years agoMerge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Martin Quinson [Sun, 15 Oct 2017 18:59:38 +0000 (20:59 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid

2 years agokill last dicts in instr
Frederic Suter [Sun, 15 Oct 2017 16:57:26 +0000 (18:57 +0200)]
kill last dicts in instr
revalidate awfully long tesh files

2 years agocosmetics after integrating #228
Martin Quinson [Sun, 15 Oct 2017 15:21:43 +0000 (17:21 +0200)]
cosmetics after integrating #228

2 years agoremove bogus debug log file
Martin Quinson [Sun, 15 Oct 2017 14:40:12 +0000 (16:40 +0200)]
remove bogus debug log file

2 years agoMerge pull request #228 from Takishipp/actor-execute
Martin Quinson [Sun, 15 Oct 2017 14:37:30 +0000 (16:37 +0200)]
Merge pull request #228 from Takishipp/actor-execute

Convert actor-execute to s4u API

2 years agoMake it clearer that there's no memory leak here.
Arnaud Giersch [Sun, 15 Oct 2017 13:57:14 +0000 (15:57 +0200)]
Make it clearer that there's no memory leak here.

2 years agoFix segfault when exiting without running the simulation.
Arnaud Giersch [Sun, 15 Oct 2017 13:48:57 +0000 (15:48 +0200)]
Fix segfault when exiting without running the simulation.

A big warning is issued instead: not sure that it's sufficient for bug #230
to be closed.

2 years agoReplace malloc/free by new/delete.
Arnaud Giersch [Sun, 15 Oct 2017 12:55:05 +0000 (14:55 +0200)]
Replace malloc/free by new/delete.

2 years agoDocument last changes to public API, and keep old method (marked as deprecated).
Arnaud Giersch [Sun, 15 Oct 2017 12:41:38 +0000 (14:41 +0200)]
Document last changes to public API, and keep old method (marked as deprecated).

2 years agoDefine XBT_ATTRIB_DEPRECATED_v321.
Arnaud Giersch [Sun, 15 Oct 2017 12:13:56 +0000 (14:13 +0200)]
Define XBT_ATTRIB_DEPRECATED_v321.

2 years agoChange getName() and add getCname() in s4u::Storage.
Arnaud Giersch [Sat, 14 Oct 2017 20:52:46 +0000 (22:52 +0200)]
Change getName() and add getCname() in s4u::Storage.

2 years agoConstify getName()/getCname() in s4u::NetZone.
Arnaud Giersch [Sat, 14 Oct 2017 20:49:28 +0000 (22:49 +0200)]
Constify getName()/getCname() in s4u::NetZone.

2 years agoChange getName() and add getCname() in s4u::Mailbox.
Arnaud Giersch [Sat, 14 Oct 2017 20:40:05 +0000 (22:40 +0200)]
Change getName() and add getCname() in s4u::Mailbox.

2 years agoChange name() to getCname() and add getName() in s4u::Link.
Arnaud Giersch [Sat, 14 Oct 2017 20:15:40 +0000 (22:15 +0200)]
Change name() to getCname() and add getName() in s4u::Link.

2 years agoCosmetics.
Arnaud Giersch [Sat, 14 Oct 2017 20:14:55 +0000 (22:14 +0200)]
Cosmetics.

2 years agoConstify getName()/getCname() in s4u::Actor.
Arnaud Giersch [Sat, 14 Oct 2017 20:11:41 +0000 (22:11 +0200)]
Constify getName()/getCname() in s4u::Actor.

2 years agoAdd getName()/getCname() in kernel::activity::MailboxImpl.
Arnaud Giersch [Sat, 14 Oct 2017 20:07:08 +0000 (22:07 +0200)]
Add getName()/getCname() in kernel::activity::MailboxImpl.

2 years agoChange cname() to getCname() and add getName() in simix::ActorImpl.
Arnaud Giersch [Sat, 14 Oct 2017 14:12:06 +0000 (16:12 +0200)]
Change cname() to getCname() and add getName() in simix::ActorImpl.

2 years agoChange name()/cname() to getName()/getCname() in surf::FileImpl.
Arnaud Giersch [Sat, 14 Oct 2017 13:48:27 +0000 (15:48 +0200)]
Change name()/cname() to getName()/getCname() in surf::FileImpl.

2 years agoChange cname() to getCname() and add getName() in surf::Resource.
Arnaud Giersch [Sat, 14 Oct 2017 12:03:03 +0000 (14:03 +0200)]
Change cname() to getCname() and add getName() in surf::Resource.

2 years agoChange name()/cname() to getName()/getCname() in kernel::routing::NetPoint.
Arnaud Giersch [Sat, 14 Oct 2017 11:23:25 +0000 (13:23 +0200)]
Change name()/cname() to getName()/getCname() in kernel::routing::NetPoint.

2 years agoUse a C++ string instead of char* for mailbox name.
Arnaud Giersch [Sat, 14 Oct 2017 21:24:33 +0000 (23:24 +0200)]
Use a C++ string instead of char* for mailbox name.

2 years agoAdd a method to get the string_data from a simgrid::xbt::string.
Arnaud Giersch [Sat, 14 Oct 2017 21:23:09 +0000 (23:23 +0200)]
Add a method to get the string_data from a simgrid::xbt::string.

2 years agoReindent.
Arnaud Giersch [Fri, 13 Oct 2017 11:57:05 +0000 (13:57 +0200)]
Reindent.

2 years agoAvoid potential memory leak.
Arnaud Giersch [Fri, 13 Oct 2017 11:40:47 +0000 (13:40 +0200)]
Avoid potential memory leak.

2 years agoCosmetics: remove redundant "case" clause.
Arnaud Giersch [Fri, 13 Oct 2017 10:22:17 +0000 (12:22 +0200)]
Cosmetics: remove redundant "case" clause.

2 years agoCosmetics: remove redundant access specifier.
Arnaud Giersch [Fri, 13 Oct 2017 10:07:49 +0000 (12:07 +0200)]
Cosmetics: remove redundant access specifier.

2 years agoCosmetics: one statement per declaration.
Arnaud Giersch [Fri, 13 Oct 2017 09:54:28 +0000 (11:54 +0200)]
Cosmetics: one statement per declaration.

2 years agoRework way of creating Type hierarchy.
Frederic Suter [Fri, 13 Oct 2017 12:51:54 +0000 (14:51 +0200)]
Rework way of creating Type hierarchy.

Not perfect but I hope a bit better/clearer

2 years agouse bools and true/false
Frederic Suter [Fri, 13 Oct 2017 10:48:44 +0000 (12:48 +0200)]
use bools and true/false

2 years agoMore objectification of instr::Type (wip)
Frederic Suter [Fri, 13 Oct 2017 09:49:43 +0000 (11:49 +0200)]
More objectification of instr::Type (wip)

2 years agoMerge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Fri, 13 Oct 2017 09:11:47 +0000 (11:11 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid

2 years agoRepair Dijkstra's cache mode.
Arnaud Giersch [Fri, 13 Oct 2017 08:59:25 +0000 (10:59 +0200)]
Repair Dijkstra's cache mode.

2 years agoRemove an indirection and fix memory leak.
Arnaud Giersch [Fri, 13 Oct 2017 08:08:11 +0000 (10:08 +0200)]
Remove an indirection and fix memory leak.

2 years agoFix memory leaks.
Arnaud Giersch [Thu, 12 Oct 2017 21:37:35 +0000 (23:37 +0200)]
Fix memory leaks.

2 years agoIn MSG_parallel_task_create(), take a copy of flops_amount and bytes_amount.
Arnaud Giersch [Thu, 12 Oct 2017 21:25:14 +0000 (23:25 +0200)]
In MSG_parallel_task_create(), take a copy of flops_amount and bytes_amount.

Fix undefined behavior when they were not dynamically allocated, and permit
to replace more malloc/free.

2 years agoAnother bunch of s/malloc/new/.
Arnaud Giersch [Thu, 12 Oct 2017 14:50:38 +0000 (16:50 +0200)]
Another bunch of s/malloc/new/.

2 years agorefactoring and namespacing
Frederic Suter [Thu, 12 Oct 2017 15:29:10 +0000 (17:29 +0200)]
refactoring and namespacing

2 years agomove creation and destruction logging to Class
Frederic Suter [Thu, 12 Oct 2017 13:18:07 +0000 (15:18 +0200)]
move creation and destruction logging to Class

2 years agosimplify container creation
Frederic Suter [Thu, 12 Oct 2017 12:11:12 +0000 (14:11 +0200)]
simplify container creation

2 years agoPJ_container_remove_from_parent () becomes Container::removeFromParent
Frederic Suter [Thu, 12 Oct 2017 11:14:36 +0000 (13:14 +0200)]
PJ_container_remove_from_parent () becomes Container::removeFromParent

2 years agouse namespaces for instr containers and values
Frederic Suter [Thu, 12 Oct 2017 10:57:35 +0000 (12:57 +0200)]
use namespaces for instr containers and values

2 years agomore stringification/privatization
Frederic Suter [Thu, 12 Oct 2017 09:47:36 +0000 (11:47 +0200)]
more stringification/privatization

2 years agokill another dict in instr
Frederic Suter [Thu, 12 Oct 2017 08:42:21 +0000 (10:42 +0200)]
kill another dict in instr

2 years agodicts to maps in Dijkstra
Frederic Suter [Thu, 12 Oct 2017 07:58:40 +0000 (09:58 +0200)]
dicts to maps in Dijkstra

Is that code tested?

2 years agominor smell--
Frederic Suter [Thu, 12 Oct 2017 07:25:00 +0000 (09:25 +0200)]
minor smell--

2 years agoFix build on freebsd and macos.
Arnaud Giersch [Wed, 11 Oct 2017 21:31:38 +0000 (23:31 +0200)]
Fix build on freebsd and macos.

2 years agoanother pre-release check to do
Martin Quinson [Wed, 11 Oct 2017 21:20:19 +0000 (23:20 +0200)]
another pre-release check to do

2 years agodocument how the jenkins hosts were created (fix #210)
Martin Quinson [Wed, 11 Oct 2017 21:19:43 +0000 (23:19 +0200)]
document how the jenkins hosts were created (fix #210)

2 years agoComment unused function parameter.
Arnaud Giersch [Wed, 11 Oct 2017 20:27:51 +0000 (22:27 +0200)]
Comment unused function parameter.

2 years agoC -> C++ casts.
Arnaud Giersch [Wed, 11 Oct 2017 19:47:55 +0000 (21:47 +0200)]
C -> C++ casts.

2 years agoUse std::string in s4u examples.
Arnaud Giersch [Wed, 11 Oct 2017 12:38:13 +0000 (14:38 +0200)]
Use std::string in s4u examples.

2 years agoReplace some malloc/free by C++ new/delete.
Arnaud Giersch [Wed, 11 Oct 2017 09:08:39 +0000 (11:08 +0200)]
Replace some malloc/free by C++ new/delete.

2 years agoRefactoring instr
Frederic Suter [Wed, 11 Oct 2017 13:23:03 +0000 (15:23 +0200)]
Refactoring instr

PJ_container_get and PJ_container_get_or_null functions become
byName(std::string name) and byNameOrNull(std::string name) methods of
the Container class.

2 years agofurther cleanups in instr
Frederic Suter [Wed, 11 Oct 2017 09:01:31 +0000 (11:01 +0200)]
further cleanups in instr

2 years agouse initialization list to please sonar
Frederic Suter [Wed, 11 Oct 2017 07:24:40 +0000 (09:24 +0200)]
use initialization list to please sonar

2 years agoAdd a comment to empty function.
Arnaud Giersch [Tue, 10 Oct 2017 21:05:52 +0000 (23:05 +0200)]
Add a comment to empty function.

2 years agoRemove useless typedef's from C++ files.
Arnaud Giersch [Tue, 10 Oct 2017 20:48:18 +0000 (22:48 +0200)]
Remove useless typedef's from C++ files.

2 years agoComment some unused parameters.
Arnaud Giersch [Tue, 10 Oct 2017 20:38:40 +0000 (22:38 +0200)]
Comment some unused parameters.

2 years agothis field is useless indeed. Good catch CI
Frederic Suter [Tue, 10 Oct 2017 16:47:21 +0000 (18:47 +0200)]
this field is useless indeed. Good catch CI
(BTW it was useless but public before ;))

2 years agofactoring in instr Events
Frederic Suter [Tue, 10 Oct 2017 16:29:12 +0000 (18:29 +0200)]
factoring in instr Events

If all derived classes share the same fields, they may belong to the
super class ...

sonar will whine about protected fields, but I don't care

2 years agostringify and objectify instr::Value (wip)
Frederic Suter [Tue, 10 Oct 2017 15:05:16 +0000 (17:05 +0200)]
stringify and objectify instr::Value (wip)

get -> byName
get_or_new -> byNameOrCreate (as for mailboxes)
constructor and most fields are private + accessors

2 years agoMerge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Tue, 10 Oct 2017 12:29:16 +0000 (14:29 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid

2 years agoremove useless parameters in header generation
Frederic Suter [Tue, 10 Oct 2017 12:22:56 +0000 (14:22 +0200)]
remove useless parameters in header generation

2 years agoAdd dummy typedefs to fix build in C mode.
Arnaud Giersch [Mon, 9 Oct 2017 13:38:08 +0000 (15:38 +0200)]
Add dummy typedefs to fix build in C mode.

2 years agoApply clang-format on previously renamed files.
Arnaud Giersch [Tue, 10 Oct 2017 10:09:09 +0000 (12:09 +0200)]
Apply clang-format on previously renamed files.