Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agoSIMIX_io_finish becomes IoImp::finish
Frederic Suter [Mon, 18 Feb 2019 22:24:58 +0000 (23:24 +0100)]
SIMIX_io_finish becomes IoImp::finish

get rid of smx_io*
the simcall_handlers will go at the beginning of the
kernel/activity/*Impl.cpp

2 years agoadd a StorageFailureException
Frederic Suter [Mon, 18 Feb 2019 22:01:04 +0000 (23:01 +0100)]
add a StorageFailureException

2 years ago_SIMIX_cond_wait becomes ConditionVariable::wait
Frederic Suter [Mon, 18 Feb 2019 20:23:46 +0000 (21:23 +0100)]
_SIMIX_cond_wait becomes ConditionVariable::wait

2 years agoSIMIX_synchro_wait becomes RawImpl::start
Frederic Suter [Mon, 18 Feb 2019 19:49:42 +0000 (20:49 +0100)]
SIMIX_synchro_wait becomes RawImpl::start

2 years agoobjectify simix timers.
Frederic Suter [Mon, 18 Feb 2019 18:32:54 +0000 (19:32 +0100)]
objectify simix timers.
public C API remains for now. Might be deprecated or removed (?)

2 years agoAvoid some casts and copies of CommImplPtr.
Arnaud Giersch [Mon, 18 Feb 2019 12:35:40 +0000 (13:35 +0100)]
Avoid some casts and copies of CommImplPtr.

2 years agolate modification wasn't tested, former was better
Frederic Suter [Sun, 17 Feb 2019 22:57:07 +0000 (23:57 +0100)]
late modification wasn't tested, former was better

2 years agoSIMIX_process_cleanup becomes ActorImpl::Cleanup
Frederic Suter [Sun, 17 Feb 2019 22:12:36 +0000 (23:12 +0100)]
SIMIX_process_cleanup becomes ActorImpl::Cleanup
There is no more need to pass the callback on an external function
when creating context.

2 years agoweek-end cleanups in ActorImpl
Frederic Suter [Sat, 16 Feb 2019 22:29:07 +0000 (23:29 +0100)]
week-end cleanups in ActorImpl
That excalated quickly ...

2 years agodead header
Frederic Suter [Sat, 16 Feb 2019 21:54:44 +0000 (22:54 +0100)]
dead header

2 years agoSIMIX_process_yield becomes ActorImpl::yield
Frederic Suter [Sat, 16 Feb 2019 21:42:16 +0000 (22:42 +0100)]
SIMIX_process_yield becomes ActorImpl::yield

2 years agoMethods and renaming in simix::Global
Frederic Suter [Sat, 16 Feb 2019 20:49:06 +0000 (21:49 +0100)]
Methods and renaming in simix::Global
+ s/process/actors/
+ empty_trash and process_runall should be here

2 years agoadd support for CancelException
Frederic Suter [Sat, 16 Feb 2019 19:08:50 +0000 (20:08 +0100)]
add support for CancelException

2 years agoDynamic cast without checking result is slow and useless. Use static cast.
Arnaud Giersch [Fri, 15 Feb 2019 14:04:15 +0000 (15:04 +0100)]
Dynamic cast without checking result is slow and useless. Use static cast.

It brings for example > 1.2 speedup on s4u-dht-kademlia.

2 years agoCosmetics (and please scan-build about potential null surf_action_).
Arnaud Giersch [Thu, 14 Feb 2019 12:45:52 +0000 (13:45 +0100)]
Cosmetics (and please scan-build about potential null surf_action_).

2 years agoUnsigned cannot become negative.
Arnaud Giersch [Thu, 14 Feb 2019 12:45:52 +0000 (13:45 +0100)]
Unsigned cannot become negative.

2 years agoUse const references for parameters.
Arnaud Giersch [Thu, 14 Feb 2019 12:45:52 +0000 (13:45 +0100)]
Use const references for parameters.

2 years agoMore std::string parameters.
Arnaud Giersch [Thu, 14 Feb 2019 12:45:52 +0000 (13:45 +0100)]
More std::string parameters.

2 years agofix build
Frederic Suter [Fri, 15 Feb 2019 14:50:43 +0000 (15:50 +0100)]
fix build

2 years agomake e_smx_comm_type_t be en enum class
Frederic Suter [Fri, 15 Feb 2019 08:43:08 +0000 (09:43 +0100)]
make e_smx_comm_type_t be en enum class

2 years agoTransfers things from smx_network to Mailboxes
Frederic Suter [Thu, 14 Feb 2019 17:04:26 +0000 (18:04 +0100)]
Transfers things from smx_network to Mailboxes

2 years agoChange some calls to get_cname to calls to get_name.
Arnaud Giersch [Wed, 13 Feb 2019 11:08:49 +0000 (12:08 +0100)]
Change some calls to get_cname to calls to get_name.

2 years agoUse get_cname() instead of name_.c_str().
Arnaud Giersch [Wed, 13 Feb 2019 10:39:19 +0000 (11:39 +0100)]
Use get_cname() instead of name_.c_str().

2 years agoDefine ActivityImpl::get_{name,cname}.
Arnaud Giersch [Wed, 13 Feb 2019 10:37:31 +0000 (11:37 +0100)]
Define ActivityImpl::get_{name,cname}.

2 years agoPolish passage of std::string parameters.
Arnaud Giersch [Wed, 13 Feb 2019 10:07:40 +0000 (11:07 +0100)]
Polish passage of std::string parameters.

2 years agofix github issue (#132)
Frederic Suter [Wed, 13 Feb 2019 16:42:44 +0000 (17:42 +0100)]
fix github issue (#132)

The Host.off() now throws a HostFailure exception if it captures that
an actor was ended by this action.  When a Java process wants to turn
off its own host (and thus die), it now has to catch a HostFailure
exception and the simulation can goes on.

2 years agosimplification
Frederic Suter [Wed, 13 Feb 2019 15:22:39 +0000 (16:22 +0100)]
simplification

2 years agomodernize a non-blocking simcall
Frederic Suter [Wed, 13 Feb 2019 14:50:35 +0000 (15:50 +0100)]
modernize a non-blocking simcall

2 years agoadd start and copy_data methods to CommImpl
Frederic Suter [Wed, 13 Feb 2019 14:35:43 +0000 (15:35 +0100)]
add start and copy_data methods to CommImpl

2 years agouse namespaces
Frederic Suter [Wed, 13 Feb 2019 13:33:59 +0000 (14:33 +0100)]
use namespaces

2 years agomessing with msg tracing
Frederic Suter [Wed, 13 Feb 2019 13:08:18 +0000 (14:08 +0100)]
messing with msg tracing

2 years agomerge SIMIX_synchro_finish into RawImpl::post
Frederic Suter [Wed, 13 Feb 2019 10:45:41 +0000 (11:45 +0100)]
merge SIMIX_synchro_finish into RawImpl::post

2 years agouse namespaces
Frederic Suter [Wed, 13 Feb 2019 10:16:12 +0000 (11:16 +0100)]
use namespaces

2 years agomore SemaphoreImpl cleanups
Frederic Suter [Wed, 13 Feb 2019 10:10:46 +0000 (11:10 +0100)]
more SemaphoreImpl cleanups

2 years agoObjectify Semaphore kernel counterpart
Frederic Suter [Wed, 13 Feb 2019 09:46:23 +0000 (10:46 +0100)]
Objectify Semaphore kernel counterpart

2 years agoSIMIX_process_join becomes ActorImpl::join
Frederic Suter [Wed, 13 Feb 2019 08:15:29 +0000 (09:15 +0100)]
SIMIX_process_join becomes ActorImpl::join

2 years agoPlug memory leaks for tests 1 to 5.
Arnaud Giersch [Tue, 12 Feb 2019 22:27:28 +0000 (23:27 +0100)]
Plug memory leaks for tests 1 to 5.

2 years agoFix bad cast spotted by UBSan.
Arnaud Giersch [Tue, 12 Feb 2019 15:29:00 +0000 (16:29 +0100)]
Fix bad cast spotted by UBSan.

2 years agoSnake case.
Arnaud Giersch [Tue, 12 Feb 2019 14:50:50 +0000 (15:50 +0100)]
Snake case.

2 years agoUse const& for the parameters of type std::string not affected by previous commit.
Arnaud Giersch [Mon, 11 Feb 2019 20:34:59 +0000 (21:34 +0100)]
Use const& for the parameters of type std::string not affected by previous commit.

2 years agoWhenever possible, use std::move() for parameters (mostly std::string).
Arnaud Giersch [Mon, 11 Feb 2019 20:09:18 +0000 (21:09 +0100)]
Whenever possible, use std::move() for parameters (mostly std::string).

2 years agoAvoid unnecessary copy of parameters for parallel_execute.
Arnaud Giersch [Mon, 11 Feb 2019 19:49:09 +0000 (20:49 +0100)]
Avoid unnecessary copy of parameters for parallel_execute.

2 years agoGet rid of temporary vector of strings.
Arnaud Giersch [Mon, 11 Feb 2019 19:45:12 +0000 (20:45 +0100)]
Get rid of temporary vector of strings.

Save the unnecessary cost of its construction.

2 years agoDeprecate the is_off() methods.
Arnaud Giersch [Mon, 11 Feb 2019 19:40:35 +0000 (20:40 +0100)]
Deprecate the is_off() methods.

They are simply the negation of is_on() and, when the two forms are defined,
we may wonder if there is some kind of intermediate state neither on(), nor
off().

2 years ago[tesh] Split setenv parameter on first '=' only.
Arnaud Giersch [Tue, 12 Feb 2019 12:57:20 +0000 (13:57 +0100)]
[tesh] Split setenv parameter on first '=' only.

2 years agokeep a return value for MSG_process_sleep
Frederic Suter [Tue, 12 Feb 2019 15:56:09 +0000 (16:56 +0100)]
keep a return value for MSG_process_sleep
handle the exception in msg_legacy.cpp

2 years agofix build
Frederic Suter [Tue, 12 Feb 2019 14:50:54 +0000 (15:50 +0100)]
fix build

2 years agoa bug notified on July 28, 2014 is finally solved \o/
Frederic Suter [Tue, 12 Feb 2019 14:19:04 +0000 (15:19 +0100)]
a bug notified on July 28, 2014 is finally solved \o/

a true c++ exception is now raised if an actor is killed because its
host was turned off. It can be catched in the Java binding and set the
right MSG error status to MSG_HOST_FAILURE.
MSG_process_sleep can thus be marked as legacy and replaced by
s4u_actor_sleep_for

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Tue, 12 Feb 2019 13:07:48 +0000 (14:07 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agocosmetics
Frederic Suter [Tue, 12 Feb 2019 13:05:09 +0000 (14:05 +0100)]
cosmetics

2 years agoSIMIX_process_killall becomes ActorImp::kill_all
Frederic Suter [Tue, 12 Feb 2019 13:02:26 +0000 (14:02 +0100)]
SIMIX_process_killall becomes ActorImp::kill_all

2 years agoSIMIX_process_kill becomes ActorImpl::kill
Frederic Suter [Tue, 12 Feb 2019 12:49:38 +0000 (13:49 +0100)]
SIMIX_process_kill becomes ActorImpl::kill

2 years agostart to differentiate kill from exit in ActorImpl
Frederic Suter [Tue, 12 Feb 2019 10:05:29 +0000 (11:05 +0100)]
start to differentiate kill from exit in ActorImpl

2 years agoAdd suppressions for Asan when run on jenkins.
Arnaud Giersch [Mon, 11 Feb 2019 22:11:40 +0000 (23:11 +0100)]
Add suppressions for Asan when run on jenkins.

Ideally, ASAN_OPTIONS should be set by ctest but I didn't find how.

2 years agoNo need to answer to simcall when host is off.
Arnaud Giersch [Mon, 11 Feb 2019 15:07:12 +0000 (16:07 +0100)]
No need to answer to simcall when host is off.

These changes should fix tests platform-failures where some processes were
duplicated in process_to_run[], leading to runtime errors with boost and raw
contexts.

The error could be seen with a "xbt_assert(next_context != this);" just before
"this->swap_into(next_context);" in SwappedContext::suspend().

2 years agoDon't set field twice.
Arnaud Giersch [Mon, 11 Feb 2019 15:05:06 +0000 (16:05 +0100)]
Don't set field twice.

2 years agoEnrich debugging messages.
Arnaud Giersch [Mon, 11 Feb 2019 13:21:17 +0000 (14:21 +0100)]
Enrich debugging messages.

2 years agoRename file for the sake of consistency.
Arnaud Giersch [Mon, 11 Feb 2019 13:16:17 +0000 (14:16 +0100)]
Rename file for the sake of consistency.

2 years agoDeprecate an unused function.
Arnaud Giersch [Mon, 11 Feb 2019 13:08:00 +0000 (14:08 +0100)]
Deprecate an unused function.

2 years agoplease sonar with a few smells
Frederic Suter [Mon, 11 Feb 2019 10:55:45 +0000 (11:55 +0100)]
please sonar with a few smells

2 years agoTypo.
Arnaud Giersch [Sun, 10 Feb 2019 13:55:31 +0000 (14:55 +0100)]
Typo.

2 years agofinish the rename of availability_file into speed_file
Martin Quinson [Sat, 9 Feb 2019 22:10:42 +0000 (23:10 +0100)]
finish the rename of availability_file into speed_file

2 years agoremove a useless example profile
Martin Quinson [Sat, 9 Feb 2019 21:57:13 +0000 (22:57 +0100)]
remove a useless example profile

2 years agomv examples/platforms/two_hosts_platform_with_availability.xml examples/platforms...
Martin Quinson [Sat, 9 Feb 2019 16:52:32 +0000 (17:52 +0100)]
mv examples/platforms/two_hosts_platform_with_availability.xml examples/platforms/two_hosts_profiles.xml

2 years agoIn <host> and <peer>, availability_file is now speed_file
Martin Quinson [Sat, 9 Feb 2019 16:44:08 +0000 (17:44 +0100)]
In <host> and <peer>, availability_file is now speed_file

2 years agoregenerate with Flex 2.6.4
Martin Quinson [Sat, 9 Feb 2019 16:36:37 +0000 (17:36 +0100)]
regenerate with Flex 2.6.4

2 years agoTests {msg,s4u}-platform-failures seem to work as expected with threads and ucontexts.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Tests {msg,s4u}-platform-failures seem to work as expected with threads and ucontexts.

2 years agoUpdate tesh files for {msg,s4u}-platform-failures.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Update tesh files for {msg,s4u}-platform-failures.

2 years agoFile has been renamed.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
File has been renamed.

2 years agoCosmetics.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Cosmetics.

2 years agoAdd const attribute.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Add const attribute.

2 years agoUsing cancel() seems to be the right way to do.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Using cancel() seems to be the right way to do.

2 years agocosmetics
Frederic Suter [Fri, 8 Feb 2019 14:46:29 +0000 (15:46 +0100)]
cosmetics

2 years agohandle SleepImpl more like other activities
Frederic Suter [Fri, 8 Feb 2019 13:41:37 +0000 (14:41 +0100)]
handle SleepImpl more like other activities

2 years agobetter chaining
Frederic Suter [Fri, 8 Feb 2019 12:07:35 +0000 (13:07 +0100)]
better chaining

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Fri, 8 Feb 2019 11:55:52 +0000 (12:55 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agonamespace and method chaining for Io activities
Frederic Suter [Fri, 8 Feb 2019 11:55:25 +0000 (12:55 +0100)]
namespace and method chaining for Io activities

2 years agomv examples/platforms/trace examples/platforms/profiles
Martin Quinson [Fri, 8 Feb 2019 11:17:05 +0000 (12:17 +0100)]
mv examples/platforms/trace examples/platforms/profiles

2 years agoallow and use method chaining for ExecImpl
Frederic Suter [Fri, 8 Feb 2019 11:33:51 +0000 (12:33 +0100)]
allow and use method chaining for ExecImpl

2 years agoimprove the doc of this example
Martin Quinson [Fri, 8 Feb 2019 11:11:33 +0000 (12:11 +0100)]
improve the doc of this example

2 years agoadd an example of speed profile in the platform
Martin Quinson [Fri, 8 Feb 2019 10:55:17 +0000 (11:55 +0100)]
add an example of speed profile in the platform

2 years agouse namespaces for sake of readability
Frederic Suter [Fri, 8 Feb 2019 11:09:52 +0000 (12:09 +0100)]
use namespaces for sake of readability

2 years agoreplace SIMIX_execution_start by modern simcall
Frederic Suter [Fri, 8 Feb 2019 11:01:01 +0000 (12:01 +0100)]
replace SIMIX_execution_start by modern simcall

2 years agofix misleading doc!
Martin Quinson [Fri, 8 Feb 2019 10:50:53 +0000 (11:50 +0100)]
fix misleading doc!

2 years agonew functions: Link::is_{on,off}()
Martin Quinson [Fri, 8 Feb 2019 10:49:45 +0000 (11:49 +0100)]
new functions: Link::is_{on,off}()

2 years agochange_host -> set_host
Frederic Suter [Fri, 8 Feb 2019 10:02:26 +0000 (11:02 +0100)]
change_host -> set_host

2 years agoallow to set a profile to links and hosts from S4U
Martin Quinson [Fri, 8 Feb 2019 09:33:29 +0000 (10:33 +0100)]
allow to set a profile to links and hosts from S4U

2 years agoFix generation of graphical-toc.svg.
Arnaud Giersch [Wed, 6 Feb 2019 22:13:25 +0000 (23:13 +0100)]
Fix generation of graphical-toc.svg.

Attribute target="_top" was duplicated on line 6120.

2 years agoUpdate some URLs to simgrid.org.
Arnaud Giersch [Wed, 6 Feb 2019 17:12:29 +0000 (18:12 +0100)]
Update some URLs to simgrid.org.

2 years agoFix URL for simgrid.dtd.
Arnaud Giersch [Wed, 6 Feb 2019 17:01:48 +0000 (18:01 +0100)]
Fix URL for simgrid.dtd.

2 years agoFix null pointer dereference spotted by scan-build.
Arnaud Giersch [Wed, 6 Feb 2019 16:06:23 +0000 (17:06 +0100)]
Fix null pointer dereference spotted by scan-build.

2 years agoAssert that there is no memory leak (help scan-build).
Arnaud Giersch [Wed, 6 Feb 2019 13:53:51 +0000 (14:53 +0100)]
Assert that there is no memory leak (help scan-build).

2 years agoRewrite smpi_copy_file() again.
Arnaud Giersch [Wed, 6 Feb 2019 13:53:19 +0000 (14:53 +0100)]
Rewrite smpi_copy_file() again.

Slightly improve commit b618980c2b58d7347c8f9444dc63bbb3ae082e18.

2 years ago[codacy/cppcheck] Comment dead code (is_homogeneous is always true).
Arnaud Giersch [Wed, 6 Feb 2019 08:56:44 +0000 (09:56 +0100)]
[codacy/cppcheck] Comment dead code (is_homogeneous is always true).

2 years agofactor suspend/resume across Activities
Frederic Suter [Wed, 6 Feb 2019 14:21:14 +0000 (15:21 +0100)]
factor suspend/resume across Activities
 + specific Activity can override (CommImpl and SynchroRaw do that)
   + current comments are pretty confusing
 + signals are now in ActivityImpl

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Tue, 5 Feb 2019 21:03:17 +0000 (22:03 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agorequalify tesh
Augustin Degomme [Tue, 5 Feb 2019 15:16:11 +0000 (16:16 +0100)]
requalify tesh

2 years agoremove some codacy warnings
Augustin Degomme [Tue, 5 Feb 2019 15:10:11 +0000 (16:10 +0100)]
remove some codacy warnings

2 years agoWith Icc, change bogus error into warning.
Arnaud Giersch [Tue, 5 Feb 2019 14:28:52 +0000 (15:28 +0100)]
With Icc, change bogus error into warning.

src/xbt/mallocator.c(49): error #2330: argument of type "atomic_flag *" is incompatible with parameter of type "volatile void *" (dropping qualifiers)
     atomic_flag_clear(&m->lock);
     ^

2 years agoPlug memory leak.
Arnaud Giersch [Tue, 5 Feb 2019 13:09:11 +0000 (14:09 +0100)]
Plug memory leak.