Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
23 months agoUnused import.
Arnaud Giersch [Sat, 21 May 2022 07:48:40 +0000 (09:48 +0200)]
Unused import.

[ci-skip]

23 months agoSonar issues.
Arnaud Giersch [Tue, 24 May 2022 12:02:57 +0000 (14:02 +0200)]
Sonar issues.

23 months agoUseless usage of c_str().
Arnaud Giersch [Fri, 20 May 2022 12:43:50 +0000 (14:43 +0200)]
Useless usage of c_str().

23 months agoModify test to run latest libsupernode.so at least once.
Arnaud Giersch [Fri, 20 May 2022 09:10:19 +0000 (11:10 +0200)]
Modify test to run latest libsupernode.so at least once.

23 months agoToday's sonar/codefactor issues.
Arnaud Giersch [Fri, 20 May 2022 08:37:38 +0000 (10:37 +0200)]
Today's sonar/codefactor issues.

23 months agoMerge branch 'dev-add_comm_fault_scenario2' into 'master'
Augustin Degomme [Fri, 20 May 2022 08:24:24 +0000 (08:24 +0000)]
Merge branch 'dev-add_comm_fault_scenario2' into 'master'

Run all comm fault scenarios now that other MRs have been accepted

See merge request simgrid/simgrid!104

23 months agoRemove debug messages from tesh because it makes the test fragile
Fabien Chaix [Fri, 20 May 2022 08:08:50 +0000 (11:08 +0300)]
Remove debug messages from tesh because it makes the test fragile

23 months agofix for 32 bits
Augustin Degomme [Fri, 20 May 2022 07:45:28 +0000 (07:45 +0000)]
fix for 32 bits

23 months agoRun all scenarios now that other MRs have been accepted
Fabien Chaix [Fri, 20 May 2022 06:33:01 +0000 (09:33 +0300)]
Run all scenarios now that other MRs have been accepted

23 months agoMerge branch 'dev-add_comm_fault_scenario' into 'master'
Augustin Degomme [Fri, 20 May 2022 07:23:12 +0000 (07:23 +0000)]
Merge branch 'dev-add_comm_fault_scenario' into 'master'

Add a test to cover many communication fault scenarios

See merge request simgrid/simgrid!103

23 months agoRevert "Run all scenarios now that other MRs have been accepted"
Fabien Chaix [Fri, 20 May 2022 07:06:51 +0000 (07:06 +0000)]
Revert "Run all scenarios now that other MRs have been accepted"

This reverts commit 00c4012bc527af7b7d532ad4a20eb83fe55e8b20

23 months agoRun all scenarios now that other MRs have been accepted
Fabien Chaix [Fri, 20 May 2022 06:41:06 +0000 (06:41 +0000)]
Run all scenarios now that other MRs have been accepted

23 months agomore enum to use Simgrid macros
Fabien Chaix [Thu, 19 May 2022 15:34:07 +0000 (18:34 +0300)]
more enum to use Simgrid macros

23 months agoUse Simgrid macro to get cleaner enums
Fabien Chaix [Thu, 19 May 2022 15:18:26 +0000 (18:18 +0300)]
Use Simgrid macro to get cleaner enums

23 months agoUse std::unique_ptr instead of new/delete in xbt_replay (sonar).
Arnaud Giersch [Thu, 19 May 2022 15:11:45 +0000 (17:11 +0200)]
Use std::unique_ptr instead of new/delete in xbt_replay (sonar).

23 months agoMake function "const" (sonar).
Arnaud Giersch [Thu, 19 May 2022 15:00:49 +0000 (17:00 +0200)]
Make function "const" (sonar).

23 months agoDisallow template argument deduction for config::Flag.
Arnaud Giersch [Thu, 19 May 2022 14:58:09 +0000 (16:58 +0200)]
Disallow template argument deduction for config::Flag.

Rationale: constructors have so many parameters that it would be hard to read and deduce the underlying type.

23 months agoDefine xbt::type_identity_t (similar to C++20's std::type_identity_t).
Arnaud Giersch [Thu, 19 May 2022 14:54:44 +0000 (16:54 +0200)]
Define xbt::type_identity_t (similar to C++20's std::type_identity_t).

23 months agoMerge branch 'dev-fix_mailbox_clear' into 'master'
Arnaud Giersch [Thu, 19 May 2022 15:06:40 +0000 (15:06 +0000)]
Merge branch 'dev-fix_mailbox_clear' into 'master'

Fix mailbox::clear() to properly finish Comms

See merge request simgrid/simgrid!101

23 months agoMerge branch 'dev-hosts_to_activity' into 'master'
Arnaud Giersch [Thu, 19 May 2022 14:53:04 +0000 (14:53 +0000)]
Merge branch 'dev-hosts_to_activity' into 'master'

Move hosts_ attribute from ExecImpl to ActivityImpl to better handle detached cases

See merge request simgrid/simgrid!100

23 months agoCosmetics
Fabien Chaix [Thu, 19 May 2022 14:47:19 +0000 (17:47 +0300)]
Cosmetics

23 months agoReorder (sort) file lists.
Arnaud Giersch [Thu, 19 May 2022 09:38:36 +0000 (11:38 +0200)]
Reorder (sort) file lists.

23 months agoMake distcheck.
Arnaud Giersch [Thu, 19 May 2022 08:45:57 +0000 (10:45 +0200)]
Make distcheck.

23 months agoAdd comm_fault-scenarios to Tesh (only tests that pass so far)
Fabien Chaix [Thu, 19 May 2022 09:17:31 +0000 (12:17 +0300)]
Add comm_fault-scenarios to Tesh (only tests that pass so far)

23 months agoSpring refactoring of the comm_fault_cenarios test
Fabien Chaix [Thu, 19 May 2022 09:09:37 +0000 (12:09 +0300)]
Spring refactoring of the comm_fault_cenarios test

23 months agoMerge branch 'Ezibenroc/simgrid-example_platform'
Arnaud Giersch [Thu, 19 May 2022 08:45:31 +0000 (10:45 +0200)]
Merge branch 'Ezibenroc/simgrid-example_platform'

23 months agoclang-format
Tom Cornebize [Thu, 19 May 2022 07:57:29 +0000 (09:57 +0200)]
clang-format

23 months agoCosmetic
Tom Cornebize [Thu, 19 May 2022 07:54:04 +0000 (09:54 +0200)]
Cosmetic

23 months agoHandle onesided=detached comms and clean up the comm_fault_scenario test
Fabien Chaix [Thu, 19 May 2022 07:28:39 +0000 (10:28 +0300)]
Handle onesided=detached comms and clean up the comm_fault_scenario test

23 months agoAdded message before the test
Fabien Chaix [Tue, 17 May 2022 18:24:36 +0000 (21:24 +0300)]
Added message before the test

23 months agoDecrease verbosity when test pass
Fabien Chaix [Tue, 17 May 2022 10:44:06 +0000 (13:44 +0300)]
Decrease verbosity when test pass

23 months agoAdd the fault scenario test
Fabien Chaix [Thu, 17 Mar 2022 22:59:52 +0000 (00:59 +0200)]
Add the fault scenario test

23 months agoAdd fault scenarios to the manifest
Fabien Chaix [Thu, 17 Mar 2022 17:57:53 +0000 (19:57 +0200)]
Add fault scenarios to the manifest

23 months agoInitial versio of the fault scenario test
Fabien Chaix [Thu, 17 Mar 2022 08:56:11 +0000 (10:56 +0200)]
Initial versio of the fault scenario test

23 months agoNo need to check for activities_ nullness
Fabien Chaix [Thu, 19 May 2022 07:16:10 +0000 (10:16 +0300)]
No need to check for activities_ nullness

23 months agoMove hosts_ to private, and deal with consequences
Fabien Chaix [Thu, 19 May 2022 07:12:45 +0000 (10:12 +0300)]
Move hosts_ to private, and deal with consequences

23 months agoRemove post() calls when MailboxImpl::clear() is used in destructor
Fabien Chaix [Thu, 19 May 2022 06:21:23 +0000 (09:21 +0300)]
Remove post() calls when MailboxImpl::clear() is used in destructor

23 months agoAdd a 'supernode' example platform
Tom Cornebize [Wed, 18 May 2022 15:21:09 +0000 (17:21 +0200)]
Add a 'supernode' example platform

- supernode.cpp is the actual C++ platform file,
- supernode.svg is a graphical representation of this platform,
- supernode.py is the script that was used to generate the SVG

23 months agoFix mailbox::clear() to properly finish Comms
Fabien Chaix [Wed, 18 May 2022 14:27:27 +0000 (17:27 +0300)]
Fix mailbox::clear() to properly finish Comms

23 months agoFix the addition of detached comms to maestro
Fabien Chaix [Wed, 18 May 2022 14:26:28 +0000 (17:26 +0300)]
Fix the addition of detached comms to maestro

23 months agoAdd detached isend to maestro to allow tracking in case of fault
Fabien Chaix [Wed, 18 May 2022 12:27:07 +0000 (15:27 +0300)]
Add detached isend to maestro to allow tracking in case of fault

23 months agoMove hosts_ to ActivityImpl_ to allow tracking of detached comms by maestro
Fabien Chaix [Tue, 17 May 2022 11:00:53 +0000 (14:00 +0300)]
Move hosts_ to ActivityImpl_ to allow tracking of detached comms by maestro

23 months agocosmetics
Augustin Degomme [Tue, 17 May 2022 21:24:54 +0000 (21:24 +0000)]
cosmetics

23 months agoMerge branch 'dev-unit_test_cleanup' into 'master'
Augustin Degomme [Tue, 17 May 2022 21:20:57 +0000 (21:20 +0000)]
Merge branch 'dev-unit_test_cleanup' into 'master'

Dev unit test cleanup

See merge request simgrid/simgrid!98

23 months agoFix cosmetics
Fabien Chaix [Tue, 17 May 2022 21:15:19 +0000 (00:15 +0300)]
Fix cosmetics

23 months agoAdd trace2selist and re-enable unit tests for the stochastic profiles
Fabien Chaix [Tue, 17 May 2022 20:59:54 +0000 (23:59 +0300)]
Add trace2selist and re-enable unit tests for the stochastic profiles

23 months agoStarZone::get_graph: link to the gateway router when available.
Arnaud Giersch [Tue, 17 May 2022 19:59:49 +0000 (21:59 +0200)]
StarZone::get_graph: link to the gateway router when available.

This may happen e.g. with nested StarZones.

23 months agoCosmetics: declare graph edges with the "right" direction.
Arnaud Giersch [Tue, 17 May 2022 19:08:57 +0000 (21:08 +0200)]
Cosmetics: declare graph edges with the "right" direction.

23 months agoMerge branch 'dev-s4u-dirty-termination' into 'master'
Arnaud Giersch [Tue, 17 May 2022 19:06:59 +0000 (19:06 +0000)]
Merge branch 'dev-s4u-dirty-termination' into 'master'

Make S4u dirty termination better looking

See merge request simgrid/simgrid!97

23 months agoMake S4u dirty termination better looking
Fabien Chaix [Tue, 17 May 2022 12:12:59 +0000 (15:12 +0300)]
Make S4u dirty termination better looking

23 months agoMerge branch 'dev-fix-get-eager-activities' into 'master'
Augustin Degomme [Tue, 17 May 2022 12:27:44 +0000 (12:27 +0000)]
Merge branch 'dev-fix-get-eager-activities' into 'master'

add eager get comms to actor activities

See merge request simgrid/simgrid!96

23 months agoadd eager get comms to actor activities
Fabien Chaix [Tue, 17 May 2022 11:02:50 +0000 (14:02 +0300)]
add eager get comms to actor activities

23 months agoEnable test only on 64bits.
Arnaud Giersch [Fri, 13 May 2022 11:10:52 +0000 (13:10 +0200)]
Enable test only on 64bits.

23 months agoGive another try to test mc-bugged1-liveness-visited...
Arnaud Giersch [Fri, 13 May 2022 10:06:51 +0000 (12:06 +0200)]
Give another try to test mc-bugged1-liveness-visited...

... and see if the situation has changed since commit 73e643057a95ed6f20d6bd03bc8cd13a7042f9aa

23 months agoFix build with Eigen3 and Imtel compiler.
Arnaud Giersch [Thu, 12 May 2022 15:59:35 +0000 (17:59 +0200)]
Fix build with Eigen3 and Imtel compiler.

23 months agoRemove from CFLAGS warnings already enabled by -Wall.
Arnaud Giersch [Thu, 12 May 2022 15:51:27 +0000 (17:51 +0200)]
Remove from CFLAGS warnings already enabled by -Wall.

23 months agoRename VM signals to distinguish them from Host::on_creation/on_destruction.
Arnaud Giersch [Thu, 12 May 2022 08:43:08 +0000 (10:43 +0200)]
Rename VM signals to distinguish them from Host::on_creation/on_destruction.

23 months agoReduce scope for variables.
Arnaud Giersch [Thu, 12 May 2022 08:37:47 +0000 (10:37 +0200)]
Reduce scope for variables.

23 months agoRename variables to avoid shadowed declarations.
Arnaud Giersch [Thu, 12 May 2022 08:29:08 +0000 (10:29 +0200)]
Rename variables to avoid shadowed declarations.

23 months agoLink-load plugin: check no link exists
Bruno Donassolo [Thu, 12 May 2022 12:50:51 +0000 (14:50 +0200)]
Link-load plugin: check no link exists

Plugin must be initialized before creating any link.

23 months agoDefine duplicated function get_graph() only once, in common ancestor.
Arnaud Giersch [Tue, 10 May 2022 19:25:16 +0000 (21:25 +0200)]
Define duplicated function get_graph() only once, in common ancestor.

23 months agoMake helper functions static members of NetZoneImpl.
Arnaud Giersch [Tue, 10 May 2022 19:24:06 +0000 (21:24 +0200)]
Make helper functions static members of NetZoneImpl.

23 months agoApply last sonar-related changes to the new function platform_graph_export_csv().
Arnaud Giersch [Tue, 10 May 2022 16:59:47 +0000 (18:59 +0200)]
Apply last sonar-related changes to the new function platform_graph_export_csv().

23 months agoMerge branch 'master' into 'master'
Martin Quinson [Tue, 10 May 2022 15:52:19 +0000 (15:52 +0000)]
Merge branch 'master' into 'master'

Enhance graphicator program

See merge request simgrid/simgrid!95

23 months agoEnhance graphicator program
Tom Cornebize [Tue, 10 May 2022 15:52:19 +0000 (15:52 +0000)]
Enhance graphicator program

23 months agoPrefer \n over std::endl (no need to flush at each end-of-line).
Arnaud Giersch [Tue, 10 May 2022 15:11:09 +0000 (17:11 +0200)]
Prefer \n over std::endl (no need to flush at each end-of-line).

23 months agoUpdate generator script to match the current code.
Arnaud Giersch [Tue, 10 May 2022 11:38:43 +0000 (13:38 +0200)]
Update generator script to match the current code.

23 months agoConcatenate nested namespaces (sonar).
Arnaud Giersch [Tue, 10 May 2022 08:48:52 +0000 (10:48 +0200)]
Concatenate nested namespaces (sonar).

23 months agoRemove spurious "using" declarations.
Arnaud Giersch [Tue, 10 May 2022 08:47:36 +0000 (10:47 +0200)]
Remove spurious "using" declarations.

23 months agoApply exclusion to any file in include/ (*.h may be concerned).
Arnaud Giersch [Tue, 10 May 2022 07:21:46 +0000 (09:21 +0200)]
Apply exclusion to any file in include/ (*.h may be concerned).

23 months ago[sonar] Ignore C++17 rules in public headers, where we still support C++14.
Arnaud Giersch [Mon, 9 May 2022 19:42:15 +0000 (21:42 +0200)]
[sonar] Ignore C++17 rules in public headers, where we still support C++14.

[ci-skip]

23 months ago[sonar] IIUC, there is no need to duplicate exclusion rule.
Arnaud Giersch [Mon, 9 May 2022 19:31:59 +0000 (21:31 +0200)]
[sonar] IIUC, there is no need to duplicate exclusion rule.

[ci-skip]

23 months agoReplace const reference to std::string by std::string_view (sonar).
Arnaud Giersch [Mon, 9 May 2022 13:02:08 +0000 (15:02 +0200)]
Replace const reference to std::string by std::string_view (sonar).

23 months agoStructured binding here too.
Arnaud Giersch [Fri, 6 May 2022 07:15:25 +0000 (09:15 +0200)]
Structured binding here too.

23 months agoTest is normally always true: replace by an assert.
Arnaud Giersch [Mon, 9 May 2022 09:24:03 +0000 (11:24 +0200)]
Test is normally always true: replace by an assert.

23 months agoUse the init-statement to declare variables inside the if statement (sonar).
Arnaud Giersch [Sat, 7 May 2022 07:43:54 +0000 (09:43 +0200)]
Use the init-statement to declare variables inside the if statement (sonar).

23 months agoRemove superfluous parentheses.
Arnaud Giersch [Sat, 7 May 2022 07:20:42 +0000 (09:20 +0200)]
Remove superfluous parentheses.

23 months agoDisable bogus warning with g++: add -Wno-free-nonheap-object.
Arnaud Giersch [Fri, 6 May 2022 10:46:24 +0000 (12:46 +0200)]
Disable bogus warning with g++: add -Wno-free-nonheap-object.

Build fails on mc_dwarf.cpp with g++ 12.0.1.
This kind of error should be caught by valgrind and/or ASan anyway.

23 months agoReduce scope for temporary variables.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for temporary variables.

Use the init-statement to declare variables inside the if statement (sonar).

23 months agoReduce scope for static variables.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for static variables.

Use the init-statement to declare variables inside the if statement (sonar).

23 months agoReduce scope for variables used for dynamic_cast to subclass.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for variables used for dynamic_cast to subclass.

Use the init-statement to declare variables inside the if statement (sonar).

23 months agoSimplify a bit smpi_sample_* functions.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Simplify a bit smpi_sample_* functions.

* merge smpi_sample_1 and smpi_sample_2 into smpi_sample_cond
* rename smpi_sample_3 to smpi_sample_iter

23 months agoSlighly improve readbility.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Slighly improve readbility.

(and address a few sonar smells)

23 months agoSearch in map once only.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Search in map once only.

23 months agoNo need to have two code paths.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
No need to have two code paths.

23 months agoNested conditional operators are not Sonar-compliant; revert previous change.
Arnaud Giersch [Wed, 4 May 2022 06:30:25 +0000 (08:30 +0200)]
Nested conditional operators are not Sonar-compliant; revert previous change.

23 months agoOops, it's stoi() for integers.
Arnaud Giersch [Wed, 4 May 2022 06:12:55 +0000 (08:12 +0200)]
Oops, it's stoi() for integers.

23 months agoKill unused variable.
Arnaud Giersch [Tue, 3 May 2022 19:56:18 +0000 (21:56 +0200)]
Kill unused variable.

23 months agoSpurious blank line.
Arnaud Giersch [Tue, 3 May 2022 19:56:07 +0000 (21:56 +0200)]
Spurious blank line.

23 months agoDeclare local variables inside the if statement.
Arnaud Giersch [Sat, 30 Apr 2022 13:08:59 +0000 (15:08 +0200)]
Declare local variables inside the if statement.

23 months agoMisc code simplifications guided by Sonar smells.
Arnaud Giersch [Sat, 30 Apr 2022 13:07:03 +0000 (15:07 +0200)]
Misc code simplifications guided by Sonar smells.

23 months agoSave an indirection for replay/action_queues.
Arnaud Giersch [Tue, 3 May 2022 19:01:36 +0000 (21:01 +0200)]
Save an indirection for replay/action_queues.

23 months agoAvoid old-style C string processing in C++ example.
Arnaud Giersch [Mon, 2 May 2022 17:27:36 +0000 (19:27 +0200)]
Avoid old-style C string processing in C++ example.

23 months ago[ci-skip] [no-ci] bigdft ci: temporary fix for nvidia key change
Augustin Degomme [Sun, 1 May 2022 20:39:53 +0000 (20:39 +0000)]
[ci-skip] [no-ci] bigdft ci: temporary fix for nvidia key change
see https://github.com/NVIDIA/nvidia-docker/issues/1631

23 months agoExplicit cast to double (sonar).
Arnaud Giersch [Thu, 28 Apr 2022 17:16:20 +0000 (19:16 +0200)]
Explicit cast to double (sonar).

23 months agoUse const references (sonar).
Arnaud Giersch [Thu, 28 Apr 2022 13:53:51 +0000 (15:53 +0200)]
Use const references (sonar).

23 months agoAdd comment for workaround.
Arnaud Giersch [Thu, 28 Apr 2022 13:50:58 +0000 (15:50 +0200)]
Add comment for workaround.

23 months agoCosmetics: gcc is now always >= 5.0.
Arnaud Giersch [Wed, 27 Apr 2022 19:58:42 +0000 (21:58 +0200)]
Cosmetics: gcc is now always >= 5.0.

23 months agoFix build with -Werror on older g++.
Arnaud Giersch [Wed, 27 Apr 2022 19:43:42 +0000 (21:43 +0200)]
Fix build with -Werror on older g++.

23 months agoUse structured binding declarations (sonar, c++17).
Arnaud Giersch [Tue, 26 Apr 2022 22:02:38 +0000 (00:02 +0200)]
Use structured binding declarations (sonar, c++17).