Frederic Suter [Tue, 25 Jul 2017 14:55:54 +0000 (16:55 +0200)]
partial leak plug in chord
Frederic Suter [Tue, 25 Jul 2017 10:36:35 +0000 (12:36 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
degomme [Tue, 25 Jul 2017 09:27:38 +0000 (11:27 +0200)]
allgather was forgotten in ti tracing. fix this
Frederic Suter [Tue, 25 Jul 2017 08:36:32 +0000 (10:36 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Tue, 25 Jul 2017 08:35:39 +0000 (10:35 +0200)]
let parsing raise C++ exceptions, kill a dict, reindent
Martin Quinson [Mon, 24 Jul 2017 21:03:17 +0000 (23:03 +0200)]
cosmetics
Martin Quinson [Mon, 24 Jul 2017 20:44:15 +0000 (22:44 +0200)]
use a proper destructor for the paje::value type
Martin Quinson [Mon, 24 Jul 2017 20:33:30 +0000 (22:33 +0200)]
cosmetics in instr: use sensible identifier names
Martin Quinson [Mon, 24 Jul 2017 20:27:39 +0000 (22:27 +0200)]
ahem
Martin Quinson [Mon, 24 Jul 2017 20:10:40 +0000 (22:10 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Mon, 24 Jul 2017 20:10:12 +0000 (22:10 +0200)]
Merge pull request #202 from Takishipp/clear_fct
Turn paje_value to a class
Martin Quinson [Mon, 24 Jul 2017 20:03:47 +0000 (22:03 +0200)]
codacy
Martin Quinson [Mon, 24 Jul 2017 19:57:48 +0000 (21:57 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Takishipp [Mon, 24 Jul 2017 14:08:48 +0000 (16:08 +0200)]
delete unused parameters
Frederic Suter [Mon, 24 Jul 2017 13:24:06 +0000 (15:24 +0200)]
mess up with parsing and exceptions
Takishipp [Mon, 24 Jul 2017 12:05:50 +0000 (14:05 +0200)]
delete unused parameters
Takishipp [Mon, 24 Jul 2017 10:49:11 +0000 (12:49 +0200)]
remove unused parameters of some fcts
Frederic Suter [Mon, 24 Jul 2017 08:51:56 +0000 (10:51 +0200)]
overall optimization of map usage
replace all find != end + at by a try/catch on at.
This should save a useless traversal of the [unordered_]map each time
we want to access an element.
Martin Quinson [Sun, 23 Jul 2017 19:28:42 +0000 (21:28 +0200)]
fix MSG compatibility layer
Martin Quinson [Sat, 22 Jul 2017 20:26:07 +0000 (22:26 +0200)]
codacy
Frederic Suter [Fri, 21 Jul 2017 17:48:30 +0000 (19:48 +0200)]
uniform allocation is better
Frederic Suter [Fri, 21 Jul 2017 17:45:44 +0000 (19:45 +0200)]
kill degomme's masochist troll ;)
Frederic Suter [Fri, 21 Jul 2017 17:28:15 +0000 (19:28 +0200)]
kill another dict in the C++ world
Frederic Suter [Fri, 21 Jul 2017 12:57:35 +0000 (14:57 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Fri, 21 Jul 2017 12:57:16 +0000 (14:57 +0200)]
simplify process/actor restart
Augustin Degomme [Fri, 21 Jul 2017 12:44:32 +0000 (14:44 +0200)]
try to silence a valgrind leak
Frederic Suter [Fri, 21 Jul 2017 12:16:56 +0000 (14:16 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Fri, 21 Jul 2017 12:16:04 +0000 (14:16 +0200)]
simcall_mutex_unlock is back but keep the simplification of another
simcall
Martin Quinson [Fri, 21 Jul 2017 12:08:27 +0000 (14:08 +0200)]
fix make dist for MC builds
Martin Quinson [Thu, 20 Jul 2017 23:35:44 +0000 (01:35 +0200)]
cosmetics in error message
Martin Quinson [Thu, 20 Jul 2017 23:17:07 +0000 (01:17 +0200)]
sonar
Frederic Suter [Fri, 21 Jul 2017 12:05:57 +0000 (14:05 +0200)]
Revert "kill one simcall, simplify another"
This reverts commit
8639295f6bedeb3c9e1a60a1056925c4fe892fa4.
Frederic Suter [Fri, 21 Jul 2017 11:25:46 +0000 (13:25 +0200)]
please sonar (initialization lists) + reindent
Takishipp [Fri, 21 Jul 2017 10:38:05 +0000 (12:38 +0200)]
fix PJ_value class and its methods
Takishipp [Fri, 21 Jul 2017 10:34:32 +0000 (12:34 +0200)]
fix conflict
Frederic Suter [Fri, 21 Jul 2017 10:19:09 +0000 (12:19 +0200)]
simplify semaphores related simcalls
Frederic Suter [Fri, 21 Jul 2017 10:05:58 +0000 (12:05 +0200)]
tiny change
Frederic Suter [Fri, 21 Jul 2017 09:00:59 +0000 (11:00 +0200)]
modernize two more simcalls
Takishipp [Thu, 20 Jul 2017 14:46:51 +0000 (16:46 +0200)]
give s_val PJ_value as a constructor
Arnaud Giersch [Thu, 20 Jul 2017 14:32:05 +0000 (16:32 +0200)]
Looking for libelf (required by MC).
Arnaud Giersch [Thu, 20 Jul 2017 12:59:17 +0000 (14:59 +0200)]
Return what was apparently intended.
Arnaud Giersch [Thu, 20 Jul 2017 12:49:05 +0000 (14:49 +0200)]
Prefix is unsigned and can't be negative.
Arnaud Giersch [Thu, 20 Jul 2017 09:14:52 +0000 (11:14 +0200)]
Merge "if" statements.
Frederic Suter [Thu, 20 Jul 2017 14:12:56 +0000 (16:12 +0200)]
kill one simcall, simplify another
Frederic Suter [Thu, 20 Jul 2017 14:11:42 +0000 (16:11 +0200)]
cleanups
Frederic Suter [Thu, 20 Jul 2017 10:05:58 +0000 (12:05 +0200)]
simplifications
Frederic Suter [Thu, 20 Jul 2017 09:59:42 +0000 (11:59 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Arnaud Giersch [Thu, 20 Jul 2017 09:56:07 +0000 (11:56 +0200)]
Revert "Give back control to maestro as late as possible."
This reverts commit
c7829c256a041aae9a60454263de30188b3f2fcc.
Tests are failing on Travis, and build faild on Appveyor :-(
Frederic Suter [Thu, 20 Jul 2017 09:13:44 +0000 (11:13 +0200)]
remove unused variable
Arnaud Giersch [Wed, 19 Jul 2017 20:31:33 +0000 (22:31 +0200)]
Give back control to maestro as late as possible.
The test allred from smpi-mpich3-coll-thread (with thread contexts factory and
mmap privatization) occasionally segfaults on thread exit:
teshsuite/smpi/mpich3-test/coll$ ../../../../smpi_script/bin/smpirun \
-platform ../../../../examples/platforms/small_platform_with_routers.xml \
-hostfile ../../hostfile_coll --cfg=smpi/running-power:1e9 \
--cfg=smpi/async-small-thresh:65536 --cfg=contexts/factory:thread \
--cfg=smpi/privatization:1 -np 4 ./allred
[...]
No Errors
Segmentation fault.
Backtrace:
#0 do_lookup_x (...) at dl-lookup.c:98
#1 0x00007ffff7de596d in _dl_lookup_symbol_x (...) at dl-lookup.c:737
#2 0x00007ffff6a4da75 in do_dlsym (...) at dl-libc.c:97
#3 0x00007ffff7deaaa4 in _dl_catch_error (...) at dl-error.c:187
#4 0x00007ffff6a4dabf in dlerror_run (...) at dl-libc.c:46
#5 0x00007ffff6a4db78 in __GI___libc_dlsym (...) at dl-libc.c:210
#6 0x00007ffff730dfbe in pthread_cancel_init ()
at ../nptl/sysdeps/pthread/unwind-forcedunwind.c:55
#7 0x00007ffff730e16c in _Unwind_ForcedUnwind (...)
1at ../nptl/sysdeps/pthread/unwind-forcedunwind.c:129
#8 0x00007ffff730c5d0 in __GI___pthread_unwind (...>) at unwind.c:129
#9 0x00007ffff7307365 in __do_cancel () at pthreadP.h:280
#10 __pthread_exit (...) at pthread_exit.c:29
#11 0x00007ffff7c12df9 in xbt_os_thread_exit (...)
at [...]/src/xbt/xbt_os_thread.c:251
#12 0x00007ffff7c938ab in stop (...)
at [...]/src/kernel/context/ContextThread.cpp:205
#13 simgrid::kernel::context::ThreadContext::wrapper(void*) (...)
at [...]/src/kernel/context/ContextThread.cpp:159
#14 0x00007ffff7c16131 in wrapper_start_routine (...)
at [...]/src/xbt/xbt_os_thread.c:154
#15 0x00007ffff7306064 in start_thread (...) at pthread_create.c:309
#16 0x00007ffff6a1862d in clone ()
at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
Even if I don't fully understand what's going on, I suspect that a segment
switch is occurring while the thread is running some cleanup handlers. Thus the
proposed fix tries to delay the call to xbt_os_sem_release as late as possible.
Arnaud Giersch [Wed, 19 Jul 2017 14:15:51 +0000 (16:15 +0200)]
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
Run smpi tracing tests in their own directories.
Avoids failures when tests are run in parallel.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
examples/msg/trace-host-user-variables: remove generated files.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
tools/graphicator: run tesh in build directory.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
examples/smpi/replay_multiple: put generated file in build directory.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
teshsuite/smpi/mpich3-test/f77/datatype: put generated file in build directory.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
teshsuite/smpi/mpich3-test/f{77,90}: remove unused includes.
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
Use actual names for configuration options (kebab-case + a few renames).
Arnaud Giersch [Wed, 19 Jul 2017 09:56:22 +0000 (11:56 +0200)]
Add missing calls to XBT_LOG_CONNECT.
Frederic Suter [Thu, 20 Jul 2017 08:24:26 +0000 (10:24 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Thu, 20 Jul 2017 08:24:08 +0000 (10:24 +0200)]
try to please sonar and avoid protected fields
Frederic Suter [Thu, 20 Jul 2017 07:46:16 +0000 (09:46 +0200)]
remove useless function
Martin Quinson [Thu, 20 Jul 2017 07:45:51 +0000 (09:45 +0200)]
make the cpp file easier to read
Frederic Suter [Thu, 20 Jul 2017 07:41:18 +0000 (09:41 +0200)]
char* to string == free--
Frederic Suter [Thu, 20 Jul 2017 07:36:36 +0000 (09:36 +0200)]
adress smells in cpuTI
Martin Quinson [Wed, 19 Jul 2017 22:15:31 +0000 (00:15 +0200)]
dont document a deprecated function, and properly mark it so
Martin Quinson [Wed, 19 Jul 2017 21:48:38 +0000 (23:48 +0200)]
don't repeat yourself (DRY). Implement MSG on top of S4U instead
Martin Quinson [Wed, 19 Jul 2017 21:19:40 +0000 (23:19 +0200)]
fix gcov tests
Martin Quinson [Wed, 19 Jul 2017 17:32:34 +0000 (19:32 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Frederic Suter [Wed, 19 Jul 2017 15:57:55 +0000 (17:57 +0200)]
be more explicit
Frederic Suter [Wed, 19 Jul 2017 15:53:39 +0000 (17:53 +0200)]
some of clang-format
Martin Quinson [Wed, 19 Jul 2017 15:51:57 +0000 (17:51 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Frederic Suter [Wed, 19 Jul 2017 15:41:50 +0000 (17:41 +0200)]
try to please codacy and reduce NPath complexity
Frederic Suter [Wed, 19 Jul 2017 15:31:53 +0000 (17:31 +0200)]
please both sonar and codacy
but not for the same smell
Frederic Suter [Wed, 19 Jul 2017 15:27:16 +0000 (17:27 +0200)]
only codacy would have spot this
fInput didn't even exist ...
Frederic Suter [Wed, 19 Jul 2017 14:59:45 +0000 (16:59 +0200)]
try to improve coverage
Frederic Suter [Wed, 19 Jul 2017 11:59:57 +0000 (13:59 +0200)]
kill another old-fashioned simcall
Frederic Suter [Wed, 19 Jul 2017 11:43:18 +0000 (13:43 +0200)]
remove useless try/catch
Frederic Suter [Wed, 19 Jul 2017 11:43:07 +0000 (13:43 +0200)]
cosmetics
Martin Quinson [Tue, 18 Jul 2017 15:51:37 +0000 (17:51 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Frederic Suter [Tue, 18 Jul 2017 12:38:01 +0000 (14:38 +0200)]
some cleanups in maxmin
Takishipp [Tue, 18 Jul 2017 12:26:32 +0000 (14:26 +0200)]
turn paje_value to a class
Frederic Suter [Tue, 18 Jul 2017 07:36:48 +0000 (09:36 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Tue, 18 Jul 2017 07:21:11 +0000 (09:21 +0200)]
plug two more leaks
Martin Quinson [Tue, 18 Jul 2017 01:36:41 +0000 (03:36 +0200)]
sonar: align with some files that moved in smpi
Martin Quinson [Tue, 18 Jul 2017 01:31:11 +0000 (03:31 +0200)]
gramar in comments
Martin Quinson [Tue, 18 Jul 2017 00:31:29 +0000 (02:31 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Tue, 18 Jul 2017 00:31:09 +0000 (02:31 +0200)]
MC: checker kindly ask the app whether an actor is enabled instead of reading tons of remote memory
Martin Quinson [Mon, 17 Jul 2017 23:49:16 +0000 (01:49 +0200)]
foward.h should remain as short as possible
Martin Quinson [Mon, 17 Jul 2017 23:41:10 +0000 (01:41 +0200)]
Merge pull request #200 from Takishipp/clear_fct
Replace a function by its contents
Martin Quinson [Mon, 17 Jul 2017 22:44:01 +0000 (00:44 +0200)]
cosmetics and comments
Augustin Degomme [Mon, 17 Jul 2017 19:39:33 +0000 (21:39 +0200)]
try with privatization
degomme [Mon, 17 Jul 2017 18:35:58 +0000 (20:35 +0200)]
activate new fortran test
degomme [Mon, 17 Jul 2017 18:10:08 +0000 (20:10 +0200)]
Add some missing SMPI fortran bindings (recently supported functions)
degomme [Mon, 17 Jul 2017 16:03:25 +0000 (18:03 +0200)]
Split up Fortran bindings in several files to avoid 2000 lines files.
degomme [Mon, 17 Jul 2017 15:24:46 +0000 (17:24 +0200)]
Explode 3700 lines of smpi_pmpi.cpp file in several smaller files.
degomme [Mon, 17 Jul 2017 13:41:54 +0000 (15:41 +0200)]
Suppress also the privatization dlopen handle "leak" in valgrind.
degomme [Mon, 17 Jul 2017 13:14:13 +0000 (15:14 +0200)]
Big move of all SMPI files in subfolders because it was a mess.
bindings : all C/F77 bindings + PMPI_* entry functions, which will be split up into several files next
mpi : all MPI structures (Request, Op, Info, Datatype, ...) implementation.
colls : untouched, collective comms folder
internals : all SMPI specifics (sharing, dvfs, instr, privatization, processes...)
include : all *.hpp and .h files (should it be moved ? it's added by default in the include path now)
degomme [Mon, 17 Jul 2017 11:43:16 +0000 (13:43 +0200)]
remove spurious ;
Frederic Suter [Mon, 17 Jul 2017 12:16:47 +0000 (14:16 +0200)]
plug leaks in low level tests
adding a higher level init function ensures that all data structures
are correctly deallocated.
Would be better to not allocate them at all (dict of mailboxes for
instance), but no user won't ever write XBT or SURF test, will they?