From: Martin Quinson Date: Wed, 22 Mar 2017 01:51:10 +0000 (+0100) Subject: another round for sonar X-Git-Tag: v3_15~17 X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/fe84e0ac0aeb2988a5625c87e4688735de44d480?hp=63dbaf9635815b514ef4b0877b5d9967ea5f6d2e another round for sonar --- diff --git a/examples/java/app/pingpong/Main.java b/examples/java/app/pingpong/Main.java index baa07d8cc9..8e56aed06d 100644 --- a/examples/java/app/pingpong/Main.java +++ b/examples/java/app/pingpong/Main.java @@ -10,10 +10,11 @@ import org.simgrid.msg.HostNotFoundException; import org.simgrid.msg.Msg; class Main { + protected static final int TASK_COUNT = 3; + private Main() { throw new IllegalAccessError("Utility class"); } - protected static final int TASK_COUNT = 3; public static void main(String[] args) throws HostNotFoundException { Msg.init(args); diff --git a/examples/java/cloud/migration/Test.java b/examples/java/cloud/migration/Test.java index d57582d424..df9a19f344 100644 --- a/examples/java/cloud/migration/Test.java +++ b/examples/java/cloud/migration/Test.java @@ -78,7 +78,6 @@ public class Test extends Process{ tmp.setLoad(vmSrcLoad[i-1]); } - int collocatedDst = 6; int[] vmDstLoad = { 0, 40, diff --git a/src/smpi/smpi_process.hpp b/src/smpi/smpi_process.hpp index 92945463d2..0d9a73b416 100644 --- a/src/smpi/smpi_process.hpp +++ b/src/smpi/smpi_process.hpp @@ -43,7 +43,7 @@ class Process { papi_counter_t papi_counter_data_; #endif public: - Process(int index); + explicit Process(int index); void destroy(); void set_data(int index, int *argc, char ***argv); void finalize(); @@ -60,10 +60,10 @@ class Process { smx_mailbox_t mailbox(); smx_mailbox_t mailbox_small(); xbt_mutex_t mailboxes_mutex(); - #if HAVE_PAPI +#if HAVE_PAPI int papi_event_set(void); papi_counter_t& papi_counters(void); - #endif +#endif xbt_os_timer_t timer(); void simulated_start(); double simulated_elapsed();