From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Thu, 19 Nov 2020 08:34:33 +0000 (+0100)
Subject: More useless std::move.
X-Git-Tag: v3.26~167
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/f653eea6a35035be81a9b60f6c2fa7c48292d9c4

More useless std::move.
---

diff --git a/include/xbt/config.hpp b/include/xbt/config.hpp
index 10440094fd..7d5572cfe2 100644
--- a/include/xbt/config.hpp
+++ b/include/xbt/config.hpp
@@ -117,7 +117,7 @@ template <class T>
 void bind_flag(T& value, const char* name, std::initializer_list<const char*> aliases, const char* description)
 {
   bind_flag(value, name, description);
-  alias(name, std::move(aliases));
+  alias(name, aliases);
 }
 
 /** Bind a variable to configuration flag
@@ -146,7 +146,7 @@ typename std::enable_if<std::is_same<void, decltype(std::declval<F>()(std::declv
 bind_flag(T& value, const char* name, std::initializer_list<const char*> aliases, const char* description, F callback)
 {
   bind_flag(value, name, description, std::move(callback));
-  alias(name, std::move(aliases));
+  alias(name, aliases);
 }
 
 template <class T, class F>
@@ -177,7 +177,7 @@ bind_flag(T& value, const char* name, std::initializer_list<const char*> aliases
           const std::map<T, std::string>& valid_values, F callback)
 {
   bind_flag(value, name, description, valid_values, std::move(callback));
-  alias(name, std::move(aliases));
+  alias(name, aliases);
 }
 
 /** Bind a variable to configuration flag
@@ -228,7 +228,7 @@ public:
   Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, T value)
       : value_(value), name_(name)
   {
-    simgrid::config::bind_flag(value_, name, std::move(aliases), desc);
+    simgrid::config::bind_flag(value_, name, aliases, desc);
   }
 
   /* A constructor accepting a callback that will be passed the parameter.
@@ -243,7 +243,7 @@ public:
   Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, T value, F callback)
       : value_(value), name_(name)
   {
-    simgrid::config::bind_flag(value_, name, std::move(aliases), desc, std::move(callback));
+    simgrid::config::bind_flag(value_, name, aliases, desc, std::move(callback));
   }
 
   /* A constructor accepting a map of valid values -> their description,
@@ -262,7 +262,7 @@ public:
        const std::map<T, std::string>& valid_values, F callback)
       : value_(value), name_(name)
   {
-    simgrid::config::bind_flag(value_, name, std::move(aliases), desc, valid_values, std::move(callback));
+    simgrid::config::bind_flag(value_, name, aliases, desc, valid_values, std::move(callback));
   }
 
   // No copy:
diff --git a/include/xbt/string.hpp b/include/xbt/string.hpp
index 8ae6756303..0a50fb6e71 100644
--- a/include/xbt/string.hpp
+++ b/include/xbt/string.hpp
@@ -101,7 +101,7 @@ public:
   string() : string(&NUL, 0) {}
   explicit string(const char* s) : string(s, strlen(s)) {}
   string(string const& s) : string(s.c_str(), s.size()) {}
-  string(string&& s) noexcept : str(std::move(s.str))
+  string(string&& s) noexcept : str(s.str)
   {
     s.str.len  = 0;
     s.str.data = &NUL;
diff --git a/src/surf/sg_platf.cpp b/src/surf/sg_platf.cpp
index fbded0874a..42f498c0aa 100644
--- a/src/surf/sg_platf.cpp
+++ b/src/surf/sg_platf.cpp
@@ -479,7 +479,7 @@ void sg_platf_new_actor(simgrid::kernel::routing::ActorCreationArgs* actor)
 
     try {
       simgrid::kernel::actor::ActorImplPtr new_actor = nullptr;
-      new_actor = simgrid::kernel::actor::ActorImpl::create(arg->name.c_str(), std::move(code), nullptr, host,
+      new_actor = simgrid::kernel::actor::ActorImpl::create(arg->name.c_str(), code, nullptr, host,
                                                             arg->properties.get(), nullptr);
       /* The actor creation will fail if the host is currently dead, but that's fine */
       if (arg->kill_time >= 0)