From: Arnaud Giersch Date: Tue, 5 Nov 2013 12:16:41 +0000 (+0100) Subject: Check that table[0].name is defined. X-Git-Tag: v3_10_rc2~43 X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/f4d034af50e34fbac8e6cf57d767f6704dfaf49c Check that table[0].name is defined. Also change "model" for "collective" in find_coll_description(). --- diff --git a/src/smpi/smpi_coll.c b/src/smpi/smpi_coll.c index e6db1485d0..70fdb14f87 100644 --- a/src/smpi/smpi_coll.c +++ b/src/smpi/smpi_coll.c @@ -143,7 +143,9 @@ int find_coll_description(s_mpi_coll_description_t * table, return i; } } - name_list = strdup(table[0].name); + if (!table[0].name) + xbt_die("No collective is valid! This is a bug."); + name_list = xbt_strdup(table[0].name); for (i = 1; table[i].name; i++) { name_list = xbt_realloc(name_list, @@ -151,7 +153,7 @@ int find_coll_description(s_mpi_coll_description_t * table, strcat(name_list, ", "); strcat(name_list, table[i].name); } - xbt_die("Model '%s' is invalid! Valid models are: %s.", name, name_list); + xbt_die("Collective '%s' is invalid! Valid collectives are: %s.", name, name_list); return -1; } diff --git a/src/surf/surf.c b/src/surf/surf.c index de54e4373c..807bfaf8d5 100644 --- a/src/surf/surf.c +++ b/src/surf/surf.c @@ -233,7 +233,9 @@ int find_model_description(s_surf_model_description_t * table, if (!strcmp(name, table[i].name)) { return i; } - name_list = strdup(table[0].name); + if (!table[0].name) + xbt_die("No model is valid! This is a bug."); + name_list = xbt_strdup(table[0].name); for (i = 1; table[i].name; i++) { name_list = xbt_realloc(name_list,