From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Wed, 25 Oct 2017 20:02:17 +0000 (+0200)
Subject: Remove redundant forward class declarations.
X-Git-Tag: v3.18~397^2~2
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/e4fca2dba5c9d2b6ab3fa3e9d46016eff7e03103

Remove redundant forward class declarations.
---

diff --git a/src/include/surf/maxmin.hpp b/src/include/surf/maxmin.hpp
index 1df50434b3..e0dd9d7ccf 100644
--- a/src/include/surf/maxmin.hpp
+++ b/src/include/surf/maxmin.hpp
@@ -7,17 +7,11 @@
 #define SURF_MAXMIN_HPP
 
 #include "src/internal_config.h"
-#include "surf/datatypes.h"
+#include "surf/surf.h"
 #include "xbt/asserts.h"
 #include "xbt/misc.h"
 #include <cmath>
 
-namespace simgrid {
-namespace surf {
-class Action;
-}
-}
-
 /** @addtogroup SURF_lmm
  * @details
  * A linear maxmin solver to resolve inequations systems.
diff --git a/src/include/surf/surf.h b/src/include/surf/surf.h
index d83c9a0410..837c31faa8 100644
--- a/src/include/surf/surf.h
+++ b/src/include/surf/surf.h
@@ -26,7 +26,6 @@ class CpuModel;
 class HostModel;
 class NetworkModel;
 class StorageModel;
-class Resource;
 class NetworkCm02Link;
 class Action;
 }
@@ -37,7 +36,6 @@ typedef simgrid::surf::CpuModel surf_CpuModel;
 typedef simgrid::surf::HostModel surf_HostModel;
 typedef simgrid::surf::NetworkModel surf_NetworkModel;
 typedef simgrid::surf::StorageModel surf_StorageModel;
-typedef simgrid::surf::Resource surf_Resource;
 typedef simgrid::surf::Action surf_Action;
 
 #else
@@ -47,7 +45,6 @@ typedef struct surf_CpuModel surf_CpuModel;
 typedef struct surf_HostModel surf_HostModel;
 typedef struct surf_NetworkModel surf_NetworkModel;
 typedef struct surf_StorageModel surf_StorageModel;
-typedef struct surf_Resource surf_Resource;
 typedef struct surf_Action surf_Action;
 
 #endif
diff --git a/src/kernel/EngineImpl.hpp b/src/kernel/EngineImpl.hpp
index 39f041a8cb..8593bf88da 100644
--- a/src/kernel/EngineImpl.hpp
+++ b/src/kernel/EngineImpl.hpp
@@ -3,16 +3,13 @@
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
+#include <simgrid/s4u/NetZone.hpp>
 #include <simgrid/s4u/forward.hpp>
 #include <string>
 #include <unordered_map>
 
 namespace simgrid {
 namespace kernel {
-namespace routing {
-class NetZoneImpl;
-class NetPoint;
-}
 
 class EngineImpl {
 public:
diff --git a/src/plugins/vm/VirtualMachineImpl.hpp b/src/plugins/vm/VirtualMachineImpl.hpp
index 026071ea97..771747bdaa 100644
--- a/src/plugins/vm/VirtualMachineImpl.hpp
+++ b/src/plugins/vm/VirtualMachineImpl.hpp
@@ -21,13 +21,6 @@ typedef struct s_dirty_page* dirty_page_t;
 namespace simgrid {
 namespace vm {
 
-/***********
- * Classes *
- ***********/
-
-class XBT_PRIVATE VMModel;
-XBT_PUBLIC_CLASS VirtualMachineImpl; // Made visible to the Java plugin
-
 /*************
  * Callbacks *
  *************/
@@ -114,7 +107,7 @@ private:
  * @brief SURF VM model interface class
  * @details A model is an object which handle the interactions between its Resources and its Actions
  */
-class VMModel : public surf::HostModel {
+class XBT_PRIVATE VMModel : public surf::HostModel {
 public:
   VMModel();
   void ignoreEmptyVmInPmLMM() override{};
diff --git a/src/simix/smx_host_private.hpp b/src/simix/smx_host_private.hpp
index 6943f1991f..5f49d3fe1e 100644
--- a/src/simix/smx_host_private.hpp
+++ b/src/simix/smx_host_private.hpp
@@ -16,12 +16,12 @@
 #include "popping_private.hpp"
 #include "simgrid/simix.h"
 
+#include "ActorImpl.hpp"
 #include "src/kernel/activity/ExecImpl.hpp"
 
 /** @brief Host datatype from SIMIX POV */
 namespace simgrid {
 namespace simix {
-class ProcessArg;
 
 class Host {
 public:
diff --git a/src/surf/cpu_interface.hpp b/src/surf/cpu_interface.hpp
index fc67386f29..f360cf1059 100644
--- a/src/surf/cpu_interface.hpp
+++ b/src/surf/cpu_interface.hpp
@@ -18,10 +18,6 @@
 namespace simgrid {
 namespace surf {
 
-class CpuModel;
-class Cpu;
-class CpuAction;
-
  /** @ingroup SURF_cpu_interface
  * @brief SURF cpu model interface class
  * @details A model is an object which handle the interactions between its Resources and its Actions
diff --git a/src/xbt/config.cpp b/src/xbt/config.cpp
index f7d8d81815..3632eb1248 100644
--- a/src/xbt/config.cpp
+++ b/src/xbt/config.cpp
@@ -38,8 +38,6 @@ namespace config {
 
 missing_key_error::~missing_key_error() = default;
 
-class Config;
-
 namespace {
 
 const char* true_values[] = {