From: Martin Quinson <martin.quinson@loria.fr>
Date: Tue, 15 Nov 2011 11:04:08 +0000 (+0100)
Subject: damn it, there is no example testing the bypass mecanism!!
X-Git-Tag: exp_20120216~267
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/de3b1d47e9b8b9f35dc96bf24d28fb4ede24a683?hp=f3735c4ed8e2ea50363481f903209da4a35f3d44

damn it, there is no example testing the bypass mecanism!!
---

diff --git a/src/surf/surf_routing.c b/src/surf/surf_routing.c
index f6b5c4ed89..a507e10547 100644
--- a/src/surf/surf_routing.c
+++ b/src/surf/surf_routing.c
@@ -519,10 +519,10 @@ static void _get_route_and_latency(const char *src, const char *dst,
 
   if (e_route_bypass) { /* Common ancestor is kind enough to declare a bypass route from src to dst -- use it and bail out */
     if (latency)
-      xbt_die("Bypass cannot work yet with get_latency"); // FIXME: that limitation seems spurious to me -- check with alvin
-
-    *links = xbt_dynar_new(global_routing->size_of_link, NULL);
+      xbt_die("Bypass cannot work yet with get_latency"); // FIXME: get_bypass_route should update the latency itself, just like get_route
 
+    // FIXME this path is never tested. I need examples to check the bypass mechanism...
+    THROW_UNIMPLEMENTED; // let's warn the users of the problem
     xbt_dynar_foreach(e_route_bypass->link_list, cpt, link) {
       xbt_dynar_push(*links, &link);
     }
@@ -537,8 +537,7 @@ static void _get_route_and_latency(const char *src, const char *dst,
   route.link_list = xbt_dynar_new(global_routing->size_of_link, NULL);
   common_father->get_route_and_latency(common_father, src_father->name, dst_father->name, &route,latency);
 
-  xbt_assert((route.src_gateway == NULL) ==
-      (route.dst_gateway == NULL),
+  xbt_assert((route.src_gateway != NULL) && (route.dst_gateway != NULL),
       "bad gateways for route from \"%s\" to \"%s\"", src, dst);
 
   *links = xbt_dynar_new(global_routing->size_of_link, NULL);