From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Thu, 5 Oct 2017 19:48:33 +0000 (+0200)
Subject: Fix invalid free when SIMIX_global_init() exits early.
X-Git-Tag: v3_17~10
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/d71293633ab72fc082a6d5f7d9ca2f1cbf4b99dc

Fix invalid free when SIMIX_global_init() exits early.
---

diff --git a/src/s4u/s4u_engine.cpp b/src/s4u/s4u_engine.cpp
index 07fa11beb4..783ed43c4a 100644
--- a/src/s4u/s4u_engine.cpp
+++ b/src/s4u/s4u_engine.cpp
@@ -32,11 +32,11 @@ Engine *Engine::instance_ = nullptr; /* That singleton is awful, but I don't see
 
 Engine::Engine(int *argc, char **argv) {
   xbt_assert(s4u::Engine::instance_ == nullptr, "It is currently forbidden to create more than one instance of s4u::Engine");
-  s4u::Engine::instance_ = this;
-  pimpl                  = new kernel::EngineImpl();
-
   TRACE_global_init();
   SIMIX_global_init(argc, argv);
+
+  pimpl                  = new kernel::EngineImpl();
+  s4u::Engine::instance_ = this;
 }
 
 Engine::~Engine()
@@ -54,6 +54,7 @@ Engine* Engine::getInstance()
 
 void Engine::shutdown() {
   delete s4u::Engine::instance_;
+  s4u::Engine::instance_ = nullptr;
 }
 
 double Engine::getClock()