From: Martin Quinson <martin.quinson@loria.fr>
Date: Sun, 18 May 2014 17:01:09 +0000 (+0200)
Subject: previous version was initializing retval=0 and then testing retval!=MPI_ERR_REQUEST... 
X-Git-Tag: v3_11~69
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/cb4ea4fd7124e6ef595576f6382e32440e8613f5

previous version was initializing retval=0 and then testing retval!=MPI_ERR_REQUEST. This seems dubious to me
---

diff --git a/src/smpi/smpi_pmpi.c b/src/smpi/smpi_pmpi.c
index 367176d3eb..573575b20b 100644
--- a/src/smpi/smpi_pmpi.c
+++ b/src/smpi/smpi_pmpi.c
@@ -934,12 +934,13 @@ int PMPI_Start(MPI_Request * request)
 
 int PMPI_Startall(int count, MPI_Request * requests)
 {
-  int retval = 0;
+  int retval;
   int i = 0;
   smpi_bench_end();
   if (requests == NULL) {
     retval = MPI_ERR_ARG;
   } else {
+    retval = MPI_SUCCESS;
     for (i = 0 ;  i < count ; i++) {
       if(requests[i] == MPI_REQUEST_NULL) {
         retval = MPI_ERR_REQUEST;
@@ -947,7 +948,6 @@ int PMPI_Startall(int count, MPI_Request * requests)
     }
     if(retval != MPI_ERR_REQUEST) {
       smpi_mpi_startall(count, requests);
-      retval = MPI_SUCCESS;
     }
   }
   smpi_bench_begin();