From: Marion Guthmuller <marion.guthmuller@loria.fr>
Date: Tue, 13 Aug 2013 13:59:04 +0000 (+0200)
Subject: model-checker : fix dot output for liveness MC
X-Git-Tag: v3_9_90~128^2
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/ca56c046667fe56766ea8d522fd87cf2c23df4a4?hp=ef6a1c2bf7ef52a543f8a4d3276b215d5644194b

model-checker : fix dot output for liveness MC
---

diff --git a/src/mc/mc_liveness.c b/src/mc/mc_liveness.c
index 5bed09985f..27889aca59 100644
--- a/src/mc/mc_liveness.c
+++ b/src/mc/mc_liveness.c
@@ -304,7 +304,6 @@ static int is_visited_pair(mc_pair_t pair){
     size_t bytes_used_test;
     int nb_processes_test;
     int same_processes_and_bytes_not_found = 1;
-    int result;
 
     while(start <= end && same_processes_and_bytes_not_found){
       cursor = (start + end) / 2;
@@ -325,10 +324,17 @@ static int is_visited_pair(mc_pair_t pair){
           if(xbt_automaton_state_compare(pair_test->automaton_state, pair->automaton_state) == 0){
             if(xbt_automaton_propositional_symbols_compare_value(pair_test->atomic_propositions, pair->atomic_propositions) == 0){
               if(snapshot_compare(pair->graph_state->system_state, pair_test->graph_state->system_state) == 0){
+                if(pair_test->other_num == -1)
+                  pair->other_num = pair_test->num;
+                else
+                  pair->other_num = pair_test->other_num;
+                if(dot_output == NULL)
+                  XBT_DEBUG("Pair %d already visited ! (equal to pair %d)", pair->num, pair_test->num);
+                else
+                  XBT_DEBUG("Pair %d already visited ! (equal to pair %d (pair %d in dot_output))", pair->num, pair_test->num, pair->other_num);
                 xbt_dynar_remove_at(visited_pairs, cursor, NULL);
                 xbt_dynar_insert_at(visited_pairs, cursor, &pair);
                 pair_test->visited_removed = 1;
-                result = pair_test->num;
                 if(pair_test->stack_removed && pair_test->visited_removed){
                   if((pair_test->automaton_state->type == 1) || (pair_test->automaton_state->type == 2)){
                     if(pair_test->acceptance_removed){ 
@@ -342,7 +348,7 @@ static int is_visited_pair(mc_pair_t pair){
                   MC_SET_RAW_MEM;
                 else
                   MC_UNSET_RAW_MEM;
-                return result;
+                return pair->other_num;
               }
             }
           }
@@ -356,10 +362,17 @@ static int is_visited_pair(mc_pair_t pair){
             if(xbt_automaton_state_compare(pair_test->automaton_state, pair->automaton_state) == 0){
               if(xbt_automaton_propositional_symbols_compare_value(pair_test->atomic_propositions, pair->atomic_propositions) == 0){  
                 if(snapshot_compare(pair->graph_state->system_state, pair_test->graph_state->system_state) == 0){
+                  if(pair_test->other_num == -1)
+                    pair->other_num = pair_test->num;
+                  else
+                    pair->other_num = pair_test->other_num;
+                  if(dot_output == NULL)
+                    XBT_DEBUG("Pair %d already visited ! (equal to pair %d)", pair->num, pair_test->num);
+                  else
+                    XBT_DEBUG("Pair %d already visited ! (equal to pair %d (pair %d in dot_output))", pair->num, pair_test->num, pair->other_num);
                   xbt_dynar_remove_at(visited_pairs, previous_cursor, NULL);
                   xbt_dynar_insert_at(visited_pairs, previous_cursor, &pair);
                   pair_test->visited_removed = 1;
-                  result = pair_test->num;
                   if(pair_test->stack_removed && pair_test->visited_removed){
                     if((pair_test->automaton_state->type == 1) || (pair_test->automaton_state->type == 2)){
                       if(pair_test->acceptance_removed){ 
@@ -373,7 +386,7 @@ static int is_visited_pair(mc_pair_t pair){
                     MC_SET_RAW_MEM;
                   else
                     MC_UNSET_RAW_MEM;
-                  return result;
+                  return pair->other_num;
                 }
               }
             }
@@ -388,10 +401,17 @@ static int is_visited_pair(mc_pair_t pair){
             if(xbt_automaton_state_compare(pair_test->automaton_state, pair->automaton_state) == 0){
               if(xbt_automaton_propositional_symbols_compare_value(pair_test->atomic_propositions, pair->atomic_propositions) == 0){
                 if(snapshot_compare(pair->graph_state->system_state, pair_test->graph_state->system_state) == 0){
+                  if(pair_test->other_num == -1)
+                    pair->other_num = pair_test->num;
+                  else
+                    pair->other_num = pair_test->other_num;
+                  if(dot_output == NULL)
+                    XBT_DEBUG("Pair %d already visited ! (equal to pair %d)", pair->num, pair_test->num);
+                  else
+                    XBT_DEBUG("Pair %d already visited ! (equal to pair %d (pair %d in dot_output))", pair->num, pair_test->num, pair->other_num);
                   xbt_dynar_remove_at(visited_pairs, next_cursor, NULL);
                   xbt_dynar_insert_at(visited_pairs, next_cursor, &pair);
                   pair_test->visited_removed = 1;
-                  result = pair_test->num;
                   if(pair_test->stack_removed && pair_test->visited_removed){
                     if((pair_test->automaton_state->type == 1) || (pair_test->automaton_state->type == 2)){
                       if(pair_test->acceptance_removed){ 
@@ -405,7 +425,7 @@ static int is_visited_pair(mc_pair_t pair){
                     MC_SET_RAW_MEM;
                   else
                     MC_UNSET_RAW_MEM;
-                  return result;
+                  return pair->other_num;
                 }
               }
             }
@@ -655,8 +675,6 @@ void MC_ddfs(){
 
       if((visited_num = is_visited_pair(current_pair)) != -1){
 
-        XBT_DEBUG("Pair %d already visited ! (equal to pair %d)", current_pair->num, visited_num);
-
         MC_SET_RAW_MEM;
         if(dot_output != NULL)
           fprintf(dot_output, "\"%d\" -> \"%d\" [%s];\n", initial_state_liveness->prev_pair, visited_num, initial_state_liveness->prev_req);
diff --git a/src/mc/mc_pair.c b/src/mc/mc_pair.c
index 6f6506e4d2..f25394abbf 100644
--- a/src/mc/mc_pair.c
+++ b/src/mc/mc_pair.c
@@ -11,6 +11,7 @@ mc_pair_t MC_pair_new(){
   p->nb_processes = xbt_swag_size(simix_global->process_list);
   p->num = ++mc_stats->expanded_pairs;
   p->search_cycle = 0;
+  p->other_num = -1;
   return p;
 }
 
diff --git a/src/mc/mc_private.h b/src/mc/mc_private.h
index b460411f9a..52d70449fc 100644
--- a/src/mc/mc_private.h
+++ b/src/mc/mc_private.h
@@ -296,6 +296,7 @@ extern xbt_dynar_t mc_data_bss_comparison_ignore;
 
 typedef struct s_mc_pair{
   int num;
+  int other_num; /* Dot output for */
   int search_cycle;
   mc_state_t graph_state; /* System state included */
   xbt_automaton_state_t automaton_state;