From: Marion Guthmuller Date: Sun, 21 Aug 2011 09:37:04 +0000 (+0200) Subject: model-checker : stateless model checking for liveness properties X-Git-Tag: exp_20120216~133^2~75 X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/b2b401f886e6e1c849e1dcd5b70a7133ba4859f9?hp=5a9c70d5dfe11c9c7660b795b00f49b4170da968 model-checker : stateless model checking for liveness properties --- diff --git a/examples/msg/chord/CMakeLists.txt b/examples/msg/chord/CMakeLists.txt index f64019ffc2..91c86c5b52 100644 --- a/examples/msg/chord/CMakeLists.txt +++ b/examples/msg/chord/CMakeLists.txt @@ -3,7 +3,8 @@ cmake_minimum_required(VERSION 2.6) set(EXECUTABLE_OUTPUT_PATH "${CMAKE_CURRENT_BINARY_DIR}") add_executable(chord "chord.c") +add_executable(chord_stateful "chord_stateful.c") ### Add definitions for compile target_link_libraries(chord simgrid ) - +target_link_libraries(chord_stateful simgrid) diff --git a/examples/msg/chord/chord_stateful.c b/examples/msg/chord/chord_stateful.c new file mode 100644 index 0000000000..481da7ab1c --- /dev/null +++ b/examples/msg/chord/chord_stateful.c @@ -0,0 +1,948 @@ + +/* Copyright (c) 2010. The SimGrid Team. + * All rights reserved. */ + +/* This program is free software; you can redistribute it and/or modify it + * under the terms of the license (GNU LGPL) which comes with this package. */ + +#include +#include "msg/msg.h" +#include "xbt/log.h" +#include "xbt/asserts.h" +#include "mc/modelchecker.h" +#include "mc/mc.h" +#include "xbt/xbt_os_time.h" + +XBT_LOG_NEW_DEFAULT_CATEGORY(msg_chord, + "Messages specific for this msg example"); + +#define COMM_SIZE 10 +#define COMP_SIZE 0 +#define MAILBOX_NAME_SIZE 10 + +static int nb_bits = 24; +static int nb_keys = 0; +static int timeout = 50; +static int max_simulation_time = 1000; +static int periodic_stabilize_delay = 20; +static int periodic_fix_fingers_delay = 120; +static int periodic_check_predecessor_delay = 120; +static int periodic_lookup_delay = 10; + +extern long int smx_total_comms; + +/** + * Finger element. + */ +typedef struct finger { + int id; + char mailbox[MAILBOX_NAME_SIZE]; // string representation of the id +} s_finger_t, *finger_t; + +/** + * Node data. + */ +typedef struct node { + int id; // my id + char mailbox[MAILBOX_NAME_SIZE]; // my mailbox name (string representation of the id) + s_finger_t *fingers; // finger table, of size nb_bits (fingers[0] is my successor) + int pred_id; // predecessor id + char pred_mailbox[MAILBOX_NAME_SIZE]; // predecessor's mailbox name + int next_finger_to_fix; // index of the next finger to fix in fix_fingers() + msg_comm_t comm_receive; // current communication to receive + double last_change_date; // last time I changed a finger or my predecessor +} s_node_t, *node_t; + +/** + * Types of tasks exchanged between nodes. + */ +typedef enum { + TASK_FIND_SUCCESSOR, + TASK_FIND_SUCCESSOR_ANSWER, + TASK_GET_PREDECESSOR, + TASK_GET_PREDECESSOR_ANSWER, + TASK_NOTIFY, + TASK_SUCCESSOR_LEAVING, + TASK_PREDECESSOR_LEAVING +} e_task_type_t; + +/** + * Data attached with the tasks sent and received + */ +typedef struct task_data { + e_task_type_t type; // type of task + int request_id; // id paramater (used by some types of tasks) + int request_finger; // finger parameter (used by some types of tasks) + int answer_id; // answer (used by some types of tasks) + char answer_to[MAILBOX_NAME_SIZE]; // mailbox to send an answer to (if any) + const char* issuer_host_name; // used for logging +} s_task_data_t, *task_data_t; + +static int *powers2; + +// utility functions +static void chord_initialize(void); +static int normalize(int id); +static int is_in_interval(int id, int start, int end); +static void get_mailbox(int host_id, char* mailbox); +static void task_free(void* task); +static void print_finger_table(node_t node); +static void set_finger(node_t node, int finger_index, int id); +static void set_predecessor(node_t node, int predecessor_id); + +// process functions +static int node(int argc, char *argv[]); +static void handle_task(node_t node, m_task_t task); + +// Chord core +static void create(node_t node); +static int join(node_t node, int known_id); +static void leave(node_t node); +static int find_successor(node_t node, int id); +static int remote_find_successor(node_t node, int ask_to_id, int id); +static int remote_get_predecessor(node_t node, int ask_to_id); +static int closest_preceding_node(node_t node, int id); +static void stabilize(node_t node); +static void notify(node_t node, int predecessor_candidate_id); +static void remote_notify(node_t node, int notify_to, int predecessor_candidate_id); +static void fix_fingers(node_t node); +static void check_predecessor(node_t node); +static void random_lookup(node_t); +static void quit_notify(node_t node, int to); + +/** + * \brief Global initialization of the Chord simulation. + */ +static void chord_initialize(void) +{ + // compute the powers of 2 once for all + powers2 = xbt_new(int, nb_bits); + int pow = 1; + int i; + for (i = 0; i < nb_bits; i++) { + powers2[i] = pow; + pow = pow << 1; + } + nb_keys = pow; + XBT_DEBUG("Sets nb_keys to %d", nb_keys); +} + +/** + * \brief Turns an id into an equivalent id in [0, nb_keys). + * \param id an id + * \return the corresponding normalized id + */ +static int normalize(int id) +{ + // like id % nb_keys, but works with negatives numbers (and faster) + return id & (nb_keys - 1); +} + +/** + * \brief Returns whether a id belongs to the interval [start, end]. + * + * The parameters are noramlized to make sure they are between 0 and nb_keys - 1). + * 1 belongs to [62, 3] + * 1 does not belong to [3, 62] + * 63 belongs to [62, 3] + * 63 does not belong to [3, 62] + * 24 belongs to [21, 29] + * 24 does not belong to [29, 21] + * + * \param id id to check + * \param start lower bound + * \param end upper bound + * \return a non-zero value if id in in [start, end] + */ +static int is_in_interval(int id, int start, int end) +{ + id = normalize(id); + start = normalize(start); + end = normalize(end); + + // make sure end >= start and id >= start + if (end < start) { + end += nb_keys; + } + + if (id < start) { + id += nb_keys; + } + + return id <= end; +} + +/** + * \brief Gets the mailbox name of a host given its chord id. + * \param node_id id of a node + * \param mailbox pointer to where the mailbox name should be written + * (there must be enough space) + */ +static void get_mailbox(int node_id, char* mailbox) +{ + snprintf(mailbox, MAILBOX_NAME_SIZE - 1, "%d", node_id); +} + +/** + * \brief Frees the memory used by a task. + * \param task the MSG task to destroy + */ +static void task_free(void* task) +{ + // TODO add a parameter data_free_function to MSG_task_create? + xbt_free(MSG_task_get_data(task)); + MSG_task_destroy(task); +} + +/** + * \brief Displays the finger table of a node. + * \param node a node + */ +static void print_finger_table(node_t node) +{ + if (XBT_LOG_ISENABLED(msg_chord, xbt_log_priority_verbose)) { + int i; + XBT_VERB("My finger table:"); + XBT_VERB("Start | Succ "); + for (i = 0; i < nb_bits; i++) { + XBT_VERB(" %3d | %3d ", (node->id + powers2[i]) % nb_keys, node->fingers[i].id); + } + XBT_VERB("Predecessor: %d", node->pred_id); + } +} + +/** + * \brief Sets a finger of the current node. + * \param node the current node + * \param finger_index index of the finger to set (0 to nb_bits - 1) + * \param id the id to set for this finger + */ +static void set_finger(node_t node, int finger_index, int id) +{ + if (id != node->fingers[finger_index].id) { + node->fingers[finger_index].id = id; + get_mailbox(id, node->fingers[finger_index].mailbox); + node->last_change_date = MSG_get_clock(); + XBT_DEBUG("My new finger #%d is %d", finger_index, id); + } +} + +/** + * \brief Sets the predecessor of the current node. + * \param node the current node + * \param id the id to predecessor, or -1 to unset the predecessor + */ +static void set_predecessor(node_t node, int predecessor_id) +{ + if (predecessor_id != node->pred_id) { + node->pred_id = predecessor_id; + + if (predecessor_id != -1) { + get_mailbox(predecessor_id, node->pred_mailbox); + } + node->last_change_date = MSG_get_clock(); + + XBT_DEBUG("My new predecessor is %d", predecessor_id); + } +} + +/** + * \brief Node Function + * Arguments: + * - my id + * - the id of a guy I know in the system (except for the first node) + * - the time to sleep before I join (except for the first node) + */ +int node(int argc, char *argv[]) +{ + /* Reduce the run size for the MC */ + if(MC_IS_ENABLED){ + periodic_stabilize_delay = 8; + periodic_fix_fingers_delay = 8; + periodic_check_predecessor_delay = 8; + } + + double init_time = MSG_get_clock(); + m_task_t task_received = NULL; + int i; + int join_success = 0; + double deadline; + double next_stabilize_date = init_time + periodic_stabilize_delay; + double next_fix_fingers_date = init_time + periodic_fix_fingers_delay; + double next_check_predecessor_date = init_time + periodic_check_predecessor_delay; + double next_lookup_date = init_time + periodic_lookup_delay; + + xbt_assert(argc == 3 || argc == 5, "Wrong number of arguments for this node"); + + // initialize my node + s_node_t node = {0}; + node.id = atoi(argv[1]); + get_mailbox(node.id, node.mailbox); + node.next_finger_to_fix = 0; + node.fingers = xbt_new0(s_finger_t, nb_bits); + node.last_change_date = init_time; + + for (i = 0; i < nb_bits; i++) { + node.fingers[i].id = -1; + set_finger(&node, i, node.id); + } + + if (argc == 3) { // first ring + deadline = atof(argv[2]); + create(&node); + join_success = 1; + } + else { + int known_id = atoi(argv[2]); + //double sleep_time = atof(argv[3]); + deadline = atof(argv[4]); + + /* + // sleep before starting + XBT_DEBUG("Let's sleep during %f", sleep_time); + MSG_process_sleep(sleep_time); + */ + XBT_DEBUG("Hey! Let's join the system."); + + join_success = join(&node, known_id); + } + + if (join_success) { + while (MSG_get_clock() < init_time + deadline +// && MSG_get_clock() < node.last_change_date + 1000 + && MSG_get_clock() < max_simulation_time) { + + if (node.comm_receive == NULL) { + task_received = NULL; + node.comm_receive = MSG_task_irecv(&task_received, node.mailbox); + // FIXME: do not make MSG_task_irecv() calls from several functions + } + + if (!MSG_comm_test(node.comm_receive)) { + + // no task was received: make some periodic calls + if (MSG_get_clock() >= next_stabilize_date) { + stabilize(&node); + next_stabilize_date = MSG_get_clock() + periodic_stabilize_delay; + } + else if (MSG_get_clock() >= next_fix_fingers_date) { + fix_fingers(&node); + next_fix_fingers_date = MSG_get_clock() + periodic_fix_fingers_delay; + } + else if (MSG_get_clock() >= next_check_predecessor_date) { + check_predecessor(&node); + next_check_predecessor_date = MSG_get_clock() + periodic_check_predecessor_delay; + } + else if (MSG_get_clock() >= next_lookup_date) { + random_lookup(&node); + next_lookup_date = MSG_get_clock() + periodic_lookup_delay; + } + else { + // nothing to do: sleep for a while + MSG_process_sleep(5); + } + } + else { + // a transfer has occured + + MSG_error_t status = MSG_comm_get_status(node.comm_receive); + + if (status != MSG_OK) { + XBT_DEBUG("Failed to receive a task. Nevermind."); + node.comm_receive = NULL; + } + else { + // the task was successfully received + MSG_comm_destroy(node.comm_receive); + node.comm_receive = NULL; + handle_task(&node, task_received); + } + } + + // see if some communications are finished + /* + while ((index = MSG_comm_testany(node.comms)) != -1) { + comm_send = xbt_dynar_get_as(node.comms, index, msg_comm_t); + MSG_error_t status = MSG_comm_get_status(comm_send); + xbt_dynar_remove_at(node.comms, index, &comm_send); + XBT_DEBUG("Communication %p is finished with status %d, dynar size is now %lu", + comm_send, status, xbt_dynar_length(node.comms)); + m_task_t task = MSG_comm_get_task(comm_send); + MSG_comm_destroy(comm_send); + if (status != MSG_OK) { + task_data_destroy(MSG_task_get_data(task)); + MSG_task_destroy(task); + } + } + */ + } + + // clean unfinished comms sent + /* unsigned int cursor; + xbt_dynar_foreach(node.comms, cursor, comm_send) { + m_task_t task = MSG_comm_get_task(comm_send); + MSG_task_cancel(task); + task_data_destroy(MSG_task_get_data(task)); + MSG_task_destroy(task); + MSG_comm_destroy(comm_send); + // FIXME: the task is actually not destroyed because MSG thinks that the other side (whose process is dead) is still using it + }*/ + + // leave the ring + leave(&node); + } + + // stop the simulation + xbt_free(node.fingers); + return 0; +} + +/** + * \brief This function is called when the current node receives a task. + * \param node the current node + * \param task the task to handle (don't touch it then: + * it will be destroyed, reused or forwarded) + */ +static void handle_task(node_t node, m_task_t task) { + + XBT_DEBUG("Handling task %p", task); + char mailbox[MAILBOX_NAME_SIZE]; + task_data_t task_data = (task_data_t) MSG_task_get_data(task); + e_task_type_t type = task_data->type; + + switch (type) { + + case TASK_FIND_SUCCESSOR: + XBT_DEBUG("Receiving a 'Find Successor' request from %s for id %d", + task_data->issuer_host_name, task_data->request_id); + // is my successor the successor? + if (is_in_interval(task_data->request_id, node->id + 1, node->fingers[0].id)) { + task_data->type = TASK_FIND_SUCCESSOR_ANSWER; + task_data->answer_id = node->fingers[0].id; + XBT_DEBUG("Sending back a 'Find Successor Answer' to %s (mailbox %s): the successor of %d is %d", + task_data->issuer_host_name, + task_data->answer_to, + task_data->request_id, task_data->answer_id); + MSG_task_dsend(task, task_data->answer_to, task_free); + } + else { + // otherwise, forward the request to the closest preceding finger in my table + int closest = closest_preceding_node(node, task_data->request_id); + XBT_DEBUG("Forwarding the 'Find Successor' request for id %d to my closest preceding finger %d", + task_data->request_id, closest); + get_mailbox(closest, mailbox); + MSG_task_dsend(task, mailbox, task_free); + } + break; + + case TASK_GET_PREDECESSOR: + XBT_DEBUG("Receiving a 'Get Predecessor' request from %s", task_data->issuer_host_name); + task_data->type = TASK_GET_PREDECESSOR_ANSWER; + task_data->answer_id = node->pred_id; + XBT_DEBUG("Sending back a 'Get Predecessor Answer' to %s via mailbox '%s': my predecessor is %d", + task_data->issuer_host_name, + task_data->answer_to, task_data->answer_id); + MSG_task_dsend(task, task_data->answer_to, task_free); + break; + + case TASK_NOTIFY: + // someone is telling me that he may be my new predecessor + XBT_DEBUG("Receiving a 'Notify' request from %s", task_data->issuer_host_name); + notify(node, task_data->request_id); + task_free(task); + break; + + case TASK_PREDECESSOR_LEAVING: + // my predecessor is about to quit + XBT_DEBUG("Receiving a 'Predecessor Leaving' message from %s", task_data->issuer_host_name); + // modify my predecessor + set_predecessor(node, task_data->request_id); + task_free(task); + /*TODO : + >> notify my new predecessor + >> send a notify_predecessors !! + */ + break; + + case TASK_SUCCESSOR_LEAVING: + // my successor is about to quit + XBT_DEBUG("Receiving a 'Successor Leaving' message from %s", task_data->issuer_host_name); + // modify my successor FIXME : this should be implicit ? + set_finger(node, 0, task_data->request_id); + task_free(task); + /* TODO + >> notify my new successor + >> update my table & predecessors table */ + break; + + case TASK_FIND_SUCCESSOR_ANSWER: + case TASK_GET_PREDECESSOR_ANSWER: + XBT_DEBUG("Ignoring unexpected task of type %d (%p)", type, task); + task_free(task); + break; + } +} + +/** + * \brief Initializes the current node as the first one of the system. + * \param node the current node + */ +static void create(node_t node) +{ + XBT_DEBUG("Create a new Chord ring..."); + set_predecessor(node, -1); // -1 means that I have no predecessor + print_finger_table(node); +} + +/** + * \brief Makes the current node join the ring, knowing the id of a node + * already in the ring + * \param node the current node + * \param known_id id of a node already in the ring + * \return 1 if the join operation succeeded, 0 otherwise + */ +static int join(node_t node, int known_id) +{ + XBT_INFO("Joining the ring with id %d, knowing node %d", node->id, known_id); + set_predecessor(node, -1); // no predecessor (yet) + + /* + int i; + for (i = 0; i < nb_bits; i++) { + set_finger(node, i, known_id); + } + */ + + int successor_id = remote_find_successor(node, known_id, node->id); + if (successor_id == -1) { + XBT_INFO("Cannot join the ring."); + } + else { + set_finger(node, 0, successor_id); + print_finger_table(node); + } + + return successor_id != -1; +} + +/** + * \brief Makes the current node quit the system + * \param node the current node + */ +static void leave(node_t node) +{ + XBT_DEBUG("Well Guys! I Think it's time for me to quit ;)"); + quit_notify(node, 1); // notify to my successor ( >>> 1 ); + quit_notify(node, -1); // notify my predecessor ( >>> -1); + // TODO ... +} + +/* + * \brief Notifies the successor or the predecessor of the current node + * of the departure + * \param node the current node + * \param to 1 to notify the successor, -1 to notify the predecessor + * FIXME: notify both nodes with only one call + */ +static void quit_notify(node_t node, int to) +{ + /* TODO + task_data_t req_data = xbt_new0(s_task_data_t, 1); + req_data->request_id = node->id; + req_data->successor_id = node->fingers[0].id; + req_data->pred_id = node->pred_id; + req_data->issuer_host_name = MSG_host_get_name(MSG_host_self()); + req_data->answer_to = NULL; + const char* task_name = NULL; + const char* to_mailbox = NULL; + if (to == 1) { // notify my successor + to_mailbox = node->fingers[0].mailbox; + XBT_INFO("Telling my Successor %d about my departure via mailbox %s", + node->fingers[0].id, to_mailbox); + req_data->type = TASK_PREDECESSOR_LEAVING; + } + else if (to == -1) { // notify my predecessor + + if (node->pred_id == -1) { + return; + } + + to_mailbox = node->pred_mailbox; + XBT_INFO("Telling my Predecessor %d about my departure via mailbox %s", + node->pred_id, to_mailbox); + req_data->type = TASK_SUCCESSOR_LEAVING; + } + m_task_t task = MSG_task_create(NULL, COMP_SIZE, COMM_SIZE, req_data); + //char* mailbox = get_mailbox(to_mailbox); + msg_comm_t comm = MSG_task_isend(task, to_mailbox); + xbt_dynar_push(node->comms, &comm); + */ +} + +/** + * \brief Makes the current node find the successor node of an id. + * \param node the current node + * \param id the id to find + * \return the id of the successor node, or -1 if the request failed + */ +static int find_successor(node_t node, int id) +{ + // is my successor the successor? + if (is_in_interval(id, node->id + 1, node->fingers[0].id)) { + return node->fingers[0].id; + } + + // otherwise, ask the closest preceding finger in my table + int closest = closest_preceding_node(node, id); + return remote_find_successor(node, closest, id); +} + +/** + * \brief Asks another node the successor node of an id. + * \param node the current node + * \param ask_to the node to ask to + * \param id the id to find + * \return the id of the successor node, or -1 if the request failed + */ +static int remote_find_successor(node_t node, int ask_to, int id) +{ + int successor = -1; + int stop = 0; + char mailbox[MAILBOX_NAME_SIZE]; + get_mailbox(ask_to, mailbox); + task_data_t req_data = xbt_new0(s_task_data_t, 1); + req_data->type = TASK_FIND_SUCCESSOR; + req_data->request_id = id; + get_mailbox(node->id, req_data->answer_to); + req_data->issuer_host_name = MSG_host_get_name(MSG_host_self()); + + // send a "Find Successor" request to ask_to_id + m_task_t task_sent = MSG_task_create(NULL, COMP_SIZE, COMM_SIZE, req_data); + XBT_DEBUG("Sending a 'Find Successor' request (task %p) to %d for id %d", task_sent, ask_to, id); + MSG_error_t res = MSG_task_send_with_timeout(task_sent, mailbox, timeout); + + if (res != MSG_OK) { + XBT_DEBUG("Failed to send the 'Find Successor' request (task %p) to %d for id %d", + task_sent, ask_to, id); + task_free(task_sent); + } + else { + + // receive the answer + XBT_DEBUG("Sent a 'Find Successor' request (task %p) to %d for key %d, waiting for the answer", + task_sent, ask_to, id); + + do { + if (node->comm_receive == NULL) { + m_task_t task_received = NULL; + node->comm_receive = MSG_task_irecv(&task_received, node->mailbox); + } + + res = MSG_comm_wait(node->comm_receive, timeout); + + if (res != MSG_OK) { + XBT_DEBUG("Failed to receive the answer to my 'Find Successor' request (task %p): %d", + task_sent, res); + stop = 1; + MSG_comm_destroy(node->comm_receive); + node->comm_receive = NULL; + } + else { + m_task_t task_received = MSG_comm_get_task(node->comm_receive); + XBT_DEBUG("Received a task (%p)", task_received); + task_data_t ans_data = MSG_task_get_data(task_received); + + if (MC_IS_ENABLED) { + MC_assert_stateful(task_received == task_sent); + } + + if (task_received != task_sent) { + // this is not the expected answer + MSG_comm_destroy(node->comm_receive); + node->comm_receive = NULL; + handle_task(node, task_received); + } + else { + // this is our answer + XBT_DEBUG("Received the answer to my 'Find Successor' request for id %d (task %p): the successor of key %d is %d", + ans_data->request_id, task_received, id, ans_data->answer_id); + successor = ans_data->answer_id; + stop = 1; + MSG_comm_destroy(node->comm_receive); + node->comm_receive = NULL; + task_free(task_received); + } + } + } while (!stop); + } + + return successor; +} + +/** + * \brief Asks another node its predecessor. + * \param node the current node + * \param ask_to the node to ask to + * \return the id of its predecessor node, or -1 if the request failed + * (or if the node does not know its predecessor) + */ +static int remote_get_predecessor(node_t node, int ask_to) +{ + int predecessor_id = -1; + int stop = 0; + char mailbox[MAILBOX_NAME_SIZE]; + get_mailbox(ask_to, mailbox); + task_data_t req_data = xbt_new0(s_task_data_t, 1); + req_data->type = TASK_GET_PREDECESSOR; + get_mailbox(node->id, req_data->answer_to); + req_data->issuer_host_name = MSG_host_get_name(MSG_host_self()); + + // send a "Get Predecessor" request to ask_to_id + XBT_DEBUG("Sending a 'Get Predecessor' request to %d", ask_to); + m_task_t task_sent = MSG_task_create(NULL, COMP_SIZE, COMM_SIZE, req_data); + MSG_error_t res = MSG_task_send_with_timeout(task_sent, mailbox, timeout); + + if (res != MSG_OK) { + XBT_DEBUG("Failed to send the 'Get Predecessor' request (task %p) to %d", + task_sent, ask_to); + task_free(task_sent); + } + else { + + // receive the answer + XBT_DEBUG("Sent 'Get Predecessor' request (task %p) to %d, waiting for the answer on my mailbox '%s'", + task_sent, ask_to, req_data->answer_to); + + do { + if (node->comm_receive == NULL) { // FIXME simplify this + m_task_t task_received = NULL; + node->comm_receive = MSG_task_irecv(&task_received, node->mailbox); + } + + res = MSG_comm_wait(node->comm_receive, timeout); + + if (res != MSG_OK) { + XBT_DEBUG("Failed to receive the answer to my 'Get Predecessor' request (task %p): %d", + task_sent, res); + stop = 1; + MSG_comm_destroy(node->comm_receive); + node->comm_receive = NULL; + } + else { + m_task_t task_received = MSG_comm_get_task(node->comm_receive); + task_data_t ans_data = MSG_task_get_data(task_received); + + if (MC_IS_ENABLED) { + MC_assert_stateful(task_received == task_sent); + } + + if (task_received != task_sent) { + MSG_comm_destroy(node->comm_receive); + node->comm_receive = NULL; + handle_task(node, task_received); + } + else { + XBT_DEBUG("Received the answer to my 'Get Predecessor' request (task %p): the predecessor of node %d is %d", + task_received, ask_to, ans_data->answer_id); + predecessor_id = ans_data->answer_id; + stop = 1; + MSG_comm_destroy(node->comm_receive); + node->comm_receive = NULL; + task_free(task_received); + } + } + } while (!stop); + } + + return predecessor_id; +} + +/** + * \brief Returns the closest preceding finger of an id + * with respect to the finger table of the current node. + * \param node the current node + * \param id the id to find + * \return the closest preceding finger of that id + */ +int closest_preceding_node(node_t node, int id) +{ + int i; + for (i = nb_bits - 1; i >= 0; i--) { + if (is_in_interval(node->fingers[i].id, node->id + 1, id - 1)) { + return node->fingers[i].id; + } + } + return node->id; +} + +/** + * \brief This function is called periodically. It checks the immediate + * successor of the current node. + * \param node the current node + */ +static void stabilize(node_t node) +{ + XBT_DEBUG("Stabilizing node"); + + // get the predecessor of my immediate successor + int candidate_id; + int successor_id = node->fingers[0].id; + if (successor_id != node->id) { + candidate_id = remote_get_predecessor(node, successor_id); + } + else { + candidate_id = node->pred_id; + } + + // this node is a candidate to become my new successor + if (candidate_id != -1 + && is_in_interval(candidate_id, node->id + 1, successor_id - 1)) { + set_finger(node, 0, candidate_id); + } + if (successor_id != node->id) { + remote_notify(node, successor_id, node->id); + } +} + +/** + * \brief Notifies the current node that its predecessor may have changed. + * \param node the current node + * \param candidate_id the possible new predecessor + */ +static void notify(node_t node, int predecessor_candidate_id) { + + if (node->pred_id == -1 + || is_in_interval(predecessor_candidate_id, node->pred_id + 1, node->id - 1)) { + + set_predecessor(node, predecessor_candidate_id); + print_finger_table(node); + } + else { + XBT_DEBUG("I don't have to change my predecessor to %d", predecessor_candidate_id); + } +} + +/** + * \brief Notifies a remote node that its predecessor may have changed. + * \param node the current node + * \param notify_id id of the node to notify + * \param candidate_id the possible new predecessor + */ +static void remote_notify(node_t node, int notify_id, int predecessor_candidate_id) { + + task_data_t req_data = xbt_new0(s_task_data_t, 1); + req_data->type = TASK_NOTIFY; + req_data->request_id = predecessor_candidate_id; + req_data->issuer_host_name = MSG_host_get_name(MSG_host_self()); + + // send a "Notify" request to notify_id + m_task_t task = MSG_task_create(NULL, COMP_SIZE, COMM_SIZE, req_data); + XBT_DEBUG("Sending a 'Notify' request (task %p) to %d", task, notify_id); + char mailbox[MAILBOX_NAME_SIZE]; + get_mailbox(notify_id, mailbox); + MSG_task_dsend(task, mailbox, task_free); +} + +/** + * \brief This function is called periodically. + * It refreshes the finger table of the current node. + * \param node the current node + */ +static void fix_fingers(node_t node) { + + XBT_DEBUG("Fixing fingers"); + int i = node->next_finger_to_fix; + int id = find_successor(node, node->id + powers2[i]); + if (id != -1) { + + if (id != node->fingers[i].id) { + set_finger(node, i, id); + print_finger_table(node); + } + node->next_finger_to_fix = (i + 1) % nb_bits; + } +} + +/** + * \brief This function is called periodically. + * It checks whether the predecessor has failed + * \param node the current node + */ +static void check_predecessor(node_t node) +{ + XBT_DEBUG("Checking whether my predecessor is alive"); + // TODO +} + +/** + * \brief Performs a find successor request to a random id. + * \param node the current node + */ +static void random_lookup(node_t node) +{ + int id = 1337; // TODO pick a pseudorandom id + XBT_DEBUG("Making a lookup request for id %d", id); + find_successor(node, id); +} + +/** + * \brief Main function. + */ +int main(int argc, char *argv[]) +{ + xbt_os_timer_t timer = xbt_os_timer_new(); + + if (argc < 3) { + printf("Usage: %s [-nb_bits=n] [-timeout=t] platform_file deployment_file\n", argv[0]); + printf("example: %s ../msg_platform.xml chord.xml\n", argv[0]); + exit(1); + } + + MSG_global_init(&argc, argv); + + char **options = &argv[1]; + while (!strncmp(options[0], "-", 1)) { + + int length = strlen("-nb_bits="); + if (!strncmp(options[0], "-nb_bits=", length) && strlen(options[0]) > length) { + nb_bits = atoi(options[0] + length); + XBT_DEBUG("Set nb_bits to %d", nb_bits); + } + else { + + length = strlen("-timeout="); + if (!strncmp(options[0], "-timeout=", length) && strlen(options[0]) > length) { + timeout = atoi(options[0] + length); + XBT_DEBUG("Set timeout to %d", timeout); + } + else { + xbt_die("Invalid chord option '%s'", options[0]); + } + } + options++; + } + + const char* platform_file = options[0]; + const char* application_file = options[1]; + + chord_initialize(); + + MSG_set_channel_number(0); + MSG_create_environment(platform_file); + + MSG_function_register("node", node); + MSG_launch_application(application_file); + + xbt_os_timer_start(timer); + MSG_error_t res = MSG_main_stateful(); + xbt_os_timer_stop(timer); + XBT_CRITICAL("Simulation time %lf, messages created: %ld", xbt_os_timer_elapsed(timer), smx_total_comms); + XBT_INFO("Simulated time: %g", MSG_get_clock()); + + MSG_clean(); + + if (res == MSG_OK) + return 0; + else + return 1; +} diff --git a/examples/msg/mc/CMakeLists.txt b/examples/msg/mc/CMakeLists.txt index f1daa84a49..d8ac83f5cd 100644 --- a/examples/msg/mc/CMakeLists.txt +++ b/examples/msg/mc/CMakeLists.txt @@ -5,6 +5,7 @@ set(EXECUTABLE_OUTPUT_PATH "${CMAKE_CURRENT_BINARY_DIR}") add_executable(centralized centralized_mutex.c) add_executable(bugged1 bugged1.c) add_executable(bugged1_stateful bugged1_stateful.c) +add_executable(bugged2_stateful bugged2_stateful.c) add_executable(bugged2 bugged2.c) add_executable(bugged3 bugged3.c) add_executable(random_test random_test.c) @@ -13,6 +14,7 @@ add_executable(example_automaton automaton.c automatonparse_promela.c example_au target_link_libraries(centralized simgrid m ) target_link_libraries(bugged1 simgrid m ) target_link_libraries(bugged1_stateful simgrid m) +target_link_libraries(bugged2_stateful simgrid m) target_link_libraries(bugged2 simgrid m ) target_link_libraries(bugged3 simgrid m ) target_link_libraries(random_test simgrid m ) diff --git a/examples/msg/mc/example_automaton.c b/examples/msg/mc/example_automaton.c index deb1129565..a45c3f8f0f 100644 --- a/examples/msg/mc/example_automaton.c +++ b/examples/msg/mc/example_automaton.c @@ -59,7 +59,7 @@ int server(int argc, char *argv[]) //XBT_INFO("r (server) = %d", r); } - MC_assert_pair_stateful(atoi(MSG_task_get_name(task)) == 3); + MC_assert_pair_stateless(atoi(MSG_task_get_name(task)) == 3); XBT_INFO("OK"); return 0; @@ -108,7 +108,7 @@ int main(int argc, char **argv){ //XBT_INFO("r=%d", r); - MSG_main_liveness_stateful(automaton); + MSG_main_liveness_stateless(automaton); MSG_clean(); diff --git a/src/mc/mc_global.c b/src/mc/mc_global.c index 68d6453533..addfdbbcc4 100644 --- a/src/mc/mc_global.c +++ b/src/mc/mc_global.c @@ -106,7 +106,7 @@ void MC_init_liveness_stateful(xbt_automaton_t a){ /* Initialize statistics */ mc_stats_pair = xbt_new0(s_mc_stats_pair_t, 1); - mc_stats = xbt_new0(s_mc_stats_t, 1); + //mc_stats = xbt_new0(s_mc_stats_t, 1); XBT_DEBUG("Creating snapshot_stack"); @@ -136,7 +136,7 @@ void MC_init_liveness_stateless(xbt_automaton_t a){ /* Initialize statistics */ mc_stats_pair = xbt_new0(s_mc_stats_pair_t, 1); - XBT_DEBUG("Creating snapshot_stack"); + XBT_DEBUG("Creating stack"); /* Create exploration stack */ mc_stack_liveness_stateless = xbt_fifo_new(); @@ -144,6 +144,8 @@ void MC_init_liveness_stateless(xbt_automaton_t a){ MC_UNSET_RAW_MEM; MC_ddfs_stateless_init(a); + + } @@ -281,6 +283,57 @@ void MC_replay(xbt_fifo_t stack) XBT_DEBUG("**** End Replay ****"); } +void MC_replay_liveness(xbt_fifo_t stack) +{ + int value; + char *req_str; + smx_req_t req = NULL, saved_req = NULL; + xbt_fifo_item_t item; + mc_state_t state; + mc_pair_stateless_t pair; + + XBT_DEBUG("**** Begin Replay ****"); + + /* Restore the initial state */ + MC_restore_snapshot(initial_snapshot); + /* At the moment of taking the snapshot the raw heap was set, so restoring + * it will set it back again, we have to unset it to continue */ + MC_UNSET_RAW_MEM; + + /* Traverse the stack from the initial state and re-execute the transitions */ + for (item = xbt_fifo_get_last_item(stack); + item != xbt_fifo_get_first_item(stack); + item = xbt_fifo_get_prev_item(item)) { + + pair = (mc_pair_stateless_t) xbt_fifo_get_item_content(item); + state = (mc_state_t) pair->graph_state; + saved_req = MC_state_get_executed_request(state, &value); + //XBT_DEBUG("SavedReq->call %u", saved_req->call); + + if(saved_req != NULL){ + /* because we got a copy of the executed request, we have to fetch the + real one, pointed by the request field of the issuer process */ + req = &saved_req->issuer->request; + //XBT_DEBUG("Req->call %u", req->call); + + /* Debug information */ + if(XBT_LOG_ISENABLED(mc_global, xbt_log_priority_debug)){ + req_str = MC_request_to_string(req, value); + XBT_DEBUG("Replay: %s (%p)", req_str, state); + xbt_free(req_str); + } + } + + SIMIX_request_pre(req, value); + MC_wait_for_requests(); + + /* Update statistics */ + mc_stats_pair->visited_pairs++; + } + XBT_DEBUG("**** End Replay ****"); +} + + /** * \brief Dumps the contents of a model-checker's stack and shows the actual * execution trace diff --git a/src/mc/mc_liveness.c b/src/mc/mc_liveness.c index 0e8d494993..eee93052c2 100644 --- a/src/mc/mc_liveness.c +++ b/src/mc/mc_liveness.c @@ -7,6 +7,7 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_liveness, mc, xbt_dynar_t initial_pairs = NULL; int max_pair = 0; xbt_dynar_t reached_pairs; +extern mc_snapshot_t initial_snapshot; mc_pair_t new_pair(mc_snapshot_t sn, mc_state_t sg, xbt_state_t st){ mc_pair_t p = NULL; @@ -21,7 +22,6 @@ mc_pair_t new_pair(mc_snapshot_t sn, mc_state_t sg, xbt_state_t st){ } - int reached(mc_pair_t pair){ char* hash_reached = malloc(sizeof(char)*160); @@ -750,7 +750,7 @@ void set_pair_stateless_reached(mc_pair_stateless_t pair){ void MC_ddfs_stateless_init(xbt_automaton_t a){ XBT_DEBUG("**************************************************"); - XBT_DEBUG("Double-DFS without visited state and with restore snapshot init"); + XBT_DEBUG("Double-DFS stateless init"); XBT_DEBUG("**************************************************"); mc_pair_stateless_t mc_initial_pair; @@ -823,6 +823,10 @@ void MC_ddfs_stateless_init(xbt_automaton_t a){ xbt_fifo_unshift(mc_stack_liveness_stateless, pair_succ); + /* Save the initial state */ + initial_snapshot = xbt_new0(s_mc_snapshot_t, 1); + MC_take_snapshot(initial_snapshot); + MC_UNSET_RAW_MEM; if(cursor == 0){ @@ -834,8 +838,149 @@ void MC_ddfs_stateless_init(xbt_automaton_t a){ } -void MC_ddfs_stateless(xbt_automaton_t a, int search_cycle, int restore){ +void MC_ddfs_stateless(xbt_automaton_t a, int search_cycle, int replay){ + + smx_process_t process = NULL; + + + if(xbt_fifo_size(mc_stack_liveness_stateless) == 0) + return; + + /* Get current state */ + mc_pair_stateless_t current_pair = (mc_pair_stateless_t)xbt_fifo_get_item_content(xbt_fifo_get_first_item(mc_stack_liveness_stateless)); + + XBT_DEBUG("********************* ( Depth = %d, search_cycle = %d )", xbt_fifo_size(mc_stack_liveness_stateless), search_cycle); + XBT_DEBUG("Pair : graph=%p, automaton=%p(%s), %u interleave", current_pair->graph_state, current_pair->automaton_state, current_pair->automaton_state->id,MC_state_interleave_size(current_pair->graph_state)); + + + mc_stats_pair->visited_pairs++; + + int value; + mc_state_t next_graph_state = NULL; + smx_req_t req = NULL; + char *req_str; + + mc_pair_stateless_t pair_succ; + xbt_transition_t transition_succ; + unsigned int cursor; + int res; + + xbt_dynar_t successors; + + mc_pair_stateless_t next_pair; + + while((req = MC_state_get_request(current_pair->graph_state, &value)) != NULL){ + + //XBT_DEBUG("Interleave size %u", MC_state_interleave_size(current_pair->graph_state)); + + /* Debug information */ + if(XBT_LOG_ISENABLED(mc_liveness, xbt_log_priority_debug)){ + req_str = MC_request_to_string(req, value); + XBT_DEBUG("Execute: %s", req_str); + xbt_free(req_str); + } + + //sleep(1); + + MC_state_set_executed_request(current_pair->graph_state, req, value); + + /* Answer the request */ + SIMIX_request_pre(req, value); + + /* Wait for requests (schedules processes) */ + MC_wait_for_requests(); + + + /* Create the new expanded graph_state */ + MC_SET_RAW_MEM; + + next_graph_state = MC_state_pair_new(); + + /* Get enabled process and insert it in the interleave set of the next graph_state */ + xbt_swag_foreach(process, simix_global->process_list){ + if(MC_process_is_enabled(process)){ + MC_state_interleave_process(next_graph_state, process); + } + } + + successors = xbt_dynar_new(sizeof(mc_pair_stateless_t), NULL); + + MC_UNSET_RAW_MEM; + + //xbt_dynar_reset(successors); + + cursor = 0; + + xbt_dynar_foreach(current_pair->automaton_state->out, cursor, transition_succ){ + + res = MC_automaton_evaluate_label(a, transition_succ->label); + + MC_SET_RAW_MEM; + + if((res == 1) || (res == 2)){ // enabled transition in automaton + next_pair = new_pair_stateless(next_graph_state, transition_succ->dst); + xbt_dynar_push(successors, &next_pair); + } + + MC_UNSET_RAW_MEM; + } + + + if(xbt_dynar_length(successors) == 0){ + MC_SET_RAW_MEM; + next_pair = new_pair_stateless(next_graph_state, current_pair->automaton_state); + xbt_dynar_push(successors, &next_pair); + MC_UNSET_RAW_MEM; + + } + + cursor = 0; + + xbt_dynar_foreach(successors, cursor, pair_succ){ + + if((search_cycle == 1) && (reached_stateless(pair_succ) == 1)){ + XBT_INFO("*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*"); + XBT_INFO("| ACCEPTANCE CYCLE |"); + XBT_INFO("*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*"); + XBT_INFO("Counter-example that violates formula :"); + MC_show_stack_liveness_stateless(mc_stack_liveness_stateless); + MC_dump_stack_liveness_stateless(mc_stack_liveness_stateless); + MC_print_statistics_pairs(mc_stats_pair); + exit(0); + } + + mc_stats_pair->executed_transitions++; + MC_SET_RAW_MEM; + xbt_fifo_unshift(mc_stack_liveness_stateless, pair_succ); + MC_UNSET_RAW_MEM; + + + + MC_ddfs_stateless(a, search_cycle, 0); + + if((search_cycle == 0) && (current_pair->automaton_state->type == 1)){ + + set_pair_stateless_reached(current_pair); + XBT_DEBUG("Acceptance pair : graph=%p, automaton=%p(%s)", current_pair->graph_state, current_pair->automaton_state, current_pair->automaton_state->id); + MC_replay_liveness(mc_stack_liveness_stateless); + MC_ddfs_stateless(a, 1, 1); + + } + } + + if(MC_state_interleave_size(current_pair->graph_state) > 0){ + XBT_DEBUG("Backtracking to depth %u", xbt_fifo_size(mc_stack_liveness_stateless)); + MC_replay_liveness(mc_stack_liveness_stateless); + } + } + + + MC_SET_RAW_MEM; + xbt_fifo_shift(mc_stack_liveness_stateless); + XBT_DEBUG("Pair (graph=%p, automaton =%p) shifted in stack", current_pair->graph_state, current_pair->automaton_state); + MC_UNSET_RAW_MEM; + } diff --git a/src/mc/private.h b/src/mc/private.h index ff72bba5ac..e9428c2221 100644 --- a/src/mc/private.h +++ b/src/mc/private.h @@ -46,6 +46,7 @@ extern double *mc_time; int MC_deadlock_check(void); void MC_replay(xbt_fifo_t stack); +void MC_replay_liveness(xbt_fifo_t stack); void MC_wait_for_requests(void); void MC_get_enabled_processes(); void MC_show_deadlock(smx_req_t req); @@ -233,7 +234,7 @@ extern xbt_fifo_t mc_stack_liveness_stateless; mc_pair_stateless_t new_pair_stateless(mc_state_t sg, xbt_state_t st); void MC_ddfs_stateless_init(xbt_automaton_t a); -void MC_ddfs_stateless(xbt_automaton_t a, int search_cycle, int restore); +void MC_ddfs_stateless(xbt_automaton_t a, int search_cycle, int replay); int reached_stateless(mc_pair_stateless_t p); void set_pair_stateless_reached(mc_pair_stateless_t p); void MC_show_stack_liveness_stateless(xbt_fifo_t stack);