From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Sat, 28 Oct 2017 16:56:12 +0000 (+0200)
Subject: Sonar: make overridden methods virtual.
X-Git-Tag: v3.18~242^2~75
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/ae8ac21191cac33b0b16c0c6efa6bd5d17ff240c

Sonar: make overridden methods virtual.
---

diff --git a/src/smpi/include/smpi_comm.hpp b/src/smpi/include/smpi_comm.hpp
index ed621f1a98..86f00b24f7 100644
--- a/src/smpi/include/smpi_comm.hpp
+++ b/src/smpi/include/smpi_comm.hpp
@@ -58,7 +58,7 @@ class Comm : public F2C, public Keyval{
     static void destroy(MPI_Comm comm);
     void init_smp();
 
-    int add_f();
+    int add_f() override;
     static void free_f(int id);
     static Comm* f2c(int);
 
diff --git a/src/smpi/include/smpi_f2c.hpp b/src/smpi/include/smpi_f2c.hpp
index 207c699c4f..03d8908047 100644
--- a/src/smpi/include/smpi_f2c.hpp
+++ b/src/smpi/include/smpi_f2c.hpp
@@ -33,10 +33,12 @@ class F2C {
     static void delete_lookup();
     static std::unordered_map<std::string, F2C*>* lookup();
 
+    virtual ~F2C() = default;
+
     //Override these to handle specific values.
-    int add_f();
+    virtual int add_f();
     static void free_f(int id);
-    int c2f();
+    virtual int c2f();
 
     // This method should be overridden in all subclasses to avoid casting the result when calling it.
     // For the default one, the MPI_*_NULL returned is assumed to be NULL.
diff --git a/src/smpi/include/smpi_request.hpp b/src/smpi/include/smpi_request.hpp
index 5a11b2d009..f6c69ac21f 100644
--- a/src/smpi/include/smpi_request.hpp
+++ b/src/smpi/include/smpi_request.hpp
@@ -91,7 +91,7 @@ class Request : public F2C {
     static int match_send(void* a, void* b, simgrid::kernel::activity::CommImpl* ignored);
     static int match_recv(void* a, void* b, simgrid::kernel::activity::CommImpl* ignored);
 
-    int add_f();
+    int add_f() override;
     static void free_f(int id);
     static Request* f2c(int);