From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Fri, 12 Feb 2021 11:36:23 +0000 (+0100)
Subject: Add some comments about unexpected failures.
X-Git-Tag: v3.27~397
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/aba961ae5e8c0f92bc3e7b6b4a9a6f4d13173ea3

Add some comments about unexpected failures.
---

diff --git a/teshsuite/s4u/activity-lifecycle/testing_test-wait.cpp b/teshsuite/s4u/activity-lifecycle/testing_test-wait.cpp
index 76f8135218..0e15dcd1e3 100644
--- a/teshsuite/s4u/activity-lifecycle/testing_test-wait.cpp
+++ b/teshsuite/s4u/activity-lifecycle/testing_test-wait.cpp
@@ -298,24 +298,34 @@ TEST_CASE("Activity test/wait: tests currently failing", "[.][failing]")
   XBT_INFO("#####[ launch next failing test ]#####");
 
   // with tester_wait<0>
+  // -> wait_for() should return immediately and signal a timeout (timeout == 0)
   RUN_SECTION("exec: run and wait<0> many", test_basic<ExecPtr, create_exec, tester_wait<0>>);
+  // -> wait_for() should return immediately and signal a timeout (timeout == 0)
   RUN_SECTION("exec: actor failure and wait<0> / sleep",
               test_failure_actor<ExecPtr, create_exec, tester_wait<0>, waiter_sleep6>);
+  // -> wait_for() should return immediately and signal a timeout (timeout == 0)
   RUN_SECTION("exec: host failure and wait<0> / sleep",
               test_failure_host<ExecPtr, create_exec, tester_wait<0>, waiter_sleep6>);
+  // -> wait_for() should return immediately and signal a timeout (timeout == 0)
   RUN_SECTION("exec: actor failure and wait<0> / wait",
               test_failure_actor<ExecPtr, create_exec, tester_wait<0>, waiter_wait>);
+  // -> wait_for() should return immediately and signal a timeout (timeout == 0)
   RUN_SECTION("exec: host failure and wait<0> / wait",
               test_failure_host<ExecPtr, create_exec, tester_wait<0>, waiter_wait>);
 
   // with tester_wait<1>
+  // -> second call to wait_for() should wait for timeuout and not return immediately
   RUN_SECTION("exec: run and wait<1> many", test_basic<ExecPtr, create_exec, tester_wait<1>>);
+  // -> second call to wait_for() should report a failure, and not a timeout
   RUN_SECTION("exec: actor failure and wait<1> / sleep",
               test_failure_actor<ExecPtr, create_exec, tester_wait<1>, waiter_sleep6>);
+  // -> second call to wait_for() should report a failure, and not a timeout
   RUN_SECTION("exec: host failure and wait<1> / sleep",
               test_failure_host<ExecPtr, create_exec, tester_wait<1>, waiter_sleep6>);
+  // -> actor should not be killed by TimeoutException
   RUN_SECTION("exec: actor failure and wait<1> / wait",
               test_failure_actor<ExecPtr, create_exec, tester_wait<1>, waiter_wait>);
+  // -> actor should not be killed by TimeoutException
   RUN_SECTION("exec: host failure and wait<1> / wait",
               test_failure_host<ExecPtr, create_exec, tester_wait<1>, waiter_wait>);