From: Augustin Degomme <adegomme@users.noreply.github.com>
Date: Wed, 1 May 2019 12:51:11 +0000 (+0200)
Subject: get out before dereferencing null pointer in this case
X-Git-Tag: v3.22.2~15
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/93eb67e63855e061dfbbffe2a691e45cd5269d87?ds=sidebyside

get out before dereferencing null pointer in this case
---

diff --git a/src/smpi/mpi/smpi_comm.cpp b/src/smpi/mpi/smpi_comm.cpp
index 6baa55961e..5bdf88d4f5 100644
--- a/src/smpi/mpi/smpi_comm.cpp
+++ b/src/smpi/mpi/smpi_comm.cpp
@@ -98,6 +98,8 @@ int Comm::dup(MPI_Comm* newcomm){
 
 int Comm::dup_with_info(MPI_Info info, MPI_Comm* newcomm){
   int ret = dup(newcomm);
+  if(ret != MPI_SUCCESS)
+    return ret;
   if((*newcomm)->info_!=MPI_INFO_NULL){
     simgrid::smpi::Info::unref((*newcomm)->info_);
     (*newcomm)->info_=MPI_INFO_NULL;