From: degomme <augustin.degomme@unibas.ch>
Date: Thu, 16 Feb 2017 09:33:08 +0000 (+0100)
Subject: Avoid overflowing in the MPI_Prod version by using larger datatype
X-Git-Tag: v3_15~344^2~3
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/93b0e262565ee62951b93582814854aafd37aab9?hp=ad465a6f2ab399c98418b92d4976a35a9288767b

Avoid overflowing in the MPI_Prod version by using larger datatype
---

diff --git a/teshsuite/smpi/coll-reduce/coll-reduce.c b/teshsuite/smpi/coll-reduce/coll-reduce.c
index 9543c53bee..b7da72ae68 100644
--- a/teshsuite/smpi/coll-reduce/coll-reduce.c
+++ b/teshsuite/smpi/coll-reduce/coll-reduce.c
@@ -19,16 +19,16 @@ int main(int argc, char *argv[])
 {
   int rank, size;
   int i;
-  long int *sb;
-  long int *rb;
+  unsigned long long *sb;
+  unsigned long long *rb;
   int status;
 
   MPI_Init(&argc, &argv);
   MPI_Comm_rank(MPI_COMM_WORLD, &rank);
   MPI_Comm_size(MPI_COMM_WORLD, &size);
 
-  sb = (long int *) xbt_malloc(size * sizeof(long int));
-  rb = (long int *) xbt_malloc(size * sizeof(long int));
+  sb = (unsigned long long *) xbt_malloc(size * sizeof(unsigned long long));
+  rb = (unsigned long long *) xbt_malloc(size * sizeof(unsigned long long));
 
   for (i = 0; i < size; ++i) {
     sb[i] = rank*size + i;
@@ -36,17 +36,17 @@ int main(int argc, char *argv[])
   }
   printf("[%d] sndbuf=[", rank);
   for (i = 0; i < size; i++)
-    printf("%ld ", sb[i]);
+    printf("%llu ", sb[i]);
   printf("]\n");
 
   int root=0;
-  status = MPI_Reduce(sb, rb, size, MPI_LONG, MPI_SUM, root, MPI_COMM_WORLD);
+  status = MPI_Reduce(sb, rb, size, MPI_UNSIGNED_LONG_LONG, MPI_SUM, root, MPI_COMM_WORLD);
   MPI_Barrier(MPI_COMM_WORLD);
 
   if (rank == root) {
     printf("[%d] rcvbuf=[", rank);
     for (i = 0; i < size; i++)
-      printf("%ld ", rb[i]);
+      printf("%llu ", rb[i]);
     printf("]\n");
     if (status != MPI_SUCCESS) {
       printf("all_to_all returned %d\n", status);
@@ -56,17 +56,17 @@ int main(int argc, char *argv[])
 
   printf("[%d] second sndbuf=[", rank);
   for (i = 0; i < 1; i++)
-    printf("%ld ", sb[i]);
+    printf("%llu ", sb[i]);
   printf("]\n");
 
   root=size-1;
-  status = MPI_Reduce(sb, rb, 1, MPI_LONG, MPI_PROD, root, MPI_COMM_WORLD);
+  status = MPI_Reduce(sb, rb, 1, MPI_UNSIGNED_LONG_LONG, MPI_PROD, root, MPI_COMM_WORLD);
   MPI_Barrier(MPI_COMM_WORLD);
 
   if (rank == root) {
     printf("[%d] rcvbuf=[", rank);
     for (i = 0; i < 1; i++)
-      printf("%ld ", rb[i]);
+      printf("%llu ", rb[i]);
     printf("]\n");
     if (status != MPI_SUCCESS) {
       printf("all_to_all returned %d\n", status);