From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Tue, 21 Nov 2017 13:50:23 +0000 (+0100)
Subject: Sonar: constructors should only call non-overridable methods.
X-Git-Tag: v3.18~272^2~3^2~3
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/84062f0184ab0822e1dfa87740a0a73ceff0883d

Sonar: constructors should only call non-overridable methods.
---

diff --git a/src/surf/StorageImpl.cpp b/src/surf/StorageImpl.cpp
index 51d1368a93..cc888ddd19 100644
--- a/src/surf/StorageImpl.cpp
+++ b/src/surf/StorageImpl.cpp
@@ -68,7 +68,7 @@ StorageImpl::StorageImpl(Model* model, std::string name, lmm_system_t maxminSyst
     , attach_(attach)
 {
   content_ = parseContent(content_name);
-  turnOn();
+  StorageImpl::turnOn();
   XBT_DEBUG("Create resource with Bread '%f' Bwrite '%f' and Size '%llu'", bread, bwrite, size);
   constraintRead_  = lmm_constraint_new(maxminSystem, this, bread);
   constraintWrite_ = lmm_constraint_new(maxminSystem, this, bwrite);
diff --git a/src/surf/network_cm02.cpp b/src/surf/network_cm02.cpp
index bd5b18af45..c7b6abcc47 100644
--- a/src/surf/network_cm02.cpp
+++ b/src/surf/network_cm02.cpp
@@ -150,7 +150,7 @@ NetworkCm02Model::NetworkCm02Model()
   }
 
   maxminSystem_ = lmm_system_new(selectiveUpdate_);
-  loopback_     = createLink("__loopback__", 498000000, 0.000015, SURF_LINK_FATPIPE);
+  loopback_     = NetworkCm02Model::createLink("__loopback__", 498000000, 0.000015, SURF_LINK_FATPIPE);
 
   if (getUpdateMechanism() == UM_LAZY) {
     modifiedSet_ = new ActionLmmList();
diff --git a/src/surf/ptask_L07.cpp b/src/surf/ptask_L07.cpp
index c62664e6e0..bc65a38011 100644
--- a/src/surf/ptask_L07.cpp
+++ b/src/surf/ptask_L07.cpp
@@ -65,7 +65,7 @@ NetworkL07Model::NetworkL07Model(HostL07Model *hmodel, lmm_system_t sys)
   , hostModel_(hmodel)
 {
   maxminSystem_ = sys;
-  loopback_     = createLink("__loopback__", 498000000, 0.000015, SURF_LINK_FATPIPE);
+  loopback_     = NetworkL07Model::createLink("__loopback__", 498000000, 0.000015, SURF_LINK_FATPIPE);
 }
 
 NetworkL07Model::~NetworkL07Model()