From: Arnaud Giersch Date: Mon, 15 Apr 2019 12:32:52 +0000 (+0200) Subject: [sonar] Remove custom destructors for routing/DragonflyZone. X-Git-Tag: v3.22.2~120 X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/7b4d2c4a1c1c667a0a5676dff5dffe6cb6b8aced?ds=inline [sonar] Remove custom destructors for routing/DragonflyZone. --- diff --git a/include/simgrid/kernel/routing/DragonflyZone.hpp b/include/simgrid/kernel/routing/DragonflyZone.hpp index f8052992ce..9144e16a61 100644 --- a/include/simgrid/kernel/routing/DragonflyZone.hpp +++ b/include/simgrid/kernel/routing/DragonflyZone.hpp @@ -18,14 +18,11 @@ public: unsigned int group_; unsigned int chassis_; unsigned int blade_; - resource::LinkImpl** blue_links_ = nullptr; - resource::LinkImpl** black_links_ = nullptr; - resource::LinkImpl** green_links_ = nullptr; - resource::LinkImpl** my_nodes_ = nullptr; - DragonflyRouter(int i, int j, int k); - DragonflyRouter(const DragonflyRouter&) = delete; - DragonflyRouter& operator=(const DragonflyRouter&) = delete; - ~DragonflyRouter(); + resource::LinkImpl* blue_link_ = nullptr; + std::vector black_links_; + std::vector green_links_; + std::vector my_nodes_; + DragonflyRouter(unsigned group, unsigned chassis, unsigned blade) : group_(group), chassis_(chassis), blade_(blade) {} }; /** @ingroup ROUTING_API @@ -64,9 +61,6 @@ public: class XBT_PUBLIC DragonflyZone : public ClusterZone { public: explicit DragonflyZone(NetZoneImpl* father, const std::string& name, resource::NetworkModel* netmodel); - DragonflyZone(const DragonflyZone&) = delete; - DragonflyZone& operator=(const DragonflyZone&) = delete; - ~DragonflyZone() override; // void create_links_for_node(sg_platf_cluster_cbarg_t cluster, int id, int rank, int position) override; void get_local_route(NetPoint* src, NetPoint* dst, RouteCreationArgs* into, double* latency) override; void parse_specific_arguments(ClusterCreationArgs* cluster) override; @@ -91,7 +85,7 @@ private: unsigned int num_links_black_ = 0; unsigned int num_links_blue_ = 0; unsigned int num_links_per_link_ = 1; // splitduplex -> 2, only for local link - DragonflyRouter** routers_ = nullptr; + std::vector routers_; }; } // namespace routing } // namespace kernel diff --git a/src/kernel/routing/DragonflyZone.cpp b/src/kernel/routing/DragonflyZone.cpp index 68235e4bb2..911f9506d6 100644 --- a/src/kernel/routing/DragonflyZone.cpp +++ b/src/kernel/routing/DragonflyZone.cpp @@ -23,15 +23,6 @@ DragonflyZone::DragonflyZone(NetZoneImpl* father, const std::string& name, resou { } -DragonflyZone::~DragonflyZone() -{ - if (this->routers_ != nullptr) { - for (unsigned int i = 0; i < this->num_groups_ * this->num_chassis_per_group_ * this->num_blades_per_chassis_; i++) - delete routers_[i]; - delete[] routers_; - } -} - void DragonflyZone::rankId_to_coords(int rankId, unsigned int coords[4]) { // coords : group, chassis, blade, node @@ -132,32 +123,13 @@ void DragonflyZone::seal() this->generate_links(); } -DragonflyRouter::DragonflyRouter(int group, int chassis, int blade) : group_(group), chassis_(chassis), blade_(blade) -{ -} - -DragonflyRouter::~DragonflyRouter() -{ - delete[] my_nodes_; - delete[] green_links_; - delete[] black_links_; - delete blue_links_; -} - void DragonflyZone::generate_routers() { - this->routers_ = - new DragonflyRouter*[this->num_groups_ * this->num_chassis_per_group_ * this->num_blades_per_chassis_]; - - for (unsigned int i = 0; i < this->num_groups_; i++) { - for (unsigned int j = 0; j < this->num_chassis_per_group_; j++) { - for (unsigned int k = 0; k < this->num_blades_per_chassis_; k++) { - DragonflyRouter* router = new DragonflyRouter(i, j, k); - this->routers_[i * this->num_chassis_per_group_ * this->num_blades_per_chassis_ + - j * this->num_blades_per_chassis_ + k] = router; - } - } - } + this->routers_.reserve(this->num_groups_ * this->num_chassis_per_group_ * this->num_blades_per_chassis_); + for (unsigned int i = 0; i < this->num_groups_; i++) + for (unsigned int j = 0; j < this->num_chassis_per_group_; j++) + for (unsigned int k = 0; k < this->num_blades_per_chassis_; k++) + this->routers_.emplace_back(i, j, k); } void DragonflyZone::create_link(const std::string& id, int numlinks, resource::LinkImpl** linkup, @@ -194,18 +166,18 @@ void DragonflyZone::generate_links() // Links from routers to their local nodes. for (unsigned int i = 0; i < numRouters; i++) { // allocate structures - this->routers_[i]->my_nodes_ = new resource::LinkImpl*[num_links_per_link_ * this->num_nodes_per_blade_]; - this->routers_[i]->green_links_ = new resource::LinkImpl*[this->num_blades_per_chassis_]; - this->routers_[i]->black_links_ = new resource::LinkImpl*[this->num_chassis_per_group_]; + this->routers_[i].my_nodes_.resize(num_links_per_link_ * this->num_nodes_per_blade_); + this->routers_[i].green_links_.resize(this->num_blades_per_chassis_); + this->routers_[i].black_links_.resize(this->num_chassis_per_group_); for (unsigned int j = 0; j < num_links_per_link_ * this->num_nodes_per_blade_; j += num_links_per_link_) { std::string id = "local_link_from_router_" + std::to_string(i) + "_to_node_" + std::to_string(j / num_links_per_link_) + "_" + std::to_string(uniqueId); this->create_link(id, 1, &linkup, &linkdown); - this->routers_[i]->my_nodes_[j] = linkup; + this->routers_[i].my_nodes_[j] = linkup; if (this->sharing_policy_ == s4u::Link::SharingPolicy::SPLITDUPLEX) - this->routers_[i]->my_nodes_[j + 1] = linkdown; + this->routers_[i].my_nodes_[j + 1] = linkdown; uniqueId++; } @@ -219,8 +191,8 @@ void DragonflyZone::generate_links() std::to_string(j) + "_and_" + std::to_string(k) + "_" + std::to_string(uniqueId); this->create_link(id, this->num_links_green_, &linkup, &linkdown); - this->routers_[i * num_blades_per_chassis_ + j]->green_links_[k] = linkup; - this->routers_[i * num_blades_per_chassis_ + k]->green_links_[j] = linkdown; + this->routers_[i * num_blades_per_chassis_ + j].green_links_[k] = linkup; + this->routers_[i * num_blades_per_chassis_ + k].green_links_[j] = linkdown; uniqueId++; } } @@ -236,9 +208,9 @@ void DragonflyZone::generate_links() this->create_link(id, this->num_links_black_, &linkup, &linkdown); this->routers_[i * num_blades_per_chassis_ * num_chassis_per_group_ + j * num_blades_per_chassis_ + l] - ->black_links_[k] = linkup; + .black_links_[k] = linkup; this->routers_[i * num_blades_per_chassis_ * num_chassis_per_group_ + k * num_blades_per_chassis_ + l] - ->black_links_[j] = linkdown; + .black_links_[j] = linkdown; uniqueId++; } } @@ -252,14 +224,12 @@ void DragonflyZone::generate_links() for (unsigned int j = i + 1; j < this->num_groups_; j++) { unsigned int routernumi = i * num_blades_per_chassis_ * num_chassis_per_group_ + j; unsigned int routernumj = j * num_blades_per_chassis_ * num_chassis_per_group_ + i; - this->routers_[routernumi]->blue_links_ = new resource::LinkImpl*; - this->routers_[routernumj]->blue_links_ = new resource::LinkImpl*; std::string id = "blue_link_between_group_"+ std::to_string(i) +"_and_" + std::to_string(j) +"_routers_" + std::to_string(routernumi) + "_and_" + std::to_string(routernumj) + "_" + std::to_string(uniqueId); this->create_link(id, this->num_links_blue_, &linkup, &linkdown); - this->routers_[routernumi]->blue_links_[0] = linkup; - this->routers_[routernumj]->blue_links_[0] = linkdown; + this->routers_[routernumi].blue_link_ = linkup; + this->routers_[routernumj].blue_link_ = linkdown; uniqueId++; } } @@ -293,10 +263,10 @@ void DragonflyZone::get_local_route(NetPoint* src, NetPoint* dst, RouteCreationA XBT_DEBUG("dst : %u group, %u chassis, %u blade, %u node", targetCoords[0], targetCoords[1], targetCoords[2], targetCoords[3]); - DragonflyRouter* myRouter = routers_[myCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + - myCoords[1] * num_blades_per_chassis_ + myCoords[2]]; - DragonflyRouter* targetRouter = routers_[targetCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + - targetCoords[1] * num_blades_per_chassis_ + targetCoords[2]]; + DragonflyRouter* myRouter = &routers_[myCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + + myCoords[1] * num_blades_per_chassis_ + myCoords[2]]; + DragonflyRouter* targetRouter = &routers_[targetCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + + targetCoords[1] * num_blades_per_chassis_ + targetCoords[2]]; DragonflyRouter* currentRouter = myRouter; // node->router local link @@ -319,8 +289,8 @@ void DragonflyZone::get_local_route(NetPoint* src, NetPoint* dst, RouteCreationA route->link_list.push_back(currentRouter->green_links_[targetCoords[0]]); if (latency) *latency += currentRouter->green_links_[targetCoords[0]]->get_latency(); - currentRouter = routers_[myCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + - myCoords[1] * num_blades_per_chassis_ + targetCoords[0]]; + currentRouter = &routers_[myCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + + myCoords[1] * num_blades_per_chassis_ + targetCoords[0]]; } if (currentRouter->chassis_ != 0) { @@ -328,14 +298,14 @@ void DragonflyZone::get_local_route(NetPoint* src, NetPoint* dst, RouteCreationA route->link_list.push_back(currentRouter->black_links_[0]); if (latency) *latency += currentRouter->black_links_[0]->get_latency(); - currentRouter = routers_[myCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + targetCoords[0]]; + currentRouter = &routers_[myCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + targetCoords[0]]; } // go to destination group - the only optical hop - route->link_list.push_back(currentRouter->blue_links_[0]); + route->link_list.push_back(currentRouter->blue_link_); if (latency) - *latency += currentRouter->blue_links_[0]->get_latency(); - currentRouter = routers_[targetCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + myCoords[0]]; + *latency += currentRouter->blue_link_->get_latency(); + currentRouter = &routers_[targetCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + myCoords[0]]; } // same group, but same blade ? @@ -343,7 +313,7 @@ void DragonflyZone::get_local_route(NetPoint* src, NetPoint* dst, RouteCreationA route->link_list.push_back(currentRouter->green_links_[targetCoords[2]]); if (latency) *latency += currentRouter->green_links_[targetCoords[2]]->get_latency(); - currentRouter = routers_[targetCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + targetCoords[2]]; + currentRouter = &routers_[targetCoords[0] * (num_chassis_per_group_ * num_blades_per_chassis_) + targetCoords[2]]; } // same blade, but same chassis ?