From: Augustin Degomme <adegomme@gmail.com>
Date: Thu, 21 Nov 2019 16:16:00 +0000 (+0100)
Subject: Add tolerance for floating point precision comparisons.
X-Git-Tag: v3.25~375^2~1
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/4ec6b8eff9ba82b24a71a062eb8bf7f86a770432

Add tolerance for floating point precision comparisons.
Fails on 32bits if equality is used.
---

diff --git a/src/xbt/random_test.cpp b/src/xbt/random_test.cpp
index d8cee2232a..c964cb861b 100644
--- a/src/xbt/random_test.cpp
+++ b/src/xbt/random_test.cpp
@@ -7,6 +7,7 @@
 #include "xbt/log.h"
 #include "xbt/random.hpp"
 #include <random>
+#include <cmath>
 
 TEST_CASE("xbt::random: Random Number Generation")
 {
@@ -14,10 +15,10 @@ TEST_CASE("xbt::random: Random Number Generation")
   {
     simgrid::xbt::random::set_mersenne_seed(12345);
 
-    REQUIRE(simgrid::xbt::random::exponential(25) == 0.00291934351538427348);
+    REQUIRE(fabs(simgrid::xbt::random::exponential(25) - 0.00291934351538427348) <= 1e-14);
     REQUIRE(simgrid::xbt::random::uniform_int(1, 6) == 4);
-    REQUIRE(simgrid::xbt::random::uniform_real(0, 1) == 0.31637556043369124970);
-    REQUIRE(simgrid::xbt::random::normal(0, 2) == 1.62746784745133976635);
+    REQUIRE(fabs(simgrid::xbt::random::uniform_real(0, 1) - 0.31637556043369124970) <= 1e-14);
+    REQUIRE(fabs(simgrid::xbt::random::normal(0, 2) - 1.62746784745133976635) <= 1e-14);
   }
 
   SECTION("Using XBT_RNG_std")
@@ -33,9 +34,9 @@ TEST_CASE("xbt::random: Random Number Generation")
     std::uniform_real_distribution<> distC(0, 1);
     std::normal_distribution<> distD(0, 2);
 
-    REQUIRE(simgrid::xbt::random::exponential(25) == distA(gen));
+    REQUIRE(fabs(simgrid::xbt::random::exponential(25) - distA(gen)) <= 1e-14);
     REQUIRE(simgrid::xbt::random::uniform_int(1, 6) == distB(gen));
-    REQUIRE(simgrid::xbt::random::uniform_real(0, 1) == distC(gen));
-    REQUIRE(simgrid::xbt::random::normal(0, 2) == distD(gen));
+    REQUIRE(fabs(simgrid::xbt::random::uniform_real(0, 1) - distC(gen)) <= 1e-14);
+    REQUIRE(fabs(simgrid::xbt::random::normal(0, 2) - distD(gen)) <= 1e-14);
   }
 }