From: Martin Quinson Date: Sat, 7 Apr 2018 15:35:41 +0000 (+0200) Subject: various useless cosmetics X-Git-Tag: v3.20~507 X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/38dfe4cc823740a962aa1da0f3be0c40582d7648 various useless cosmetics --- diff --git a/include/simgrid/forward.h b/include/simgrid/forward.h index 15adc03554..11b07d2cea 100644 --- a/include/simgrid/forward.h +++ b/include/simgrid/forward.h @@ -77,9 +77,12 @@ namespace simix { } namespace surf { class Cpu; + class CpuModel; class HostImpl; + class HostModel; class StorageImpl; class StorageType; + class StorageModel; } namespace trace_mgr { class trace; diff --git a/include/simgrid/s4u/Link.hpp b/include/simgrid/s4u/Link.hpp index 120989b33d..81c392938b 100644 --- a/include/simgrid/s4u/Link.hpp +++ b/include/simgrid/s4u/Link.hpp @@ -38,10 +38,7 @@ public: /** @brief Retrieves the name of that link as a C string */ const char* get_cname() const; - XBT_ATTRIB_DEPRECATED_v323("Please use Link::by_name()") static Link* byName(const char* name) - { - return by_name(name); - } + XBT_ATTRIB_DEPRECATED_v323("Please use Link::by_name()") static Link* byName(const char* name) { return by_name(name); } XBT_ATTRIB_DEPRECATED_v323("Please use Link::get_name()") const std::string& getName() const { return get_name(); } XBT_ATTRIB_DEPRECATED_v323("Please use Link::get_cname()") const char* getCname() const { return get_cname(); } diff --git a/src/include/surf/surf.hpp b/src/include/surf/surf.hpp index b43f7b9226..03768f9408 100644 --- a/src/include/surf/surf.hpp +++ b/src/include/surf/surf.hpp @@ -9,16 +9,6 @@ #include "simgrid/forward.h" #include "xbt/graph.h" -namespace simgrid { -namespace surf { -class CpuModel; -class HostModel; -class NetworkModel; -class StorageModel; -class NetworkCm02Link; -} -} - /** \brief Resource model description */ struct surf_model_description { diff --git a/src/kernel/lmm/maxmin.cpp b/src/kernel/lmm/maxmin.cpp index adeee26ea5..b98ae8c321 100644 --- a/src/kernel/lmm/maxmin.cpp +++ b/src/kernel/lmm/maxmin.cpp @@ -202,8 +202,7 @@ void System::variable_mallocator_free_f(void* var) delete static_cast(var); } -Variable* System::variable_new(simgrid::kernel::resource::Action* id, double sharing_weight, double bound, - int number_of_constraints) +Variable* System::variable_new(resource::Action* id, double sharing_weight, double bound, int number_of_constraints) { XBT_IN("(sys=%p, id=%p, weight=%f, bound=%f, num_cons =%d)", this, id, sharing_weight, bound, number_of_constraints); @@ -525,7 +524,7 @@ template void System::lmm_solve(CnstList& cnst_list) cnst.usage = elem.consumption_weight / elem.variable->sharing_weight; elem.make_active(); - simgrid::kernel::resource::Action* action = static_cast(elem.variable->id); + resource::Action* action = static_cast(elem.variable->id); if (modified_set_ && not action->is_within_modified_set()) modified_set_->push_back(*action); } @@ -697,7 +696,7 @@ void System::update_variable_bound(Variable* var, double bound) update_modified_set(var->cnsts[0].constraint); } -void Variable::initialize(simgrid::kernel::resource::Action* id_value, double sharing_weight_value, double bound_value, +void Variable::initialize(resource::Action* id_value, double sharing_weight_value, double bound_value, int number_of_constraints, unsigned visited_value) { id = id_value; diff --git a/src/kernel/lmm/maxmin.hpp b/src/kernel/lmm/maxmin.hpp index 67b6f78216..465930c6f8 100644 --- a/src/kernel/lmm/maxmin.hpp +++ b/src/kernel/lmm/maxmin.hpp @@ -316,7 +316,7 @@ private: */ class XBT_PUBLIC Variable { public: - void initialize(simgrid::kernel::resource::Action * id_value, double sharing_weight_value, double bound_value, + void initialize(resource::Action* id_value, double sharing_weight_value, double bound_value, int number_of_constraints, unsigned visited_value); /** @@ -361,7 +361,7 @@ public: * @brief Get the data associated to a variable * @return The data associated to the variable */ - simgrid::kernel::resource::Action* get_id() const { return id; } + resource::Action* get_id() const { return id; } /** * @brief Get the weight of a variable @@ -394,7 +394,7 @@ public: double bound; double value; short int concurrency_share; /* The maximum number of elements that variable will add to a constraint */ - simgrid::kernel::resource::Action* id; + resource::Action* id; int id_int; unsigned visited; /* used by System::update_modified_set() */ /* \begin{For Lagrange only} */ @@ -443,8 +443,7 @@ public: * @param bound The maximum value of the variable (-1.0 if no maximum value) * @param number_of_constraints The maximum number of constraint to associate to the variable */ - Variable* variable_new(simgrid::kernel::resource::Action * id, double weight_value, double bound, - int number_of_constraints); + Variable* variable_new(resource::Action* id, double weight_value, double bound, int number_of_constraints); /** * @brief Free a variable @@ -584,7 +583,7 @@ public: &Constraint::saturated_constraint_set_hook>> saturated_constraint_set; - simgrid::kernel::resource::Action::ModifiedSet* modified_set_ = nullptr; + resource::Action::ModifiedSet* modified_set_ = nullptr; private: bool selective_update_active; /* flag to update partially the system only selecting changed portions */