From: Martin Quinson <martin.quinson@ens-rennes.fr>
Date: Tue, 5 Mar 2019 06:29:53 +0000 (+0100)
Subject: sonar: pass large parameters as const; don't name unused params
X-Git-Tag: v3_22~180^2~1
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/30c0dd6aa9c864e251eb1496595e05307c965c19

sonar: pass large parameters as const; don't name unused params
---

diff --git a/src/s4u/s4u_Actor.cpp b/src/s4u/s4u_Actor.cpp
index 005dc0bc71..b20d8c6d37 100644
--- a/src/s4u/s4u_Actor.cpp
+++ b/src/s4u/s4u_Actor.cpp
@@ -92,10 +92,10 @@ void Actor::on_exit(int_f_pvoid_pvoid_t fun,
   simgrid::simix::simcall([this, fun, data] { SIMIX_process_on_exit(pimpl_, fun, data); });
 }
 
-void Actor::on_exit(std::function<void(bool /*failed*/)> fun)
+void Actor::on_exit(std::function<void(bool /*failed*/)> const fun)
 {
   simgrid::simix::simcall(
-      [this, fun] { SIMIX_process_on_exit(pimpl_, [fun](int a, void* data) { fun(a != 0); }, nullptr); });
+      [this, fun] { SIMIX_process_on_exit(pimpl_, [fun](int a, void* /*data*/) { fun(a != 0); }, nullptr); });
 }
 
 void Actor::migrate(Host* new_host)
@@ -405,12 +405,12 @@ void exit()
   simgrid::simix::simcall([actor] { actor->exit(); });
 }
 
-void on_exit(std::function<void(bool)> fun)
+void on_exit(std::function<void(bool)> const fun)
 {
   SIMIX_process_self()->iface()->on_exit(fun);
 }
 
-void on_exit(std::function<void(int, void*)> fun, void* data) /* deprecated */
+void on_exit(std::function<void(int, void*)> const fun, void* data) /* deprecated */
 {
   SIMIX_process_self()->iface()->on_exit([fun, data](bool exit) { fun(exit, data); });
 }