From: Arnaud Giersch Date: Wed, 28 Mar 2018 15:57:55 +0000 (+0200) Subject: Remove std::move. X-Git-Tag: v3.20~599 X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/2eb1a8a54c227887b868d199a590e585cb9b84d6?hp=1340b2bc2a098a7e87fa45ff31591d32c864dc7a Remove std::move. According to clang: src/xbt/xbt_replay.cpp:123:38: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] simgrid::xbt::ReplayAction evt(std::move(simgrid::xbt::get_action(argv[0]))); ^ src/xbt/xbt_replay.cpp:123:38: note: remove std::move call here simgrid::xbt::ReplayAction evt(std::move(simgrid::xbt::get_action(argv[0]))); ^~~~~~~~~~ ~ 1 error generated. --- diff --git a/src/xbt/xbt_replay.cpp b/src/xbt/xbt_replay.cpp index b022e52764..23be2f5f1b 100644 --- a/src/xbt/xbt_replay.cpp +++ b/src/xbt/xbt_replay.cpp @@ -120,7 +120,7 @@ int replay_runner(int argc, char* argv[]) { if (simgrid::xbt::action_fs) { // A unique trace file while (true) { - simgrid::xbt::ReplayAction evt(std::move(simgrid::xbt::get_action(argv[0]))); + simgrid::xbt::ReplayAction evt(simgrid::xbt::get_action(argv[0])); if (evt.empty()) break; simgrid::xbt::handle_action(evt);