From: Gabriel Corona Date: Thu, 7 Apr 2016 12:33:42 +0000 (+0200) Subject: [mc] Sort out FIXMEs and TODOs X-Git-Tag: v3_13~128 X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/2203b8d747fab1b5b6dacf2d27b4321455174a03 [mc] Sort out FIXMEs and TODOs --- diff --git a/src/mc/RegionSnapshot.hpp b/src/mc/RegionSnapshot.hpp index 30beff1e20..7a76d7c815 100644 --- a/src/mc/RegionSnapshot.hpp +++ b/src/mc/RegionSnapshot.hpp @@ -29,7 +29,6 @@ enum class RegionType { Data = 2 }; -// TODO, use Boost.Variant instead of this enum class StorageType { NoData = 0, Flat = 1, diff --git a/src/mc/mc_base.cpp b/src/mc/mc_base.cpp index cfd63caaa1..5b7ce3b134 100644 --- a/src/mc/mc_base.cpp +++ b/src/mc/mc_base.cpp @@ -38,7 +38,6 @@ int MC_random(int min, int max) xbt_assert(mc_mode != MC_MODE_SERVER); /* TODO, if the MC is disabled we do not really need to make a simcall for * this :) */ - /* FIXME: return mc_current_state->executed_transition->random.value; */ return simcall_mc_random(min, max); } diff --git a/src/mc/mc_request.cpp b/src/mc/mc_request.cpp index cc844032c5..26b9d30193 100644 --- a/src/mc/mc_request.cpp +++ b/src/mc/mc_request.cpp @@ -101,9 +101,11 @@ bool request_depend_asymmetric(smx_simcall_t r1, smx_simcall_t r2) /* FIXME: the following rule assumes that the result of the * isend/irecv call is not stored in a buffer used in the * test call. */ - /*if( (r1->call == SIMCALL_COMM_ISEND || r1->call == SIMCALL_COMM_IRECV) +#if 0 + if((r1->call == SIMCALL_COMM_ISEND || r1->call == SIMCALL_COMM_IRECV) && r2->call == SIMCALL_COMM_TEST) - return FALSE; */ + return FALSE; +#endif if (r1->call == SIMCALL_COMM_WAIT && (r2->call == SIMCALL_COMM_WAIT || r2->call == SIMCALL_COMM_TEST)