From: Frederic Suter <frederic.suter@cc.in2p3.fr>
Date: Wed, 6 Mar 2019 08:23:10 +0000 (+0100)
Subject: please sonar
X-Git-Tag: v3_22~169
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/2143d8fb56b12f02f6123087bafa5d0d32ffa944?ds=sidebyside

please sonar
---

diff --git a/include/simgrid/s4u/Exec.hpp b/include/simgrid/s4u/Exec.hpp
index c7a4187c91..287eaa05e3 100644
--- a/include/simgrid/s4u/Exec.hpp
+++ b/include/simgrid/s4u/Exec.hpp
@@ -46,7 +46,6 @@ public:
   static xbt::signal<void(ActorPtr)> on_start;
   static xbt::signal<void(ActorPtr)> on_completion;
 
-  virtual double get_remaining() override = 0;
   virtual Exec* start() override          = 0;
   virtual double get_remaining_ratio()    = 0;
   virtual ExecPtr set_host(Host* host)    = 0;
diff --git a/src/kernel/activity/ExecImpl.cpp b/src/kernel/activity/ExecImpl.cpp
index d0ff6ae6df..452d6fd288 100644
--- a/src/kernel/activity/ExecImpl.cpp
+++ b/src/kernel/activity/ExecImpl.cpp
@@ -51,10 +51,10 @@ namespace simgrid {
 namespace kernel {
 namespace activity {
 
-ExecImpl::ExecImpl(std::string name, std::string tracing_category) : ActivityImpl(std::move(name))
+ExecImpl::ExecImpl(const std::string& name, const std::string& tracing_category) : ActivityImpl(name)
 {
   this->state_ = SIMIX_RUNNING;
-  this->set_category(std::move(tracing_category));
+  this->set_category(tracing_category);
 
   XBT_DEBUG("Create exec %p", this);
 }
diff --git a/src/kernel/activity/ExecImpl.hpp b/src/kernel/activity/ExecImpl.hpp
index 966438fdce..607e671d77 100644
--- a/src/kernel/activity/ExecImpl.hpp
+++ b/src/kernel/activity/ExecImpl.hpp
@@ -18,7 +18,7 @@ class XBT_PUBLIC ExecImpl : public ActivityImpl {
   ~ExecImpl() override;
 
 public:
-  explicit ExecImpl(std::string name, std::string tracing_category);
+  explicit ExecImpl(const std::string& name, const std::string& tracing_category);
   ExecImpl* start(double flops_amount, double priority, double bound);
   ExecImpl* start(const std::vector<s4u::Host*>& hosts, const std::vector<double>& flops_amounts,
                   const std::vector<double>& bytes_amounts);