From: Frederic Suter <frederic.suter@cc.in2p3.fr>
Date: Fri, 27 Mar 2020 10:41:15 +0000 (+0100)
Subject: simplify: callbacks are only called is trace is enabled.
X-Git-Tag: v3.26~694
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/1ea1dc433f416051a4a6bd873426f5d828b92b2e

simplify: callbacks are only called is trace is enabled.
testing trace_disable_destroy only is thus enough
---

diff --git a/src/instr/instr_config.cpp b/src/instr/instr_config.cpp
index 135b2d2f09..b0b66ab369 100644
--- a/src/instr/instr_config.cpp
+++ b/src/instr/instr_config.cpp
@@ -166,11 +166,6 @@ bool TRACE_disable_speed()
   return trace_disable_power && trace_enabled;
 }
 
-bool TRACE_disable_destroy ()
-{
-  return trace_disable_destroy && trace_enabled;
-}
-
 bool TRACE_basic ()
 {
   return trace_basic && trace_enabled;
@@ -267,7 +262,7 @@ static void on_container_destruction_paje(Container& c)
   TRACE_paje_dump_buffer(true);
 
   // trace my destruction, but not if user requests so or if the container is root
-  if (not TRACE_disable_destroy() && &c != Container::get_root()) {
+  if (not trace_disable_destroy && &c != Container::get_root()) {
     std::stringstream stream;
     double timestamp = SIMIX_get_clock();
 
@@ -312,7 +307,7 @@ static void on_container_destruction_ti(Container& c)
   TRACE_last_timestamp_to_dump = SIMIX_get_clock();
   TRACE_paje_dump_buffer(true);
 
-  if (not TRACE_disable_destroy() && &c != Container::get_root()) {
+  if (not trace_disable_destroy && &c != Container::get_root()) {
     XBT_DEBUG("%s: event_type=%u, timestamp=%f", __func__, PAJE_DestroyContainer, SIMIX_get_clock());
     if (not simgrid::config::get_value<bool>("tracing/smpi/format/ti-one-file") || tracing_files.size() == 1) {
       tracing_files.at(&c)->close();
diff --git a/src/instr/instr_private.hpp b/src/instr/instr_private.hpp
index 16605e42d7..34317ef96d 100644
--- a/src/instr/instr_private.hpp
+++ b/src/instr/instr_private.hpp
@@ -258,7 +258,6 @@ XBT_PRIVATE bool TRACE_actor_is_enabled();
 XBT_PRIVATE bool TRACE_vm_is_enabled();
 XBT_PRIVATE bool TRACE_disable_link();
 XBT_PRIVATE bool TRACE_disable_speed();
-XBT_PRIVATE bool TRACE_disable_destroy();
 XBT_PRIVATE bool TRACE_basic();
 XBT_PRIVATE bool TRACE_display_sizes();
 XBT_PRIVATE int TRACE_precision();