From: Christophe Thiéry <christopho128@gmail.com>
Date: Thu, 5 Jan 2012 17:10:46 +0000 (+0100)
Subject: SMPI: before terminating a process, wait for its asynchronous comms
X-Git-Tag: exp_20120216~195^2~2
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/1ae612ef301a26795068505cf761169ed29a5451

SMPI: before terminating a process, wait for its asynchronous comms
---

diff --git a/include/simix/simix.h b/include/simix/simix.h
index f25bf3dfca..96230b548e 100644
--- a/include/simix/simix.h
+++ b/include/simix/simix.h
@@ -67,6 +67,7 @@ XBT_PUBLIC(void) SIMIX_process_self_set_data(smx_process_t self, void *data);
 XBT_PUBLIC(void*) SIMIX_process_self_get_data(smx_process_t self);
 XBT_PUBLIC(smx_context_t) SIMIX_process_get_context(smx_process_t);
 XBT_PUBLIC(void) SIMIX_process_set_context(smx_process_t p,smx_context_t c);
+XBT_PUBLIC(int) SIMIX_process_has_pending_comms(smx_process_t process);
 
 /****************************** Communication *********************************/
 XBT_PUBLIC(void) SIMIX_comm_set_copy_data_callback(void (*callback) (smx_action_t, size_t));
diff --git a/src/simix/smx_process.c b/src/simix/smx_process.c
index e57176a749..bd3413769b 100644
--- a/src/simix/smx_process.c
+++ b/src/simix/smx_process.c
@@ -30,7 +30,16 @@ XBT_INLINE smx_process_t SIMIX_process_self(void)
 }
 
 /**
- * \brief Move a process to the list of processes to destroy.
+ * \brief Returns whether a process has pending asynchronous communications.
+ * \return true if there are asynchronous communications in this process
+ */
+int SIMIX_process_has_pending_comms(smx_process_t process) {
+
+  return xbt_fifo_size(process->comms) > 0;
+}
+
+/**
+ * \brief Moves a process to the list of processes to destroy.
  */
 void SIMIX_process_cleanup(smx_process_t process)
 {
diff --git a/src/smpi/private.h b/src/smpi/private.h
index d457c767b4..6105faaa10 100644
--- a/src/smpi/private.h
+++ b/src/smpi/private.h
@@ -40,6 +40,7 @@ typedef struct s_smpi_mpi_request {
 
 void smpi_process_init(int *argc, char ***argv);
 void smpi_process_destroy(void);
+void smpi_process_finalize(void);
 
 smpi_process_data_t smpi_process_data(void);
 smpi_process_data_t smpi_process_remote_data(int index);
diff --git a/src/smpi/smpi_base.c b/src/smpi/smpi_base.c
index 8a02def723..076cd429da 100644
--- a/src/smpi/smpi_base.c
+++ b/src/smpi/smpi_base.c
@@ -294,8 +294,10 @@ int smpi_mpi_testany(int count, MPI_Request requests[], int *index,
 void smpi_mpi_wait(MPI_Request * request, MPI_Status * status)
 {
   print_request("Waiting", *request);
-  if ((*request)->action != NULL ) 
- 	 SIMIX_req_comm_wait((*request)->action, -1.0);
+  if ((*request)->action != NULL) {
+
+      SIMIX_req_comm_wait((*request)->action, -1.0);
+  }
   finish_wait(request, status);
 }
 
diff --git a/src/smpi/smpi_global.c b/src/smpi/smpi_global.c
index 6fa73d2ef6..470be9c857 100644
--- a/src/smpi/smpi_global.c
+++ b/src/smpi/smpi_global.c
@@ -70,6 +70,17 @@ void smpi_process_destroy(void)
   XBT_DEBUG("<%d> Process left the game", index);
 }
 
+/**
+ * @brief Prepares the current process for termination.
+ */
+void smpi_process_finalize(void)
+{
+  // wait for all pending asynchronous comms to finish
+  while (SIMIX_process_has_pending_comms(SIMIX_process_self())) {
+    SIMIX_req_process_sleep(1);
+  }
+}
+
 int smpi_process_argc(void) {
   smpi_process_data_t data = smpi_process_data();
 
diff --git a/src/smpi/smpi_pmpi.c b/src/smpi/smpi_pmpi.c
index ec3da34945..ba07a45915 100644
--- a/src/smpi/smpi_pmpi.c
+++ b/src/smpi/smpi_pmpi.c
@@ -36,6 +36,7 @@ int PMPI_Init(int *argc, char ***argv)
 
 int PMPI_Finalize(void)
 {
+  smpi_process_finalize();
   smpi_bench_end();
 #ifdef HAVE_TRACING
   TRACE_smpi_finalize(smpi_process_index());