From: Martin Quinson <martin.quinson@loria.fr>
Date: Tue, 13 Mar 2018 20:21:26 +0000 (+0100)
Subject: cosmetics in comments
X-Git-Tag: v3.19~54
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/18fd03bb84ea54b81f11bc9d8857d36e57e27485

cosmetics in comments
---

diff --git a/include/xbt/ex.hpp b/include/xbt/ex.hpp
index 1f7d0e153e..e929d6cca9 100644
--- a/include/xbt/ex.hpp
+++ b/include/xbt/ex.hpp
@@ -41,7 +41,7 @@ public:
     simgrid::xbt::WithContextException(throwpoint, simgrid::xbt::backtrace())
   {}
 
-  ~xbt_ex();
+  ~xbt_ex(); // DO NOT define it here -- see ex.cpp for a rational
 
   /** Category (what went wrong) */
   xbt_errcat_t category = unknown_error;
diff --git a/src/xbt/ex.cpp b/src/xbt/ex.cpp
index c35a90e403..19906e6c8f 100644
--- a/src/xbt/ex.cpp
+++ b/src/xbt/ex.cpp
@@ -22,8 +22,10 @@
 
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(xbt_ex, xbt, "Exception mechanism");
 
-// Don't define ~xbt_ex() in ex.hpp.  It is defined here to ensure that there is an unique definition of xt_ex in
-// libsimgrid, but not in libsimgrid-java.  Otherwise, sone tests are broken (seen with clang/libc++ on freebsd).
+// DO NOT define ~xbt_ex() in ex.hpp.
+// Defining it here ensures that xbt_ex is defined only in libsimgrid, but not in libsimgrid-java.
+// Doing otherwise naturally breaks things (at least on freebsd with clang).
+
 xbt_ex::~xbt_ex() = default;
 
 void _xbt_throw(char* message, xbt_errcat_t errcat, int value, const char* file, int line, const char* func)