From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Fri, 28 Sep 2018 13:03:12 +0000 (+0200)
Subject: Clang's address sanitizer is not compatible with -Wl,-z,defs.
X-Git-Tag: v3_21~11^2~1
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/1503dc964a5f0c874f5e2161fcf2553b6df013e8

Clang's address sanitizer is not compatible with -Wl,-z,defs.

See: https://clang.llvm.org/docs/AddressSanitizer.html#usage
---

diff --git a/src/smpi/smpicc.in b/src/smpi/smpicc.in
index 75a0396927..790469e4fb 100755
--- a/src/smpi/smpicc.in
+++ b/src/smpi/smpicc.in
@@ -16,6 +16,13 @@ CMAKE_LINKARGS="-L@libdir@"
 
 @SMPITOOLS_SH@
 
+# Don't use -Wl,-z-defs with Clang and address sanitizer
+if [ "@CMAKE_C_COMPILER_ID@" = "Clang" -a "@HAVE_SANITIZER_ADDRESS@" = "TRUE" ]; then
+    LINKER_UNDEFINED_ERROR=""
+else
+    LINKER_UNDEFINED_ERROR="1"
+fi
+
 list_set CFLAGS
 list_set LINKARGS "-lm"
 if [ "x@WIN32@" = "x1" ]; then
@@ -29,7 +36,7 @@ elif [ "x@APPLE@" = "x1" ]; then
     else
        echo "Warning: smpicc pretends to be a regular compiler (SMPI_PRETEND_CC is set). Produced binaries will not be usable in SimGrid."
     fi
-    list_add LINKARGS "-lsimgrid" "-Wl,-undefined,error"
+    list_add LINKARGS "-lsimgrid" ${LINKER_UNDEFINED_ERROR:+"-Wl,-undefined,error"}
 else
     list_add CFLAGS "-include" "@includedir@/smpi/smpi_helpers.h"
     list_add CFLAGS "-fpic"
@@ -38,7 +45,7 @@ else
     else
        echo "Warning: smpicc pretends to be a regular compiler (SMPI_PRETEND_CC is set). Produced binaries will not be usable in SimGrid."
     fi
-    list_add LINKARGS "-lsimgrid" "-Wl,-z,defs"
+    list_add LINKARGS "-lsimgrid" ${LINKER_UNDEFINED_ERROR:+"-Wl,-z,defs"}
 fi