deprecate a function to snake_case it

diff --git a/include/simgrid/s4u/Host.hpp b/include/simgrid/s4u/Host.hpp
index c67ead8..a87405b 100644 (file)
--- a/include/simgrid/s4u/Host.hpp
+++ b/include/simgrid/s4u/Host.hpp
@@ -96,8 +96,8 @@ public:
   void setPstate(int pstate_index);
   int getPstate();
   std::vector<const char*> get_attached_storages();
   void setPstate(int pstate_index);
   int getPstate();
   std::vector<const char*> get_attached_storages();

-  // XBT_ATTRIB_DEPRECATED_v323("Please use Host::get_attached_storages() instead.")
-  void getAttachedStorages(std::vector<const char*> * storages);
+  XBT_ATTRIB_DEPRECATED_v323("Please use Host::get_attached_storages() instead.") void getAttachedStorages(
+      std::vector<const char*>* storages);

 
   /** Get an associative list [mount point]->[Storage] of all local mount points.
    *
 
   /** Get an associative list [mount point]->[Storage] of all local mount points.
    *

diff --git a/src/simgrid/host.cpp b/src/simgrid/host.cpp
index 32f2e5d..e47f72a 100644 (file)
--- a/src/simgrid/host.cpp
+++ b/src/simgrid/host.cpp
@@ -110,12 +110,10 @@ xbt_dict_t sg_host_get_mounted_storage_list(sg_host_t host){
 }
 
 xbt_dynar_t sg_host_get_attached_storage_list(sg_host_t host){
 }
 
 xbt_dynar_t sg_host_get_attached_storage_list(sg_host_t host){

-  std::vector<const char*>* storage_vector = new std::vector<const char*>();

   xbt_dynar_t storage_dynar = xbt_dynar_new(sizeof(const char*), nullptr);
   xbt_dynar_t storage_dynar = xbt_dynar_new(sizeof(const char*), nullptr);

-  host->getAttachedStorages(storage_vector);
-  for (auto const& name : *storage_vector)
+  std::vector<const char*> storage_vector = host->get_attached_storages();
+  for (auto const& name : storage_vector)

     xbt_dynar_push(storage_dynar, &name);
     xbt_dynar_push(storage_dynar, &name);

-  delete storage_vector;

   return storage_dynar;
 }
 
   return storage_dynar;
 }