clang complains about these seemingly unecessary std::move.

diff --git a/src/mc/LivenessChecker.cpp b/src/mc/LivenessChecker.cpp
index f573622..19e6347 100644 (file)
--- a/src/mc/LivenessChecker.cpp
+++ b/src/mc/LivenessChecker.cpp
@@ -454,7 +454,7 @@ std::shared_ptr<Pair> LivenessChecker::newPair(Pair* current_pair, xbt_automaton
     next_pair->search_cycle = true;
   else
     next_pair->search_cycle = false;
     next_pair->search_cycle = true;
   else
     next_pair->search_cycle = false;

-  return std::move(next_pair);
+  return next_pair;

 }
 
 void LivenessChecker::backtrack()
 }
 
 void LivenessChecker::backtrack()

diff --git a/src/mc/VisitedState.cpp b/src/mc/VisitedState.cpp
index 3aa0e5f..5d547bf 100644 (file)
--- a/src/mc/VisitedState.cpp
+++ b/src/mc/VisitedState.cpp
@@ -118,7 +118,7 @@ std::unique_ptr<simgrid::mc::VisitedState> VisitedStates::addVisitedState(
           old_state->num, new_state->num);
 
         visited_state = std::move(new_state);
           old_state->num, new_state->num);
 
         visited_state = std::move(new_state);

-        return std::move(old_state);
+        return old_state;

       }
     }
 
       }
     }
 


@@ -129,4 +129,4 @@ std::unique_ptr<simgrid::mc::VisitedState> VisitedStates::addVisitedState(
 }
 
 }
 }
 
 }

-}
\ No newline at end of file
+}

diff --git a/src/xbt/backtrace_linux.cpp b/src/xbt/backtrace_linux.cpp
index e37bbcc..0e191b4 100644 (file)
--- a/src/xbt/backtrace_linux.cpp
+++ b/src/xbt/backtrace_linux.cpp
@@ -158,7 +158,7 @@ std::vector<std::string> resolveBacktrace(
   if (binary_name.empty()) {
     for (std::size_t i = 0; i < count; i++)
       result.push_back(simgrid::xbt::string_printf("%p", loc[i]));
   if (binary_name.empty()) {
     for (std::size_t i = 0; i < count; i++)
       result.push_back(simgrid::xbt::string_printf("%p", loc[i]));

-    return std::move(result);
+    return result;

   }
 
   // Create the system command for add2line:
   }
 
   // Create the system command for add2line: