Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Revert "disable dlopen when under sanitizers"
authorMartin Quinson <martin.quinson@loria.fr>
Mon, 12 Mar 2018 07:36:36 +0000 (08:36 +0100)
committerMartin Quinson <martin.quinson@loria.fr>
Mon, 12 Mar 2018 07:36:36 +0000 (08:36 +0100)
This reverts commit 4e2035d7b4730d535ebd7619c4e85878f71f8cb2.

CMakeLists.txt
src/smpi/internals/smpi_global.cpp
tools/cmake/src/internal_config.h.in
tools/tesh/tesh.py

index b16aeab..51590bc 100644 (file)
@@ -618,10 +618,6 @@ endif()
 file(REMOVE test_stackgrowth)
 #--------------------------------------------------------------------------------------------------
 
-if(enable_address_sanitizer OR enable_thread_sanitizer OR enable_undefined_sanitizer)
-  set(HAVE_SANITIZER 1)
-endif()
-
 ### check for addr2line
 find_path(ADDR2LINE NAMES addr2line    PATHS NO_DEFAULT_PATHS)
 if(ADDR2LINE)
index 0c1a3b7..769c009 100644 (file)
@@ -388,13 +388,6 @@ static void smpi_init_options(){
     }
 #endif
 
-#if defined(HAVE_SANITIZER)
-    if (smpi_privatize_global_variables == SMPI_PRIVATIZE_DLOPEN) {
-      XBT_INFO("Sanitizers don't like dlopen, switching to mmap privatization instead.");
-      smpi_privatize_global_variables = SMPI_PRIVATIZE_MMAP;
-    }
-#endif
-
     if (smpi_cpu_threshold < 0)
       smpi_cpu_threshold = DBL_MAX;
 
index 90d8c70..aac7ce0 100644 (file)
 #cmakedefine01 HAVE_GRAPHVIZ
 /* The lib unwind library (for MC and backtrace display) */
 #cmakedefine01 HAVE_LIBUNWIND
-/* Whether we are built under a sanitizer (to disable dlopen privatization) */
-#cmakedefine01 HAVE_SANITIZER
index 2cd1dce..a37449e 100755 (executable)
@@ -467,7 +467,6 @@ if __name__ == '__main__':
            re.compile(r"cmake: /usr/local/lib/libcurl\.so\.4: no version information available \(required by cmake\)"), # Seen on CircleCI
            re.compile(r".*mmap broken on FreeBSD, but dlopen\+thread broken too. Switching to dlopen\+raw contexts\."),
            re.compile(r".*dlopen\+thread broken on Apple and BSD\. Switching to raw contexts\."),
-           re.compile(r"Sanitizers don.t like dlopen, switching to mmap privatization instead\."),
            ]
         TeshState().jenkins = True # This is a Jenkins build