Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
remove any virtuals from Context::StopRequest
authorMartin Quinson <martin.quinson@ens-rennes.fr>
Tue, 8 Jan 2019 07:16:56 +0000 (08:16 +0100)
committerMartin Quinson <martin.quinson@ens-rennes.fr>
Tue, 8 Jan 2019 07:16:59 +0000 (08:16 +0100)
commit6146adc437b5b5e57f546b09c26d3392487766b7
treec05ddf1be06536ea70a2d5090b60cf8910a6a063
parent701ae7999bdecd06414d92d2e4b8f825afea83ee
remove any virtuals from Context::StopRequest

Some clang versions fail otherwise:

/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/8.2.1/../../../../include/c++/8.2.1/bits/exception_ptr.h:172:9: error: destructor called on non-final 'simgrid::kernel::context::Context::StopRequest' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
      { static_cast<_Ex*>(__x)->~_Ex(); }
        ^
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/8.2.1/../../../../include/c++/8.2.1/bits/exception_ptr.h:185:21: note: in instantiation of function template specialization 'std::__exception_ptr::__dest_thunk<simgrid::kernel::context::Context::StopRequest>' requested here
          __exception_ptr::__dest_thunk<_Ex>);
                           ^
/builds/workspace/SimGrid/build_mode/Debug/node/simgrid-manjaro/build/SimGrid-3.21.90/src/simix/ActorImpl.cpp:507:35: note: in instantiation of function template specialization 'std::make_exception_ptr<simgrid::kernel::context::Context::StopRequest>' requested here
actor->throw_exception(std::make_exception_ptr(simgrid::kernel::context::Context::StopRequest("host failed")));
                                  ^
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/8.2.1/../../../../include/c++/8.2.1/bits/exception_ptr.h:172:34: note: qualify call to silence this warning
      { static_cast<_Ex*>(__x)->~_Ex(); }
                                 ^
1 error generated.
src/kernel/context/Context.hpp