X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/fe304706848f0a64477d4687b3ea97d5b9a0c35c..b0c36e046aa9d57ba90e5be5875b4754d9b8a545:/src/surf/cpu_cas01.cpp diff --git a/src/surf/cpu_cas01.cpp b/src/surf/cpu_cas01.cpp index 1bb85a7711..557e549d78 100644 --- a/src/surf/cpu_cas01.cpp +++ b/src/surf/cpu_cas01.cpp @@ -1,10 +1,11 @@ -/* Copyright (c) 2009-2019. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2009-2020. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ #include "cpu_cas01.hpp" #include "simgrid/sg_config.hpp" +#include "src/kernel/resource/profile/Event.hpp" #include "src/surf/cpu_ti.hpp" #include "src/surf/surf_interface.hpp" #include "surf/surf.hpp" @@ -63,7 +64,7 @@ CpuCas01Model::CpuCas01Model(Model::UpdateAlgo algo) : CpuModel(algo) bool select = config::get_value("cpu/maxmin-selective-update"); - if (algo == Model::UpdateAlgo::LAZY) { + if (is_update_lazy()) { xbt_assert(select || config::is_default("cpu/maxmin-selective-update"), "You cannot disable cpu selective update when using the lazy update mechanism"); select = true; @@ -101,13 +102,13 @@ bool CpuCas01::is_used() /** @brief take into account changes of speed (either load or max) */ void CpuCas01::on_speed_change() { - lmm::Variable* var = nullptr; + const lmm::Variable* var; const lmm::Element* elem = nullptr; get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), get_core_count() * speed_.scale * speed_.peak); while ((var = get_constraint()->get_variable(&elem))) { - CpuCas01Action* action = static_cast(var->get_id()); + auto* action = static_cast(var->get_id()); get_model()->get_maxmin_system()->update_variable_bound(action->get_variable(), action->requested_core() * speed_.scale * speed_.peak); @@ -132,19 +133,19 @@ void CpuCas01::apply_event(profile::Event* event, double value) if (value > 0) { if (not is_on()) { - XBT_VERB("Restart processes on host %s", get_host()->get_cname()); + XBT_VERB("Restart actors on host %s", get_host()->get_cname()); get_host()->turn_on(); } } else { - lmm::Constraint* cnst = get_constraint(); - lmm::Variable* var = nullptr; + const lmm::Constraint* cnst = get_constraint(); + const lmm::Variable* var; const lmm::Element* elem = nullptr; double date = surf_get_clock(); get_host()->turn_off(); while ((var = cnst->get_variable(&elem))) { - Action* action = static_cast(var->get_id()); + auto* action = static_cast(var->get_id()); if (action->get_state() == Action::State::INITED || action->get_state() == Action::State::STARTED || action->get_state() == Action::State::IGNORED) { @@ -178,8 +179,7 @@ CpuAction* CpuCas01::sleep(double duration) duration = std::max(duration, sg_surf_precision); XBT_IN("(%s,%g)", get_cname(), duration); - CpuCas01Action* action = - new CpuCas01Action(get_model(), 1.0, not is_on(), speed_.scale * speed_.peak, get_constraint()); + auto* action = new CpuCas01Action(get_model(), 1.0, not is_on(), speed_.scale * speed_.peak, get_constraint()); // FIXME: sleep variables should not consume 1.0 in System::expand() action->set_max_duration(duration); @@ -187,8 +187,8 @@ CpuAction* CpuCas01::sleep(double duration) if (duration == NO_MAX_DURATION) action->set_state(Action::State::IGNORED); - get_model()->get_maxmin_system()->update_variable_weight(action->get_variable(), 0.0); - if (get_model()->get_update_algorithm() == Model::UpdateAlgo::LAZY) { // remove action from the heap + get_model()->get_maxmin_system()->update_variable_penalty(action->get_variable(), 0.0); + if (get_model()->is_update_lazy()) { // remove action from the heap get_model()->get_action_heap().remove(action); // this is necessary for a variable with weight 0 since such variables are ignored in lmm and we need to set its // max_duration correctly at the next call to share_resources @@ -208,7 +208,7 @@ CpuCas01Action::CpuCas01Action(Model* model, double cost, bool failed, double sp model->get_maxmin_system()->variable_new(this, 1.0 / requested_core, requested_core * speed, 1)) , requested_core_(requested_core) { - if (model->get_update_algorithm() == Model::UpdateAlgo::LAZY) + if (model->is_update_lazy()) set_last_update(); model->get_maxmin_system()->expand(constraint, get_variable(), 1.0); }