X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/f3b7e5f4b4d7c87ee3e8827313ec966ea8fc8387..3e8599b4a7dfd1fddb2d2292bbbafd043db883ae:/src/mc/checker/LivenessChecker.cpp diff --git a/src/mc/checker/LivenessChecker.cpp b/src/mc/checker/LivenessChecker.cpp index b586e8cfa2..12b4356642 100644 --- a/src/mc/checker/LivenessChecker.cpp +++ b/src/mc/checker/LivenessChecker.cpp @@ -10,12 +10,15 @@ #include "src/mc/mc_private.hpp" #include "src/mc/mc_request.hpp" #include "src/mc/mc_smx.hpp" +#include "src/mc/mc_api.hpp" #include #include XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_liveness, mc, "Logging specific to algorithms for liveness properties verification"); +using mcapi = simgrid::mc::mc_api; + /********* Static functions *********/ namespace simgrid { @@ -51,12 +54,9 @@ static bool evaluate_label(const xbt_automaton_exp_label* l, std::vector co case xbt_automaton_exp_label::AUT_NOT: return not evaluate_label(l->u.exp_not, values); case xbt_automaton_exp_label::AUT_PREDICAT:{ - unsigned int cursor = 0; - xbt_automaton_propositional_symbol_t p = nullptr; - xbt_dynar_foreach(simgrid::mc::property_automaton->propositional_symbols, cursor, p) { - if (std::strcmp(xbt_automaton_propositional_symbol_get_name(p), l->u.predicat) == 0) - return values[cursor] != 0; - } + auto cursor = mcapi::get().compare_automaton_exp_lable(l, values); + if(cursor >= 0) + return values[cursor] != 0; xbt_die("Missing predicate"); break; } @@ -72,11 +72,7 @@ Pair::Pair(unsigned long expanded_pairs) : num(expanded_pairs) std::shared_ptr> LivenessChecker::get_proposition_values() const { - std::vector values; - unsigned int cursor = 0; - xbt_automaton_propositional_symbol_t ps = nullptr; - xbt_dynar_foreach (mc::property_automaton->propositional_symbols, cursor, ps) - values.push_back(xbt_automaton_propositional_symbol_evaluate(ps)); + auto values = mcapi::get().automaton_propositional_symbol_evaluate(); return std::make_shared>(std::move(values)); } @@ -85,13 +81,13 @@ std::shared_ptr LivenessChecker::insert_acceptance_pair(simgrid::mc auto new_pair = std::make_shared(pair->num, pair->automaton_state, pair->atomic_propositions, pair->graph_state); - auto res = boost::range::equal_range(acceptance_pairs_, new_pair.get(), DerefAndCompareByActorsCountAndUsedHeap()); + auto res = boost::range::equal_range(acceptance_pairs_, new_pair.get(), mcapi::get().compare_pair()); if (pair->search_cycle) for (auto i = res.first; i != res.second; ++i) { std::shared_ptr const& pair_test = *i; - if (xbt_automaton_state_compare(pair_test->automaton_state, new_pair->automaton_state) != 0 || + if (mcapi::get().automaton_state_compare(pair_test->automaton_state, new_pair->automaton_state) != 0 || *(pair_test->atomic_propositions) != *(new_pair->atomic_propositions) || - not snapshot_equal(pair_test->graph_state->system_state_.get(), new_pair->graph_state->system_state_.get())) + not mcapi::get().snapshot_equal(pair_test->graph_state->system_state_.get(), new_pair->graph_state->system_state_.get())) continue; XBT_INFO("Pair %d already reached (equal to pair %d) !", new_pair->num, pair_test->num); exploration_stack_.pop_back(); @@ -144,16 +140,14 @@ void LivenessChecker::replay() smx_simcall_t req = nullptr; - if (saved_req != nullptr) { - /* because we got a copy of the executed request, we have to fetch the - real one, pointed by the request field of the issuer process */ - const smx_actor_t issuer = MC_smx_simcall_get_issuer(saved_req); - req = &issuer->simcall_; + /* because we got a copy of the executed request, we have to fetch the + real one, pointed by the request field of the issuer process */ + const smx_actor_t issuer = MC_smx_simcall_get_issuer(saved_req); + req = &issuer->simcall_; - /* Debug information */ - XBT_DEBUG("Replay (depth = %d) : %s (%p)", depth, - request_to_string(req, req_num, simgrid::mc::RequestType::simix).c_str(), state.get()); - } + /* Debug information */ + XBT_DEBUG("Replay (depth = %d) : %s (%p)", depth, + mcapi::get().request_to_string(req, req_num, simgrid::mc::RequestType::simix).c_str(), state.get()); this->get_session().execute(state->transition_); } @@ -179,11 +173,11 @@ int LivenessChecker::insert_visited_pair(std::shared_ptr visited_pa visited_pair = std::make_shared(pair->num, pair->automaton_state, pair->atomic_propositions, pair->graph_state); - auto range = boost::range::equal_range(visited_pairs_, visited_pair.get(), DerefAndCompareByActorsCountAndUsedHeap()); + auto range = boost::range::equal_range(visited_pairs_, visited_pair.get(), mcapi::get().compare_pair()); for (auto i = range.first; i != range.second; ++i) { const VisitedPair* pair_test = i->get(); - if (xbt_automaton_state_compare(pair_test->automaton_state, visited_pair->automaton_state) != 0 || + if (mcapi::get().automaton_state_compare(pair_test->automaton_state, visited_pair->automaton_state) != 0 || *(pair_test->atomic_propositions) != *(visited_pair->atomic_propositions) || not snapshot_equal(pair_test->graph_state->system_state_.get(), visited_pair->graph_state->system_state_.get())) continue; @@ -231,7 +225,7 @@ void LivenessChecker::log_state() // override { XBT_INFO("Expanded pairs = %lu", expanded_pairs_count_); XBT_INFO("Visited pairs = %lu", visited_pairs_count_); - XBT_INFO("Executed transitions = %lu", mc_model_checker->executed_transitions); + XBT_INFO("Executed transitions = %lu", mcapi::get().mc_get_executed_trans()); } void LivenessChecker::show_acceptance_cycle(std::size_t depth) @@ -242,8 +236,8 @@ void LivenessChecker::show_acceptance_cycle(std::size_t depth) XBT_INFO("Counter-example that violates formula:"); for (auto const& s : this->get_textual_trace()) XBT_INFO(" %s", s.c_str()); - mc::dumpRecordPath(); - mc::session->log_state(); + mcapi::get().dump_record_path(); + mcapi::get().log_state(); XBT_INFO("Counter-example depth: %zu", depth); } @@ -253,8 +247,8 @@ std::vector LivenessChecker::get_textual_trace() // override for (std::shared_ptr const& pair : exploration_stack_) { int req_num = pair->graph_state->transition_.argument_; smx_simcall_t req = &pair->graph_state->executed_req_; - if (req && req->call_ != SIMCALL_NONE) - trace.push_back(request_to_string(req, req_num, RequestType::executed)); + if (req->call_ != simix::Simcall::NONE) + trace.push_back(mcapi::get().request_to_string(req, req_num, RequestType::executed)); } return trace; } @@ -273,8 +267,9 @@ std::shared_ptr LivenessChecker::create_pair(const Pair* current_pair, xbt else next_pair->depth = 1; /* Get enabled actors and insert them in the interleave set of the next graph_state */ - for (auto& actor : mc_model_checker->get_remote_simulation().actors()) - if (mc::actor_is_enabled(actor.copy.get_buffer())) + auto actors = mcapi::get().get_actors(); + for (auto& actor : actors) + if (mcapi::get().actor_is_enabled(actor.copy.get_buffer()->get_pid())) next_pair->graph_state->add_interleaving_set(actor.copy.get_buffer()); next_pair->requests = next_pair->graph_state->interleave_size(); /* FIXME : get search_cycle value for each accepting state */ @@ -310,10 +305,10 @@ void LivenessChecker::backtrack() void LivenessChecker::run() { XBT_INFO("Check the liveness property %s", _sg_mc_property_file.get().c_str()); - MC_automaton_load(_sg_mc_property_file.get().c_str()); + mcapi::get().automaton_load(_sg_mc_property_file.get().c_str()); XBT_DEBUG("Starting the liveness algorithm"); - mc::session->initialize(); + mcapi::get().session_initialize(); /* Initialize */ this->previous_pair_ = 0; @@ -322,18 +317,18 @@ void LivenessChecker::run() // For each initial state of the property automaton, push a // (application_state, automaton_state) pair to the exploration stack: - unsigned int cursor = 0; - xbt_automaton_state_t automaton_state; - xbt_dynar_foreach (mc::property_automaton->states, cursor, automaton_state) + auto automaton_stack = mcapi::get().get_automaton_state(); + std::for_each(automaton_stack.begin(), automaton_stack.end(), [&](xbt_automaton_state_t const& automaton_state) { if (automaton_state->type == -1) exploration_stack_.push_back(this->create_pair(nullptr, automaton_state, propos)); + }); /* Actually run the double DFS search for counter-examples */ while (not exploration_stack_.empty()) { std::shared_ptr current_pair = exploration_stack_.back(); /* Update current state in buchi automaton */ - mc::property_automaton->current_state = current_pair->automaton_state; + mcapi::get().set_property_automaton(current_pair->automaton_state); XBT_DEBUG( "********************* ( Depth = %d, search_cycle = %d, interleave size = %zu, pair_num = %d, requests = %d)", @@ -370,7 +365,7 @@ void LivenessChecker::run() } } - smx_simcall_t req = MC_state_choose_request(current_pair->graph_state.get()); + smx_simcall_t req = mcapi::get().mc_state_choose_request(current_pair->graph_state.get()); int req_num = current_pair->graph_state->transition_.argument_; if (dot_output != nullptr) { @@ -386,7 +381,7 @@ void LivenessChecker::run() fflush(dot_output); } - XBT_DEBUG("Execute: %s", request_to_string(req, req_num, RequestType::simix).c_str()); + XBT_DEBUG("Execute: %s", mcapi::get().request_to_string(req, req_num, RequestType::simix).c_str()); /* Update stats */ mc_model_checker->executed_transitions++;