X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/f35db13138682b1be530a509d1eeadeafff84ca7..b19516b0c55b093120c06185c404bfc22ef90f80:/src/smpi/colls/allreduce/allreduce-smp-binomial.cpp diff --git a/src/smpi/colls/allreduce/allreduce-smp-binomial.cpp b/src/smpi/colls/allreduce/allreduce-smp-binomial.cpp index 42af04d0a6..16f60d6eec 100644 --- a/src/smpi/colls/allreduce/allreduce-smp-binomial.cpp +++ b/src/smpi/colls/allreduce/allreduce-smp-binomial.cpp @@ -1,14 +1,14 @@ -/* Copyright (c) 2013-2014. The SimGrid Team. +/* Copyright (c) 2013-2019. The SimGrid Team. * All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include "../colls_private.h" -/* IMPLEMENTED BY PITCH PATARASUK - Non-topoloty-specific (however, number of cores/node need to be changed) +#include "../colls_private.hpp" +/* IMPLEMENTED BY PITCH PATARASUK + Non-topoloty-specific (however, number of cores/node need to be changed) all-reduce operation designed for smp clusters - It uses 2-layer communication: binomial for both intra-communication + It uses 2-layer communication: binomial for both intra-communication inter-communication*/ @@ -29,12 +29,11 @@ This fucntion performs all-reduce operation as follow. */ namespace simgrid{ namespace smpi{ -int Coll_allreduce_smp_binomial::allreduce(void *send_buf, void *recv_buf, +int Coll_allreduce_smp_binomial::allreduce(const void *send_buf, void *recv_buf, int count, MPI_Datatype dtype, MPI_Op op, MPI_Comm comm) { int comm_size, rank; - void *tmp_buf; int tag = COLL_TAG_ALLREDUCE; int mask, src, dst; @@ -51,7 +50,7 @@ int Coll_allreduce_smp_binomial::allreduce(void *send_buf, void *recv_buf, rank=comm->rank(); MPI_Aint extent, lb; dtype->extent(&lb, &extent); - tmp_buf = (void *) smpi_get_tmp_sendbuffer(count * extent); + unsigned char* tmp_buf = smpi_get_tmp_sendbuffer(count * extent); /* compute intra and inter ranking */ int intra_rank, inter_rank; @@ -83,7 +82,7 @@ int Coll_allreduce_smp_binomial::allreduce(void *send_buf, void *recv_buf, mask <<= 1; } - /* start binomial reduce inter-communication between each SMP nodes: + /* start binomial reduce inter-communication between each SMP nodes: each node only have one process that can communicate to other nodes */ if (intra_rank == 0) { mask = 1; @@ -103,7 +102,7 @@ int Coll_allreduce_smp_binomial::allreduce(void *send_buf, void *recv_buf, } } - /* start binomial broadcast inter-communication between each SMP nodes: + /* start binomial broadcast inter-communication between each SMP nodes: each node only have one process that can communicate to other nodes */ if (intra_rank == 0) { mask = 1;