X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/edcc47d7373e2f1bc9ae14bf0dcceb38af59ba2b..d5355ccc72f1c707374415f7352d87caa120606c:/src/smpi/bindings/smpi_pmpi_group.cpp

diff --git a/src/smpi/bindings/smpi_pmpi_group.cpp b/src/smpi/bindings/smpi_pmpi_group.cpp
index 4155bf6e6f..1403317b2e 100644
--- a/src/smpi/bindings/smpi_pmpi_group.cpp
+++ b/src/smpi/bindings/smpi_pmpi_group.cpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2007-2019. The SimGrid Team. All rights reserved.          */
+/* Copyright (c) 2007-2021. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -16,175 +16,199 @@ XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(smpi_pmpi);
 
 int PMPI_Group_free(MPI_Group * group)
 {
-  if (group == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    if(*group != MPI_COMM_WORLD->group() && *group != MPI_GROUP_EMPTY)
-      simgrid::smpi::Group::unref(*group);
-    *group = MPI_GROUP_NULL;
-    return MPI_SUCCESS;
+  CHECK_NULL(1, MPI_ERR_ARG, group)
+  CHECK_MPI_NULL(1, MPI_GROUP_NULL, MPI_ERR_GROUP, *group)
+  if(*group != MPI_COMM_WORLD->group() && *group != MPI_GROUP_EMPTY){
+    (*group)->mark_as_deleted();
+    simgrid::smpi::Group::unref(*group);
   }
+  *group = MPI_GROUP_NULL;
+  return MPI_SUCCESS;
 }
 
 int PMPI_Group_size(MPI_Group group, int *size)
 {
-  if (group == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (size == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    *size = group->size();
-    return MPI_SUCCESS;
-  }
+  CHECK_GROUP(1, group)
+  CHECK_NULL(2, MPI_ERR_ARG, size)
+  *size = group->size();
+  return MPI_SUCCESS;
 }
 
 int PMPI_Group_rank(MPI_Group group, int *rank)
 {
-  if (group == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (rank == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    *rank = group->rank(simgrid::s4u::this_actor::get_pid());
-    return MPI_SUCCESS;
-  }
+  CHECK_GROUP(1, group)
+  CHECK_NULL(2, MPI_ERR_ARG, rank)
+  *rank = group->rank(simgrid::s4u::this_actor::get_pid());
+  return MPI_SUCCESS;
 }
 
 int PMPI_Group_translate_ranks(MPI_Group group1, int n, const int *ranks1, MPI_Group group2, int *ranks2)
 {
-  if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else {
-    for (int i = 0; i < n; i++) {
-      if(ranks1[i]==MPI_PROC_NULL){
-        ranks2[i]=MPI_PROC_NULL;
-      }else{
-        simgrid::s4u::ActorPtr actor = group1->actor(ranks1[i]);
-        ranks2[i] = group2->rank(actor);
-      }
+  CHECK_GROUP(1, group1)
+  CHECK_NEGATIVE(2, MPI_ERR_ARG, n)
+  CHECK_NULL(3, MPI_ERR_ARG, ranks1)
+  CHECK_NULL(5, MPI_ERR_ARG, ranks2)
+  CHECK_GROUP(4, group2)
+  for (int i = 0; i < n; i++) {
+    if (ranks1[i] != MPI_PROC_NULL && (ranks1[i] < 0 || ranks1[i] >= group1->size()))
+      return MPI_ERR_RANK;
+    if(ranks1[i]==MPI_PROC_NULL){
+      ranks2[i]=MPI_PROC_NULL;
+    }else{
+      aid_t actor = group1->actor(ranks1[i]);
+      ranks2[i] = group2->rank(actor);
     }
-    return MPI_SUCCESS;
   }
+  return MPI_SUCCESS;
 }
 
 int PMPI_Group_compare(MPI_Group group1, MPI_Group group2, int *result)
 {
-  if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (result == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    *result = group1->compare(group2);
-    return MPI_SUCCESS;
-  }
+  CHECK_GROUP(1, group1)
+  CHECK_GROUP(2, group2)
+  CHECK_NULL(3, MPI_ERR_ARG, result)
+  *result = group1->compare(group2);
+  return MPI_SUCCESS;
 }
 
 int PMPI_Group_union(MPI_Group group1, MPI_Group group2, MPI_Group * newgroup)
 {
-
-  if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (newgroup == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    return group1->group_union(group2, newgroup);
-  }
+  CHECK_GROUP(1, group1)
+  CHECK_GROUP(2, group2)
+  CHECK_NULL(3, MPI_ERR_ARG, newgroup)
+  return group1->group_union(group2, newgroup);
 }
 
 int PMPI_Group_intersection(MPI_Group group1, MPI_Group group2, MPI_Group * newgroup)
 {
-
-  if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (newgroup == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    return group1->intersection(group2,newgroup);
+  CHECK_GROUP(1, group1)
+  CHECK_GROUP(2, group2)
+  CHECK_NULL(3, MPI_ERR_ARG, newgroup)
+  if(group1 == MPI_GROUP_EMPTY || group2 == MPI_GROUP_EMPTY){
+    *newgroup = MPI_GROUP_EMPTY;
+    return MPI_SUCCESS;
   }
+  return group1->intersection(group2,newgroup);
 }
 
 int PMPI_Group_difference(MPI_Group group1, MPI_Group group2, MPI_Group * newgroup)
 {
-  if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (newgroup == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    return group1->difference(group2,newgroup);
-  }
+  CHECK_GROUP(1, group1)
+  CHECK_GROUP(2, group2)
+  CHECK_NULL(3, MPI_ERR_ARG, newgroup)
+  return group1->difference(group2,newgroup);
 }
 
+#define CHECK_GROUP_RANKS(group, n, ranks)                                                                             \
+  for (int i = 0; i < (n); i++) {                                                                                      \
+    if ((ranks)[i] < 0 || (ranks)[i] >= (group)->size())                                                               \
+      return MPI_ERR_RANK;                                                                                             \
+    for (int j = i + 1; j < (n); j++) {                                                                                \
+      if ((ranks)[i] == (ranks)[j])                                                                                    \
+        return MPI_ERR_RANK;                                                                                           \
+    }                                                                                                                  \
+  }                                                                                                                    \
+  if ((n) > (group)->size()) {                                                                                         \
+    XBT_WARN("%s, param 2 > group size", __func__);                                                                    \
+    return MPI_ERR_ARG;                                                                                                \
+  }
+
 int PMPI_Group_incl(MPI_Group group, int n, const int *ranks, MPI_Group * newgroup)
 {
-  if (group == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (newgroup == nullptr) {
-    return MPI_ERR_ARG;
-  } else {
-    return group->incl(n, ranks, newgroup);
-  }
+  CHECK_GROUP(1, group)
+  CHECK_NEGATIVE(2, MPI_ERR_ARG, n)
+  CHECK_NULL(3, MPI_ERR_ARG, ranks)
+  CHECK_NULL(4, MPI_ERR_ARG, newgroup)
+  CHECK_GROUP_RANKS(group, n, ranks)
+  return group->incl(n, ranks, newgroup);
 }
 
 int PMPI_Group_excl(MPI_Group group, int n, const int *ranks, MPI_Group * newgroup)
 {
-  if (group == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (newgroup == nullptr) {
-    return MPI_ERR_ARG;
+  CHECK_GROUP(1, group)
+  CHECK_NEGATIVE(2, MPI_ERR_ARG, n)
+  CHECK_NULL(3, MPI_ERR_ARG, ranks)
+  CHECK_NULL(4, MPI_ERR_ARG, newgroup)
+  CHECK_GROUP_RANKS(group, n, ranks)
+  if (n == 0) {
+    *newgroup = group;
+    if (group != MPI_GROUP_EMPTY &&
+        group != MPI_COMM_WORLD->group() &&
+        ((smpi_process()->comm_self_is_set()) || (group != MPI_COMM_SELF->group())))
+      group->ref();
+    return MPI_SUCCESS;
+  } else if (n == group->size()) {
+    *newgroup = MPI_GROUP_EMPTY;
+    return MPI_SUCCESS;
   } else {
-    if (n == 0) {
-      *newgroup = group;
-      if (group != MPI_COMM_WORLD->group() && group != MPI_COMM_SELF->group() && group != MPI_GROUP_EMPTY)
-        group->ref();
-      return MPI_SUCCESS;
-    } else if (n == group->size()) {
-      *newgroup = MPI_GROUP_EMPTY;
-      return MPI_SUCCESS;
-    } else {
-      return group->excl(n,ranks,newgroup);
-    }
+    return group->excl(n,ranks,newgroup);
   }
 }
 
+#undef CHECK_GROUP_RANKS
+
+#define CHECK_GROUP_RANGES(group, n, ranges)                                                                           \
+  for (int i = 0; i < (n); i++) {                                                                                      \
+    if ((ranges)[i][0] < 0 || (ranges)[i][0] >= (group)->size() || (ranges)[i][1] < 0 ||                               \
+        (ranges)[i][1] >= (group)->size()) {                                                                           \
+      return MPI_ERR_RANK;                                                                                             \
+    }                                                                                                                  \
+    if (((ranges)[i][0] < (ranges)[i][1] && (ranges)[i][2] < 0) ||                                                     \
+        ((ranges)[i][0] > (ranges)[i][1] && (ranges)[i][2] > 0)) {                                                     \
+      return MPI_ERR_ARG;                                                                                              \
+    }                                                                                                                  \
+    if ((ranges)[i][2] == 0)                                                                                           \
+      return MPI_ERR_ARG;                                                                                              \
+  }                                                                                                                    \
+  if ((n) > (group)->size()) {                                                                                         \
+    XBT_WARN("%s, param 2 > group size", __func__);                                                                    \
+    return MPI_ERR_ARG;                                                                                                \
+  }
+
 int PMPI_Group_range_incl(MPI_Group group, int n, int ranges[][3], MPI_Group * newgroup)
 {
-  if (group == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (newgroup == nullptr) {
-    return MPI_ERR_ARG;
+  CHECK_GROUP(1, group)
+  CHECK_NEGATIVE(2, MPI_ERR_ARG, n)
+  CHECK_NULL(3, MPI_ERR_ARG, ranges)
+  CHECK_NULL(4, MPI_ERR_ARG, newgroup)
+  CHECK_GROUP_RANGES(group, n, ranges)
+  if (n == 0) {
+    *newgroup = MPI_GROUP_EMPTY;
+    return MPI_SUCCESS;
   } else {
-    if (n == 0) {
-      *newgroup = MPI_GROUP_EMPTY;
-      return MPI_SUCCESS;
-    } else {
-      return group->range_incl(n,ranges,newgroup);
-    }
+    return group->range_incl(n,ranges,newgroup);
   }
 }
 
 int PMPI_Group_range_excl(MPI_Group group, int n, int ranges[][3], MPI_Group * newgroup)
 {
-  if (group == MPI_GROUP_NULL) {
-    return MPI_ERR_GROUP;
-  } else if (newgroup == nullptr) {
-    return MPI_ERR_ARG;
+  CHECK_GROUP(1, group)
+  CHECK_NEGATIVE(2, MPI_ERR_ARG, n)
+  CHECK_NULL(3, MPI_ERR_ARG, ranges)
+  CHECK_NULL(4, MPI_ERR_ARG, newgroup)
+  CHECK_GROUP_RANGES(group, n, ranges)
+  if (n == 0) {
+    *newgroup = group;
+    if (group != MPI_GROUP_EMPTY &&
+        group != MPI_COMM_WORLD->group() &&
+        ((smpi_process()->comm_self_is_set()) || (group != MPI_COMM_SELF->group())))
+      group->ref();
+    return MPI_SUCCESS;
   } else {
-    if (n == 0) {
-      *newgroup = group;
-      if (group != MPI_COMM_WORLD->group() && group != MPI_COMM_SELF->group() &&
-          group != MPI_GROUP_EMPTY)
-        group->ref();
-      return MPI_SUCCESS;
-    } else {
-      return group->range_excl(n,ranges,newgroup);
-    }
+    return group->range_excl(n,ranges,newgroup);
   }
 }
 
+#undef CHECK_GROUP_RANGES
+
 MPI_Group PMPI_Group_f2c(MPI_Fint group){
+  if(group==-1)
+    return MPI_GROUP_NULL;
   return simgrid::smpi::Group::f2c(group);
 }
 
 MPI_Fint PMPI_Group_c2f(MPI_Group group){
+  if(group==MPI_GROUP_NULL)
+    return -1;
   return group->c2f();
 }