X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/eadbe829389f23151f79257824f3164d7801bbc7..271068c7d949ed959313b055466e13539485bc2c:/src/plugins/host_dvfs.cpp diff --git a/src/plugins/host_dvfs.cpp b/src/plugins/host_dvfs.cpp index 0cca4f8c2d..2466f28eb0 100644 --- a/src/plugins/host_dvfs.cpp +++ b/src/plugins/host_dvfs.cpp @@ -221,9 +221,9 @@ public: * * > The CPUfreq governor "conservative", much like the "ondemand" * > governor, sets the CPU frequency depending on the current usage. It - * > differs in behaviour in that it gracefully increases and decreases the + * > differs in behavior in that it gracefully increases and decreases the * > CPU speed rather than jumping to max speed the moment there is any load - * > on the CPU. This behaviour is more suitable in a battery powered + * > on the CPU. This behavior is more suitable in a battery powered * > environment. */ class Conservative : public Governor { @@ -293,19 +293,17 @@ public: task_id = 0; } }); - simgrid::kernel::activity::ExecImpl::on_creation.connect( - [this](simgrid::kernel::activity::ExecImpl const& activity) { - if (activity.host_ == get_host()) - pre_task(); - }); - simgrid::kernel::activity::ExecImpl::on_completion.connect( - [this](simgrid::kernel::activity::ExecImpl const& activity) { - // For more than one host (not yet supported), we can access the host via - // simcalls_.front()->issuer->iface()->get_host() - if (activity.host_ == get_host() && iteration_running) { - comp_timer += activity.surf_action_->get_finish_time() - activity.surf_action_->get_start_time(); - } - }); + simgrid::s4u::Exec::on_start.connect([this](simgrid::s4u::Actor const&, simgrid::s4u::Exec const& activity) { + if (activity.get_host() == get_host()) + pre_task(); + }); + simgrid::s4u::Exec::on_completion.connect([this](simgrid::s4u::Actor const&, simgrid::s4u::Exec const& activity) { + // For more than one host (not yet supported), we can access the host via + // simcalls_.front()->issuer->iface()->get_host() + if (activity.get_host() == get_host() && iteration_running) { + comp_timer += activity.get_finish_time() - activity.get_start_time(); + } + }); // FIXME I think that this fires at the same time for all hosts, so when the src sends something, // the dst will be notified even though it didn't even arrive at the recv yet simgrid::s4u::Link::on_communicate.connect( @@ -336,9 +334,8 @@ public: { double computed_flops = sg_host_get_computed_flops(get_host()) - comp_counter; double target_time = (simgrid::s4u::Engine::get_clock() - start_time); - target_time = - target_time * - static_cast(99.0 / 100.0); // FIXME We account for t_copy arbitrarily with 1% -- this needs to be fixed + target_time = target_time * 99.0 / 100.0; // FIXME We account for t_copy arbitrarily with 1% + // -- this needs to be fixed bool is_initialized = rates[task_id][best_pstate] != 0; rates[task_id][best_pstate] = computed_flops / comp_timer; @@ -440,7 +437,7 @@ static void on_host_added(simgrid::s4u::Host& host) /* **************************** Public interface *************************** */ -/** @ingroup SURF_plugin_load +/** * @brief Initializes the HostDvfs plugin * @details The HostDvfs plugin provides an API to get the current load of each host. */