X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/ea5d4ac6b57a3771a16f9a998179688088f8b96c..fb47192844897233f23f85dbd9776bf7dc8c5f83:/src/instr/instr_routing.c

diff --git a/src/instr/instr_routing.c b/src/instr/instr_routing.c
index ac379d73cf..0802395057 100644
--- a/src/instr/instr_routing.c
+++ b/src/instr/instr_routing.c
@@ -18,42 +18,60 @@ extern xbt_dict_t defined_types; /* from instr_interface.c */
 static int platform_created = 0;            /* indicate whether the platform file has been traced */
 static xbt_dynar_t currentContainer = NULL; /* push and pop, used only in creation */
 
-static container_t findChild (container_t root, container_t a1)
+static container_t lowestCommonAncestor (container_t a1, container_t a2)
 {
-  if (root == a1) return root;
+  //this is only an optimization (since most of a1 and a2 share the same parent)
+  if (a1->father == a2->father) return a1->father;
 
-  xbt_dict_cursor_t cursor = NULL;
-  container_t child;
-  char *child_name;
-  xbt_dict_foreach(root->children, cursor, child_name, child) {
-    if (findChild (child, a1)) return child;
+  //create an array with all ancestors of a1
+  xbt_dynar_t ancestors_a1 = xbt_dynar_new(sizeof(container_t), NULL);
+  container_t p;
+  p = a1->father;
+  while (p){
+    xbt_dynar_push_as (ancestors_a1, container_t, p);
+    p = p->father;
   }
-  return NULL;
-}
 
-static container_t findCommonFather (container_t root, container_t a1, container_t a2)
-{
-  if (a1->father == a2->father) return a1->father;
+  //create an array with all ancestors of a2
+  xbt_dynar_t ancestors_a2 = xbt_dynar_new(sizeof(container_t), NULL);
+  p = a2->father;
+  while (p){
+    xbt_dynar_push_as (ancestors_a2, container_t, p);
+    p = p->father;
+  }
 
-  xbt_dict_cursor_t cursor = NULL;
-  container_t child;
-  char *child_name;
-  container_t a1_try = NULL;
-  container_t a2_try = NULL;
-  xbt_dict_foreach(root->children, cursor, child_name, child) {
-    a1_try = findChild (child, a1);
-    a2_try = findChild (child, a2);
-    if (a1_try && a2_try) return child;
+  //find the lowest ancestor
+  p = NULL;
+  int i = xbt_dynar_length (ancestors_a1) - 1;
+  int j = xbt_dynar_length (ancestors_a2) - 1;
+  while (i >= 0 && j >= 0){
+    container_t a1p = *(container_t*)xbt_dynar_get_ptr (ancestors_a1, i);
+    container_t a2p = *(container_t*)xbt_dynar_get_ptr (ancestors_a2, j);
+    if (a1p == a2p){
+      p = a1p;
+    }else{
+      break;
+    }
+    i--;
+    j--;
   }
-  return NULL;
+  xbt_dynar_free (&ancestors_a1);
+  xbt_dynar_free (&ancestors_a2);
+  return p;
 }
 
-static void linkContainers (container_t father, container_t src, container_t dst, xbt_dict_t filter)
+static void linkContainers (container_t src, container_t dst, xbt_dict_t filter)
 {
   //ignore loopback
   if (strcmp (src->name, "__loopback__") == 0 || strcmp (dst->name, "__loopback__") == 0)
     return;
 
+  //find common father
+  container_t father = lowestCommonAncestor (src, dst);
+  if (!father){
+    xbt_die ("common father unknown, this is a tracing problem");
+  }
+
   if (filter != NULL){
     //check if we already register this pair (we only need one direction)
     char aux1[INSTR_DEFAULT_STR_SIZE], aux2[INSTR_DEFAULT_STR_SIZE];
@@ -69,8 +87,11 @@ static void linkContainers (container_t father, container_t src, container_t dst
 
   //declare type
   char link_typename[INSTR_DEFAULT_STR_SIZE];
-  snprintf (link_typename, INSTR_DEFAULT_STR_SIZE, "%s-%s", src->type->name, dst->type->name);
-  type_t link_type = PJ_type_get (link_typename, father->type);
+  snprintf (link_typename, INSTR_DEFAULT_STR_SIZE, "%s-%s%s-%s%s",
+            father->type->name,
+            src->type->name, src->type->id,
+            dst->type->name, dst->type->id);
+  type_t link_type = PJ_type_get_or_null (link_typename, father->type);
   if (link_type == NULL){
     link_type = PJ_type_link_new (link_typename, father->type, src->type, dst->type);
   }
@@ -131,10 +152,10 @@ static void recursiveGraphExtraction (AS_t rc, container_t container, xbt_dict_t
           link_CM02_t *link = ((link_CM02_t*)xbt_dynar_get_ptr (route, i));
           char *link_name = (*link)->lmm_resource.generic_resource.name;
           container_t current = PJ_container_get(link_name);
-          linkContainers(container, previous, current, filter);
+          linkContainers(previous, current, filter);
           previous = current;
         }
-        linkContainers(container, previous, child2, filter);
+        linkContainers(previous, child2, filter);
 
       }else if (child1->kind == INSTR_AS &&
                 child2->kind == INSTR_AS &&
@@ -149,11 +170,11 @@ static void recursiveGraphExtraction (AS_t rc, container_t container, xbt_dict_t
         xbt_dynar_foreach (route->link_list, cpt, link) {
           char *link_name = ((link_CM02_t)link)->lmm_resource.generic_resource.name;
           container_t current = PJ_container_get(link_name);
-          linkContainers (container, previous, current, filter);
+          linkContainers (previous, current, filter);
           previous = current;
         }
         container_t last = PJ_container_get(route->dst_gateway);
-        linkContainers (container, previous, last, filter);
+        linkContainers (previous, last, filter);
         generic_free_route(route);
       }
     }
@@ -173,7 +194,7 @@ static void instr_routing_parse_start_AS (const char*id,const char*routing)
 
     if (TRACE_smpi_is_enabled()) {
       if (!TRACE_smpi_is_grouped()){
-        type_t mpi = PJ_type_get ("MPI", root->type);
+        type_t mpi = PJ_type_get_or_null ("MPI", root->type);
         if (mpi == NULL){
           mpi = PJ_type_container_new("MPI", root->type);
           PJ_type_state_new ("MPI_STATE", mpi);
@@ -229,11 +250,11 @@ static void instr_routing_parse_start_link (sg_platf_link_cbarg_t link)
     container_t new = PJ_container_new (link_name, INSTR_LINK, father);
 
     if (TRACE_categorized() || TRACE_uncategorized()){
-      type_t bandwidth = PJ_type_get ("bandwidth", new->type);
+      type_t bandwidth = PJ_type_get_or_null ("bandwidth", new->type);
       if (bandwidth == NULL){
         bandwidth = PJ_type_variable_new ("bandwidth", NULL, new->type);
       }
-      type_t latency = PJ_type_get ("latency", new->type);
+      type_t latency = PJ_type_get_or_null ("latency", new->type);
       if (latency == NULL){
         latency = PJ_type_variable_new ("latency", NULL, new->type);
       }
@@ -241,7 +262,7 @@ static void instr_routing_parse_start_link (sg_platf_link_cbarg_t link)
       new_pajeSetVariable (0, new, latency, latency_value);
     }
     if (TRACE_uncategorized()){
-      type_t bandwidth_used = PJ_type_get ("bandwidth_used", new->type);
+      type_t bandwidth_used = PJ_type_get_or_null ("bandwidth_used", new->type);
       if (bandwidth_used == NULL){
         bandwidth_used = PJ_type_variable_new ("bandwidth_used", "0.5 0.5 0.5", new->type);
       }
@@ -257,21 +278,21 @@ static void instr_routing_parse_start_host (sg_platf_host_cbarg_t host)
   container_t new = PJ_container_new (host->id, INSTR_HOST, father);
 
   if (TRACE_categorized() || TRACE_uncategorized()) {
-    type_t power = PJ_type_get ("power", new->type);
+    type_t power = PJ_type_get_or_null ("power", new->type);
     if (power == NULL){
       power = PJ_type_variable_new ("power", NULL, new->type);
     }
     new_pajeSetVariable (0, new, power, host->power_peak);
   }
   if (TRACE_uncategorized()){
-    type_t power_used = PJ_type_get ("power_used", new->type);
+    type_t power_used = PJ_type_get_or_null ("power_used", new->type);
     if (power_used == NULL){
       power_used = PJ_type_variable_new ("power_used", "0.5 0.5 0.5", new->type);
     }
   }
 
   if (TRACE_smpi_is_enabled() && TRACE_smpi_is_grouped()){
-    type_t mpi = PJ_type_get ("MPI", new->type);
+    type_t mpi = PJ_type_get_or_null ("MPI", new->type);
     if (mpi == NULL){
       mpi = PJ_type_container_new("MPI", new->type);
       PJ_type_state_new ("MPI_STATE", mpi);
@@ -280,7 +301,7 @@ static void instr_routing_parse_start_host (sg_platf_host_cbarg_t host)
   }
 
   if (TRACE_msg_process_is_enabled()) {
-    type_t msg_process = PJ_type_get ("MSG_PROCESS", new->type);
+    type_t msg_process = PJ_type_get_or_null ("MSG_PROCESS", new->type);
     if (msg_process == NULL){
       msg_process = PJ_type_container_new("MSG_PROCESS", new->type);
       type_t state = PJ_type_state_new ("MSG_PROCESS_STATE", msg_process);