X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/e709643ef0c5b61c6c878016c418bffa2b1b20cd..e6f836d79ad3def5358ceafe9c4640fbf163cc42:/src/instr/instr_platform.cpp diff --git a/src/instr/instr_platform.cpp b/src/instr/instr_platform.cpp index f0f6442bf6..5b88ebd177 100644 --- a/src/instr/instr_platform.cpp +++ b/src/instr/instr_platform.cpp @@ -29,22 +29,23 @@ std::string instr_pid(simgrid::s4u::Actor const& proc) return std::string(proc.get_name()) + "-" + std::to_string(proc.get_pid()); } -static container_t lowestCommonAncestor(const simgrid::instr::Container* a1, const simgrid::instr::Container* a2) +static simgrid::instr::Container* lowestCommonAncestor(const simgrid::instr::Container* a1, + const simgrid::instr::Container* a2) { // this is only an optimization (since most of a1 and a2 share the same parent) if (a1->father_ == a2->father_) return a1->father_; // create an array with all ancestors of a1 - std::vector ancestors_a1; - container_t p = a1->father_; + std::vector ancestors_a1; + simgrid::instr::Container* p = a1->father_; while (p) { ancestors_a1.push_back(p); p = p->father_; } // create an array with all ancestors of a2 - std::vector ancestors_a2; + std::vector ancestors_a2; p = a2->father_; while (p) { ancestors_a2.push_back(p); @@ -56,7 +57,7 @@ static container_t lowestCommonAncestor(const simgrid::instr::Container* a1, con int i = static_cast(ancestors_a1.size()) - 1; int j = static_cast(ancestors_a2.size()) - 1; while (i >= 0 && j >= 0) { - container_t a1p = ancestors_a1.at(i); + simgrid::instr::Container* a1p = ancestors_a1.at(i); const simgrid::instr::Container* a2p = ancestors_a2.at(j); if (a1p == a2p) { p = a1p; @@ -69,7 +70,8 @@ static container_t lowestCommonAncestor(const simgrid::instr::Container* a1, con return p; } -static void linkContainers(container_t src, container_t dst, std::set* filter) +static void linkContainers(simgrid::instr::Container* src, simgrid::instr::Container* dst, + std::set* filter) { // ignore loopback if (src->get_name() == "__loopback__" || dst->get_name() == "__loopback__") { @@ -78,7 +80,7 @@ static void linkContainers(container_t src, container_t dst, std::set %s", src->get_cname(), dst->get_cname()); } -static void recursiveGraphExtraction(const simgrid::s4u::NetZone* netzone, container_t container, +static void recursiveGraphExtraction(const simgrid::s4u::NetZone* netzone, simgrid::instr::Container* container, std::set* filter) { if (not TRACE_platform_topology()) { @@ -129,23 +131,21 @@ static void recursiveGraphExtraction(const simgrid::s4u::NetZone* netzone, conta if (not netzone->get_children().empty()) { // bottom-up recursion for (auto const& nz_son : netzone->get_children()) { - container_t child_container = container->children_.at(nz_son->get_name()); + simgrid::instr::Container* child_container = container->children_.at(nz_son->get_name()); recursiveGraphExtraction(nz_son, child_container, filter); } } - xbt_graph_t graph = xbt_graph_new_graph(0, nullptr); - std::map* nodes = new std::map(); - std::map* edges = new std::map(); + auto* graph = xbt_graph_new_graph(0, nullptr); + std::map nodes; + std::map edges; - netzone->get_impl()->get_graph(graph, nodes, edges); - for (auto elm : *edges) { + netzone->get_impl()->get_graph(graph, &nodes, &edges); + for (auto elm : edges) { const xbt_edge* edge = elm.second; linkContainers(simgrid::instr::Container::by_name(static_cast(edge->src->data)), simgrid::instr::Container::by_name(static_cast(edge->dst->data)), filter); } - delete nodes; - delete edges; xbt_graph_free_graph(graph, xbt_free_f, xbt_free_f, nullptr); } @@ -222,10 +222,10 @@ namespace instr { void platform_graph_export_graphviz(const std::string& output_filename) { - xbt_graph_t g = xbt_graph_new_graph(0, nullptr); - std::map* nodes = new std::map(); - std::map* edges = new std::map(); - s4u::Engine::get_instance()->get_netzone_root()->extract_xbt_graph(g, nodes, edges); + auto* g = xbt_graph_new_graph(0, nullptr); + std::map nodes; + std::map edges; + s4u::Engine::get_instance()->get_netzone_root()->extract_xbt_graph(g, &nodes, &edges); std::ofstream fs; fs.open(output_filename, std::ofstream::out); @@ -241,10 +241,10 @@ void platform_graph_export_graphviz(const std::string& output_filename) fs << " node [shape=box, style=filled]" << std::endl; fs << " node [width=.3, height=.3, style=filled, color=skyblue]" << std::endl << std::endl; - for (auto const& elm : *nodes) + for (auto const& elm : nodes) fs << " \"" << elm.first << "\";" << std::endl; - for (auto const& elm : *edges) { + for (auto const& elm : edges) { const char* src_s = static_cast(elm.second->src->data); const char* dst_s = static_cast(elm.second->dst->data); if (g->directed) @@ -256,8 +256,6 @@ void platform_graph_export_graphviz(const std::string& output_filename) fs.close(); xbt_graph_free_graph(g, xbt_free_f, xbt_free_f, nullptr); - delete nodes; - delete edges; } /* Callbacks */ @@ -266,11 +264,11 @@ static void on_netzone_creation(s4u::NetZone const& netzone) { std::string id = netzone.get_name(); if (Container::get_root() == nullptr) { - NetZoneContainer* root = new NetZoneContainer(id, 0, nullptr); + auto* root = new NetZoneContainer(id, 0, nullptr); xbt_assert(Container::get_root() == root); if (TRACE_smpi_is_enabled()) { - ContainerType* mpi = root->type_->by_name_or_create("MPI"); + auto* mpi = root->type_->by_name_or_create("MPI"); if (not TRACE_smpi_is_grouped()) mpi->by_name_or_create("MPI_STATE"); root->type_->by_name_or_create("MPI_LINK", mpi, mpi); @@ -286,8 +284,8 @@ static void on_netzone_creation(s4u::NetZone const& netzone) } if (TRACE_needs_platform()) { - unsigned level = static_cast(currentContainer.size()); - NetZoneContainer* container = new NetZoneContainer(id, level, currentContainer.back()); + auto level = static_cast(currentContainer.size()); + auto* container = new NetZoneContainer(id, level, currentContainer.back()); currentContainer.push_back(container); } } @@ -297,7 +295,7 @@ static void on_link_creation(s4u::Link const& link) if (currentContainer.empty()) // No ongoing parsing. Are you creating the loopback? return; - Container* container = new Container(link.get_name(), "LINK", currentContainer.back()); + auto* container = new Container(link.get_name(), "LINK", currentContainer.back()); if ((TRACE_categorized() || TRACE_uncategorized() || TRACE_platform()) && (not TRACE_disable_link())) { VariableType* bandwidth = container->type_->by_name_or_create("bandwidth", ""); @@ -332,7 +330,7 @@ static void on_host_creation(s4u::Host const& host) container->type_->by_name_or_create("speed_used", "0.5 0.5 0.5"); if (TRACE_smpi_is_enabled() && TRACE_smpi_is_grouped()) { - ContainerType* mpi = container->type_->by_name_or_create("MPI"); + auto* mpi = container->type_->by_name_or_create("MPI"); mpi->by_name_or_create("MPI_STATE"); // TODO See if we can move this to the LoadBalancer plugin root->type_->by_name_or_create("MIGRATE_LINK", mpi, mpi); @@ -343,7 +341,7 @@ static void on_host_creation(s4u::Host const& host) static void on_action_state_change(kernel::resource::Action const& action, kernel::resource::Action::State /* previous */) { - unsigned n = static_cast(action.get_variable()->get_number_of_constraint()); + auto n = static_cast(action.get_variable()->get_number_of_constraint()); for (unsigned i = 0; i < n; i++) { double value = action.get_variable()->get_value() * action.get_variable()->get_constraint_weight(i); @@ -366,11 +364,10 @@ static void on_action_state_change(kernel::resource::Action const& action, static void on_platform_created() { currentContainer.clear(); - std::set* filter = new std::set(); + std::set filter; XBT_DEBUG("Starting graph extraction."); - recursiveGraphExtraction(s4u::Engine::get_instance()->get_netzone_root(), Container::get_root(), filter); + recursiveGraphExtraction(s4u::Engine::get_instance()->get_netzone_root(), Container::get_root(), &filter); XBT_DEBUG("Graph extraction finished."); - delete filter; dump_buffer(true); } @@ -381,8 +378,8 @@ static void on_actor_creation(s4u::Actor const& actor) std::string container_name = instr_pid(actor); container->create_child(container_name, "ACTOR"); - ContainerType* actor_type = container->type_->by_name_or_create("ACTOR"); - StateType* state = actor_type->by_name_or_create("ACTOR_STATE"); + auto* actor_type = container->type_->by_name_or_create("ACTOR"); + auto* state = actor_type->by_name_or_create("ACTOR_STATE"); state->add_entity_value("suspend", "1 0 1"); state->add_entity_value("sleep", "1 1 0"); state->add_entity_value("receive", "1 0 0"); @@ -400,7 +397,7 @@ static void on_actor_creation(s4u::Actor const& actor) static void on_actor_host_change(s4u::Actor const& actor, s4u::Host const& /*previous_location*/) { static long long int counter = 0; - container_t container = Container::by_name(instr_pid(actor)); + Container* container = Container::by_name(instr_pid(actor)); LinkType* link = Container::get_root()->get_link("ACTOR_LINK"); // start link @@ -418,8 +415,8 @@ static void on_vm_creation(s4u::Host const& host) { const Container* container = new HostContainer(host, currentContainer.back()); const Container* root = Container::get_root(); - ContainerType* vm = container->type_->by_name_or_create("VM"); - StateType* state = vm->by_name_or_create("VM_STATE"); + auto* vm = container->type_->by_name_or_create("VM"); + auto* state = vm->by_name_or_create("VM_STATE"); state->add_entity_value("suspend", "1 0 1"); state->add_entity_value("sleep", "1 1 0"); state->add_entity_value("receive", "1 0 0");