X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/de990633aaf39e92d639a9b190bcef1d6219a780..003b5738f292534807ec502bebc5704810798902:/src/smpi/smpi_pmpi.cpp diff --git a/src/smpi/smpi_pmpi.cpp b/src/smpi/smpi_pmpi.cpp index 5c00ad0ccf..5335aedad3 100644 --- a/src/smpi/smpi_pmpi.cpp +++ b/src/smpi/smpi_pmpi.cpp @@ -1,10 +1,11 @@ - -/* Copyright (c) 2007-2015. The SimGrid Team. - * All rights reserved. */ +/* Copyright (c) 2007-2017. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ +#include +#include + #include "private.h" #include "smpi_mpi_dt_private.h" @@ -21,13 +22,14 @@ void TRACE_smpi_set_category(const char *category) } /* PMPI User level calls */ +extern "C" { // Obviously, the C MPI interface should use the C linkage int PMPI_Init(int *argc, char ***argv) { // PMPI_Init is call only one time by only by SMPI process int already_init; MPI_Initialized(&already_init); - if(!(already_init)){ + if(already_init == 0){ smpi_process_init(argc, argv); smpi_process_mark_as_initialized(); int rank = smpi_process_index(); @@ -39,10 +41,13 @@ int PMPI_Init(int *argc, char ***argv) TRACE_smpi_collective_out(rank, -1, __FUNCTION__); smpi_bench_begin(); } + + smpi_mpi_init(); + return MPI_SUCCESS; } -int PMPI_Finalize(void) +int PMPI_Finalize() { smpi_bench_end(); int rank = smpi_process_index(); @@ -71,18 +76,17 @@ int PMPI_Get_version (int *version,int *subversion){ } int PMPI_Get_library_version (char *version,int *len){ - int retval = MPI_SUCCESS; smpi_bench_end(); snprintf(version,MPI_MAX_LIBRARY_VERSION_STRING,"SMPI Version %d.%d. Copyright The Simgrid Team 2007-2015", SIMGRID_VERSION_MAJOR, SIMGRID_VERSION_MINOR); *len = strlen(version) > MPI_MAX_LIBRARY_VERSION_STRING ? MPI_MAX_LIBRARY_VERSION_STRING : strlen(version); smpi_bench_begin(); - return retval; + return MPI_SUCCESS; } int PMPI_Init_thread(int *argc, char ***argv, int required, int *provided) { - if (provided != NULL) { + if (provided != nullptr) { *provided = MPI_THREAD_SINGLE; } return MPI_Init(argc, argv); @@ -90,28 +94,22 @@ int PMPI_Init_thread(int *argc, char ***argv, int required, int *provided) int PMPI_Query_thread(int *provided) { - int retval = 0; - - if (provided == NULL) { - retval = MPI_ERR_ARG; + if (provided == nullptr) { + return MPI_ERR_ARG; } else { *provided = MPI_THREAD_SINGLE; - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Is_thread_main(int *flag) { - int retval = 0; - - if (flag == NULL) { - retval = MPI_ERR_ARG; + if (flag == nullptr) { + return MPI_ERR_ARG; } else { *flag = smpi_process_index() == 0; - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Abort(MPI_Comm comm, int errorcode) @@ -123,28 +121,25 @@ int PMPI_Abort(MPI_Comm comm, int errorcode) return MPI_SUCCESS; } -double PMPI_Wtime(void) +double PMPI_Wtime() { return smpi_mpi_wtime(); } extern double sg_maxmin_precision; -double PMPI_Wtick(void) +double PMPI_Wtick() { return sg_maxmin_precision; } int PMPI_Address(void *location, MPI_Aint * address) { - int retval = 0; - - if (!address) { - retval = MPI_ERR_ARG; + if (address==nullptr) { + return MPI_ERR_ARG; } else { - *address = (MPI_Aint) location; - retval = MPI_SUCCESS; + *address = reinterpret_cast(location); + return MPI_SUCCESS; } - return retval; } int PMPI_Get_address(void *location, MPI_Aint * address) @@ -154,44 +149,48 @@ int PMPI_Get_address(void *location, MPI_Aint * address) int PMPI_Type_free(MPI_Datatype * datatype) { - int retval = 0; /* Free a predefined datatype is an error according to the standard, and should be checked for */ if (*datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_ARG; } else { - smpi_datatype_free(datatype); - retval = MPI_SUCCESS; + smpi_datatype_unuse(*datatype); + return MPI_SUCCESS; } - return retval; } int PMPI_Type_size(MPI_Datatype datatype, int *size) { - int retval = 0; + if (datatype == MPI_DATATYPE_NULL) { + return MPI_ERR_TYPE; + } else if (size == nullptr) { + return MPI_ERR_ARG; + } else { + *size = static_cast(smpi_datatype_size(datatype)); + return MPI_SUCCESS; + } +} +int PMPI_Type_size_x(MPI_Datatype datatype, MPI_Count *size) +{ if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; - } else if (size == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (size == nullptr) { + return MPI_ERR_ARG; } else { - *size = (int) smpi_datatype_size(datatype); - retval = MPI_SUCCESS; + *size = static_cast(smpi_datatype_size(datatype)); + return MPI_SUCCESS; } - return retval; } int PMPI_Type_get_extent(MPI_Datatype datatype, MPI_Aint * lb, MPI_Aint * extent) { - int retval = 0; - if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; - } else if (lb == NULL || extent == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (lb == nullptr || extent == nullptr) { + return MPI_ERR_ARG; } else { - retval = smpi_datatype_extent(datatype, lb, extent); + return smpi_datatype_extent(datatype, lb, extent); } - return retval; } int PMPI_Type_get_true_extent(MPI_Datatype datatype, MPI_Aint * lb, MPI_Aint * extent) @@ -201,181 +200,148 @@ int PMPI_Type_get_true_extent(MPI_Datatype datatype, MPI_Aint * lb, MPI_Aint * e int PMPI_Type_extent(MPI_Datatype datatype, MPI_Aint * extent) { - int retval = 0; - if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; - } else if (extent == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (extent == nullptr) { + return MPI_ERR_ARG; } else { *extent = smpi_datatype_get_extent(datatype); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Type_lb(MPI_Datatype datatype, MPI_Aint * disp) { - int retval = 0; - if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; - } else if (disp == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (disp == nullptr) { + return MPI_ERR_ARG; } else { *disp = smpi_datatype_lb(datatype); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Type_ub(MPI_Datatype datatype, MPI_Aint * disp) { - int retval = 0; - if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; - } else if (disp == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (disp == nullptr) { + return MPI_ERR_ARG; } else { *disp = smpi_datatype_ub(datatype); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Type_dup(MPI_Datatype datatype, MPI_Datatype *newtype){ - int retval = 0; - if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else { - retval = smpi_datatype_dup(datatype, newtype); + return smpi_datatype_dup(datatype, newtype); } - return retval; } int PMPI_Op_create(MPI_User_function * function, int commute, MPI_Op * op) { - int retval = 0; - - if (function == NULL || op == NULL) { - retval = MPI_ERR_ARG; + if (function == nullptr || op == nullptr) { + return MPI_ERR_ARG; } else { - *op = smpi_op_new(function, commute); - retval = MPI_SUCCESS; + *op = smpi_op_new(function, (commute!=0)); + return MPI_SUCCESS; } - return retval; } int PMPI_Op_free(MPI_Op * op) { - int retval = 0; - - if (op == NULL) { - retval = MPI_ERR_ARG; + if (op == nullptr) { + return MPI_ERR_ARG; } else if (*op == MPI_OP_NULL) { - retval = MPI_ERR_OP; + return MPI_ERR_OP; } else { smpi_op_destroy(*op); *op = MPI_OP_NULL; - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_free(MPI_Group * group) { - int retval = 0; - - if (group == NULL) { - retval = MPI_ERR_ARG; + if (group == nullptr) { + return MPI_ERR_ARG; } else { smpi_group_destroy(*group); *group = MPI_GROUP_NULL; - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_size(MPI_Group group, int *size) { - int retval = 0; - if (group == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (size == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (size == nullptr) { + return MPI_ERR_ARG; } else { *size = smpi_group_size(group); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_rank(MPI_Group group, int *rank) { - int retval = 0; - if (group == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (rank == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (rank == nullptr) { + return MPI_ERR_ARG; } else { *rank = smpi_group_rank(group, smpi_process_index()); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_translate_ranks(MPI_Group group1, int n, int *ranks1, MPI_Group group2, int *ranks2) { - int retval, i, index; if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; + return MPI_ERR_GROUP; } else { - for (i = 0; i < n; i++) { + for (int i = 0; i < n; i++) { if(ranks1[i]==MPI_PROC_NULL){ ranks2[i]=MPI_PROC_NULL; }else{ - index = smpi_group_index(group1, ranks1[i]); + int index = smpi_group_index(group1, ranks1[i]); ranks2[i] = smpi_group_rank(group2, index); } } - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_compare(MPI_Group group1, MPI_Group group2, int *result) { - int retval = 0; - if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (result == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (result == nullptr) { + return MPI_ERR_ARG; } else { *result = smpi_group_compare(group1, group2); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_union(MPI_Group group1, MPI_Group group2, MPI_Group * newgroup) { - int retval, i, proc1, proc2, size, size2; if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (newgroup == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (newgroup == nullptr) { + return MPI_ERR_ARG; } else { - size = smpi_group_size(group1); - size2 = smpi_group_size(group2); - for (i = 0; i < size2; i++) { - proc2 = smpi_group_index(group2, i); - proc1 = smpi_group_rank(group1, proc2); + int size = smpi_group_size(group1); + int size2 = smpi_group_size(group2); + for (int i = 0; i < size2; i++) { + int proc2 = smpi_group_index(group2, i); + int proc1 = smpi_group_rank(group1, proc2); if (proc1 == MPI_UNDEFINED) { size++; } @@ -385,33 +351,31 @@ int PMPI_Group_union(MPI_Group group1, MPI_Group group2, MPI_Group * newgroup) } else { *newgroup = smpi_group_new(size); size2 = smpi_group_size(group1); - for (i = 0; i < size2; i++) { - proc1 = smpi_group_index(group1, i); + for (int i = 0; i < size2; i++) { + int proc1 = smpi_group_index(group1, i); smpi_group_set_mapping(*newgroup, proc1, i); } - for (i = size2; i < size; i++) { - proc2 = smpi_group_index(group2, i - size2); + for (int i = size2; i < size; i++) { + int proc2 = smpi_group_index(group2, i - size2); smpi_group_set_mapping(*newgroup, proc2, i); } } - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_intersection(MPI_Group group1, MPI_Group group2, MPI_Group * newgroup) { - int retval, i, proc1, proc2, size; if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (newgroup == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (newgroup == nullptr) { + return MPI_ERR_ARG; } else { - size = smpi_group_size(group2); - for (i = 0; i < size; i++) { - proc2 = smpi_group_index(group2, i); - proc1 = smpi_group_rank(group1, proc2); + int size = smpi_group_size(group2); + for (int i = 0; i < size; i++) { + int proc2 = smpi_group_index(group2, i); + int proc1 = smpi_group_rank(group1, proc2); if (proc1 == MPI_UNDEFINED) { size--; } @@ -421,33 +385,31 @@ int PMPI_Group_intersection(MPI_Group group1, MPI_Group group2, MPI_Group * newg } else { *newgroup = smpi_group_new(size); int j=0; - for (i = 0; i < smpi_group_size(group2); i++) { - proc2 = smpi_group_index(group2, i); - proc1 = smpi_group_rank(group1, proc2); + for (int i = 0; i < smpi_group_size(group2); i++) { + int proc2 = smpi_group_index(group2, i); + int proc1 = smpi_group_rank(group1, proc2); if (proc1 != MPI_UNDEFINED) { smpi_group_set_mapping(*newgroup, proc2, j); j++; } } } - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_difference(MPI_Group group1, MPI_Group group2, MPI_Group * newgroup) { - int retval, i, proc1, proc2, size, size2; - if (group1 == MPI_GROUP_NULL || group2 == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (newgroup == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (newgroup == nullptr) { + return MPI_ERR_ARG; } else { - size = size2 = smpi_group_size(group1); - for (i = 0; i < size2; i++) { - proc1 = smpi_group_index(group1, i); - proc2 = smpi_group_rank(group2, proc1); + int size = smpi_group_size(group1); + int size2 = size; + for (int i = 0; i < size2; i++) { + int proc1 = smpi_group_index(group1, i); + int proc2 = smpi_group_rank(group2, proc1); if (proc2 != MPI_UNDEFINED) { size--; } @@ -456,64 +418,58 @@ int PMPI_Group_difference(MPI_Group group1, MPI_Group group2, MPI_Group * newgro *newgroup = MPI_GROUP_EMPTY; } else { *newgroup = smpi_group_new(size); - for (i = 0; i < size2; i++) { - proc1 = smpi_group_index(group1, i); - proc2 = smpi_group_rank(group2, proc1); + for (int i = 0; i < size2; i++) { + int proc1 = smpi_group_index(group1, i); + int proc2 = smpi_group_rank(group2, proc1); if (proc2 == MPI_UNDEFINED) { smpi_group_set_mapping(*newgroup, proc1, i); } } } - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_incl(MPI_Group group, int n, int *ranks, MPI_Group * newgroup) { - int retval; - if (group == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (newgroup == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (newgroup == nullptr) { + return MPI_ERR_ARG; } else { - retval = smpi_group_incl(group, n, ranks, newgroup); + return smpi_group_incl(group, n, ranks, newgroup); } - return retval; } int PMPI_Group_excl(MPI_Group group, int n, int *ranks, MPI_Group * newgroup) { - int retval, i, j, newsize, oldsize, index; - if (group == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (newgroup == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (newgroup == nullptr) { + return MPI_ERR_ARG; } else { if (n == 0) { *newgroup = group; - if(group!= smpi_comm_group(MPI_COMM_WORLD) && group != MPI_GROUP_NULL + if (group != smpi_comm_group(MPI_COMM_WORLD) && group != smpi_comm_group(MPI_COMM_SELF) && group != MPI_GROUP_EMPTY) smpi_group_use(group); } else if (n == smpi_group_size(group)) { *newgroup = MPI_GROUP_EMPTY; } else { - oldsize=smpi_group_size(group); - newsize = oldsize - n; + int oldsize = smpi_group_size(group); + int newsize = oldsize - n; *newgroup = smpi_group_new(newsize); int* to_exclude=xbt_new0(int, smpi_group_size(group)); - for(i=0; i= 0 && rank < smpi_group_size(group); /* Last */ - ) { + ) { size++; if(rank == ranges[i][1]){/*already last ?*/ break; } rank += ranges[i][2]; /* Stride */ - if (ranges[i][0] ranges[i][1]) - break; - }else{ - if(rank < ranges[i][1]) - break; - } + if (ranges[i][0] < ranges[i][1]) { + if (rank > ranges[i][1]) + break; + } else { + if (rank < ranges[i][1]) + break; + } } } *newgroup = smpi_group_new(size); - j = 0; - for (i = 0; i < n; i++) { - for (rank = ranges[i][0]; /* First */ + int j = 0; + for (int i = 0; i < n; i++) { + for (int rank = ranges[i][0]; /* First */ rank >= 0 && rank < smpi_group_size(group); /* Last */ ) { - index = smpi_group_index(group, rank); + int index = smpi_group_index(group, rank); smpi_group_set_mapping(*newgroup, index, j); j++; if(rank == ranges[i][1]){/*already last ?*/ break; } rank += ranges[i][2]; /* Stride */ - if (ranges[i][0] ranges[i][1]) - break; - }else{ - if(rank < ranges[i][1]) - break; - } + if (ranges[i][0] < ranges[i][1]) { + if (rank > ranges[i][1]) + break; + } else { + if (rank < ranges[i][1]) + break; + } } } } - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Group_range_excl(MPI_Group group, int n, int ranges[][3], MPI_Group * newgroup) { - int retval, i, rank, newrank,oldrank, size, index, add; - if (group == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (newgroup == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (newgroup == nullptr) { + return MPI_ERR_ARG; } else { if (n == 0) { *newgroup = group; - if(group!= smpi_comm_group(MPI_COMM_WORLD) && group != MPI_GROUP_NULL - && group != smpi_comm_group(MPI_COMM_SELF) && group != MPI_GROUP_EMPTY) - smpi_group_use(group); + if (group != smpi_comm_group(MPI_COMM_WORLD) && group != smpi_comm_group(MPI_COMM_SELF) && + group != MPI_GROUP_EMPTY) + smpi_group_use(group); } else { - size = smpi_group_size(group); - for (i = 0; i < n; i++) { - for (rank = ranges[i][0]; /* First */ + int size = smpi_group_size(group); + for (int i = 0; i < n; i++) { + for (int rank = ranges[i][0]; /* First */ rank >= 0 && rank < smpi_group_size(group); /* Last */ - ) { + ) { size--; if(rank == ranges[i][1]){/*already last ?*/ break; } rank += ranges[i][2]; /* Stride */ - if (ranges[i][0] ranges[i][1]) - break; - }else{ - if(rank < ranges[i][1]) - break; - } + if (ranges[i][0] < ranges[i][1]) { + if (rank > ranges[i][1]) + break; + } else { + if (rank < ranges[i][1]) + break; + } } } if (size == 0) { *newgroup = MPI_GROUP_EMPTY; } else { *newgroup = smpi_group_new(size); - newrank=0; - oldrank=0; + int newrank = 0; + int oldrank = 0; while (newrank < size) { - add=1; - for (i = 0; i < n; i++) { - for (rank = ranges[i][0]; - rank >= 0 && rank < smpi_group_size(group); - ){ + int add = 1; + for (int i = 0; i < n; i++) { + for (int rank = ranges[i][0]; rank >= 0 && rank < smpi_group_size(group);) { if(rank==oldrank){ - add=0; - break; + add = 0; + break; } if(rank == ranges[i][1]){/*already last ?*/ break; } rank += ranges[i][2]; /* Stride */ if (ranges[i][0] ranges[i][1]) - break; + if (rank > ranges[i][1]) + break; }else{ - if(rank < ranges[i][1]) - break; + if (rank < ranges[i][1]) + break; } } } if(add==1){ - index = smpi_group_index(group, oldrank); + int index = smpi_group_index(group, oldrank); smpi_group_set_mapping(*newgroup, index, newrank); newrank++; } @@ -658,81 +606,66 @@ int PMPI_Group_range_excl(MPI_Group group, int n, int ranges[][3], MPI_Group * n } } } - - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_rank(MPI_Comm comm, int *rank) { - int retval = 0; if (comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; - } else if (rank == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_COMM; + } else if (rank == nullptr) { + return MPI_ERR_ARG; } else { *rank = smpi_comm_rank(comm); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_size(MPI_Comm comm, int *size) { - int retval = 0; if (comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; - } else if (size == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_COMM; + } else if (size == nullptr) { + return MPI_ERR_ARG; } else { *size = smpi_comm_size(comm); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_get_name (MPI_Comm comm, char* name, int* len) { - int retval = 0; - if (comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; - } else if (name == NULL || len == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_COMM; + } else if (name == nullptr || len == nullptr) { + return MPI_ERR_ARG; } else { smpi_comm_get_name(comm, name, len); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_group(MPI_Comm comm, MPI_Group * group) { - int retval = 0; - if (comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; - } else if (group == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_COMM; + } else if (group == nullptr) { + return MPI_ERR_ARG; } else { *group = smpi_comm_group(comm); - if(*group!= smpi_comm_group(MPI_COMM_WORLD) && *group != MPI_GROUP_NULL - && *group != smpi_comm_group(MPI_COMM_SELF) && *group != MPI_GROUP_EMPTY) - smpi_group_use(*group); - retval = MPI_SUCCESS; + if (*group != smpi_comm_group(MPI_COMM_WORLD) && *group != MPI_GROUP_NULL && *group != MPI_GROUP_EMPTY) + smpi_group_use(*group); + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_compare(MPI_Comm comm1, MPI_Comm comm2, int *result) { - int retval = 0; - if (comm1 == MPI_COMM_NULL || comm2 == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; - } else if (result == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_COMM; + } else if (result == nullptr) { + return MPI_ERR_ARG; } else { if (comm1 == comm2) { /* Same communicators means same groups */ *result = MPI_IDENT; @@ -742,77 +675,64 @@ int PMPI_Comm_compare(MPI_Comm comm1, MPI_Comm comm2, int *result) *result = MPI_CONGRUENT; } } - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_dup(MPI_Comm comm, MPI_Comm * newcomm) { - int retval = 0; - if (comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; - } else if (newcomm == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_COMM; + } else if (newcomm == nullptr) { + return MPI_ERR_ARG; } else { - retval = smpi_comm_dup(comm, newcomm); + return smpi_comm_dup(comm, newcomm); } - return retval; } int PMPI_Comm_create(MPI_Comm comm, MPI_Group group, MPI_Comm * newcomm) { - int retval = 0; - if (comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; + return MPI_ERR_COMM; } else if (group == MPI_GROUP_NULL) { - retval = MPI_ERR_GROUP; - } else if (newcomm == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_GROUP; + } else if (newcomm == nullptr) { + return MPI_ERR_ARG; } else if(smpi_group_rank(group,smpi_process_index())==MPI_UNDEFINED){ *newcomm= MPI_COMM_NULL; - retval = MPI_SUCCESS; + return MPI_SUCCESS; }else{ - - *newcomm = smpi_comm_new(group, NULL); - retval = MPI_SUCCESS; + smpi_group_use(group); + *newcomm = smpi_comm_new(group, nullptr); + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_free(MPI_Comm * comm) { - int retval = 0; - - if (comm == NULL) { - retval = MPI_ERR_ARG; + if (comm == nullptr) { + return MPI_ERR_ARG; } else if (*comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; + return MPI_ERR_COMM; } else { smpi_comm_destroy(*comm); *comm = MPI_COMM_NULL; - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_disconnect(MPI_Comm * comm) { /* TODO: wait until all communication in comm are done */ - int retval = 0; - - if (comm == NULL) { - retval = MPI_ERR_ARG; + if (comm == nullptr) { + return MPI_ERR_ARG; } else if (*comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; + return MPI_ERR_COMM; } else { smpi_comm_destroy(*comm); *comm = MPI_COMM_NULL; - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Comm_split(MPI_Comm comm, int color, int key, MPI_Comm* comm_out) @@ -820,7 +740,7 @@ int PMPI_Comm_split(MPI_Comm comm, int color, int key, MPI_Comm* comm_out) int retval = 0; smpi_bench_end(); - if (comm_out == NULL) { + if (comm_out == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -833,12 +753,29 @@ int PMPI_Comm_split(MPI_Comm comm, int color, int key, MPI_Comm* comm_out) return retval; } +int PMPI_Comm_create_group(MPI_Comm comm, MPI_Group group, int, MPI_Comm* comm_out) +{ + int retval = 0; + smpi_bench_end(); + + if (comm_out == nullptr) { + retval = MPI_ERR_ARG; + } else if (comm == MPI_COMM_NULL) { + retval = MPI_ERR_COMM; + } else { + retval = MPI_Comm_create(comm, group, comm_out); + } + smpi_bench_begin(); + + return retval; +} + int PMPI_Send_init(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MPI_Comm comm, MPI_Request * request) { int retval = 0; smpi_bench_end(); - if (request == NULL) { + if (request == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -851,7 +788,7 @@ int PMPI_Send_init(void *buf, int count, MPI_Datatype datatype, int dst, int tag retval = MPI_SUCCESS; } smpi_bench_begin(); - if (retval != MPI_SUCCESS && request) + if (retval != MPI_SUCCESS && request != nullptr) *request = MPI_REQUEST_NULL; return retval; } @@ -861,7 +798,7 @@ int PMPI_Recv_init(void *buf, int count, MPI_Datatype datatype, int src, int tag int retval = 0; smpi_bench_end(); - if (request == NULL) { + if (request == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -874,7 +811,7 @@ int PMPI_Recv_init(void *buf, int count, MPI_Datatype datatype, int src, int tag retval = MPI_SUCCESS; } smpi_bench_begin(); - if (retval != MPI_SUCCESS && request) + if (retval != MPI_SUCCESS && request != nullptr) *request = MPI_REQUEST_NULL; return retval; } @@ -884,7 +821,7 @@ int PMPI_Ssend_init(void* buf, int count, MPI_Datatype datatype, int dst, int ta int retval = 0; smpi_bench_end(); - if (request == NULL) { + if (request == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -897,7 +834,7 @@ int PMPI_Ssend_init(void* buf, int count, MPI_Datatype datatype, int dst, int ta retval = MPI_SUCCESS; } smpi_bench_begin(); - if (retval != MPI_SUCCESS && request) + if (retval != MPI_SUCCESS && request != nullptr) *request = MPI_REQUEST_NULL; return retval; } @@ -907,7 +844,7 @@ int PMPI_Start(MPI_Request * request) int retval = 0; smpi_bench_end(); - if (request == NULL || *request == MPI_REQUEST_NULL) { + if (request == nullptr || *request == MPI_REQUEST_NULL) { retval = MPI_ERR_REQUEST; } else { smpi_mpi_start(*request); @@ -920,13 +857,12 @@ int PMPI_Start(MPI_Request * request) int PMPI_Startall(int count, MPI_Request * requests) { int retval; - int i = 0; smpi_bench_end(); - if (requests == NULL) { + if (requests == nullptr) { retval = MPI_ERR_ARG; } else { retval = MPI_SUCCESS; - for (i = 0 ; i < count ; i++) { + for (int i = 0; i < count; i++) { if(requests[i] == MPI_REQUEST_NULL) { retval = MPI_ERR_REQUEST; } @@ -960,7 +896,7 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP smpi_bench_end(); - if (request == NULL) { + if (request == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -969,9 +905,7 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP retval = MPI_SUCCESS; } else if (src!=MPI_ANY_SOURCE && (src >= smpi_group_size(smpi_comm_group(comm)) || src <0)){ retval = MPI_ERR_RANK; - } else if (count < 0) { - retval = MPI_ERR_COUNT; - } else if (buf==NULL && count > 0) { + } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; } else if (!is_datatype_valid(datatype)) { retval = MPI_ERR_TYPE; @@ -989,7 +923,7 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP int known=0; extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; - if(!known) + if(known==0) dt_size_send = smpi_datatype_size(datatype); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra); @@ -1002,7 +936,7 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP } smpi_bench_begin(); - if (retval != MPI_SUCCESS && request) + if (retval != MPI_SUCCESS && request != nullptr) *request = MPI_REQUEST_NULL; return retval; } @@ -1013,7 +947,7 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP int retval = 0; smpi_bench_end(); - if (request == NULL) { + if (request == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -1022,16 +956,13 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP retval = MPI_SUCCESS; } else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){ retval = MPI_ERR_RANK; - } else if (count < 0) { - retval = MPI_ERR_COUNT; - } else if (buf==NULL && count > 0) { + } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; } else if (!is_datatype_valid(datatype)) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; int dst_traced = smpi_group_index(smpi_comm_group(comm), dst); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); @@ -1041,11 +972,11 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP int known=0; extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; - if(!known) + if(known==0) dt_size_send = smpi_datatype_size(datatype); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag, count*smpi_datatype_size(datatype)); *request = smpi_mpi_isend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; @@ -1055,7 +986,7 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP } smpi_bench_begin(); - if (retval != MPI_SUCCESS && request) + if (retval != MPI_SUCCESS && request!=nullptr) *request = MPI_REQUEST_NULL; return retval; } @@ -1065,7 +996,7 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M int retval = 0; smpi_bench_end(); - if (request == NULL) { + if (request == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -1074,16 +1005,13 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M retval = MPI_SUCCESS; } else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){ retval = MPI_ERR_RANK; - } else if (count < 0) { - retval = MPI_ERR_COUNT; - } else if (buf==NULL && count > 0) { + } else if ((count < 0)|| (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; } else if (!is_datatype_valid(datatype)) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; int dst_traced = smpi_group_index(smpi_comm_group(comm), dst); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); @@ -1093,11 +1021,11 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M int known=0; extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; - if(!known) + if(known==0) dt_size_send = smpi_datatype_size(datatype); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag, count*smpi_datatype_size(datatype)); *request = smpi_mpi_issend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; @@ -1107,7 +1035,7 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M } smpi_bench_begin(); - if (retval != MPI_SUCCESS && request) + if (retval != MPI_SUCCESS && request!=nullptr) *request = MPI_REQUEST_NULL; return retval; } @@ -1125,40 +1053,38 @@ int PMPI_Recv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MPI retval = MPI_SUCCESS; } else if (src!=MPI_ANY_SOURCE && (src >= smpi_group_size(smpi_comm_group(comm)) || src <0)){ retval = MPI_ERR_RANK; - } else if (count < 0) { - retval = MPI_ERR_COUNT; - } else if (buf==NULL && count > 0) { + } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; } else if (!is_datatype_valid(datatype)) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int src_traced = smpi_group_index(smpi_comm_group(comm), src); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_RECV; - extra->src = src_traced; - extra->dst = rank; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; - TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int src_traced = smpi_group_index(smpi_comm_group(comm), src); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_RECV; + extra->src = src_traced; + extra->dst = rank; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = count * dt_size_send; + TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra); smpi_mpi_recv(buf, count, datatype, src, tag, comm, status); retval = MPI_SUCCESS; - //the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) - if(status!=MPI_STATUS_IGNORE){ - src_traced = smpi_group_index(smpi_comm_group(comm), status->MPI_SOURCE); - if (!TRACE_smpi_view_internals()) { - TRACE_smpi_recv(rank, src_traced, rank); + // the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) + if (status != MPI_STATUS_IGNORE) { + src_traced = smpi_group_index(smpi_comm_group(comm), status->MPI_SOURCE); + if (!TRACE_smpi_view_internals()) { + TRACE_smpi_recv(rank, src_traced, rank, tag); + } } - } - TRACE_smpi_ptp_out(rank, src_traced, rank, __FUNCTION__); + TRACE_smpi_ptp_out(rank, src_traced, rank, __FUNCTION__); } smpi_bench_begin(); @@ -1177,89 +1103,84 @@ int PMPI_Send(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MPI retval = MPI_SUCCESS; } else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){ retval = MPI_ERR_RANK; - } else if (count < 0) { - retval = MPI_ERR_COUNT; - } else if (buf==NULL && count > 0) { + } else if ((count < 0) || (buf == nullptr && count > 0)) { retval = MPI_ERR_COUNT; } else if (!is_datatype_valid(datatype)) { - retval = MPI_ERR_TYPE; - } else if(tag<0 && tag != MPI_ANY_TAG){ + retval = MPI_ERR_TYPE; + } else if(tag < 0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int dst_traced = smpi_group_index(smpi_comm_group(comm), dst); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_SEND; - extra->src = rank; - extra->dst = dst_traced; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; - TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - if (!TRACE_smpi_view_internals()) { - TRACE_smpi_send(rank, rank, dst_traced,count*smpi_datatype_size(datatype)); - } + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int dst_traced = smpi_group_index(smpi_comm_group(comm), dst); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); + extra->type = TRACING_SEND; + extra->src = rank; + extra->dst = dst_traced; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) { + dt_size_send = smpi_datatype_size(datatype); + } + extra->send_size = count*dt_size_send; + TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); + if (!TRACE_smpi_view_internals()) { + TRACE_smpi_send(rank, rank, dst_traced, tag,count*smpi_datatype_size(datatype)); + } smpi_mpi_send(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; - TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); + TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); } smpi_bench_begin(); return retval; } - - int PMPI_Ssend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MPI_Comm comm) { int retval = 0; - smpi_bench_end(); - - if (comm == MPI_COMM_NULL) { - retval = MPI_ERR_COMM; - } else if (dst == MPI_PROC_NULL) { - retval = MPI_SUCCESS; - } else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){ - retval = MPI_ERR_RANK; - } else if (count < 0) { - retval = MPI_ERR_COUNT; - } else if (buf==NULL && count > 0) { - retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)){ - retval = MPI_ERR_TYPE; - } else if(tag<0 && tag != MPI_ANY_TAG){ - retval = MPI_ERR_TAG; - } else { - - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int dst_traced = smpi_group_index(smpi_comm_group(comm), dst); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_SSEND; - extra->src = rank; - extra->dst = dst_traced; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; - TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced,count*smpi_datatype_size(datatype)); - - smpi_mpi_ssend(buf, count, datatype, dst, tag, comm); - retval = MPI_SUCCESS; - - TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); - } - - smpi_bench_begin(); - return retval;} + smpi_bench_end(); + + if (comm == MPI_COMM_NULL) { + retval = MPI_ERR_COMM; + } else if (dst == MPI_PROC_NULL) { + retval = MPI_SUCCESS; + } else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0){ + retval = MPI_ERR_RANK; + } else if ((count < 0) || (buf==nullptr && count > 0)) { + retval = MPI_ERR_COUNT; + } else if (!is_datatype_valid(datatype)){ + retval = MPI_ERR_TYPE; + } else if(tag<0 && tag != MPI_ANY_TAG){ + retval = MPI_ERR_TAG; + } else { + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int dst_traced = smpi_group_index(smpi_comm_group(comm), dst); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); + extra->type = TRACING_SSEND; + extra->src = rank; + extra->dst = dst_traced; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if(known == 0) { + dt_size_send = smpi_datatype_size(datatype); + } + extra->send_size = count*dt_size_send; + TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); + TRACE_smpi_send(rank, rank, dst_traced, tag,count*smpi_datatype_size(datatype)); + + smpi_mpi_ssend(buf, count, datatype, dst, tag, comm); + retval = MPI_SUCCESS; + + TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); + } + + smpi_bench_begin(); + return retval; +} int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, int sendtag, void *recvbuf, int recvcount, MPI_Datatype recvtype, int src, int recvtag, MPI_Comm comm, MPI_Status * status) @@ -1270,19 +1191,17 @@ int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(sendtype) - || !is_datatype_valid(recvtype)) { + } else if (!is_datatype_valid(sendtype) || !is_datatype_valid(recvtype)) { retval = MPI_ERR_TYPE; } else if (src == MPI_PROC_NULL || dst == MPI_PROC_NULL) { - smpi_empty_status(status); - status->MPI_SOURCE = MPI_PROC_NULL; - retval = MPI_SUCCESS; + smpi_empty_status(status); + status->MPI_SOURCE = MPI_PROC_NULL; + retval = MPI_SUCCESS; }else if (dst >= smpi_group_size(smpi_comm_group(comm)) || dst <0 || (src!=MPI_ANY_SOURCE && (src >= smpi_group_size(smpi_comm_group(comm)) || src <0))){ retval = MPI_ERR_RANK; - } else if (sendcount < 0 || recvcount<0) { - retval = MPI_ERR_COUNT; - } else if ((sendbuf==NULL && sendcount > 0)||(recvbuf==NULL && recvcount>0)) { + } else if ((sendcount < 0 || recvcount<0) || + (sendbuf==nullptr && sendcount > 0) || (recvbuf==nullptr && recvcount>0)) { retval = MPI_ERR_COUNT; } else if((sendtag<0 && sendtag != MPI_ANY_TAG)||(recvtag<0 && recvtag != MPI_ANY_TAG)){ retval = MPI_ERR_TAG; @@ -1298,43 +1217,41 @@ int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, int known=0; extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; - if(!known) + if(known==0) dt_size_send = smpi_datatype_size(sendtype); extra->send_size = sendcount*dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; - if(!known) + if(known==0) dt_size_recv = smpi_datatype_size(recvtype); extra->recv_size = recvcount*dt_size_recv; TRACE_smpi_ptp_in(rank, src_traced, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced,sendcount*smpi_datatype_size(sendtype)); + TRACE_smpi_send(rank, rank, dst_traced, sendtag,sendcount*smpi_datatype_size(sendtype)); - smpi_mpi_sendrecv(sendbuf, sendcount, sendtype, dst, sendtag, recvbuf, - recvcount, recvtype, src, recvtag, comm, status); - retval = MPI_SUCCESS; + smpi_mpi_sendrecv(sendbuf, sendcount, sendtype, dst, sendtag, recvbuf, recvcount, recvtype, src, recvtag, comm, + status); + retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, src_traced, dst_traced, __FUNCTION__); - TRACE_smpi_recv(rank, src_traced, rank); + TRACE_smpi_recv(rank, src_traced, rank, recvtag); } smpi_bench_begin(); return retval; } -int PMPI_Sendrecv_replace(void *buf, int count, MPI_Datatype datatype, int dst, int sendtag, int src, int recvtag, - MPI_Comm comm, MPI_Status * status) +int PMPI_Sendrecv_replace(void* buf, int count, MPI_Datatype datatype, int dst, int sendtag, int src, int recvtag, + MPI_Comm comm, MPI_Status* status) { - //TODO: suboptimal implementation - void *recvbuf; int retval = 0; if (!is_datatype_valid(datatype)) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count < 0) { - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { int size = smpi_datatype_get_extent(datatype) * count; - recvbuf = xbt_new0(char, size); + void* recvbuf = xbt_new0(char, size); retval = MPI_Sendrecv(buf, count, datatype, dst, sendtag, recvbuf, count, datatype, src, recvtag, comm, status); if(retval==MPI_SUCCESS){ smpi_datatype_copy(recvbuf, count, datatype, buf, count, datatype); @@ -1349,14 +1266,14 @@ int PMPI_Test(MPI_Request * request, int *flag, MPI_Status * status) { int retval = 0; smpi_bench_end(); - if (request == NULL || flag == NULL) { + if (request == nullptr || flag == nullptr) { retval = MPI_ERR_ARG; } else if (*request == MPI_REQUEST_NULL) { *flag= true; smpi_empty_status(status); retval = MPI_SUCCESS; } else { - int rank = request && (*request)->comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = ((*request)->comm != MPI_COMM_NULL) ? smpi_process_index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_TEST; @@ -1376,7 +1293,7 @@ int PMPI_Testany(int count, MPI_Request requests[], int *index, int *flag, MPI_S int retval = 0; smpi_bench_end(); - if (index == NULL || flag == NULL) { + if (index == nullptr || flag == nullptr) { retval = MPI_ERR_ARG; } else { *flag = smpi_mpi_testany(count, requests, index, status); @@ -1391,7 +1308,7 @@ int PMPI_Testall(int count, MPI_Request* requests, int* flag, MPI_Status* status int retval = 0; smpi_bench_end(); - if (flag == NULL) { + if (flag == nullptr) { retval = MPI_ERR_ARG; } else { *flag = smpi_mpi_testall(count, requests, statuses); @@ -1405,7 +1322,7 @@ int PMPI_Probe(int source, int tag, MPI_Comm comm, MPI_Status* status) { int retval = 0; smpi_bench_end(); - if (status == NULL) { + if (status == nullptr) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -1425,9 +1342,7 @@ int PMPI_Iprobe(int source, int tag, MPI_Comm comm, int* flag, MPI_Status* statu int retval = 0; smpi_bench_end(); - if (flag == NULL) { - retval = MPI_ERR_ARG; - } else if (status == NULL) { + if ((flag == nullptr) || (status == nullptr)) { retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; @@ -1452,16 +1367,17 @@ int PMPI_Wait(MPI_Request * request, MPI_Status * status) smpi_empty_status(status); - if (request == NULL) { + if (request == nullptr) { retval = MPI_ERR_ARG; } else if (*request == MPI_REQUEST_NULL) { retval = MPI_SUCCESS; } else { - int rank = request && (*request)->comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = (request!=nullptr && (*request)->comm != MPI_COMM_NULL) ? smpi_process_index() : -1; int src_traced = (*request)->src; int dst_traced = (*request)->dst; + int tag_traced= (*request)->tag; MPI_Comm comm = (*request)->comm; int is_wait_for_receive = (*request)->recv; instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); @@ -1478,7 +1394,7 @@ int PMPI_Wait(MPI_Request * request, MPI_Status * status) src_traced = (status!=MPI_STATUS_IGNORE) ? smpi_group_rank(smpi_comm_group(comm), status->MPI_SOURCE) : src_traced; - TRACE_smpi_recv(rank, src_traced, dst_traced); + TRACE_smpi_recv(rank, src_traced, dst_traced, tag_traced); } } @@ -1488,24 +1404,26 @@ int PMPI_Wait(MPI_Request * request, MPI_Status * status) int PMPI_Waitany(int count, MPI_Request requests[], int *index, MPI_Status * status) { - if (index == NULL) + if (index == nullptr) return MPI_ERR_ARG; smpi_bench_end(); //save requests information for tracing - int i; - int *srcs = xbt_new0(int, count); - int *dsts = xbt_new0(int, count); - int *recvs = xbt_new0(int, count); - MPI_Comm *comms = xbt_new0(MPI_Comm, count); - - for (i = 0; i < count; i++) { + typedef struct { + int src; + int dst; + int recv; + int tag; + MPI_Comm comm; + } savedvalstype; + savedvalstype* savedvals=nullptr; + if(count>0){ + savedvals = xbt_new0(savedvalstype, count); + } + for (int i = 0; i < count; i++) { MPI_Request req = requests[i]; //already received requests are no longer valid if (req) { - srcs[i] = req->src; - dsts[i] = req->dst; - recvs[i] = req->recv; - comms[i] = req->comm; + savedvals[i]=(savedvalstype){req->src, req->dst, req->recv, req->tag, req->comm}; } } int rank_traced = smpi_process_index(); @@ -1517,23 +1435,21 @@ int PMPI_Waitany(int count, MPI_Request requests[], int *index, MPI_Status * sta *index = smpi_mpi_waitany(count, requests, status); if(*index!=MPI_UNDEFINED){ - int src_traced = srcs[*index]; + int src_traced = savedvals[*index].src; //the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) - int dst_traced = dsts[*index]; - int is_wait_for_receive = recvs[*index]; + int dst_traced = savedvals[*index].dst; + int is_wait_for_receive = savedvals[*index].recv; if (is_wait_for_receive) { - if(srcs[*index]==MPI_ANY_SOURCE) - src_traced = (status!=MPI_STATUSES_IGNORE) ? - smpi_group_rank(smpi_comm_group(comms[*index]), status->MPI_SOURCE) : srcs[*index]; - TRACE_smpi_recv(rank_traced, src_traced, dst_traced); + if(savedvals[*index].src==MPI_ANY_SOURCE) + src_traced = (status != MPI_STATUSES_IGNORE) + ? smpi_group_rank(smpi_comm_group(savedvals[*index].comm), status->MPI_SOURCE) + : savedvals[*index].src; + TRACE_smpi_recv(rank_traced, src_traced, dst_traced, savedvals[*index].tag); } TRACE_smpi_ptp_out(rank_traced, src_traced, dst_traced, __FUNCTION__); - xbt_free(srcs); - xbt_free(dsts); - xbt_free(recvs); - xbt_free(comms); - } + xbt_free(savedvals); + smpi_bench_begin(); return MPI_SUCCESS; } @@ -1542,24 +1458,22 @@ int PMPI_Waitall(int count, MPI_Request requests[], MPI_Status status[]) { smpi_bench_end(); //save information from requests - int i; - int *srcs = xbt_new0(int, count); - int *dsts = xbt_new0(int, count); - int *recvs = xbt_new0(int, count); - int *valid = xbt_new0(int, count); - MPI_Comm *comms = xbt_new0(MPI_Comm, count); - - //int valid_count = 0; - for (i = 0; i < count; i++) { + typedef struct { + int src; + int dst; + int recv; + int tag; + int valid; + MPI_Comm comm; + } savedvalstype; + savedvalstype* savedvals=xbt_new0(savedvalstype, count); + + for (int i = 0; i < count; i++) { MPI_Request req = requests[i]; if(req!=MPI_REQUEST_NULL){ - srcs[i] = req->src; - dsts[i] = req->dst; - recvs[i] = req->recv; - comms[i] = req->comm; - valid[i]=1;; + savedvals[i]=(savedvalstype){req->src, req->dst, req->recv, req->tag, 1, req->comm}; }else{ - valid[i]=0; + savedvals[i].valid=0; } } int rank_traced = smpi_process_index(); @@ -1570,27 +1484,22 @@ int PMPI_Waitall(int count, MPI_Request requests[], MPI_Status status[]) int retval = smpi_mpi_waitall(count, requests, status); - for (i = 0; i < count; i++) { - if(valid[i]){ - //int src_traced = srcs[*index]; + for (int i = 0; i < count; i++) { + if(savedvals[i].valid){ //the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) - int src_traced = srcs[i]; - int dst_traced = dsts[i]; - int is_wait_for_receive = recvs[i]; + int src_traced = savedvals[i].src; + int dst_traced = savedvals[i].dst; + int is_wait_for_receive = savedvals[i].recv; if (is_wait_for_receive) { if(src_traced==MPI_ANY_SOURCE) src_traced = (status!=MPI_STATUSES_IGNORE) ? - smpi_group_rank(smpi_comm_group(comms[i]), status[i].MPI_SOURCE) : srcs[i]; - TRACE_smpi_recv(rank_traced, src_traced, dst_traced); + smpi_group_rank(smpi_comm_group(savedvals[i].comm), status[i].MPI_SOURCE) : savedvals[i].src; + TRACE_smpi_recv(rank_traced, src_traced, dst_traced,savedvals[i].tag); } } } TRACE_smpi_ptp_out(rank_traced, -1, -1, __FUNCTION__); - xbt_free(srcs); - xbt_free(dsts); - xbt_free(recvs); - xbt_free(valid); - xbt_free(comms); + xbt_free(savedvals); smpi_bench_begin(); return retval; @@ -1601,7 +1510,7 @@ int PMPI_Waitsome(int incount, MPI_Request requests[], int *outcount, int *indic int retval = 0; smpi_bench_end(); - if (outcount == NULL) { + if (outcount == nullptr) { retval = MPI_ERR_ARG; } else { *outcount = smpi_mpi_waitsome(incount, requests, indices, status); @@ -1615,15 +1524,15 @@ int PMPI_Testsome(int incount, MPI_Request requests[], int* outcount, int* indic { int retval = 0; - smpi_bench_end(); - if (outcount == NULL) { - retval = MPI_ERR_ARG; - } else { - *outcount = smpi_mpi_testsome(incount, requests, indices, status); - retval = MPI_SUCCESS; - } - smpi_bench_begin(); - return retval; + smpi_bench_end(); + if (outcount == nullptr) { + retval = MPI_ERR_ARG; + } else { + *outcount = smpi_mpi_testsome(incount, requests, indices, status); + retval = MPI_SUCCESS; + } + smpi_bench_begin(); + return retval; } @@ -1636,28 +1545,27 @@ int PMPI_Bcast(void *buf, int count, MPI_Datatype datatype, int root, MPI_Comm c if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; } else if (!is_datatype_valid(datatype)) { - retval = MPI_ERR_ARG; + retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int root_traced = smpi_group_index(smpi_comm_group(comm), root); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int root_traced = smpi_group_index(smpi_comm_group(comm), root); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_BCAST; - extra->root = root_traced; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; - TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - - mpi_coll_bcast_fun(buf, count, datatype, root, comm); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_BCAST; + extra->root = root_traced; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = count * dt_size_send; + TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); + if (smpi_comm_size(comm) > 1) + mpi_coll_bcast_fun(buf, count, datatype, root, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } - smpi_bench_begin(); return retval; } @@ -1671,15 +1579,15 @@ int PMPI_Barrier(MPI_Comm comm) if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_BARRIER; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_BARRIER; + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_barrier_fun(comm); - retval = MPI_SUCCESS; + mpi_coll_barrier_fun(comm); + retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); @@ -1702,36 +1610,36 @@ int PMPI_Gather(void *sendbuf, int sendcount, MPI_Datatype sendtype,void *recvbu retval = MPI_ERR_COUNT; } else { - char* sendtmpbuf = (char*) sendbuf; + char* sendtmpbuf = static_cast(sendbuf); int sendtmpcount = sendcount; MPI_Datatype sendtmptype = sendtype; if( (smpi_comm_rank(comm) == root) && (sendbuf == MPI_IN_PLACE )) { sendtmpcount=0; sendtmptype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int root_traced = smpi_group_index(smpi_comm_group(comm), root); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_GATHER; - extra->root = root_traced; - int known=0; - extra->datatype1 = encode_datatype(sendtmptype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(sendtmptype); - extra->send_size = sendtmpcount*dt_size_send; - extra->datatype2 = encode_datatype(recvtype, &known); - int dt_size_recv = 1; - if((smpi_comm_rank(comm)==root) && !known) - dt_size_recv = smpi_datatype_size(recvtype); - extra->recv_size = recvcount*dt_size_recv; + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int root_traced = smpi_group_index(smpi_comm_group(comm), root); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_GATHER; + extra->root = root_traced; + int known = 0; + extra->datatype1 = encode_datatype(sendtmptype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(sendtmptype); + extra->send_size = sendtmpcount * dt_size_send; + extra->datatype2 = encode_datatype(recvtype, &known); + int dt_size_recv = 1; + if ((smpi_comm_rank(comm) == root) && known == 0) + dt_size_recv = smpi_datatype_size(recvtype); + extra->recv_size = recvcount * dt_size_recv; + + TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); + + mpi_coll_gather_fun(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, root, comm); - TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - - mpi_coll_gather_fun(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, root, comm); - - retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); + retval = MPI_SUCCESS; + TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } smpi_bench_begin(); @@ -1752,10 +1660,10 @@ int PMPI_Gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, void *recv retval = MPI_ERR_TYPE; } else if (( sendbuf != MPI_IN_PLACE) && (sendcount <0)){ retval = MPI_ERR_COUNT; - } else if (recvcounts == NULL || displs == NULL) { + } else if (recvcounts == nullptr || displs == nullptr) { retval = MPI_ERR_ARG; } else { - char* sendtmpbuf = (char*) sendbuf; + char* sendtmpbuf = static_cast(sendbuf); int sendtmpcount = sendcount; MPI_Datatype sendtmptype = sendtype; if( (smpi_comm_rank(comm) == root) && (sendbuf == MPI_IN_PLACE )) { @@ -1763,34 +1671,34 @@ int PMPI_Gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, void *recv sendtmptype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int root_traced = smpi_group_index(smpi_comm_group(comm), root); - int i=0; - int size = smpi_comm_size(comm); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_GATHERV; - extra->num_processes = size; - extra->root = root_traced; - int known=0; - extra->datatype1 = encode_datatype(sendtmptype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(sendtype); - extra->send_size = sendtmpcount*dt_size_send; - extra->datatype2 = encode_datatype(recvtype, &known); - int dt_size_recv = 1; - if(!known) - dt_size_recv = smpi_datatype_size(recvtype); - if((smpi_comm_rank(comm)==root)){ - extra->recvcounts= xbt_new(int,size); - for(i=0; i< size; i++)//copy data to avoid bad free - extra->recvcounts[i] = recvcounts[i]*dt_size_recv; - } - TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__,extra); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int root_traced = smpi_group_index(smpi_comm_group(comm), root); + int i = 0; + int size = smpi_comm_size(comm); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_GATHERV; + extra->num_processes = size; + extra->root = root_traced; + int known = 0; + extra->datatype1 = encode_datatype(sendtmptype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(sendtype); + extra->send_size = sendtmpcount * dt_size_send; + extra->datatype2 = encode_datatype(recvtype, &known); + int dt_size_recv = 1; + if (known == 0) + dt_size_recv = smpi_datatype_size(recvtype); + if ((smpi_comm_rank(comm) == root)) { + extra->recvcounts = xbt_new(int, size); + for (i = 0; i < size; i++) // copy data to avoid bad free + extra->recvcounts[i] = recvcounts[i] * dt_size_recv; + } + TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - smpi_mpi_gatherv(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcounts, displs, recvtype, root, comm); + smpi_mpi_gatherv(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcounts, displs, recvtype, root, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); + TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } smpi_bench_begin(); @@ -1814,30 +1722,30 @@ int PMPI_Allgather(void *sendbuf, int sendcount, MPI_Datatype sendtype, retval = MPI_ERR_COUNT; } else { if(sendbuf == MPI_IN_PLACE) { - sendbuf=((char*)recvbuf)+smpi_datatype_get_extent(recvtype)*recvcount*smpi_comm_rank(comm); + sendbuf=static_cast(recvbuf)+smpi_datatype_get_extent(recvtype)*recvcount*smpi_comm_rank(comm); sendcount=recvcount; sendtype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_ALLGATHER; - int known=0; - extra->datatype1 = encode_datatype(sendtype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(sendtype); - extra->send_size = sendcount*dt_size_send; - extra->datatype2 = encode_datatype(recvtype, &known); - int dt_size_recv = 1; - if(!known) - dt_size_recv = smpi_datatype_size(recvtype); - extra->recv_size = recvcount*dt_size_recv; + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_ALLGATHER; + int known = 0; + extra->datatype1 = encode_datatype(sendtype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(sendtype); + extra->send_size = sendcount * dt_size_send; + extra->datatype2 = encode_datatype(recvtype, &known); + int dt_size_recv = 1; + if (known == 0) + dt_size_recv = smpi_datatype_size(recvtype); + extra->recv_size = recvcount * dt_size_recv; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_allgather_fun(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, comm); + mpi_coll_allgather_fun(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); return retval; @@ -1852,45 +1760,44 @@ int PMPI_Allgatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if ((( sendbuf != MPI_IN_PLACE) && (sendtype == MPI_DATATYPE_NULL)) || - (recvtype == MPI_DATATYPE_NULL)){ + } else if (((sendbuf != MPI_IN_PLACE) && (sendtype == MPI_DATATYPE_NULL)) || (recvtype == MPI_DATATYPE_NULL)) { retval = MPI_ERR_TYPE; } else if (( sendbuf != MPI_IN_PLACE) && (sendcount <0)){ retval = MPI_ERR_COUNT; - } else if (recvcounts == NULL || displs == NULL) { + } else if (recvcounts == nullptr || displs == nullptr) { retval = MPI_ERR_ARG; } else { if(sendbuf == MPI_IN_PLACE) { - sendbuf=((char*)recvbuf)+smpi_datatype_get_extent(recvtype)*displs[smpi_comm_rank(comm)]; + sendbuf=static_cast(recvbuf)+smpi_datatype_get_extent(recvtype)*displs[smpi_comm_rank(comm)]; sendcount=recvcounts[smpi_comm_rank(comm)]; sendtype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int i=0; - int size = smpi_comm_size(comm); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_ALLGATHERV; - extra->num_processes = size; - int known=0; - extra->datatype1 = encode_datatype(sendtype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(sendtype); - extra->send_size = sendcount*dt_size_send; - extra->datatype2 = encode_datatype(recvtype, &known); - int dt_size_recv = 1; - if(!known) - dt_size_recv = smpi_datatype_size(recvtype); - extra->recvcounts= xbt_new(int, size); - for(i=0; i< size; i++)//copy data to avoid bad free - extra->recvcounts[i] = recvcounts[i]*dt_size_recv; + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int i = 0; + int size = smpi_comm_size(comm); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_ALLGATHERV; + extra->num_processes = size; + int known = 0; + extra->datatype1 = encode_datatype(sendtype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(sendtype); + extra->send_size = sendcount * dt_size_send; + extra->datatype2 = encode_datatype(recvtype, &known); + int dt_size_recv = 1; + if (known == 0) + dt_size_recv = smpi_datatype_size(recvtype); + extra->recvcounts = xbt_new(int, size); + for (i = 0; i < size; i++) // copy data to avoid bad free + extra->recvcounts[i] = recvcounts[i] * dt_size_recv; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); mpi_coll_allgatherv_fun(sendbuf, sendcount, sendtype, recvbuf, recvcounts, displs, recvtype, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); @@ -1906,39 +1813,39 @@ int PMPI_Scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (((smpi_comm_rank(comm)==root) && (!is_datatype_valid(sendtype))) - || ((recvbuf !=MPI_IN_PLACE) && (!is_datatype_valid(recvtype)))){ + } else if (((smpi_comm_rank(comm) == root) && (!is_datatype_valid(sendtype))) || + ((recvbuf != MPI_IN_PLACE) && (!is_datatype_valid(recvtype)))) { retval = MPI_ERR_TYPE; } else if ((sendbuf == recvbuf) || - ((smpi_comm_rank(comm)==root) && sendcount>0 && (sendbuf == NULL))){ + ((smpi_comm_rank(comm)==root) && sendcount>0 && (sendbuf == nullptr))){ retval = MPI_ERR_BUFFER; }else { if (recvbuf == MPI_IN_PLACE) { - recvtype=sendtype; - recvcount=sendcount; + recvtype = sendtype; + recvcount = sendcount; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int root_traced = smpi_group_index(smpi_comm_group(comm), root); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_SCATTER; - extra->root = root_traced; - int known=0; - extra->datatype1 = encode_datatype(sendtype, &known); - int dt_size_send = 1; - if((smpi_comm_rank(comm)==root) && !known) - dt_size_send = smpi_datatype_size(sendtype); - extra->send_size = sendcount*dt_size_send; - extra->datatype2 = encode_datatype(recvtype, &known); - int dt_size_recv = 1; - if(!known) - dt_size_recv = smpi_datatype_size(recvtype); - extra->recv_size = recvcount*dt_size_recv; - TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__,extra); - - mpi_coll_scatter_fun(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, root, comm); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int root_traced = smpi_group_index(smpi_comm_group(comm), root); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_SCATTER; + extra->root = root_traced; + int known = 0; + extra->datatype1 = encode_datatype(sendtype, &known); + int dt_size_send = 1; + if ((smpi_comm_rank(comm) == root) && known == 0) + dt_size_send = smpi_datatype_size(sendtype); + extra->send_size = sendcount * dt_size_send; + extra->datatype2 = encode_datatype(recvtype, &known); + int dt_size_recv = 1; + if (known == 0) + dt_size_recv = smpi_datatype_size(recvtype); + extra->recv_size = recvcount * dt_size_recv; + TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); + + mpi_coll_scatter_fun(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, root, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); + TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } smpi_bench_begin(); @@ -1954,45 +1861,45 @@ int PMPI_Scatterv(void *sendbuf, int *sendcounts, int *displs, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (sendcounts == NULL || displs == NULL) { + } else if (sendcounts == nullptr || displs == nullptr) { retval = MPI_ERR_ARG; - } else if (((smpi_comm_rank(comm)==root) && (sendtype == MPI_DATATYPE_NULL)) - || ((recvbuf !=MPI_IN_PLACE) && (recvtype == MPI_DATATYPE_NULL))) { + } else if (((smpi_comm_rank(comm) == root) && (sendtype == MPI_DATATYPE_NULL)) || + ((recvbuf != MPI_IN_PLACE) && (recvtype == MPI_DATATYPE_NULL))) { retval = MPI_ERR_TYPE; } else { if (recvbuf == MPI_IN_PLACE) { - recvtype=sendtype; - recvcount=sendcounts[smpi_comm_rank(comm)]; + recvtype = sendtype; + recvcount = sendcounts[smpi_comm_rank(comm)]; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int root_traced = smpi_group_index(smpi_comm_group(comm), root); - int i=0; - int size = smpi_comm_size(comm); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_SCATTERV; - extra->num_processes = size; - extra->root = root_traced; - int known=0; - extra->datatype1 = encode_datatype(sendtype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(sendtype); - if((smpi_comm_rank(comm)==root)){ - extra->sendcounts= xbt_new(int, size); - for(i=0; i< size; i++)//copy data to avoid bad free - extra->sendcounts[i] = sendcounts[i]*dt_size_send; - } - extra->datatype2 = encode_datatype(recvtype, &known); - int dt_size_recv = 1; - if(!known) - dt_size_recv = smpi_datatype_size(recvtype); - extra->recv_size = recvcount*dt_size_recv; - TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__,extra); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int root_traced = smpi_group_index(smpi_comm_group(comm), root); + int i = 0; + int size = smpi_comm_size(comm); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_SCATTERV; + extra->num_processes = size; + extra->root = root_traced; + int known = 0; + extra->datatype1 = encode_datatype(sendtype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(sendtype); + if ((smpi_comm_rank(comm) == root)) { + extra->sendcounts = xbt_new(int, size); + for (i = 0; i < size; i++) // copy data to avoid bad free + extra->sendcounts[i] = sendcounts[i] * dt_size_send; + } + extra->datatype2 = encode_datatype(recvtype, &known); + int dt_size_recv = 1; + if (known == 0) + dt_size_recv = smpi_datatype_size(recvtype); + extra->recv_size = recvcount * dt_size_recv; + TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); smpi_mpi_scatterv(sendbuf, sendcounts, displs, sendtype, recvbuf, recvcount, recvtype, root, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); + TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } smpi_bench_begin(); @@ -2010,24 +1917,24 @@ int PMPI_Reduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, } else if (!is_datatype_valid(datatype) || op == MPI_OP_NULL) { retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int root_traced = smpi_group_index(smpi_comm_group(comm), root); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_REDUCE; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; - extra->root = root_traced; + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int root_traced = smpi_group_index(smpi_comm_group(comm), root); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_REDUCE; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = count * dt_size_send; + extra->root = root_traced; - TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__,extra); + TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - mpi_coll_reduce_fun(sendbuf, recvbuf, count, datatype, op, root, comm); + mpi_coll_reduce_fun(sendbuf, recvbuf, count, datatype, op, root, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); + TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } smpi_bench_begin(); @@ -2037,15 +1944,15 @@ int PMPI_Reduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, int PMPI_Reduce_local(void *inbuf, void *inoutbuf, int count, MPI_Datatype datatype, MPI_Op op){ int retval = 0; - smpi_bench_end(); - if (!is_datatype_valid(datatype) || op == MPI_OP_NULL) { - retval = MPI_ERR_ARG; - } else { - smpi_op_apply(op, inbuf, inoutbuf, &count, &datatype); - retval=MPI_SUCCESS; - } - smpi_bench_begin(); - return retval; + smpi_bench_end(); + if (!is_datatype_valid(datatype) || op == MPI_OP_NULL) { + retval = MPI_ERR_ARG; + } else { + smpi_op_apply(op, inbuf, inoutbuf, &count, &datatype); + retval = MPI_SUCCESS; + } + smpi_bench_begin(); + return retval; } int PMPI_Allreduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, MPI_Op op, MPI_Comm comm) @@ -2062,30 +1969,30 @@ int PMPI_Allreduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatyp retval = MPI_ERR_OP; } else { - char* sendtmpbuf = (char*) sendbuf; + char* sendtmpbuf = static_cast(sendbuf); if( sendbuf == MPI_IN_PLACE ) { - sendtmpbuf = (char *)xbt_malloc(count*smpi_datatype_get_extent(datatype)); + sendtmpbuf = static_cast(xbt_malloc(count*smpi_datatype_get_extent(datatype))); smpi_datatype_copy(recvbuf, count, datatype,sendtmpbuf, count, datatype); } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_ALLREDUCE; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_ALLREDUCE; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = count * dt_size_send; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_allreduce_fun(sendtmpbuf, recvbuf, count, datatype, op, comm); + mpi_coll_allreduce_fun(sendtmpbuf, recvbuf, count, datatype, op, comm); if( sendbuf == MPI_IN_PLACE ) xbt_free(sendtmpbuf); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); @@ -2105,22 +2012,22 @@ int PMPI_Scan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, MP } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_SCAN; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_SCAN; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = count * dt_size_send; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - smpi_mpi_scan(sendbuf, recvbuf, count, datatype, op, comm); + smpi_mpi_scan(sendbuf, recvbuf, count, datatype, op, comm); - retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + retval = MPI_SUCCESS; + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); @@ -2139,20 +2046,27 @@ int PMPI_Exscan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_EXSCAN; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = count*dt_size_send; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_EXSCAN; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = count * dt_size_send; + void* sendtmpbuf = sendbuf; + if (sendbuf == MPI_IN_PLACE) { + sendtmpbuf = static_cast(xbt_malloc(count * smpi_datatype_size(datatype))); + memcpy(sendtmpbuf, recvbuf, count * smpi_datatype_size(datatype)); + } + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - smpi_mpi_exscan(sendbuf, recvbuf, count, datatype, op, comm); + smpi_mpi_exscan(sendtmpbuf, recvbuf, count, datatype, op, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + if (sendbuf == MPI_IN_PLACE) + xbt_free(sendtmpbuf); } smpi_bench_begin(); @@ -2170,33 +2084,41 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; - } else if (recvcounts == NULL) { + } else if (recvcounts == nullptr) { retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int i=0; - int size = smpi_comm_size(comm); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_REDUCE_SCATTER; - extra->num_processes = size; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = 0; - extra->recvcounts= xbt_new(int, size); - for(i=0; i< size; i++)//copy data to avoid bad free - extra->recvcounts[i] = recvcounts[i]*dt_size_send; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); - - void* sendtmpbuf=sendbuf; - if(sendbuf==MPI_IN_PLACE) - sendtmpbuf=recvbuf; - - mpi_coll_reduce_scatter_fun(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int i = 0; + int size = smpi_comm_size(comm); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_REDUCE_SCATTER; + extra->num_processes = size; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = 0; + extra->recvcounts = xbt_new(int, size); + int totalcount = 0; + for (i = 0; i < size; i++) { // copy data to avoid bad free + extra->recvcounts[i] = recvcounts[i] * dt_size_send; + totalcount += recvcounts[i]; + } + void* sendtmpbuf = sendbuf; + if (sendbuf == MPI_IN_PLACE) { + sendtmpbuf = static_cast(xbt_malloc(totalcount * smpi_datatype_size(datatype))); + memcpy(sendtmpbuf, recvbuf, totalcount * smpi_datatype_size(datatype)); + } + + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); + + mpi_coll_reduce_scatter_fun(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm); retval = MPI_SUCCESS; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + + if (sendbuf == MPI_IN_PLACE) + xbt_free(sendtmpbuf); } smpi_bench_begin(); @@ -2206,7 +2128,7 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, MPI_Datatype datatype, MPI_Op op, MPI_Comm comm) { - int retval,i; + int retval; smpi_bench_end(); if (comm == MPI_COMM_NULL) { @@ -2218,77 +2140,99 @@ int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, } else if (recvcount < 0) { retval = MPI_ERR_ARG; } else { - int count=smpi_comm_size(comm); + int count = smpi_comm_size(comm); + + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_REDUCE_SCATTER; + extra->num_processes = count; + int known = 0; + extra->datatype1 = encode_datatype(datatype, &known); + int dt_size_send = 1; + if (known == 0) + dt_size_send = smpi_datatype_size(datatype); + extra->send_size = 0; + extra->recvcounts = xbt_new(int, count); + for (int i = 0; i < count; i++) // copy data to avoid bad free + extra->recvcounts[i] = recvcount * dt_size_send; + void* sendtmpbuf = sendbuf; + if (sendbuf == MPI_IN_PLACE) { + sendtmpbuf = static_cast(xbt_malloc(recvcount * count * smpi_datatype_size(datatype))); + memcpy(sendtmpbuf, recvbuf, recvcount * count * smpi_datatype_size(datatype)); + } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_REDUCE_SCATTER; - extra->num_processes = count; - int known=0; - extra->datatype1 = encode_datatype(datatype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(datatype); - extra->send_size = 0; - extra->recvcounts= xbt_new(int, count); - for(i=0; i< count; i++)//copy data to avoid bad free - extra->recvcounts[i] = recvcount*dt_size_send; - - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); - - int* recvcounts=(int*)xbt_malloc(count); - for (i=0; i(xbt_malloc(count * sizeof(int))); + for (int i = 0; i < count; i++) + recvcounts[i] = recvcount; + mpi_coll_reduce_scatter_fun(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm); xbt_free(recvcounts); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + + if (sendbuf == MPI_IN_PLACE) + xbt_free(sendtmpbuf); } smpi_bench_begin(); return retval; } -int PMPI_Alltoall(void *sendbuf, int sendcount, MPI_Datatype sendtype, - void *recvbuf, int recvcount, MPI_Datatype recvtype, MPI_Comm comm) +int PMPI_Alltoall(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* recvbuf, int recvcount, + MPI_Datatype recvtype, MPI_Comm comm) { int retval = 0; - smpi_bench_end(); if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (sendtype == MPI_DATATYPE_NULL - || recvtype == MPI_DATATYPE_NULL) { + } else if ((sendbuf != MPI_IN_PLACE && sendtype == MPI_DATATYPE_NULL) || recvtype == MPI_DATATYPE_NULL) { retval = MPI_ERR_TYPE; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_ALLTOALL; - int known=0; - extra->datatype1 = encode_datatype(sendtype, &known); - if(!known) - extra->send_size = sendcount*smpi_datatype_size(sendtype); - else - extra->send_size = sendcount; - extra->datatype2 = encode_datatype(recvtype, &known); - if(!known) - extra->recv_size = recvcount*smpi_datatype_size(recvtype); - else - extra->recv_size = recvcount; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_ALLTOALL; + + void* sendtmpbuf = static_cast(sendbuf); + int sendtmpcount = sendcount; + MPI_Datatype sendtmptype = sendtype; + if (sendbuf == MPI_IN_PLACE) { + sendtmpbuf = static_cast(xbt_malloc(recvcount * smpi_comm_size(comm) * smpi_datatype_size(recvtype))); + memcpy(sendtmpbuf, recvbuf, recvcount * smpi_comm_size(comm) * smpi_datatype_size(recvtype)); + sendtmpcount = recvcount; + sendtmptype = recvtype; + } - retval = mpi_coll_alltoall_fun(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, comm); + int known = 0; + extra->datatype1 = encode_datatype(sendtmptype, &known); + if (known == 0) + extra->send_size = sendtmpcount * smpi_datatype_size(sendtmptype); + else + extra->send_size = sendtmpcount; + extra->datatype2 = encode_datatype(recvtype, &known); + if (known == 0) + extra->recv_size = recvcount * smpi_datatype_size(recvtype); + else + extra->recv_size = recvcount; - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); + + retval = mpi_coll_alltoall_fun(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, comm); + + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + + if (sendbuf == MPI_IN_PLACE) + xbt_free(sendtmpbuf); } smpi_bench_begin(); return retval; } -int PMPI_Alltoallv(void *sendbuf, int *sendcounts, int *senddisps,MPI_Datatype sendtype, void *recvbuf, int *recvcounts, - int *recvdisps, MPI_Datatype recvtype, MPI_Comm comm) +int PMPI_Alltoallv(void* sendbuf, int* sendcounts, int* senddisps, MPI_Datatype sendtype, void* recvbuf, + int* recvcounts, int* recvdisps, MPI_Datatype recvtype, MPI_Comm comm) { int retval = 0; @@ -2298,40 +2242,65 @@ int PMPI_Alltoallv(void *sendbuf, int *sendcounts, int *senddisps,MPI_Datatype s retval = MPI_ERR_COMM; } else if (sendtype == MPI_DATATYPE_NULL || recvtype == MPI_DATATYPE_NULL) { retval = MPI_ERR_TYPE; - } else if (sendcounts == NULL || senddisps == NULL || recvcounts == NULL || recvdisps == NULL) { + } else if ((sendbuf != MPI_IN_PLACE && (sendcounts == nullptr || senddisps == nullptr)) || recvcounts == nullptr || + recvdisps == nullptr) { retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; - int i=0; - int size = smpi_comm_size(comm); - instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); - extra->type = TRACING_ALLTOALLV; - extra->send_size = 0; - extra->recv_size = 0; - extra->recvcounts= xbt_new(int, size); - extra->sendcounts= xbt_new(int, size); - int known=0; - extra->datatype1 = encode_datatype(sendtype, &known); - int dt_size_send = 1; - if(!known) - dt_size_send = smpi_datatype_size(sendtype); - int dt_size_recv = 1; - extra->datatype2 = encode_datatype(recvtype, &known); - if(!known) - dt_size_recv = smpi_datatype_size(recvtype); - for(i=0; i< size; i++){//copy data to avoid bad free - extra->send_size += sendcounts[i]*dt_size_send; - extra->recv_size += recvcounts[i]*dt_size_recv; + int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int i = 0; + int size = smpi_comm_size(comm); + instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); + extra->type = TRACING_ALLTOALLV; + extra->send_size = 0; + extra->recv_size = 0; + extra->recvcounts = xbt_new(int, size); + extra->sendcounts = xbt_new(int, size); + int known = 0; + int dt_size_recv = 1; + extra->datatype2 = encode_datatype(recvtype, &known); + dt_size_recv = smpi_datatype_size(recvtype); + + void* sendtmpbuf = static_cast(sendbuf); + int* sendtmpcounts = sendcounts; + int* sendtmpdisps = senddisps; + MPI_Datatype sendtmptype = sendtype; + int maxsize = 0; + for (i = 0; i < size; i++) { // copy data to avoid bad free + extra->recv_size += recvcounts[i] * dt_size_recv; + extra->recvcounts[i] = recvcounts[i] * dt_size_recv; + if (((recvdisps[i] + recvcounts[i]) * dt_size_recv) > maxsize) + maxsize = (recvdisps[i] + recvcounts[i]) * dt_size_recv; + } - extra->sendcounts[i] = sendcounts[i]*dt_size_send; - extra->recvcounts[i] = recvcounts[i]*dt_size_recv; - } - extra->num_processes = size; - TRACE_smpi_collective_in(rank, -1, __FUNCTION__,extra); + if (sendbuf == MPI_IN_PLACE) { + sendtmpbuf = static_cast(xbt_malloc(maxsize)); + memcpy(sendtmpbuf, recvbuf, maxsize); + sendtmpcounts = static_cast(xbt_malloc(size * sizeof(int))); + memcpy(sendtmpcounts, recvcounts, size * sizeof(int)); + sendtmpdisps = static_cast(xbt_malloc(size * sizeof(int))); + memcpy(sendtmpdisps, recvdisps, size * sizeof(int)); + sendtmptype = recvtype; + } - retval = mpi_coll_alltoallv_fun(sendbuf, sendcounts, senddisps, sendtype, recvbuf, recvcounts, recvdisps, recvtype, - comm); - TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + extra->datatype1 = encode_datatype(sendtmptype, &known); + int dt_size_send = 1; + dt_size_send = smpi_datatype_size(sendtmptype); + + for (i = 0; i < size; i++) { // copy data to avoid bad free + extra->send_size += sendtmpcounts[i] * dt_size_send; + extra->sendcounts[i] = sendtmpcounts[i] * dt_size_send; + } + extra->num_processes = size; + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); + retval = mpi_coll_alltoallv_fun(sendtmpbuf, sendtmpcounts, sendtmpdisps, sendtmptype, recvbuf, recvcounts, + recvdisps, recvtype, comm); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); + + if (sendbuf == MPI_IN_PLACE) { + xbt_free(sendtmpbuf); + xbt_free(sendtmpcounts); + xbt_free(sendtmpdisps); + } } smpi_bench_begin(); @@ -2341,87 +2310,71 @@ int PMPI_Alltoallv(void *sendbuf, int *sendcounts, int *senddisps,MPI_Datatype s int PMPI_Get_processor_name(char *name, int *resultlen) { - int retval = MPI_SUCCESS; - - strncpy(name, sg_host_get_name(SIMIX_host_self()), - strlen(sg_host_get_name(SIMIX_host_self())) < MPI_MAX_PROCESSOR_NAME - 1 ? - strlen(sg_host_get_name(SIMIX_host_self())) +1 : MPI_MAX_PROCESSOR_NAME - 1 ); + strncpy(name, SIMIX_host_self()->cname(), strlen(SIMIX_host_self()->cname()) < MPI_MAX_PROCESSOR_NAME - 1 + ? strlen(SIMIX_host_self()->cname()) + 1 + : MPI_MAX_PROCESSOR_NAME - 1); *resultlen = strlen(name) > MPI_MAX_PROCESSOR_NAME ? MPI_MAX_PROCESSOR_NAME : strlen(name); - return retval; + return MPI_SUCCESS; } int PMPI_Get_count(MPI_Status * status, MPI_Datatype datatype, int *count) { - int retval = MPI_SUCCESS; - size_t size; - - if (status == NULL || count == NULL) { - retval = MPI_ERR_ARG; + if (status == nullptr || count == nullptr) { + return MPI_ERR_ARG; } else if (!is_datatype_valid(datatype)) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else { - size = smpi_datatype_size(datatype); + size_t size = smpi_datatype_size(datatype); if (size == 0) { *count = 0; + return MPI_SUCCESS; } else if (status->count % size != 0) { - retval = MPI_UNDEFINED; + return MPI_UNDEFINED; } else { *count = smpi_mpi_get_count(status, datatype); + return MPI_SUCCESS; } } - return retval; } int PMPI_Type_contiguous(int count, MPI_Datatype old_type, MPI_Datatype* new_type) { - int retval = 0; - if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - retval = smpi_datatype_contiguous(count, old_type, new_type, 0); + return smpi_datatype_contiguous(count, old_type, new_type, 0); } - return retval; } int PMPI_Type_commit(MPI_Datatype* datatype) { - int retval = 0; - - if (datatype == NULL || *datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + if (datatype == nullptr || *datatype == MPI_DATATYPE_NULL) { + return MPI_ERR_TYPE; } else { smpi_datatype_commit(datatype); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Type_vector(int count, int blocklen, int stride, MPI_Datatype old_type, MPI_Datatype* new_type) { - int retval = 0; - if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0 || blocklen<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - retval = smpi_datatype_vector(count, blocklen, stride, old_type, new_type); + return smpi_datatype_vector(count, blocklen, stride, old_type, new_type); } - return retval; } int PMPI_Type_hvector(int count, int blocklen, MPI_Aint stride, MPI_Datatype old_type, MPI_Datatype* new_type) { - int retval = 0; - if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0 || blocklen<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - retval = smpi_datatype_hvector(count, blocklen, stride, old_type, new_type); + return smpi_datatype_hvector(count, blocklen, stride, old_type, new_type); } - return retval; } int PMPI_Type_create_hvector(int count, int blocklen, MPI_Aint stride, MPI_Datatype old_type, MPI_Datatype* new_type) { @@ -2429,59 +2382,51 @@ int PMPI_Type_create_hvector(int count, int blocklen, MPI_Aint stride, MPI_Datat } int PMPI_Type_indexed(int count, int* blocklens, int* indices, MPI_Datatype old_type, MPI_Datatype* new_type) { - int retval = 0; - if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - retval = smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + return smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); } - return retval; } int PMPI_Type_create_indexed(int count, int* blocklens, int* indices, MPI_Datatype old_type, MPI_Datatype* new_type) { - int retval = 0; - if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - retval = smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + return smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); } - return retval; } int PMPI_Type_create_indexed_block(int count, int blocklength, int* indices, MPI_Datatype old_type, - MPI_Datatype* new_type) { - int retval,i; - + MPI_Datatype* new_type) +{ if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - int* blocklens=(int*)xbt_malloc(blocklength*count); - for (i=0; i(xbt_malloc(blocklength*count*sizeof(int))); + for (int i = 0; i < count; i++) + blocklens[i]=blocklength; + int retval = smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); xbt_free(blocklens); + return retval; } - return retval; } -int PMPI_Type_hindexed(int count, int* blocklens, MPI_Aint* indices, MPI_Datatype old_type, MPI_Datatype* new_type) { - int retval = 0; - +int PMPI_Type_hindexed(int count, int* blocklens, MPI_Aint* indices, MPI_Datatype old_type, MPI_Datatype* new_type) +{ if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - retval = smpi_datatype_hindexed(count, blocklens, indices, old_type, new_type); + return smpi_datatype_hindexed(count, blocklens, indices, old_type, new_type); } - return retval; } int PMPI_Type_create_hindexed(int count, int* blocklens, MPI_Aint* indices, MPI_Datatype old_type, @@ -2491,30 +2436,26 @@ int PMPI_Type_create_hindexed(int count, int* blocklens, MPI_Aint* indices, MPI_ int PMPI_Type_create_hindexed_block(int count, int blocklength, MPI_Aint* indices, MPI_Datatype old_type, MPI_Datatype* new_type) { - int retval,i; - if (old_type == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; + return MPI_ERR_TYPE; } else if (count<0){ - retval = MPI_ERR_COUNT; + return MPI_ERR_COUNT; } else { - int* blocklens=(int*)xbt_malloc(blocklength*count); - for (i=0; i 0 && (dims == NULL || periodic == NULL)) || comm_cart == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_COMM; + } else if (ndims < 0 || (ndims > 0 && (dims == nullptr || periodic == nullptr)) || comm_cart == nullptr) { + return MPI_ERR_ARG; } else{ - retval = smpi_mpi_cart_create(comm_old, ndims, dims, periodic, reorder, comm_cart); + return smpi_mpi_cart_create(comm_old, ndims, dims, periodic, reorder, comm_cart); } - return retval; } int PMPI_Cart_rank(MPI_Comm comm, int* coords, int* rank) { - if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == NULL) { + if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == nullptr) { return MPI_ERR_TOPOLOGY; } - if (coords == NULL) { + if (coords == nullptr) { return MPI_ERR_ARG; } return smpi_mpi_cart_rank(comm, coords, rank); } int PMPI_Cart_shift(MPI_Comm comm, int direction, int displ, int* source, int* dest) { - if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == NULL) { + if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == nullptr) { return MPI_ERR_TOPOLOGY; } - if (source == NULL || dest == NULL || direction < 0 ) { + if (source == nullptr || dest == nullptr || direction < 0 ) { return MPI_ERR_ARG; } return smpi_mpi_cart_shift(comm, direction, displ, source, dest); } int PMPI_Cart_coords(MPI_Comm comm, int rank, int maxdims, int* coords) { - if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == NULL) { + if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == nullptr) { return MPI_ERR_TOPOLOGY; } if (rank < 0 || rank >= smpi_comm_size(comm)) { @@ -2579,34 +2518,34 @@ int PMPI_Cart_coords(MPI_Comm comm, int rank, int maxdims, int* coords) { if (maxdims <= 0) { return MPI_ERR_ARG; } - if(coords == NULL) { + if(coords == nullptr) { return MPI_ERR_ARG; } return smpi_mpi_cart_coords(comm, rank, maxdims, coords); } int PMPI_Cart_get(MPI_Comm comm, int maxdims, int* dims, int* periods, int* coords) { - if(comm == NULL || smpi_comm_topo(comm) == NULL) { + if(comm == nullptr || smpi_comm_topo(comm) == nullptr) { return MPI_ERR_TOPOLOGY; } - if(maxdims <= 0 || dims == NULL || periods == NULL || coords == NULL) { + if(maxdims <= 0 || dims == nullptr || periods == nullptr || coords == nullptr) { return MPI_ERR_ARG; } return smpi_mpi_cart_get(comm, maxdims, dims, periods, coords); } int PMPI_Cartdim_get(MPI_Comm comm, int* ndims) { - if (comm == MPI_COMM_NULL || smpi_comm_topo(comm) == NULL) { + if (comm == MPI_COMM_NULL || smpi_comm_topo(comm) == nullptr) { return MPI_ERR_TOPOLOGY; } - if (ndims == NULL) { + if (ndims == nullptr) { return MPI_ERR_ARG; } return smpi_mpi_cartdim_get(comm, ndims); } int PMPI_Dims_create(int nnodes, int ndims, int* dims) { - if(dims == NULL) { + if(dims == nullptr) { return MPI_ERR_ARG; } if (ndims < 1 || nnodes < 1) { @@ -2617,28 +2556,28 @@ int PMPI_Dims_create(int nnodes, int ndims, int* dims) { } int PMPI_Cart_sub(MPI_Comm comm, int* remain_dims, MPI_Comm* comm_new) { - if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == NULL) { + if(comm == MPI_COMM_NULL || smpi_comm_topo(comm) == nullptr) { return MPI_ERR_TOPOLOGY; } - if (comm_new == NULL) { + if (comm_new == nullptr) { return MPI_ERR_ARG; } return smpi_mpi_cart_sub(comm, remain_dims, comm_new); } int PMPI_Type_create_resized(MPI_Datatype oldtype,MPI_Aint lb, MPI_Aint extent, MPI_Datatype *newtype){ - if(oldtype == MPI_DATATYPE_NULL) { - return MPI_ERR_TYPE; - } - int blocks[3] = { 1, 1, 1 }; - MPI_Aint disps[3] = { lb, 0, lb+extent }; - MPI_Datatype types[3] = { MPI_LB, oldtype, MPI_UB }; + if (oldtype == MPI_DATATYPE_NULL) { + return MPI_ERR_TYPE; + } + int blocks[3] = {1, 1, 1}; + MPI_Aint disps[3] = {lb, 0, lb + extent}; + MPI_Datatype types[3] = {MPI_LB, oldtype, MPI_UB}; - s_smpi_mpi_struct_t* subtype = smpi_datatype_struct_create( blocks, disps, 3, types); - smpi_datatype_create(newtype,oldtype->size, lb, lb + extent, sizeof(s_smpi_mpi_struct_t) , subtype, DT_FLAG_VECTOR); + s_smpi_mpi_struct_t* subtype = smpi_datatype_struct_create(blocks, disps, 3, types); + smpi_datatype_create(newtype, oldtype->size, lb, lb + extent, sizeof(s_smpi_mpi_struct_t), subtype, DT_FLAG_VECTOR); - (*newtype)->flags &= ~DT_FLAG_COMMITED; - return MPI_SUCCESS; + (*newtype)->flags &= ~DT_FLAG_COMMITED; + return MPI_SUCCESS; } int PMPI_Win_create( void *base, MPI_Aint size, int disp_unit, MPI_Info info, MPI_Comm comm, MPI_Win *win){ @@ -2646,7 +2585,7 @@ int PMPI_Win_create( void *base, MPI_Aint size, int disp_unit, MPI_Info info, MP smpi_bench_end(); if (comm == MPI_COMM_NULL) { retval= MPI_ERR_COMM; - }else if ((base == NULL && size != 0) || disp_unit <= 0 || size < 0 ){ + }else if ((base == nullptr && size != 0) || disp_unit <= 0 || size < 0 ){ retval= MPI_ERR_OTHER; }else{ *win = smpi_mpi_win_create( base, size, disp_unit, info, comm); @@ -2659,7 +2598,7 @@ int PMPI_Win_create( void *base, MPI_Aint size, int disp_unit, MPI_Info info, MP int PMPI_Win_free( MPI_Win* win){ int retval = 0; smpi_bench_end(); - if (win == NULL || *win == MPI_WIN_NULL) { + if (win == nullptr || *win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; }else{ retval=smpi_mpi_win_free(win); @@ -2670,43 +2609,38 @@ int PMPI_Win_free( MPI_Win* win){ int PMPI_Win_set_name(MPI_Win win, char * name) { - int retval = 0; if (win == MPI_WIN_NULL) { - retval = MPI_ERR_TYPE; - } else if (name == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (name == nullptr) { + return MPI_ERR_ARG; } else { smpi_mpi_win_set_name(win, name); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Win_get_name(MPI_Win win, char * name, int* len) { - int retval = MPI_SUCCESS; - if (win == MPI_WIN_NULL) { - retval = MPI_ERR_WIN; - } else if (name == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_WIN; + } else if (name == nullptr) { + return MPI_ERR_ARG; } else { smpi_mpi_win_get_name(win, name, len); + return MPI_SUCCESS; } - return retval; } int PMPI_Win_get_group(MPI_Win win, MPI_Group * group){ - int retval = MPI_SUCCESS; if (win == MPI_WIN_NULL) { - retval = MPI_ERR_WIN; + return MPI_ERR_WIN; }else { smpi_mpi_win_get_group(win, group); + smpi_group_use(*group); + return MPI_SUCCESS; } - return retval; } - int PMPI_Win_fence( int assert, MPI_Win win){ int retval = 0; smpi_bench_end(); @@ -2714,7 +2648,7 @@ int PMPI_Win_fence( int assert, MPI_Win win){ retval = MPI_ERR_WIN; } else { int rank = smpi_process_index(); - TRACE_smpi_collective_in(rank, -1, __FUNCTION__, NULL); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = smpi_mpi_win_fence(assert, win); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -2733,10 +2667,9 @@ int PMPI_Get( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, } else if (target_rank <0){ retval = MPI_ERR_RANK; } else if (target_disp <0){ - retval = MPI_ERR_ARG; - } else if (origin_count < 0 || target_count < 0) { - retval = MPI_ERR_COUNT; - } else if (origin_addr==NULL && origin_count > 0){ + retval = MPI_ERR_ARG; + } else if ((origin_count < 0 || target_count < 0) || + (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; } else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) { retval = MPI_ERR_TYPE; @@ -2745,7 +2678,7 @@ int PMPI_Get( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, MPI_Group group; smpi_mpi_win_get_group(win, &group); int src_traced = smpi_group_index(group, target_rank); - TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, NULL); + TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, nullptr); retval = smpi_mpi_get( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, target_datatype, win); @@ -2768,9 +2701,8 @@ int PMPI_Put( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, retval = MPI_ERR_RANK; } else if (target_disp <0){ retval = MPI_ERR_ARG; - } else if (origin_count < 0 || target_count < 0) { - retval = MPI_ERR_COUNT; - } else if (origin_addr==NULL && origin_count > 0){ + } else if ((origin_count < 0 || target_count < 0) || + (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; } else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) { retval = MPI_ERR_TYPE; @@ -2779,8 +2711,8 @@ int PMPI_Put( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, MPI_Group group; smpi_mpi_win_get_group(win, &group); int dst_traced = smpi_group_index(group, target_rank); - TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, NULL); - TRACE_smpi_send(rank, rank, dst_traced, origin_count*smpi_datatype_size(origin_datatype)); + TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, nullptr); + TRACE_smpi_send(rank, rank, dst_traced, SMPI_RMA_TAG, origin_count*smpi_datatype_size(origin_datatype)); retval = smpi_mpi_put( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, target_datatype, win); @@ -2803,9 +2735,8 @@ int PMPI_Accumulate( void *origin_addr, int origin_count, MPI_Datatype origin_da retval = MPI_ERR_RANK; } else if (target_disp <0){ retval = MPI_ERR_ARG; - } else if (origin_count < 0 || target_count < 0) { - retval = MPI_ERR_COUNT; - } else if (origin_addr==NULL && origin_count > 0){ + } else if ((origin_count < 0 || target_count < 0) || + (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; } else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) { @@ -2817,7 +2748,7 @@ int PMPI_Accumulate( void *origin_addr, int origin_count, MPI_Datatype origin_da MPI_Group group; smpi_mpi_win_get_group(win, &group); int src_traced = smpi_group_index(group, target_rank); - TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, NULL); + TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, nullptr); retval = smpi_mpi_accumulate( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, target_datatype, op, win); @@ -2835,10 +2766,9 @@ int PMPI_Win_post(MPI_Group group, int assert, MPI_Win win){ retval = MPI_ERR_WIN; } else if (group==MPI_GROUP_NULL){ retval = MPI_ERR_GROUP; - } - else { + } else { int rank = smpi_process_index(); - TRACE_smpi_collective_in(rank, -1, __FUNCTION__, NULL); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = smpi_mpi_win_post(group,assert,win); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -2853,10 +2783,9 @@ int PMPI_Win_start(MPI_Group group, int assert, MPI_Win win){ retval = MPI_ERR_WIN; } else if (group==MPI_GROUP_NULL){ retval = MPI_ERR_GROUP; - } - else { + } else { int rank = smpi_process_index(); - TRACE_smpi_collective_in(rank, -1, __FUNCTION__, NULL); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = smpi_mpi_win_start(group,assert,win); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -2869,10 +2798,9 @@ int PMPI_Win_complete(MPI_Win win){ smpi_bench_end(); if (win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; - } - else { + } else { int rank = smpi_process_index(); - TRACE_smpi_collective_in(rank, -1, __FUNCTION__, NULL); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = smpi_mpi_win_complete(win); @@ -2887,10 +2815,9 @@ int PMPI_Win_wait(MPI_Win win){ smpi_bench_end(); if (win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; - } - else { + } else { int rank = smpi_process_index(); - TRACE_smpi_collective_in(rank, -1, __FUNCTION__, NULL); + TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = smpi_mpi_win_wait(win); @@ -2902,10 +2829,10 @@ int PMPI_Win_wait(MPI_Win win){ int PMPI_Alloc_mem(MPI_Aint size, MPI_Info info, void *baseptr){ void *ptr = xbt_malloc(size); - if(!ptr) + if(ptr==nullptr) return MPI_ERR_NO_MEM; else { - *(void **)baseptr = ptr; + *static_cast(baseptr) = ptr; return MPI_SUCCESS; } } @@ -2917,31 +2844,26 @@ int PMPI_Free_mem(void *baseptr){ int PMPI_Type_set_name(MPI_Datatype datatype, char * name) { - int retval = 0; if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; - } else if (name == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (name == nullptr) { + return MPI_ERR_ARG; } else { smpi_datatype_set_name(datatype, name); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } int PMPI_Type_get_name(MPI_Datatype datatype, char * name, int* len) { - int retval = 0; - if (datatype == MPI_DATATYPE_NULL) { - retval = MPI_ERR_TYPE; - } else if (name == NULL) { - retval = MPI_ERR_ARG; + return MPI_ERR_TYPE; + } else if (name == nullptr) { + return MPI_ERR_ARG; } else { smpi_datatype_get_name(datatype, name, len); - retval = MPI_SUCCESS; + return MPI_SUCCESS; } - return retval; } MPI_Datatype PMPI_Type_f2c(MPI_Fint datatype){ @@ -3034,23 +2956,23 @@ int PMPI_Attr_get(MPI_Comm comm, int keyval, void* attr_value, int* flag) { case MPI_IO: case MPI_APPNUM: *flag = 1; - *(int**)attr_value = &zero; + *static_cast(attr_value) = &zero; return MPI_SUCCESS; case MPI_UNIVERSE_SIZE: *flag = 1; - *(int**)attr_value = &smpi_universe_size; + *static_cast(attr_value) = &smpi_universe_size; return MPI_SUCCESS; case MPI_LASTUSEDCODE: *flag = 1; - *(int**)attr_value = &last_used_code; + *static_cast(attr_value) = &last_used_code; return MPI_SUCCESS; case MPI_TAG_UB: *flag=1; - *(int**)attr_value = &tag_ub; + *static_cast(attr_value) = &tag_ub; return MPI_SUCCESS; case MPI_WTIME_IS_GLOBAL: *flag = 1; - *(int**)attr_value = &one; + *static_cast(attr_value) = &one; return MPI_SUCCESS; default: return smpi_comm_attr_get(comm, keyval, attr_value, flag); @@ -3127,24 +3049,24 @@ int PMPI_Type_free_keyval(int* keyval) { } int PMPI_Info_create( MPI_Info *info){ - if (info == NULL) + if (info == nullptr) return MPI_ERR_ARG; *info = xbt_new(s_smpi_mpi_info_t, 1); - (*info)->info_dict= xbt_dict_new_homogeneous(NULL); + (*info)->info_dict= xbt_dict_new_homogeneous(xbt_free_f); (*info)->refcount=1; return MPI_SUCCESS; } int PMPI_Info_set( MPI_Info info, char *key, char *value){ - if (info == NULL || key == NULL || value == NULL) + if (info == nullptr || key == nullptr || value == nullptr) return MPI_ERR_ARG; - xbt_dict_set(info->info_dict, key, (void*)value, NULL); + xbt_dict_set(info->info_dict, key, xbt_strdup(value), nullptr); return MPI_SUCCESS; } int PMPI_Info_free( MPI_Info *info){ - if (info == NULL || *info==NULL) + if (info == nullptr || *info==nullptr) return MPI_ERR_ARG; (*info)->refcount--; if((*info)->refcount==0){ @@ -3157,12 +3079,13 @@ int PMPI_Info_free( MPI_Info *info){ int PMPI_Info_get(MPI_Info info,char *key,int valuelen, char *value, int *flag){ *flag=false; - if (info == NULL || key == NULL || valuelen <0) + if (info == nullptr || key == nullptr || valuelen <0) return MPI_ERR_ARG; - if (value == NULL) + if (value == nullptr) return MPI_ERR_INFO_VALUE; - char* tmpvalue=(char*)xbt_dict_get_or_null(info->info_dict, key); + char* tmpvalue=static_cast(xbt_dict_get_or_null(info->info_dict, key)); if(tmpvalue){ + memset(value, 0, valuelen); memcpy(value,tmpvalue, (strlen(tmpvalue) + 1 < static_cast(valuelen)) ? strlen(tmpvalue) + 1 : valuelen); *flag=true; } @@ -3170,50 +3093,51 @@ int PMPI_Info_get(MPI_Info info,char *key,int valuelen, char *value, int *flag){ } int PMPI_Info_dup(MPI_Info info, MPI_Info *newinfo){ - if (info == NULL || newinfo==NULL) + if (info == nullptr || newinfo==nullptr) return MPI_ERR_ARG; *newinfo = xbt_new(s_smpi_mpi_info_t, 1); - (*newinfo)->info_dict= xbt_dict_new_homogeneous(NULL); - xbt_dict_cursor_t cursor = NULL; + (*newinfo)->info_dict= xbt_dict_new_homogeneous(xbt_free_f); + (*newinfo)->refcount=1; + xbt_dict_cursor_t cursor = nullptr; int *key; void* data; xbt_dict_foreach(info->info_dict,cursor,key,data){ - xbt_dict_set((*newinfo)->info_dict, (char*)key, data, NULL); + xbt_dict_set((*newinfo)->info_dict, reinterpret_cast(key), xbt_strdup(reinterpret_cast(data)), nullptr); } return MPI_SUCCESS; } int PMPI_Info_delete(MPI_Info info, char *key){ - xbt_ex_t e; - if (info == NULL || key==NULL) + if (info == nullptr || key==nullptr) return MPI_ERR_ARG; - TRY { + try { xbt_dict_remove(info->info_dict, key); - }CATCH(e){ - xbt_ex_free(e); + } + catch(xbt_ex& e){ return MPI_ERR_INFO_NOKEY; } return MPI_SUCCESS; } int PMPI_Info_get_nkeys( MPI_Info info, int *nkeys){ - if (info == NULL || nkeys==NULL) + if (info == nullptr || nkeys==nullptr) return MPI_ERR_ARG; *nkeys=xbt_dict_size(info->info_dict); return MPI_SUCCESS; } int PMPI_Info_get_nthkey( MPI_Info info, int n, char *key){ - if (info == NULL || key==NULL || n<0 || n> MPI_MAX_INFO_KEY) + if (info == nullptr || key==nullptr || n<0 || n> MPI_MAX_INFO_KEY) return MPI_ERR_ARG; - xbt_dict_cursor_t cursor = NULL; + xbt_dict_cursor_t cursor = nullptr; char *keyn; void* data; int num=0; xbt_dict_foreach(info->info_dict,cursor,keyn,data){ if(num==n){ - strcpy(key,keyn); + strncpy(key,keyn,strlen(keyn)+1); + xbt_dict_cursor_free(&cursor); return MPI_SUCCESS; } num++; @@ -3223,7 +3147,7 @@ int PMPI_Info_get_nthkey( MPI_Info info, int n, char *key){ int PMPI_Info_get_valuelen( MPI_Info info, char *key, int *valuelen, int *flag){ *flag=false; - if (info == NULL || key == NULL || valuelen==NULL) + if (info == nullptr || key == nullptr || valuelen==nullptr) return MPI_ERR_ARG; char* tmpvalue=(char*)xbt_dict_get_or_null(info->info_dict, key); if(tmpvalue){ @@ -3234,7 +3158,7 @@ int PMPI_Info_get_valuelen( MPI_Info info, char *key, int *valuelen, int *flag){ } int PMPI_Unpack(void* inbuf, int incount, int* position, void* outbuf, int outcount, MPI_Datatype type, MPI_Comm comm) { - if(incount<0 || outcount < 0 || inbuf==NULL || outbuf==NULL) + if(incount<0 || outcount < 0 || inbuf==nullptr || outbuf==nullptr) return MPI_ERR_ARG; if(!is_datatype_valid(type)) return MPI_ERR_TYPE; @@ -3244,7 +3168,7 @@ int PMPI_Unpack(void* inbuf, int incount, int* position, void* outbuf, int outco } int PMPI_Pack(void* inbuf, int incount, MPI_Datatype type, void* outbuf, int outcount, int* position, MPI_Comm comm) { - if(incount<0 || outcount < 0|| inbuf==NULL || outbuf==NULL) + if(incount<0 || outcount < 0|| inbuf==nullptr || outbuf==nullptr) return MPI_ERR_ARG; if(!is_datatype_valid(type)) return MPI_ERR_TYPE; @@ -3266,3 +3190,4 @@ int PMPI_Pack_size(int incount, MPI_Datatype datatype, MPI_Comm comm, int* size) return MPI_SUCCESS; } +} // extern "C"