X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/de7d161240f434a809ae7739fbb15a1db6ab86f2..37c3311044fe215372be2a6075b82dba65ac5b1a:/src/simix/smx_context_thread.c

diff --git a/src/simix/smx_context_thread.c b/src/simix/smx_context_thread.c
index 64705e3dc7..ddd4deb48d 100644
--- a/src/simix/smx_context_thread.c
+++ b/src/simix/smx_context_thread.c
@@ -16,6 +16,8 @@
 
 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(simix_context);
 
+int smx_parallel_contexts = 0;
+
 typedef struct s_smx_ctx_thread {
   s_smx_ctx_base_t super;       /* Fields of super implementation */
   xbt_os_thread_t thread;       /* a plain dumb thread (portable to posix or windows) */
@@ -33,8 +35,8 @@ static void smx_ctx_thread_free(smx_context_t context);
 static void smx_ctx_thread_stop(smx_context_t context);
 static void smx_ctx_thread_suspend(smx_context_t context);
 static void smx_ctx_thread_resume(smx_context_t new_context);
-static void smx_ctx_thread_runall_serial(xbt_swag_t processes);
-static void smx_ctx_thread_runall_parallel(xbt_swag_t processes);
+static void smx_ctx_thread_runall_serial(xbt_dynar_t processes);
+static void smx_ctx_thread_runall_parallel(xbt_dynar_t processes);
 static smx_context_t smx_ctx_thread_self(void);
 
 static void *smx_ctx_thread_wrapper(void *param);
@@ -42,6 +44,7 @@ static void *smx_ctx_thread_wrapper(void *param);
 void SIMIX_ctx_thread_factory_init(smx_context_factory_t * factory)
 {
   smx_ctx_base_factory_init(factory);
+  VERB0("Activating thread context factory");
 
   (*factory)->create_context = smx_ctx_thread_factory_create_context;
   /* Do not overload that method (*factory)->finalize */
@@ -49,7 +52,7 @@ void SIMIX_ctx_thread_factory_init(smx_context_factory_t * factory)
   (*factory)->stop = smx_ctx_thread_stop;
   (*factory)->suspend = smx_ctx_thread_suspend;
 
-  if(_surf_parallel_contexts)
+  if (smx_parallel_contexts)
     (*factory)->runall = smx_ctx_thread_runall_parallel;
   else
     (*factory)->runall = smx_ctx_thread_runall_serial;
@@ -74,9 +77,14 @@ smx_ctx_thread_factory_create_context(xbt_main_func_t code, int argc,
   if (code) {
     context->begin = xbt_os_sem_init(0);
     context->end = xbt_os_sem_init(0);
+    /* create and start the process */
+    /* NOTE: The first argument to xbt_os_thread_create used to be the process *
+    * name, but now the name is stored at SIMIX level, so we pass a null  */
+    context->thread =
+      xbt_os_thread_create(NULL, smx_ctx_thread_wrapper, context, context);
 
-    /* delay the thread creation until first run */
-    context->thread = NULL;
+    /* wait the starting of the newly created process */
+    xbt_os_sem_acquire(context->end);
 
   } else {
     xbt_os_thread_set_extra_data(context);
@@ -89,19 +97,15 @@ static void smx_ctx_thread_free(smx_context_t pcontext)
 {
   smx_ctx_thread_t context = (smx_ctx_thread_t) pcontext;
 
-  /* check if the context has a thread or not */
-  /* if it doesn't, it is maestro's context or the context never run */
+  /* check if this is the context of maestro (it doesn't has a real thread) */
   if (context->thread) {
     /* wait about the thread terminason */
     xbt_os_thread_join(context->thread, NULL);
-  }
 
-  /* destroy the synchronisation objects */
-  if (context->begin)
+    /* destroy the synchronisation objects */
     xbt_os_sem_destroy(context->begin);
-
-  if (context->end)
     xbt_os_sem_destroy(context->end);
+  }
 
   smx_ctx_base_free(pcontext);
 }
@@ -137,43 +141,34 @@ static void *smx_ctx_thread_wrapper(void *param)
 
 static void smx_ctx_thread_suspend(smx_context_t context)
 {
-  if (((smx_ctx_thread_t) context)->thread) {
-    xbt_os_sem_release(((smx_ctx_thread_t) context)->end);
-    xbt_os_sem_acquire(((smx_ctx_thread_t) context)->begin);
-  }
+  xbt_os_sem_release(((smx_ctx_thread_t) context)->end);
+  xbt_os_sem_acquire(((smx_ctx_thread_t) context)->begin);
 }
 
-static void smx_ctx_thread_runall_serial(xbt_swag_t processes)
+static void smx_ctx_thread_runall_serial(xbt_dynar_t processes)
 {
   smx_process_t process;
-  while ((process = xbt_swag_extract(processes))) {
-    /* if the context has no thread associated, create one for it (first run) */
-    if (!(((smx_ctx_thread_t)process->context)->thread)) {
-      ((smx_ctx_thread_t) process->context)->thread =
-        xbt_os_thread_create(NULL, smx_ctx_thread_wrapper, process->context, process->context);
-      xbt_os_sem_acquire(((smx_ctx_thread_t) process->context)->end);
-    }
+  unsigned int cursor;
+
+  xbt_dynar_foreach(processes, cursor, process) {
     xbt_os_sem_release(((smx_ctx_thread_t) process->context)->begin);
     xbt_os_sem_acquire(((smx_ctx_thread_t) process->context)->end);
   }
+  xbt_dynar_reset(processes);
 }
 
-static void smx_ctx_thread_runall_parallel(xbt_swag_t processes)
+static void smx_ctx_thread_runall_parallel(xbt_dynar_t processes)
 {
-  smx_process_t process, p_next;
-  xbt_swag_foreach_safe(process, p_next, processes) {
-    /* if the context has no thread associated, create one for it (first run) */
-    if (!(((smx_ctx_thread_t) process->context)->thread)) {
-      ((smx_ctx_thread_t)process->context)->thread =
-        xbt_os_thread_create(NULL, smx_ctx_thread_wrapper, process->context, process->context);
-      xbt_os_sem_acquire(((smx_ctx_thread_t) process->context)->end);
-    }
+  unsigned int index;
+  smx_process_t process;
+
+  xbt_dynar_foreach(processes, index, process)
     xbt_os_sem_release(((smx_ctx_thread_t) process->context)->begin);
-  }
 
-  while ((process = xbt_swag_extract(processes))) {
-    xbt_os_sem_acquire(((smx_ctx_thread_t) process->context)->end);
+  xbt_dynar_foreach(processes, index, process) {
+     xbt_os_sem_acquire(((smx_ctx_thread_t) process->context)->end);
   }
+  xbt_dynar_reset(processes);
 }
 
 static smx_context_t smx_ctx_thread_self(void)